[INFO] fetching crate git-repo-language-trends 0.4.0... [INFO] checking git-repo-language-trends-0.4.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate git-repo-language-trends 0.4.0 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate git-repo-language-trends 0.4.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate git-repo-language-trends 0.4.0 [INFO] finished tweaking crates.io crate git-repo-language-trends 0.4.0 [INFO] tweaked toml for crates.io crate git-repo-language-trends 0.4.0 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate crates.io crate git-repo-language-trends 0.4.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] cdbd2b55be8ea796d1089c0b1dda8a1fc67fe0b54d8c7fa55fca3740ac7f74dd [INFO] running `Command { std: "docker" "start" "-a" "cdbd2b55be8ea796d1089c0b1dda8a1fc67fe0b54d8c7fa55fca3740ac7f74dd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "cdbd2b55be8ea796d1089c0b1dda8a1fc67fe0b54d8c7fa55fca3740ac7f74dd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cdbd2b55be8ea796d1089c0b1dda8a1fc67fe0b54d8c7fa55fca3740ac7f74dd", kill_on_drop: false }` [INFO] [stdout] cdbd2b55be8ea796d1089c0b1dda8a1fc67fe0b54d8c7fa55fca3740ac7f74dd [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4c1c04df79acc6423b76c2bdb978ebade48a826798e430e2b3a7a4086898689c [INFO] running `Command { std: "docker" "start" "-a" "4c1c04df79acc6423b76c2bdb978ebade48a826798e430e2b3a7a4086898689c", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.82 [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Compiling version_check v0.9.2 [INFO] [stderr] Compiling memchr v2.3.4 [INFO] [stderr] Compiling pkg-config v0.3.19 [INFO] [stderr] Checking once_cell v1.5.2 [INFO] [stderr] Checking unicode-width v0.1.8 [INFO] [stderr] Compiling quote v1.0.8 [INFO] [stderr] Checking matches v0.1.8 [INFO] [stderr] Checking thread_local v1.1.2 [INFO] [stderr] Checking tinyvec_macros v0.1.0 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Checking regex-syntax v0.6.22 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Checking aho-corasick v0.7.15 [INFO] [stderr] Compiling syn v1.0.59 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking tinyvec v1.1.0 [INFO] [stderr] Compiling num-integer v0.1.44 [INFO] [stderr] Checking unicode-bidi v0.3.4 [INFO] [stderr] Checking percent-encoding v2.1.0 [INFO] [stderr] Compiling jobserver v0.1.21 [INFO] [stderr] Compiling log v0.4.13 [INFO] [stderr] Compiling unicode-segmentation v1.7.1 [INFO] [stderr] Checking form_urlencoded v1.0.0 [INFO] [stderr] Compiling cc v1.0.66 [INFO] [stderr] Checking terminal_size v0.1.16 [INFO] [stderr] Checking unicode-normalization v0.1.16 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking predicates-core v1.0.1 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Compiling heck v0.3.2 [INFO] [stderr] Compiling doc-comment v0.3.3 [INFO] [stderr] Checking clap v2.33.3 [INFO] [stderr] Checking float-cmp v0.8.0 [INFO] [stderr] Checking normalize-line-endings v0.3.0 [INFO] [stderr] Checking treeline v0.1.0 [INFO] [stderr] Checking difference v2.0.0 [INFO] [stderr] Checking number_prefix v0.3.0 [INFO] [stderr] Checking predicates-tree v1.0.1 [INFO] [stderr] Checking wait-timeout v0.2.0 [INFO] [stderr] Checking chrono v0.4.19 [INFO] [stderr] Compiling libz-sys v1.1.2 [INFO] [stderr] Compiling libgit2-sys v0.12.18+1.1.0 [INFO] [stderr] Checking idna v0.2.0 [INFO] [stderr] Checking regex v1.4.3 [INFO] [stderr] Checking url v2.2.0 [INFO] [stderr] Checking console v0.14.0 [INFO] [stderr] Checking indicatif v0.15.0 [INFO] [stderr] Checking predicates v1.0.6 [INFO] [stderr] Checking assert_cmd v1.0.2 [INFO] [stderr] Compiling structopt-derive v0.4.14 [INFO] [stderr] Checking structopt v0.3.21 [INFO] [stderr] Checking git2 v0.13.16 [INFO] [stderr] Checking git-repo-language-trends v0.4.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/repoutils.rs:18:12 [INFO] [stdout] | [INFO] [stdout] 16 | pub fn from_path>(path: P) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | let repo = git2::Repository::open(path)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | Ok(Repo { repo }) [INFO] [stdout] | ^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/repoutils.rs:33:12 [INFO] [stdout] | [INFO] [stdout] 25 | let mut revwalk = self.repo.revwalk()?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | let rev = self.repo.revparse_single(&args.start_commit)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 33 | Ok(revwalk [INFO] [stdout] | ____________^ [INFO] [stdout] 34 | | .into_iter() [INFO] [stdout] 35 | | .filter_map(|rev| { [INFO] [stdout] 36 | | // Note that if we are analyzing shallow git clones, we can [INFO] [stdout] ... | [INFO] [stdout] 45 | | }) [INFO] [stdout] 46 | | .collect()) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |______________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `git-repo-language-trends` (bin "git-repo-language-trends") due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/repoutils.rs:18:12 [INFO] [stdout] | [INFO] [stdout] 16 | pub fn from_path>(path: P) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | let repo = git2::Repository::open(path)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | Ok(Repo { repo }) [INFO] [stdout] | ^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/repoutils.rs:33:12 [INFO] [stdout] | [INFO] [stdout] 25 | let mut revwalk = self.repo.revwalk()?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | let rev = self.repo.revparse_single(&args.start_commit)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 33 | Ok(revwalk [INFO] [stdout] | ____________^ [INFO] [stdout] 34 | | .into_iter() [INFO] [stdout] 35 | | .filter_map(|rev| { [INFO] [stdout] 36 | | // Note that if we are analyzing shallow git clones, we can [INFO] [stdout] ... | [INFO] [stdout] 45 | | }) [INFO] [stdout] 46 | | .collect()) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |______________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `git-repo-language-trends` (bin "git-repo-language-trends" test) due to 3 previous errors [INFO] running `Command { std: "docker" "inspect" "4c1c04df79acc6423b76c2bdb978ebade48a826798e430e2b3a7a4086898689c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4c1c04df79acc6423b76c2bdb978ebade48a826798e430e2b3a7a4086898689c", kill_on_drop: false }` [INFO] [stdout] 4c1c04df79acc6423b76c2bdb978ebade48a826798e430e2b3a7a4086898689c