[INFO] fetching crate git-perf 0.15.5... [INFO] checking git-perf-0.15.5 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate git-perf 0.15.5 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate git-perf 0.15.5 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate git-perf 0.15.5 [INFO] finished tweaking crates.io crate git-perf 0.15.5 [INFO] tweaked toml for crates.io crate git-perf 0.15.5 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate git-perf 0.15.5 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 77785af5662b9ab98ea8e90e26552dd3a667970afc0ef0e5fccc00fc699528bd [INFO] running `Command { std: "docker" "start" "-a" "77785af5662b9ab98ea8e90e26552dd3a667970afc0ef0e5fccc00fc699528bd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "77785af5662b9ab98ea8e90e26552dd3a667970afc0ef0e5fccc00fc699528bd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "77785af5662b9ab98ea8e90e26552dd3a667970afc0ef0e5fccc00fc699528bd", kill_on_drop: false }` [INFO] [stdout] 77785af5662b9ab98ea8e90e26552dd3a667970afc0ef0e5fccc00fc699528bd [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e32c3761786ba2608265f6d6f0a0ed8295b5da745c0931a4d9e5dc8aa02ba97f [INFO] running `Command { std: "docker" "start" "-a" "e32c3761786ba2608265f6d6f0a0ed8295b5da745c0931a4d9e5dc8aa02ba97f", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.76 [INFO] [stderr] Compiling serde v1.0.195 [INFO] [stderr] Compiling libc v0.2.152 [INFO] [stderr] Checking itoa v1.0.10 [INFO] [stderr] Checking memchr v2.7.1 [INFO] [stderr] Compiling libm v0.2.8 [INFO] [stderr] Compiling rustix v0.38.28 [INFO] [stderr] Compiling crossbeam-utils v0.8.19 [INFO] [stderr] Checking linux-raw-sys v0.4.12 [INFO] [stderr] Checking bitflags v2.4.1 [INFO] [stderr] Compiling unicase v2.7.0 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Compiling num-traits v0.2.17 [INFO] [stderr] Compiling serde_json v1.0.111 [INFO] [stderr] Checking pin-project-lite v0.2.13 [INFO] [stderr] Checking equivalent v1.0.1 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking hashbrown v0.14.3 [INFO] [stderr] Checking ryu v1.0.16 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Checking anstyle-parse v0.2.3 [INFO] [stderr] Compiling minimal-lexical v0.2.1 [INFO] [stderr] Checking anstyle v1.0.4 [INFO] [stderr] Compiling mime_guess v2.0.4 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Checking colorchoice v1.0.0 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Checking anstyle-query v1.0.2 [INFO] [stderr] Checking bytes v1.5.0 [INFO] [stderr] Compiling rayon-core v1.12.0 [INFO] [stderr] Checking clap_lex v0.6.0 [INFO] [stderr] Checking regex-syntax v0.8.2 [INFO] [stderr] Checking anstream v0.6.5 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Checking either v1.9.0 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Compiling mime v0.3.17 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking aho-corasick v1.1.2 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking ciborium-io v0.2.1 [INFO] [stderr] Checking winnow v0.5.33 [INFO] [stderr] Checking half v1.8.2 [INFO] [stderr] Checking plotters-backend v0.3.5 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking http v0.2.11 [INFO] [stderr] Checking indexmap v2.1.0 [INFO] [stderr] Checking ciborium-ll v0.2.1 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Checking getrandom v0.2.11 [INFO] [stderr] Compiling nom v7.1.3 [INFO] [stderr] Checking mio v0.8.10 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking socket2 v0.5.5 [INFO] [stderr] Compiling syn v2.0.48 [INFO] [stderr] Checking plotters-svg v0.3.5 [INFO] [stderr] Checking humansize v2.1.3 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling httparse v1.8.0 [INFO] [stderr] Compiling anyhow v1.0.79 [INFO] [stderr] Checking askama_escape v0.10.3 [INFO] [stderr] Checking cast v0.3.0 [INFO] [stderr] Compiling thiserror v1.0.56 [INFO] [stderr] Checking walkdir v2.4.0 [INFO] [stderr] Checking tokio v1.35.1 [INFO] [stderr] Checking easy-cast v0.4.4 [INFO] [stderr] Checking instant v0.1.12 [INFO] [stderr] Checking float-ord v0.3.2 [INFO] [stderr] Checking dyn-clone v1.0.16 [INFO] [stderr] Checking oorandom v11.1.3 [INFO] [stderr] Checking try-lock v0.2.5 [INFO] [stderr] Checking anes v0.1.6 [INFO] [stderr] Checking roff v0.2.1 [INFO] [stderr] Checking plotters v0.3.5 [INFO] [stderr] Checking rayon v1.8.0 [INFO] [stderr] Checking want v0.3.1 [INFO] [stderr] Checking http-body v0.4.6 [INFO] [stderr] Checking httpdate v1.0.3 [INFO] [stderr] Checking hex v0.4.3 [INFO] [stderr] Checking tower-service v0.3.2 [INFO] [stderr] Checking bstr v0.2.17 [INFO] [stderr] Checking regex-automata v0.4.3 [INFO] [stderr] Checking crossbeam-channel v0.5.11 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Checking fastrand v2.0.1 [INFO] [stderr] Checking criterion-plot v0.5.0 [INFO] [stderr] Checking average v0.13.1 [INFO] [stderr] Checking backoff v0.4.0 [INFO] [stderr] Compiling askama_parser v0.2.0 [INFO] [stderr] Checking terminal_size v0.3.0 [INFO] [stderr] Checking is-terminal v0.4.10 [INFO] [stderr] Checking tempfile v3.9.0 [INFO] [stderr] Checking clap_builder v4.4.12 [INFO] [stderr] Checking regex v1.10.2 [INFO] [stderr] Compiling darling_core v0.20.3 [INFO] [stderr] Compiling darling_core v0.14.4 [INFO] [stderr] Compiling serde_derive v1.0.195 [INFO] [stderr] Compiling clap_derive v4.4.7 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling thiserror-impl v1.0.56 [INFO] [stderr] Compiling serde_repr v0.1.18 [INFO] [stderr] Checking tokio-util v0.7.10 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Compiling darling_macro v0.20.3 [INFO] [stderr] Compiling darling_macro v0.14.4 [INFO] [stderr] Compiling darling v0.20.3 [INFO] [stderr] Compiling serde_with_macros v2.3.3 [INFO] [stderr] Compiling darling v0.14.4 [INFO] [stderr] Checking clap v4.4.13 [INFO] [stderr] Compiling plotly_derive v0.8.4 [INFO] [stderr] Checking clap_mangen v0.2.16 [INFO] [stderr] Checking h2 v0.3.22 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking toml_datetime v0.6.5 [INFO] [stderr] Checking serde_spanned v0.6.5 [INFO] [stderr] Checking erased-serde v0.3.31 [INFO] [stderr] Checking serde_with v2.3.3 [INFO] [stderr] Checking ciborium v0.2.1 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking toml_edit v0.21.0 [INFO] [stderr] Checking toml_edit v0.20.7 [INFO] [stderr] Compiling basic-toml v0.1.8 [INFO] [stderr] Checking hyper v0.14.28 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking criterion v0.5.1 [INFO] [stderr] Compiling askama_derive v0.12.4 [INFO] [stderr] Checking toml v0.8.8 [INFO] [stderr] Checking httptest v0.15.5 [INFO] [stderr] Checking askama v0.12.1 [INFO] [stderr] Checking plotly v0.8.4 [INFO] [stderr] Checking git-perf v0.15.5 (/opt/rustwide/workdir) [INFO] [stdout] warning: struct `SerializeMeasurementData` is never constructed [INFO] [stdout] --> src/serialization.rs:15:8 [INFO] [stdout] | [INFO] [stdout] 15 | struct SerializeMeasurementData<'a> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/git_interop.rs:205:17 [INFO] [stdout] | [INFO] [stdout] 200 | .map(|(k, v)| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 205 | v.map(|(_, v)| v.to_owned()).collect::>(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `git-perf` (lib) due to 2 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: struct `SerializeMeasurementData` is never constructed [INFO] [stdout] --> src/serialization.rs:15:8 [INFO] [stdout] | [INFO] [stdout] 15 | struct SerializeMeasurementData<'a> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/git_interop.rs:205:17 [INFO] [stdout] | [INFO] [stdout] 200 | .map(|(k, v)| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 205 | v.map(|(_, v)| v.to_owned()).collect::>(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `git-perf` (lib test) due to 2 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "e32c3761786ba2608265f6d6f0a0ed8295b5da745c0931a4d9e5dc8aa02ba97f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e32c3761786ba2608265f6d6f0a0ed8295b5da745c0931a4d9e5dc8aa02ba97f", kill_on_drop: false }` [INFO] [stdout] e32c3761786ba2608265f6d6f0a0ed8295b5da745c0931a4d9e5dc8aa02ba97f