[INFO] fetching crate git-metrics 0.2.3... [INFO] checking git-metrics-0.2.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate git-metrics 0.2.3 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate git-metrics 0.2.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-7-tc2/source/.cargo/config.toml [INFO] removed /workspace/builds/worker-7-tc2/source/rust-toolchain.toml [INFO] started tweaking crates.io crate git-metrics 0.2.3 [INFO] finished tweaking crates.io crate git-metrics 0.2.3 [INFO] tweaked toml for crates.io crate git-metrics 0.2.3 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate crates.io crate git-metrics 0.2.3 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 564ce84a20c1b7b3e48503d37ed6b3e3ec03fcf2f5076bf7bb67310cd43593ff [INFO] running `Command { std: "docker" "start" "-a" "564ce84a20c1b7b3e48503d37ed6b3e3ec03fcf2f5076bf7bb67310cd43593ff", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "564ce84a20c1b7b3e48503d37ed6b3e3ec03fcf2f5076bf7bb67310cd43593ff", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "564ce84a20c1b7b3e48503d37ed6b3e3ec03fcf2f5076bf7bb67310cd43593ff", kill_on_drop: false }` [INFO] [stdout] 564ce84a20c1b7b3e48503d37ed6b3e3ec03fcf2f5076bf7bb67310cd43593ff [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3896064d02dc36d62a49a585bb6417febc6261cc3d660d3d5ce2118e87b8fc72 [INFO] running `Command { std: "docker" "start" "-a" "3896064d02dc36d62a49a585bb6417febc6261cc3d660d3d5ce2118e87b8fc72", kill_on_drop: false }` [INFO] [stderr] Compiling once_cell v1.19.0 [INFO] [stderr] Compiling serde v1.0.204 [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Checking anstyle v1.0.7 [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Compiling syn v2.0.71 [INFO] [stderr] Checking is_terminal_polyfill v1.70.0 [INFO] [stderr] Checking colorchoice v1.0.1 [INFO] [stderr] Compiling thiserror v1.0.62 [INFO] [stderr] Checking anstyle-parse v0.2.4 [INFO] [stderr] Checking anstyle-query v1.1.0 [INFO] [stderr] Checking option-ext v0.2.0 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking predicates-core v1.0.6 [INFO] [stderr] Checking winnow v0.6.13 [INFO] [stderr] Checking clap_lex v0.7.1 [INFO] [stderr] Checking anstream v0.6.14 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Checking terminal-prompt v0.2.3 [INFO] [stderr] Checking dirs v5.0.1 [INFO] [stderr] Checking termtree v0.4.1 [INFO] [stderr] Checking similar v2.5.0 [INFO] [stderr] Checking rustix v0.38.34 [INFO] [stderr] Checking predicates-tree v1.0.9 [INFO] [stderr] Checking predicates v3.1.0 [INFO] [stderr] Checking clap_builder v4.5.9 [INFO] [stderr] Checking console v0.15.8 [INFO] [stderr] Checking human-number v0.1.2 [INFO] [stderr] Checking fastrand v2.1.0 [INFO] [stderr] Checking fragile v2.0.0 [INFO] [stderr] Compiling jobserver v0.1.31 [INFO] [stderr] Checking downcast v0.11.0 [INFO] [stderr] Checking nu-ansi-term v0.50.0 [INFO] [stderr] Checking similar-asserts v1.5.0 [INFO] [stderr] Compiling cc v1.1.1 [INFO] [stderr] Compiling libz-sys v1.1.18 [INFO] [stderr] Compiling openssl-sys v0.9.102 [INFO] [stderr] Compiling libssh2-sys v0.3.0 [INFO] [stderr] Compiling libgit2-sys v0.17.0+1.8.1 [INFO] [stderr] Checking tempfile v3.10.1 [INFO] [stderr] Compiling test-case-core v3.3.1 [INFO] [stderr] Compiling serde_derive v1.0.204 [INFO] [stderr] Compiling thiserror-impl v1.0.62 [INFO] [stderr] Compiling clap_derive v4.5.8 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling test-case-macros v3.3.1 [INFO] [stderr] Compiling mockall_derive v0.12.1 [INFO] [stderr] Checking test-case v3.3.1 [INFO] [stderr] Checking lcov v0.8.1 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking clap v4.5.9 [INFO] [stderr] Checking mockall v0.12.1 [INFO] [stderr] Checking serde_spanned v0.6.6 [INFO] [stderr] Checking toml_datetime v0.6.6 [INFO] [stderr] Checking indexmap v2.2.6 [INFO] [stderr] Checking toml_edit v0.22.15 [INFO] [stderr] Checking git2 v0.19.0 [INFO] [stderr] Checking toml v0.8.14 [INFO] [stderr] Checking auth-git2 v0.5.4 [INFO] [stderr] Checking git-metrics v0.2.3 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/backend/git2.rs:99:12 [INFO] [stdout] | [INFO] [stdout] 88 | let repo = match root { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 99 | Ok(Git2Backend { [INFO] [stdout] | ____________^ [INFO] [stdout] 100 | | repo, [INFO] [stdout] 101 | | credentials: GitCredentials::default(), [INFO] [stdout] 102 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/backend/git2.rs:253:12 [INFO] [stdout] | [INFO] [stdout] 243 | let notes = match self.repo.notes(Some(¬e_ref.to_string())) { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 244 | Ok(notes) => notes, [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 245 | Err(error) => { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 253 | Ok(notes [INFO] [stdout] | ____________^ [INFO] [stdout] 254 | | .filter_map(|note| note.ok()) [INFO] [stdout] 255 | | .map(|(note_id, commit_id)| super::Note { [INFO] [stdout] 256 | | note_id: note_id.to_string(), [INFO] [stdout] 257 | | commit_id: commit_id.to_string(), [INFO] [stdout] 258 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/backend/git2.rs:286:9 [INFO] [stdout] | [INFO] [stdout] 281 | let Ok(note) = self.repo.find_note(Some(¬e_ref.to_string()), rev_id) else { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 286 | / note.message() [INFO] [stdout] 287 | | .map(|msg| { [INFO] [stdout] 288 | | tracing::trace!("deserializing note content"); [INFO] [stdout] 289 | | toml::from_str::(msg).map(Some).map_err(|err| { [INFO] [stdout] ... | [INFO] [stdout] 292 | | }) [INFO] [stdout] 293 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |______________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/backend/git2.rs:376:9 [INFO] [stdout] | [INFO] [stdout] 357 | let config = self [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 361 | let mut remote = self [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 365 | let auth = self.authenticator(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 366 | let mut remote_cb = git2::RemoteCallbacks::new(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 373 | let mut push_opts = git2::PushOptions::new(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 376 | / remote [INFO] [stdout] 377 | | .push( [INFO] [stdout] 378 | | &[format!("{local_ref}:{REMOTE_METRICS_REF}",)], [INFO] [stdout] 379 | | Some(&mut push_opts), [INFO] [stdout] 380 | | ) [INFO] [stdout] 381 | | .map_err(with_git2_error!("unable to push metrics")) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |________________________________________________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/entity/check.rs:225:22 [INFO] [stdout] | [INFO] [stdout] 221 | fn neutral(diff: MetricDiff) -> Self { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 225 | subsets: IndexMap::with_capacity(0), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/entity/difference.rs:110:13 [INFO] [stdout] | [INFO] [stdout] 108 | pub fn remove_missing(self) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 109 | Self( [INFO] [stdout] 110 | / self.0 [INFO] [stdout] 111 | | .into_iter() [INFO] [stdout] 112 | | .filter(|m| m.comparison.has_current()) [INFO] [stdout] 113 | | .collect(), [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/entity/metric.rs:28:20 [INFO] [stdout] | [INFO] [stdout] 26 | pub(crate) fn from_iter(iter: impl Iterator) -> Self { [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | Self { [INFO] [stdout] 28 | inner: IndexMap::from_iter(iter.map(|Metric { header, value }| (header, value))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/entity/metric.rs:61:20 [INFO] [stdout] | [INFO] [stdout] 59 | pub(crate) fn into_metric_iter(self) -> MetricStackIterator { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | MetricStackIterator { [INFO] [stdout] 61 | inner: self.inner.into_iter(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/entity/metric.rs:70:9 [INFO] [stdout] | [INFO] [stdout] 69 | pub(crate) fn into_vec(self) -> Vec { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 70 | self.into_metric_iter().collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/entity/metric.rs:138:21 [INFO] [stdout] | [INFO] [stdout] 133 | pub(crate) fn new(name: N, value: f64) -> Self [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 138 | header: MetricHeader { [INFO] [stdout] | _____________________^ [INFO] [stdout] 139 | | name: name.into(), [INFO] [stdout] 140 | | tags: Default::default(), [INFO] [stdout] 141 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/service/mod.rs:26:23 [INFO] [stdout] | [INFO] [stdout] 25 | fn from(value: E) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | Self::Backend(value.into()) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/service/mod.rs:100:12 [INFO] [stdout] | [INFO] [stdout] 92 | let remote_metrics = self [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 98 | let diff_metrics = self.get_metric_changes(commit_sha)?; [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 99 | [INFO] [stdout] 100 | Ok(MetricStack::from_iter(remote_metrics.into_iter()) [INFO] [stdout] | ____________^ [INFO] [stdout] 101 | | .with_changes(diff_metrics.into_iter())) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |___________________________________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/service/check.rs:33:12 [INFO] [stdout] | [INFO] [stdout] 24 | let diff = self [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | let config = self.open_config()?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | Ok(CheckList::evaluate(&config, diff)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/service/diff.rs:42:12 [INFO] [stdout] | [INFO] [stdout] 29 | let (before, after) = match rev_parse { [INFO] [stdout] | ------ ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | RevParse::Range(ref first, _) => { [INFO] [stdout] 31 | let before = self.stack_metrics(opts.remote, first.as_str())?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | let after = self.stack_metrics(opts.remote, &rev_parse.to_string())?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 36 | let before = self.stack_metrics(opts.remote, &format!("{single}~1"))?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | let after = self.get_metrics(single.as_str(), opts.remote)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 42 | Ok(MetricDiffList::new(before, after)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 14 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `git-metrics` (bin "git-metrics") due to 15 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/backend/git2.rs:99:12 [INFO] [stdout] | [INFO] [stdout] 88 | let repo = match root { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 99 | Ok(Git2Backend { [INFO] [stdout] | ____________^ [INFO] [stdout] 100 | | repo, [INFO] [stdout] 101 | | credentials: GitCredentials::default(), [INFO] [stdout] 102 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/backend/git2.rs:253:12 [INFO] [stdout] | [INFO] [stdout] 243 | let notes = match self.repo.notes(Some(¬e_ref.to_string())) { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 244 | Ok(notes) => notes, [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 245 | Err(error) => { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 253 | Ok(notes [INFO] [stdout] | ____________^ [INFO] [stdout] 254 | | .filter_map(|note| note.ok()) [INFO] [stdout] 255 | | .map(|(note_id, commit_id)| super::Note { [INFO] [stdout] 256 | | note_id: note_id.to_string(), [INFO] [stdout] 257 | | commit_id: commit_id.to_string(), [INFO] [stdout] 258 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/backend/git2.rs:286:9 [INFO] [stdout] | [INFO] [stdout] 281 | let Ok(note) = self.repo.find_note(Some(¬e_ref.to_string()), rev_id) else { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 286 | / note.message() [INFO] [stdout] 287 | | .map(|msg| { [INFO] [stdout] 288 | | tracing::trace!("deserializing note content"); [INFO] [stdout] 289 | | toml::from_str::(msg).map(Some).map_err(|err| { [INFO] [stdout] ... | [INFO] [stdout] 292 | | }) [INFO] [stdout] 293 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |______________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/backend/git2.rs:376:9 [INFO] [stdout] | [INFO] [stdout] 357 | let config = self [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 361 | let mut remote = self [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 365 | let auth = self.authenticator(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 366 | let mut remote_cb = git2::RemoteCallbacks::new(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 373 | let mut push_opts = git2::PushOptions::new(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 376 | / remote [INFO] [stdout] 377 | | .push( [INFO] [stdout] 378 | | &[format!("{local_ref}:{REMOTE_METRICS_REF}",)], [INFO] [stdout] 379 | | Some(&mut push_opts), [INFO] [stdout] 380 | | ) [INFO] [stdout] 381 | | .map_err(with_git2_error!("unable to push metrics")) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |________________________________________________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/entity/check.rs:201:22 [INFO] [stdout] | [INFO] [stdout] 197 | pub fn new(diff: MetricDiff) -> Self { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 201 | subsets: Default::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/entity/check.rs:225:22 [INFO] [stdout] | [INFO] [stdout] 221 | fn neutral(diff: MetricDiff) -> Self { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 225 | subsets: IndexMap::with_capacity(0), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/entity/difference.rs:110:13 [INFO] [stdout] | [INFO] [stdout] 108 | pub fn remove_missing(self) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 109 | Self( [INFO] [stdout] 110 | / self.0 [INFO] [stdout] 111 | | .into_iter() [INFO] [stdout] 112 | | .filter(|m| m.comparison.has_current()) [INFO] [stdout] 113 | | .collect(), [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/entity/metric.rs:28:20 [INFO] [stdout] | [INFO] [stdout] 26 | pub(crate) fn from_iter(iter: impl Iterator) -> Self { [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | Self { [INFO] [stdout] 28 | inner: IndexMap::from_iter(iter.map(|Metric { header, value }| (header, value))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/entity/metric.rs:61:20 [INFO] [stdout] | [INFO] [stdout] 59 | pub(crate) fn into_metric_iter(self) -> MetricStackIterator { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | MetricStackIterator { [INFO] [stdout] 61 | inner: self.inner.into_iter(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/entity/metric.rs:70:9 [INFO] [stdout] | [INFO] [stdout] 69 | pub(crate) fn into_vec(self) -> Vec { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 70 | self.into_metric_iter().collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/entity/metric.rs:103:19 [INFO] [stdout] | [INFO] [stdout] 100 | pub fn new>(name: N) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 103 | tags: Default::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/entity/metric.rs:138:21 [INFO] [stdout] | [INFO] [stdout] 133 | pub(crate) fn new(name: N, value: f64) -> Self [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 138 | header: MetricHeader { [INFO] [stdout] | _____________________^ [INFO] [stdout] 139 | | name: name.into(), [INFO] [stdout] 140 | | tags: Default::default(), [INFO] [stdout] 141 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/service/mod.rs:26:23 [INFO] [stdout] | [INFO] [stdout] 25 | fn from(value: E) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | Self::Backend(value.into()) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/service/mod.rs:100:12 [INFO] [stdout] | [INFO] [stdout] 92 | let remote_metrics = self [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 98 | let diff_metrics = self.get_metric_changes(commit_sha)?; [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 99 | [INFO] [stdout] 100 | Ok(MetricStack::from_iter(remote_metrics.into_iter()) [INFO] [stdout] | ____________^ [INFO] [stdout] 101 | | .with_changes(diff_metrics.into_iter())) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |___________________________________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/service/check.rs:33:12 [INFO] [stdout] | [INFO] [stdout] 24 | let diff = self [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | let config = self.open_config()?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | Ok(CheckList::evaluate(&config, diff)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/service/diff.rs:42:12 [INFO] [stdout] | [INFO] [stdout] 29 | let (before, after) = match rev_parse { [INFO] [stdout] | ------ ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | RevParse::Range(ref first, _) => { [INFO] [stdout] 31 | let before = self.stack_metrics(opts.remote, first.as_str())?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | let after = self.stack_metrics(opts.remote, &rev_parse.to_string())?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 36 | let before = self.stack_metrics(opts.remote, &format!("{single}~1"))?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | let after = self.get_metrics(single.as_str(), opts.remote)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 42 | Ok(MetricDiffList::new(before, after)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 16 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `git-metrics` (bin "git-metrics" test) due to 17 previous errors [INFO] running `Command { std: "docker" "inspect" "3896064d02dc36d62a49a585bb6417febc6261cc3d660d3d5ce2118e87b8fc72", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3896064d02dc36d62a49a585bb6417febc6261cc3d660d3d5ce2118e87b8fc72", kill_on_drop: false }` [INFO] [stdout] 3896064d02dc36d62a49a585bb6417febc6261cc3d660d3d5ce2118e87b8fc72