[INFO] fetching crate git-local-ignore 1.0.0... [INFO] checking git-local-ignore-1.0.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate git-local-ignore 1.0.0 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate git-local-ignore 1.0.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate git-local-ignore 1.0.0 [INFO] finished tweaking crates.io crate git-local-ignore 1.0.0 [INFO] tweaked toml for crates.io crate git-local-ignore 1.0.0 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate git-local-ignore 1.0.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5006b5ecab5e5559b8bc0d20634d55feec6589608b0935edc049d50257b71464 [INFO] running `Command { std: "docker" "start" "-a" "5006b5ecab5e5559b8bc0d20634d55feec6589608b0935edc049d50257b71464", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5006b5ecab5e5559b8bc0d20634d55feec6589608b0935edc049d50257b71464", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5006b5ecab5e5559b8bc0d20634d55feec6589608b0935edc049d50257b71464", kill_on_drop: false }` [INFO] [stdout] 5006b5ecab5e5559b8bc0d20634d55feec6589608b0935edc049d50257b71464 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e5246026929f686b5675115c8e21ac212afb391baf9b624e471d5014e53cbb25 [INFO] running `Command { std: "docker" "start" "-a" "e5246026929f686b5675115c8e21ac212afb391baf9b624e471d5014e53cbb25", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.71 [INFO] [stderr] Compiling version_check v0.9.2 [INFO] [stderr] Compiling proc-macro2 v1.0.18 [INFO] [stderr] Compiling unicode-xid v0.2.1 [INFO] [stderr] Compiling getrandom v0.1.14 [INFO] [stderr] Compiling syn v1.0.33 [INFO] [stderr] Checking unicode-width v0.1.8 [INFO] [stderr] Compiling indexmap v1.4.0 [INFO] [stderr] Checking ppv-lite86 v0.2.8 [INFO] [stderr] Compiling unicode-segmentation v1.6.0 [INFO] [stderr] Checking regex-syntax v0.6.18 [INFO] [stderr] Checking textwrap v0.12.1 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling heck v0.3.1 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Checking termcolor v1.1.0 [INFO] [stderr] Checking remove_dir_all v0.5.3 [INFO] [stderr] Checking os_str_bytes v2.3.1 [INFO] [stderr] Checking pathdiff v0.2.0 [INFO] [stderr] Compiling quote v1.0.7 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking termios v0.3.2 [INFO] [stderr] Checking terminal_size v0.1.13 [INFO] [stderr] Checking colored v2.0.0 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking regex v1.3.9 [INFO] [stderr] Checking console v0.11.3 [INFO] [stderr] Checking tempfile v3.1.0 [INFO] [stderr] Checking dialoguer v0.6.2 [INFO] [stderr] Compiling clap_derive v3.0.0-beta.2 [INFO] [stderr] Checking clap v3.0.0-beta.2 [INFO] [stderr] Checking clap_generate v3.0.0-beta.2 [INFO] [stderr] Checking git-local-ignore v1.0.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/git.rs:16:12 [INFO] [stdout] | [INFO] [stdout] 15 | let exclude_file = File::open(self.exclude_file_path()?)?; [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | Ok(io::BufReader::new(exclude_file) [INFO] [stdout] | ____________^ [INFO] [stdout] 17 | | .lines() [INFO] [stdout] 18 | | .filter_map(Result::ok) [INFO] [stdout] 19 | | .filter(|line| !line.starts_with("#"))) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________________________________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `git-local-ignore` (bin "git-local-ignore") due to 2 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/git.rs:16:12 [INFO] [stdout] | [INFO] [stdout] 15 | let exclude_file = File::open(self.exclude_file_path()?)?; [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | Ok(io::BufReader::new(exclude_file) [INFO] [stdout] | ____________^ [INFO] [stdout] 17 | | .lines() [INFO] [stdout] 18 | | .filter_map(Result::ok) [INFO] [stdout] 19 | | .filter(|line| !line.starts_with("#"))) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________________________________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `git-local-ignore` (bin "git-local-ignore" test) due to 2 previous errors [INFO] running `Command { std: "docker" "inspect" "e5246026929f686b5675115c8e21ac212afb391baf9b624e471d5014e53cbb25", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e5246026929f686b5675115c8e21ac212afb391baf9b624e471d5014e53cbb25", kill_on_drop: false }` [INFO] [stdout] e5246026929f686b5675115c8e21ac212afb391baf9b624e471d5014e53cbb25