[INFO] fetching crate git-index 0.12.4... [INFO] checking git-index-0.12.4 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate git-index 0.12.4 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate git-index 0.12.4 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate git-index 0.12.4 [INFO] finished tweaking crates.io crate git-index 0.12.4 [INFO] tweaked toml for crates.io crate git-index 0.12.4 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 81 packages to latest compatible versions [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding dashmap v5.5.3 (latest: v6.0.1) [INFO] [stderr] Adding fastrand v1.9.0 (latest: v2.1.1) [INFO] [stderr] Adding hashbrown v0.13.2 (latest: v0.14.5) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding memmap2 v0.5.10 (latest: v0.9.4) [INFO] [stderr] Adding prodash v23.1.2 (latest: v29.0.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a2826f1bc1d77b122c4f10344e4fd9d600a2437d4da10f492abb76702dd7cdd3 [INFO] running `Command { std: "docker" "start" "-a" "a2826f1bc1d77b122c4f10344e4fd9d600a2437d4da10f492abb76702dd7cdd3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a2826f1bc1d77b122c4f10344e4fd9d600a2437d4da10f492abb76702dd7cdd3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a2826f1bc1d77b122c4f10344e4fd9d600a2437d4da10f492abb76702dd7cdd3", kill_on_drop: false }` [INFO] [stdout] a2826f1bc1d77b122c4f10344e4fd9d600a2437d4da10f492abb76702dd7cdd3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8f1e83d0e2bcca62726d255e8ace3339a81b96d8647619a9ea8e1171a3984456 [INFO] running `Command { std: "docker" "start" "-a" "8f1e83d0e2bcca62726d255e8ace3339a81b96d8647619a9ea8e1171a3984456", kill_on_drop: false }` [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Compiling time-core v0.1.2 [INFO] [stderr] Compiling num-conv v0.1.0 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking num_threads v0.1.7 [INFO] [stderr] Compiling rustix v0.38.35 [INFO] [stderr] Checking quick-error v2.0.1 [INFO] [stderr] Checking minimal-lexical v0.2.1 [INFO] [stderr] Checking bytesize v1.3.0 [INFO] [stderr] Compiling signal-hook v0.3.17 [INFO] [stderr] Checking human_format v1.1.0 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking sha1_smol v1.0.1 [INFO] [stderr] Checking hashbrown v0.13.2 [INFO] [stderr] Checking git-hash v0.10.3 [INFO] [stderr] Checking memmap2 v0.5.10 [INFO] [stderr] Checking git-bitmap v0.2.2 [INFO] [stderr] Compiling time-macros v0.2.18 [INFO] [stderr] Checking prodash v23.1.2 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking git-features v0.26.5 [INFO] [stderr] Checking git-hashtable v0.1.2 [INFO] [stderr] Checking dashmap v5.5.3 [INFO] [stderr] Checking bstr v1.10.0 [INFO] [stderr] Checking btoi v0.4.3 [INFO] [stderr] Checking atoi v2.0.0 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking git-validate v0.7.3 [INFO] [stderr] Checking tempfile v3.12.0 [INFO] [stderr] Checking git-tempfile v3.0.3 [INFO] [stderr] Checking git-lock v3.0.3 [INFO] [stderr] Checking git-date v0.4.3 [INFO] [stderr] Checking git-actor v0.17.2 [INFO] [stderr] Checking git-object v0.26.2 [INFO] [stderr] Checking git-traverse v0.22.2 [INFO] [stderr] Checking git-index v0.12.4 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `nanos_since_1970` is never read [INFO] [stdout] --> src/extension/fs_monitor.rs:10:10 [INFO] [stdout] | [INFO] [stdout] 10 | V1 { nanos_since_1970: u64 }, [INFO] [stdout] | -- ^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `Token` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `token` is never read [INFO] [stdout] --> src/extension/fs_monitor.rs:11:10 [INFO] [stdout] | [INFO] [stdout] 11 | V2 { token: BString }, [INFO] [stdout] | -- ^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `Token` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/file/init.rs:38:12 [INFO] [stdout] | [INFO] [stdout] 33 | path: impl Into, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | Ok(match Self::at(&path, object_hash, options) { [INFO] [stdout] | ____________^ [INFO] [stdout] 39 | | Ok(f) => f, [INFO] [stdout] 40 | | Err(Error::Io(err)) if err.kind() == std::io::ErrorKind::NotFound => { [INFO] [stdout] 41 | | File::from_state(State::new(object_hash), path) [INFO] [stdout] 42 | | } [INFO] [stdout] 43 | | Err(err) => return Err(err), [INFO] [stdout] 44 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/file/verify.rs:36:50 [INFO] [stdout] | [INFO] [stdout] 36 | (actual == checksum).then_some(()).ok_or(Error::ChecksumMismatch { [INFO] [stdout] | __________________________________________________^ [INFO] [stdout] 37 | | actual, [INFO] [stdout] 38 | | expected: checksum, [INFO] [stdout] 39 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/extension/decode.rs:69:8 [INFO] [stdout] | [INFO] [stdout] 38 | let mut ext = Outcome::default(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 69 | Ok((ext, &maybe_beginning_of_extensions[ext_iter.consumed..])) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/extension/tree/decode.rs:54:10 [INFO] [stdout] | [INFO] [stdout] 40 | let mut subtrees = Vec::with_capacity(subtree_count); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 54 | Some(( [INFO] [stdout] | __________^ [INFO] [stdout] 55 | | Tree { [INFO] [stdout] 56 | | id, [INFO] [stdout] 57 | | num_entries: num_entries.try_into().ok(), [INFO] [stdout] ... | [INFO] [stdout] 61 | | data, [INFO] [stdout] 62 | | )) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/access/mod.rs:37:40 [INFO] [stdout] | [INFO] [stdout] 35 | mut filter_map: impl FnMut(&'a BStr, &Entry) -> Option + 'a, [INFO] [stdout] | -------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | ) -> impl Iterator + 'a { [INFO] [stdout] 37 | self.entries.iter().filter_map(move |e| { [INFO] [stdout] | ________________________________________^ [INFO] [stdout] 38 | | let p = e.path(self); [INFO] [stdout] 39 | | filter_map(p, e).map(|t| (p, t)) [INFO] [stdout] 40 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/access/mod.rs:39:13 [INFO] [stdout] | [INFO] [stdout] 35 | mut filter_map: impl FnMut(&'a BStr, &Entry) -> Option + 'a, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | filter_map(p, e).map(|t| (p, t)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/init.rs:57:16 [INFO] [stdout] | [INFO] [stdout] 38 | pub fn from_tree(tree: &git_hash::oid, mut find: Find) -> Result [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 57 | Ok(State { [INFO] [stdout] | ________________^ [INFO] [stdout] 58 | | object_hash: tree.kind(), [INFO] [stdout] 59 | | timestamp: filetime::FileTime::now(), [INFO] [stdout] 60 | | version: Version::V2, [INFO] [stdout] ... | [INFO] [stdout] 68 | | fs_monitor: None, [INFO] [stdout] 69 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/decode/mod.rs:241:12 [INFO] [stdout] | [INFO] [stdout] 80 | let (entries, ext, data) = match start_of_extensions { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 84 | let (entries_res, ext_res) = git_features::parallel::threads(|scope| { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 194 | let (ext, data) = ext_res?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 205 | let (ext, data) = extension::decode::all(data, object_hash)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 232 | tree, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 241 | Ok(( [INFO] [stdout] | ____________^ [INFO] [stdout] 242 | | State { [INFO] [stdout] 243 | | object_hash, [INFO] [stdout] 244 | | timestamp, [INFO] [stdout] ... | [INFO] [stdout] 256 | | checksum, [INFO] [stdout] 257 | | )) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/decode/mod.rs:151:84 [INFO] [stdout] | [INFO] [stdout] 151 | ... InOrderIter::from(threads.into_iter().map(|thread| thread.join().unwrap())); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/decode/mod.rs:189:39 [INFO] [stdout] | [INFO] [stdout] 189 | .map(|thread| thread.join().unwrap()) [INFO] [stdout] | ------ ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/write.rs:127:12 [INFO] [stdout] | [INFO] [stdout] 97 | mut write: CountBytes, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 127 | Ok((out, write.inner)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/write.rs:109:66 [INFO] [stdout] | [INFO] [stdout] 109 | .and_then(|signature| self.tree().map(|tree| tree.write_to(write).map(|_| signature))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/write.rs:113:30 [INFO] [stdout] | [INFO] [stdout] 113 | .then(|| extension::sparse::write_to(write).map(|_| extension::sparse::SIGNATURE)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 13 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `git-index` (lib test) due to 14 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: field `nanos_since_1970` is never read [INFO] [stdout] --> src/extension/fs_monitor.rs:10:10 [INFO] [stdout] | [INFO] [stdout] 10 | V1 { nanos_since_1970: u64 }, [INFO] [stdout] | -- ^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `Token` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `token` is never read [INFO] [stdout] --> src/extension/fs_monitor.rs:11:10 [INFO] [stdout] | [INFO] [stdout] 11 | V2 { token: BString }, [INFO] [stdout] | -- ^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `Token` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/file/init.rs:38:12 [INFO] [stdout] | [INFO] [stdout] 33 | path: impl Into, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | Ok(match Self::at(&path, object_hash, options) { [INFO] [stdout] | ____________^ [INFO] [stdout] 39 | | Ok(f) => f, [INFO] [stdout] 40 | | Err(Error::Io(err)) if err.kind() == std::io::ErrorKind::NotFound => { [INFO] [stdout] 41 | | File::from_state(State::new(object_hash), path) [INFO] [stdout] 42 | | } [INFO] [stdout] 43 | | Err(err) => return Err(err), [INFO] [stdout] 44 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/file/verify.rs:36:50 [INFO] [stdout] | [INFO] [stdout] 36 | (actual == checksum).then_some(()).ok_or(Error::ChecksumMismatch { [INFO] [stdout] | __________________________________________________^ [INFO] [stdout] 37 | | actual, [INFO] [stdout] 38 | | expected: checksum, [INFO] [stdout] 39 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/extension/decode.rs:69:8 [INFO] [stdout] | [INFO] [stdout] 38 | let mut ext = Outcome::default(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 69 | Ok((ext, &maybe_beginning_of_extensions[ext_iter.consumed..])) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/extension/tree/decode.rs:54:10 [INFO] [stdout] | [INFO] [stdout] 40 | let mut subtrees = Vec::with_capacity(subtree_count); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 54 | Some(( [INFO] [stdout] | __________^ [INFO] [stdout] 55 | | Tree { [INFO] [stdout] 56 | | id, [INFO] [stdout] 57 | | num_entries: num_entries.try_into().ok(), [INFO] [stdout] ... | [INFO] [stdout] 61 | | data, [INFO] [stdout] 62 | | )) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/access/mod.rs:37:40 [INFO] [stdout] | [INFO] [stdout] 35 | mut filter_map: impl FnMut(&'a BStr, &Entry) -> Option + 'a, [INFO] [stdout] | -------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | ) -> impl Iterator + 'a { [INFO] [stdout] 37 | self.entries.iter().filter_map(move |e| { [INFO] [stdout] | ________________________________________^ [INFO] [stdout] 38 | | let p = e.path(self); [INFO] [stdout] 39 | | filter_map(p, e).map(|t| (p, t)) [INFO] [stdout] 40 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/access/mod.rs:39:13 [INFO] [stdout] | [INFO] [stdout] 35 | mut filter_map: impl FnMut(&'a BStr, &Entry) -> Option + 'a, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | filter_map(p, e).map(|t| (p, t)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/init.rs:57:16 [INFO] [stdout] | [INFO] [stdout] 38 | pub fn from_tree(tree: &git_hash::oid, mut find: Find) -> Result [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 57 | Ok(State { [INFO] [stdout] | ________________^ [INFO] [stdout] 58 | | object_hash: tree.kind(), [INFO] [stdout] 59 | | timestamp: filetime::FileTime::now(), [INFO] [stdout] 60 | | version: Version::V2, [INFO] [stdout] ... | [INFO] [stdout] 68 | | fs_monitor: None, [INFO] [stdout] 69 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/decode/mod.rs:241:12 [INFO] [stdout] | [INFO] [stdout] 80 | let (entries, ext, data) = match start_of_extensions { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 84 | let (entries_res, ext_res) = git_features::parallel::threads(|scope| { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 194 | let (ext, data) = ext_res?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 205 | let (ext, data) = extension::decode::all(data, object_hash)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 232 | tree, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 241 | Ok(( [INFO] [stdout] | ____________^ [INFO] [stdout] 242 | | State { [INFO] [stdout] 243 | | object_hash, [INFO] [stdout] 244 | | timestamp, [INFO] [stdout] ... | [INFO] [stdout] 256 | | checksum, [INFO] [stdout] 257 | | )) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/decode/mod.rs:151:84 [INFO] [stdout] | [INFO] [stdout] 151 | ... InOrderIter::from(threads.into_iter().map(|thread| thread.join().unwrap())); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/decode/mod.rs:189:39 [INFO] [stdout] | [INFO] [stdout] 189 | .map(|thread| thread.join().unwrap()) [INFO] [stdout] | ------ ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/write.rs:127:12 [INFO] [stdout] | [INFO] [stdout] 97 | mut write: CountBytes, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 127 | Ok((out, write.inner)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/write.rs:109:66 [INFO] [stdout] | [INFO] [stdout] 109 | .and_then(|signature| self.tree().map(|tree| tree.write_to(write).map(|_| signature))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/write.rs:113:30 [INFO] [stdout] | [INFO] [stdout] 113 | .then(|| extension::sparse::write_to(write).map(|_| extension::sparse::SIGNATURE)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 13 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `git-index` (lib) due to 14 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "8f1e83d0e2bcca62726d255e8ace3339a81b96d8647619a9ea8e1171a3984456", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8f1e83d0e2bcca62726d255e8ace3339a81b96d8647619a9ea8e1171a3984456", kill_on_drop: false }` [INFO] [stdout] 8f1e83d0e2bcca62726d255e8ace3339a81b96d8647619a9ea8e1171a3984456