[INFO] fetching crate git-gr 1.4.3... [INFO] checking git-gr-1.4.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate git-gr 1.4.3 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate git-gr 1.4.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate git-gr 1.4.3 [INFO] finished tweaking crates.io crate git-gr 1.4.3 [INFO] tweaked toml for crates.io crate git-gr 1.4.3 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate git-gr 1.4.3 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3dcf0a80baca0da20ea05227faab7b7a1375c9dd05fc98b8f7c5747c9aa5ab0f [INFO] running `Command { std: "docker" "start" "-a" "3dcf0a80baca0da20ea05227faab7b7a1375c9dd05fc98b8f7c5747c9aa5ab0f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3dcf0a80baca0da20ea05227faab7b7a1375c9dd05fc98b8f7c5747c9aa5ab0f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3dcf0a80baca0da20ea05227faab7b7a1375c9dd05fc98b8f7c5747c9aa5ab0f", kill_on_drop: false }` [INFO] [stdout] 3dcf0a80baca0da20ea05227faab7b7a1375c9dd05fc98b8f7c5747c9aa5ab0f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] bd20195cf3ddd79d5b43da3891e6c2dfa972f9068a2c0543698bc09863984952 [INFO] running `Command { std: "docker" "start" "-a" "bd20195cf3ddd79d5b43da3891e6c2dfa972f9068a2c0543698bc09863984952", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Compiling autocfg v1.3.0 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking pin-project-lite v0.2.14 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Checking bytes v1.7.1 [INFO] [stderr] Checking itoa v1.0.11 [INFO] [stderr] Compiling cc v1.1.8 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Compiling vcpkg v0.2.15 [INFO] [stderr] Compiling pkg-config v0.3.30 [INFO] [stderr] Compiling serde v1.0.204 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking fnv v1.0.7 [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Checking pin-utils v0.1.0 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking is_ci v1.2.0 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Compiling io-lifetimes v1.0.11 [INFO] [stderr] Checking equivalent v1.0.1 [INFO] [stderr] Compiling httparse v1.9.4 [INFO] [stderr] Checking tinyvec_macros v0.1.1 [INFO] [stderr] Compiling parking_lot_core v0.9.10 [INFO] [stderr] Compiling rustix v0.37.27 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Checking foreign-types-shared v0.1.1 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Compiling openssl v0.10.66 [INFO] [stderr] Checking foreign-types v0.3.2 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking tinyvec v1.8.0 [INFO] [stderr] Checking percent-encoding v2.3.1 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Checking try-lock v0.2.5 [INFO] [stderr] Compiling native-tls v0.2.12 [INFO] [stderr] Compiling ident_case v1.0.1 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking atomic-waker v1.1.2 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Compiling openssl-src v300.3.1+3.3.1 [INFO] [stderr] Compiling strsim v0.11.1 [INFO] [stderr] Compiling parking_lot_core v0.8.6 [INFO] [stderr] Checking linux-raw-sys v0.3.8 [INFO] [stderr] Compiling paste v1.0.15 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Checking anstyle-parse v0.2.5 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking form_urlencoded v1.2.1 [INFO] [stderr] Checking want v0.3.1 [INFO] [stderr] Checking indexmap v2.3.0 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Compiling syn v2.0.72 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking instant v0.1.13 [INFO] [stderr] Checking tower-service v0.3.2 [INFO] [stderr] Checking unicode-bidi v0.3.15 [INFO] [stderr] Checking anstyle-query v1.1.1 [INFO] [stderr] Compiling rustversion v1.0.17 [INFO] [stderr] Checking regex-syntax v0.6.29 [INFO] [stderr] Checking openssl-probe v0.1.5 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking tower-layer v0.3.2 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking unicode-width v0.1.13 [INFO] [stderr] Checking is_terminal_polyfill v1.70.1 [INFO] [stderr] Checking anstyle v1.0.8 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Checking colorchoice v1.0.2 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Compiling openssl-sys v0.9.103 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Checking anstream v0.6.15 [INFO] [stderr] Checking mio v1.0.1 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking is-terminal v0.4.12 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Checking smawk v0.3.2 [INFO] [stderr] Checking ryu v1.0.18 [INFO] [stderr] Checking clap_lex v0.7.2 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking powerfmt v0.2.0 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Compiling time-core v0.1.2 [INFO] [stderr] Compiling num-conv v0.1.0 [INFO] [stderr] Checking tokio v1.39.2 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking terminal_size v0.3.0 [INFO] [stderr] Checking overload v0.1.1 [INFO] [stderr] Checking unicode-linebreak v0.1.5 [INFO] [stderr] Compiling time-macros v0.2.18 [INFO] [stderr] Checking nu-ansi-term v0.46.0 [INFO] [stderr] Checking parking_lot v0.11.2 [INFO] [stderr] Checking rmp v0.8.14 [INFO] [stderr] Checking clap_builder v4.5.13 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Checking supports-color v2.1.0 [INFO] [stderr] Checking supports-color v1.3.1 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking dirs-sys v0.3.7 [INFO] [stderr] Checking fs2 v0.4.3 [INFO] [stderr] Checking fxhash v0.2.1 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Compiling fs-err v2.11.0 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Checking thread_local v1.1.8 [INFO] [stderr] Checking crc32fast v1.4.2 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking base64 v0.22.1 [INFO] [stderr] Checking rustls-pki-types v1.8.0 [INFO] [stderr] Checking num_threads v0.1.7 [INFO] [stderr] Compiling serde_json v1.0.122 [INFO] [stderr] Compiling camino v1.1.7 [INFO] [stderr] Checking sled v0.34.7 [INFO] [stderr] Checking owo-colors v3.5.0 [INFO] [stderr] Checking terminal_size v0.2.6 [INFO] [stderr] Checking directories v4.0.1 [INFO] [stderr] Checking rustls-pemfile v2.1.3 [INFO] [stderr] Checking textwrap v0.16.1 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking owo-colors v4.0.0 [INFO] [stderr] Checking itertools v0.11.0 [INFO] [stderr] Checking crossterm v0.27.0 [INFO] [stderr] Checking supports-color v3.0.0 [INFO] [stderr] Checking encoding_rs v0.8.34 [INFO] [stderr] Checking utf8-command v1.0.1 [INFO] [stderr] Checking supports-unicode v3.0.0 [INFO] [stderr] Checking home v0.5.9 [INFO] [stderr] Checking matchers v0.1.0 [INFO] [stderr] Checking zeroize v1.8.1 [INFO] [stderr] Checking strum v0.26.3 [INFO] [stderr] Checking supports-hyperlinks v3.0.0 [INFO] [stderr] Checking shell-words v1.1.0 [INFO] [stderr] Checking ipnet v2.9.0 [INFO] [stderr] Compiling convert_case v0.4.0 [INFO] [stderr] Checking mime v0.3.17 [INFO] [stderr] Checking sync_wrapper v1.0.1 [INFO] [stderr] Checking dyn-clone v1.0.17 [INFO] [stderr] Checking secrecy v0.8.0 [INFO] [stderr] Checking webbrowser v0.8.15 [INFO] [stderr] Checking itertools v0.12.1 [INFO] [stderr] Checking diff v0.1.13 [INFO] [stderr] Checking http-body-util v0.1.2 [INFO] [stderr] Checking tap v1.0.1 [INFO] [stderr] Checking yansi v0.5.1 [INFO] [stderr] Compiling indoc v2.0.5 [INFO] [stderr] Checking pretty_assertions v1.4.0 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Compiling calmio_filters v0.1.0 [INFO] [stderr] Compiling darling_core v0.20.10 [INFO] [stderr] Checking calm_io v0.1.1 [INFO] [stderr] Compiling serde_derive v1.0.204 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling clap_derive v4.5.13 [INFO] [stderr] Compiling strum_macros v0.26.4 [INFO] [stderr] Compiling derive_more v0.99.18 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking h2 v0.4.5 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking command-error v0.4.0 [INFO] [stderr] Checking miette v7.2.0 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Compiling darling_macro v0.20.10 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Compiling darling v0.20.10 [INFO] [stderr] Checking clap v4.5.13 [INFO] [stderr] Compiling serde_with_macros v3.9.0 [INFO] [stderr] Checking clap_complete v4.5.12 [INFO] [stderr] Checking tracing-human-layer v0.1.3 [INFO] [stderr] Checking comfy-table v7.1.1 [INFO] [stderr] Checking hyper v1.4.1 [INFO] [stderr] Checking hyper-util v0.1.7 [INFO] [stderr] Checking deranged v0.3.11 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking rmp-serde v1.3.0 [INFO] [stderr] Checking cached v0.49.3 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking serde_with v3.9.0 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking hyper-tls v0.6.0 [INFO] [stderr] Checking reqwest v0.12.5 [INFO] [stderr] Checking git-gr v1.4.3 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gerrit.rs:76:12 [INFO] [stdout] | [INFO] [stdout] 75 | let cache = GerritCache::new(&host)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 76 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 77 | | host, [INFO] [stdout] 78 | | http_password: None, [INFO] [stdout] 79 | | http_client: None, [INFO] [stdout] 80 | | cache, [INFO] [stdout] 81 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gerrit.rs:525:9 [INFO] [stdout] | [INFO] [stdout] 521 | method: Method, [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 525 | / serde_json::from_str(&response) [INFO] [stdout] 526 | | .into_diagnostic() [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |______________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `git-gr` (bin "git-gr") due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gerrit.rs:76:12 [INFO] [stdout] | [INFO] [stdout] 75 | let cache = GerritCache::new(&host)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 76 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 77 | | host, [INFO] [stdout] 78 | | http_password: None, [INFO] [stdout] 79 | | http_client: None, [INFO] [stdout] 80 | | cache, [INFO] [stdout] 81 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gerrit.rs:525:9 [INFO] [stdout] | [INFO] [stdout] 521 | method: Method, [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 525 | / serde_json::from_str(&response) [INFO] [stdout] 526 | | .into_diagnostic() [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |______________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/unicode_tree.rs:28:23 [INFO] [stdout] | [INFO] [stdout] 25 | pub fn new_from(label: impl AsRef, children: impl IntoIterator) -> Self { [INFO] [stdout] | ---------------------- ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 28 | children: children [INFO] [stdout] | _______________________^ [INFO] [stdout] 29 | | .into_iter() [INFO] [stdout] 30 | | .map(|child| Arc::new(Mutex::new(child))) [INFO] [stdout] 31 | | .collect(), [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/unicode_tree.rs:30:39 [INFO] [stdout] | [INFO] [stdout] 30 | .map(|child| Arc::new(Mutex::new(child))) [INFO] [stdout] | ----- ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `git-gr` (bin "git-gr" test) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "bd20195cf3ddd79d5b43da3891e6c2dfa972f9068a2c0543698bc09863984952", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bd20195cf3ddd79d5b43da3891e6c2dfa972f9068a2c0543698bc09863984952", kill_on_drop: false }` [INFO] [stdout] bd20195cf3ddd79d5b43da3891e6c2dfa972f9068a2c0543698bc09863984952