[INFO] crate git-global 0.6.3 is already in cache [INFO] checking git-global-0.6.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate git-global 0.6.3 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate git-global 0.6.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate git-global 0.6.3 [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate git-global 0.6.3 [INFO] tweaked toml for crates.io crate git-global 0.6.3 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate git-global 0.6.3 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8284aa19ebd821568fdc592277e181f17e3a12ec58b535122b995b59c03b1ba8 [INFO] running `Command { std: "docker" "start" "-a" "8284aa19ebd821568fdc592277e181f17e3a12ec58b535122b995b59c03b1ba8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8284aa19ebd821568fdc592277e181f17e3a12ec58b535122b995b59c03b1ba8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8284aa19ebd821568fdc592277e181f17e3a12ec58b535122b995b59c03b1ba8", kill_on_drop: false }` [INFO] [stdout] 8284aa19ebd821568fdc592277e181f17e3a12ec58b535122b995b59c03b1ba8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 074727e85e0592d12f3a54443f2f3f0df8739860e858c80ce6e8ff39e9301892 [INFO] running `Command { std: "docker" "start" "-a" "074727e85e0592d12f3a54443f2f3f0df8739860e858c80ce6e8ff39e9301892", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling pkg-config v0.3.30 [INFO] [stderr] Compiling vcpkg v0.2.15 [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Checking tinyvec_macros v0.1.1 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Checking colorchoice v1.0.2 [INFO] [stderr] Checking unicode-bidi v0.3.15 [INFO] [stderr] Checking anstyle v1.0.8 [INFO] [stderr] Checking is_terminal_polyfill v1.70.1 [INFO] [stderr] Checking anstyle-query v1.1.1 [INFO] [stderr] Checking percent-encoding v2.3.1 [INFO] [stderr] Compiling serde v1.0.205 [INFO] [stderr] Checking tinyvec v1.8.0 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Checking option-ext v0.2.0 [INFO] [stderr] Compiling serde_json v1.0.122 [INFO] [stderr] Checking anstyle-parse v0.2.5 [INFO] [stderr] Checking clap_lex v0.7.2 [INFO] [stderr] Checking form_urlencoded v1.2.1 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking itoa v1.0.11 [INFO] [stderr] Checking ryu v1.0.18 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Checking fastrand v2.1.0 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking anstream v0.6.15 [INFO] [stderr] Checking walkdir v2.5.0 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking clap_builder v4.5.15 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling syn v2.0.72 [INFO] [stderr] Compiling jobserver v0.1.32 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking directories v5.0.1 [INFO] [stderr] Compiling cc v1.1.8 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Compiling libz-sys v1.1.18 [INFO] [stderr] Compiling libgit2-sys v0.17.0+1.8.1 [INFO] [stderr] Checking clap v4.5.15 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking tempfile v3.12.0 [INFO] [stderr] Compiling serde_derive v1.0.205 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking git2 v0.19.0 [INFO] [stderr] Checking git-global v0.6.3 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli.rs:43:36 [INFO] [stdout] | [INFO] [stdout] 43 | .map(|(cmd, desc)| Command::new(*cmd).about(*desc)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/repo.rs:59:9 [INFO] [stdout] | [INFO] [stdout] 58 | fn branch_to_commit(branch: git2::Branch) -> Option { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 59 | branch.into_reference().peel_to_commit().ok() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/repo.rs:69:9 [INFO] [stdout] | [INFO] [stdout] 65 | commit: git2::Commit, [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 66 | ) -> Vec { [INFO] [stdout] 67 | let mut revwalk = repo.revwalk().unwrap(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 68 | revwalk.push(commit.id()).unwrap(); [INFO] [stdout] 69 | revwalk.filter_map(|id| id.ok()).collect::>() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/repo.rs:87:34 [INFO] [stdout] | [INFO] [stdout] 87 | .filter_map(|branch| branch.ok().map(|b| b.0)) [INFO] [stdout] | ------ ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/repo.rs:94:34 [INFO] [stdout] | [INFO] [stdout] 94 | .filter_map(|branch| branch.ok().map(|b| b.0)) [INFO] [stdout] | ------ ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/repo.rs:95:33 [INFO] [stdout] | [INFO] [stdout] 95 | .any(|branch| match Self::branch_to_commit(branch) { [INFO] [stdout] | ------ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/subcommands/info.rs:18:30 [INFO] [stdout] | [INFO] [stdout] 18 | .and_then(|metadata| metadata.modified().ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli.rs:43:36 [INFO] [stdout] | [INFO] [stdout] 43 | .map(|(cmd, desc)| Command::new(*cmd).about(*desc)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/repo.rs:59:9 [INFO] [stdout] | [INFO] [stdout] 58 | fn branch_to_commit(branch: git2::Branch) -> Option { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 59 | branch.into_reference().peel_to_commit().ok() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/repo.rs:69:9 [INFO] [stdout] | [INFO] [stdout] 65 | commit: git2::Commit, [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 66 | ) -> Vec { [INFO] [stdout] 67 | let mut revwalk = repo.revwalk().unwrap(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 68 | revwalk.push(commit.id()).unwrap(); [INFO] [stdout] 69 | revwalk.filter_map(|id| id.ok()).collect::>() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/repo.rs:87:34 [INFO] [stdout] | [INFO] [stdout] 87 | .filter_map(|branch| branch.ok().map(|b| b.0)) [INFO] [stdout] | ------ ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/repo.rs:94:34 [INFO] [stdout] | [INFO] [stdout] 94 | .filter_map(|branch| branch.ok().map(|b| b.0)) [INFO] [stdout] | ------ ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/repo.rs:95:33 [INFO] [stdout] | [INFO] [stdout] 95 | .any(|branch| match Self::branch_to_commit(branch) { [INFO] [stdout] | ------ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/subcommands/info.rs:18:30 [INFO] [stdout] | [INFO] [stdout] 18 | .and_then(|metadata| metadata.modified().ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `git-global` (lib) due to 8 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `git-global` (lib test) due to 8 previous errors [INFO] running `Command { std: "docker" "inspect" "074727e85e0592d12f3a54443f2f3f0df8739860e858c80ce6e8ff39e9301892", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "074727e85e0592d12f3a54443f2f3f0df8739860e858c80ce6e8ff39e9301892", kill_on_drop: false }` [INFO] [stdout] 074727e85e0592d12f3a54443f2f3f0df8739860e858c80ce6e8ff39e9301892