[INFO] fetching crate git-glimpse 0.4.7... [INFO] checking git-glimpse-0.4.7 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate git-glimpse 0.4.7 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate git-glimpse 0.4.7 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate git-glimpse 0.4.7 [INFO] finished tweaking crates.io crate git-glimpse 0.4.7 [INFO] tweaked toml for crates.io crate git-glimpse 0.4.7 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate git-glimpse 0.4.7 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 64abe474c12b12012412b44c3ca8cc206ad9d41009dc08502c2928a651d01f9e [INFO] running `Command { std: "docker" "start" "-a" "64abe474c12b12012412b44c3ca8cc206ad9d41009dc08502c2928a651d01f9e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "64abe474c12b12012412b44c3ca8cc206ad9d41009dc08502c2928a651d01f9e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "64abe474c12b12012412b44c3ca8cc206ad9d41009dc08502c2928a651d01f9e", kill_on_drop: false }` [INFO] [stdout] 64abe474c12b12012412b44c3ca8cc206ad9d41009dc08502c2928a651d01f9e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 94a04b259e94a39e4650d7d02e07962e08e6a6f695efb5f2a2d55239727b6176 [INFO] running `Command { std: "docker" "start" "-a" "94a04b259e94a39e4650d7d02e07962e08e6a6f695efb5f2a2d55239727b6176", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.64 [INFO] [stderr] Compiling quote v1.0.29 [INFO] [stderr] Compiling unicode-ident v1.0.10 [INFO] [stderr] Compiling rustix v0.38.19 [INFO] [stderr] Checking bitflags v2.4.1 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Checking linux-raw-sys v0.4.10 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Checking regex-syntax v0.7.4 [INFO] [stderr] Checking anstyle-query v1.0.0 [INFO] [stderr] Checking colorchoice v1.0.0 [INFO] [stderr] Checking anstyle v1.0.1 [INFO] [stderr] Compiling thiserror v1.0.43 [INFO] [stderr] Checking log v0.4.19 [INFO] [stderr] Checking clap_lex v0.5.0 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Compiling anyhow v1.0.71 [INFO] [stderr] Checking anstyle-parse v0.2.1 [INFO] [stderr] Checking shell-words v1.1.0 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Checking termcolor v1.2.0 [INFO] [stderr] Checking once_cell v1.18.0 [INFO] [stderr] Checking aho-corasick v1.0.2 [INFO] [stderr] Compiling syn v2.0.25 [INFO] [stderr] Checking regex-automata v0.3.3 [INFO] [stderr] Checking is-terminal v0.4.9 [INFO] [stderr] Checking anstream v0.3.2 [INFO] [stderr] Checking clap_builder v4.3.11 [INFO] [stderr] Checking regex v1.9.1 [INFO] [stderr] Checking env_logger v0.10.0 [INFO] [stderr] Compiling thiserror-impl v1.0.43 [INFO] [stderr] Compiling clap_derive v4.3.2 [INFO] [stderr] Checking ezcmd v0.2.0 [INFO] [stderr] Checking clap v4.3.11 [INFO] [stderr] Checking git-glimpse v0.4.7 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:15:11 [INFO] [stdout] | [INFO] [stdout] 10 | pub fn run(f: F) [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 15 | match f() { [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:15:11 [INFO] [stdout] | [INFO] [stdout] 10 | pub fn run(f: F) [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 15 | match f() { [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:119:5 [INFO] [stdout] | [INFO] [stdout] 80 | pub fn show_graph<'a, Os, Fs>(format: Option, object_names: Os, files: Fs) -> Result<()> [INFO] [stdout] | ---------------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 119 | / EasyCommand::new_with("git", |cmd| { [INFO] [stdout] 120 | | cmd.args(["log", "--graph", "--decorate"]); [INFO] [stdout] 121 | | if let Some(format) = format { [INFO] [stdout] 122 | | cmd.arg(format!("--format={format}")); [INFO] [stdout] ... | [INFO] [stdout] 131 | | .map_err(Into::into) [INFO] [stdout] 132 | | .map_err(Error::other) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:126:19 [INFO] [stdout] | [INFO] [stdout] 80 | pub fn show_graph<'a, Os, Fs>(format: Option, object_names: Os, files: Fs) -> Result<()> [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 126 | .args(object_names.clone().into_iter()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:137:34 [INFO] [stdout] | [INFO] [stdout] 136 | pub fn list_branches_cmd(config: impl FnOnce(&mut Command) -> &mut Command) -> EasyCommand { [INFO] [stdout] | ------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 137 | EasyCommand::new_with("git", |cmd| { [INFO] [stdout] | __________________________________^ [INFO] [stdout] 138 | | config(cmd.args(["branch", "--list", "--format=%(refname:short)"])) [INFO] [stdout] 139 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:119:5 [INFO] [stdout] | [INFO] [stdout] 80 | pub fn show_graph<'a, Os, Fs>(format: Option, object_names: Os, files: Fs) -> Result<()> [INFO] [stdout] | ---------------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 119 | / EasyCommand::new_with("git", |cmd| { [INFO] [stdout] 120 | | cmd.args(["log", "--graph", "--decorate"]); [INFO] [stdout] 121 | | if let Some(format) = format { [INFO] [stdout] 122 | | cmd.arg(format!("--format={format}")); [INFO] [stdout] ... | [INFO] [stdout] 131 | | .map_err(Into::into) [INFO] [stdout] 132 | | .map_err(Error::other) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:126:19 [INFO] [stdout] | [INFO] [stdout] 80 | pub fn show_graph<'a, Os, Fs>(format: Option, object_names: Os, files: Fs) -> Result<()> [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 126 | .args(object_names.clone().into_iter()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:137:34 [INFO] [stdout] | [INFO] [stdout] 136 | pub fn list_branches_cmd(config: impl FnOnce(&mut Command) -> &mut Command) -> EasyCommand { [INFO] [stdout] | ------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 137 | EasyCommand::new_with("git", |cmd| { [INFO] [stdout] | __________________________________^ [INFO] [stdout] 138 | | config(cmd.args(["branch", "--list", "--format=%(refname:short)"])) [INFO] [stdout] 139 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `git-glimpse` (lib) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `git-glimpse` (lib test) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "94a04b259e94a39e4650d7d02e07962e08e6a6f695efb5f2a2d55239727b6176", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "94a04b259e94a39e4650d7d02e07962e08e6a6f695efb5f2a2d55239727b6176", kill_on_drop: false }` [INFO] [stdout] 94a04b259e94a39e4650d7d02e07962e08e6a6f695efb5f2a2d55239727b6176