[INFO] fetching crate git-diff 0.26.2... [INFO] checking git-diff-0.26.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate git-diff 0.26.2 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate git-diff 0.26.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate git-diff 0.26.2 [INFO] finished tweaking crates.io crate git-diff 0.26.2 [INFO] tweaked toml for crates.io crate git-diff 0.26.2 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 54 packages to latest compatible versions [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c25d8d73fc62304fc4f03b14bf714dc2cbf982a0ba2b905903d49ff4f9f0dfe2 [INFO] running `Command { std: "docker" "start" "-a" "c25d8d73fc62304fc4f03b14bf714dc2cbf982a0ba2b905903d49ff4f9f0dfe2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c25d8d73fc62304fc4f03b14bf714dc2cbf982a0ba2b905903d49ff4f9f0dfe2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c25d8d73fc62304fc4f03b14bf714dc2cbf982a0ba2b905903d49ff4f9f0dfe2", kill_on_drop: false }` [INFO] [stdout] c25d8d73fc62304fc4f03b14bf714dc2cbf982a0ba2b905903d49ff4f9f0dfe2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8be6b2384d62a8defbf5a3d10a18192ac40403bac13822348e59c3f16222d7fd [INFO] running `Command { std: "docker" "start" "-a" "8be6b2384d62a8defbf5a3d10a18192ac40403bac13822348e59c3f16222d7fd", kill_on_drop: false }` [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking num_threads v0.1.7 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking quick-error v2.0.1 [INFO] [stderr] Checking sha1_smol v1.0.1 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Checking git-hash v0.10.3 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking git-features v0.26.5 [INFO] [stderr] Checking imara-diff v0.1.7 [INFO] [stderr] Checking bstr v1.10.0 [INFO] [stderr] Checking btoi v0.4.3 [INFO] [stderr] Checking git-validate v0.7.3 [INFO] [stderr] Checking git-date v0.4.3 [INFO] [stderr] Checking git-actor v0.17.2 [INFO] [stderr] Checking git-object v0.26.2 [INFO] [stderr] Checking git-diff v0.26.2 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tree/changes.rs:81:41 [INFO] [stdout] | [INFO] [stdout] 79 | ... rhs_entries = peekable(find(&rhs, &mut state.buf2).map_err(|err| Error::FindExisting { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 80 | ... oid: rhs, [INFO] [stdout] 81 | ... source: err.into(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tree/changes.rs:88:41 [INFO] [stdout] | [INFO] [stdout] 86 | ... lhs_entries = peekable(find(&lhs, &mut state.buf1).map_err(|err| Error::FindExisting { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 87 | ... oid: lhs, [INFO] [stdout] 88 | ... source: err.into(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tree/changes.rs:92:41 [INFO] [stdout] | [INFO] [stdout] 90 | ... rhs_entries = peekable(find(&rhs, &mut state.buf2).map_err(|err| Error::FindExisting { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 91 | ... oid: rhs, [INFO] [stdout] 92 | ... source: err.into(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tree/changes.rs:99:41 [INFO] [stdout] | [INFO] [stdout] 97 | ... lhs_entries = peekable(find(&lhs, &mut state.buf1).map_err(|err| Error::FindExisting { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 98 | ... oid: lhs, [INFO] [stdout] 99 | ... source: err.into(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tree/changes.rs:345:33 [INFO] [stdout] | [INFO] [stdout] 344 | fn peekable(iter: I) -> IteratorType { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 345 | std::mem::ManuallyDrop::new(iter.peekable()) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `git-diff` (lib test) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tree/changes.rs:81:41 [INFO] [stdout] | [INFO] [stdout] 79 | ... rhs_entries = peekable(find(&rhs, &mut state.buf2).map_err(|err| Error::FindExisting { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 80 | ... oid: rhs, [INFO] [stdout] 81 | ... source: err.into(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tree/changes.rs:88:41 [INFO] [stdout] | [INFO] [stdout] 86 | ... lhs_entries = peekable(find(&lhs, &mut state.buf1).map_err(|err| Error::FindExisting { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 87 | ... oid: lhs, [INFO] [stdout] 88 | ... source: err.into(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tree/changes.rs:92:41 [INFO] [stdout] | [INFO] [stdout] 90 | ... rhs_entries = peekable(find(&rhs, &mut state.buf2).map_err(|err| Error::FindExisting { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 91 | ... oid: rhs, [INFO] [stdout] 92 | ... source: err.into(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tree/changes.rs:99:41 [INFO] [stdout] | [INFO] [stdout] 97 | ... lhs_entries = peekable(find(&lhs, &mut state.buf1).map_err(|err| Error::FindExisting { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 98 | ... oid: lhs, [INFO] [stdout] 99 | ... source: err.into(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tree/changes.rs:345:33 [INFO] [stdout] | [INFO] [stdout] 344 | fn peekable(iter: I) -> IteratorType { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 345 | std::mem::ManuallyDrop::new(iter.peekable()) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `git-diff` (lib) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "8be6b2384d62a8defbf5a3d10a18192ac40403bac13822348e59c3f16222d7fd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8be6b2384d62a8defbf5a3d10a18192ac40403bac13822348e59c3f16222d7fd", kill_on_drop: false }` [INFO] [stdout] 8be6b2384d62a8defbf5a3d10a18192ac40403bac13822348e59c3f16222d7fd