[INFO] fetching crate git-collage 0.4.3... [INFO] checking git-collage-0.4.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate git-collage 0.4.3 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate git-collage 0.4.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate git-collage 0.4.3 [INFO] finished tweaking crates.io crate git-collage 0.4.3 [INFO] tweaked toml for crates.io crate git-collage 0.4.3 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate git-collage 0.4.3 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4571e615202820cccf5625290b873149c8fccf958188d0439bb8a0cb005d587f [INFO] running `Command { std: "docker" "start" "-a" "4571e615202820cccf5625290b873149c8fccf958188d0439bb8a0cb005d587f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4571e615202820cccf5625290b873149c8fccf958188d0439bb8a0cb005d587f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4571e615202820cccf5625290b873149c8fccf958188d0439bb8a0cb005d587f", kill_on_drop: false }` [INFO] [stdout] 4571e615202820cccf5625290b873149c8fccf958188d0439bb8a0cb005d587f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2bac860d3d19617d425794b0b775bc1dacd62ad24a693dcafdc6f39f5c9448a7 [INFO] running `Command { std: "docker" "start" "-a" "2bac860d3d19617d425794b0b775bc1dacd62ad24a693dcafdc6f39f5c9448a7", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.76 [INFO] [stderr] Compiling libc v0.2.151 [INFO] [stderr] Checking memchr v2.6.3 [INFO] [stderr] Compiling serde v1.0.204 [INFO] [stderr] Compiling pkg-config v0.3.27 [INFO] [stderr] Compiling num-traits v0.2.16 [INFO] [stderr] Checking http v1.0.0 [INFO] [stderr] Checking tracing-core v0.1.31 [INFO] [stderr] Checking rustls-pki-types v1.2.0 [INFO] [stderr] Compiling crossbeam-utils v0.8.18 [INFO] [stderr] Compiling num-integer v0.1.45 [INFO] [stderr] Checking try-lock v0.2.4 [INFO] [stderr] Checking base64 v0.21.4 [INFO] [stderr] Checking want v0.3.1 [INFO] [stderr] Checking anstyle-parse v0.2.1 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Compiling syn v2.0.48 [INFO] [stderr] Compiling jobserver v0.1.26 [INFO] [stderr] Compiling num-bigint v0.4.4 [INFO] [stderr] Compiling thiserror v1.0.48 [INFO] [stderr] Checking http-body v1.0.0 [INFO] [stderr] Checking zeroize v1.6.0 [INFO] [stderr] Compiling cc v1.0.83 [INFO] [stderr] Checking mio v1.0.1 [INFO] [stderr] Checking socket2 v0.5.5 [INFO] [stderr] Checking getrandom v0.2.11 [INFO] [stderr] Compiling rustls v0.22.4 [INFO] [stderr] Checking anstyle v1.0.6 [INFO] [stderr] Compiling time-macros v0.2.18 [INFO] [stderr] Checking anstream v0.6.13 [INFO] [stderr] Checking aho-corasick v1.1.1 [INFO] [stderr] Checking regex-syntax v0.8.2 [INFO] [stderr] Checking subtle v2.5.0 [INFO] [stderr] Checking crossbeam-epoch v0.9.15 [INFO] [stderr] Checking rustls-pemfile v2.0.0 [INFO] [stderr] Checking bitflags v2.4.0 [INFO] [stderr] Checking hashbrown v0.14.0 [INFO] [stderr] Checking clap_builder v4.4.18 [INFO] [stderr] Checking indexmap v2.0.0 [INFO] [stderr] Checking crossbeam-deque v0.8.3 [INFO] [stderr] Compiling ring v0.17.7 [INFO] [stderr] Compiling libz-sys v1.1.12 [INFO] [stderr] Compiling openssl-sys v0.9.93 [INFO] [stderr] Compiling libssh2-sys v0.3.0 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Compiling libgit2-sys v0.17.0+1.8.1 [INFO] [stderr] Checking rustls-native-certs v0.7.0 [INFO] [stderr] Checking pem v3.0.3 [INFO] [stderr] Checking iana-time-zone v0.1.57 [INFO] [stderr] Checking winnow v0.6.18 [INFO] [stderr] Checking regex-automata v0.4.4 [INFO] [stderr] Checking iri-string v0.7.0 [INFO] [stderr] Checking either v1.9.0 [INFO] [stderr] Checking rayon-core v1.12.1 [INFO] [stderr] Checking secrecy v0.8.0 [INFO] [stderr] Checking arc-swap v1.6.0 [INFO] [stderr] Compiling once_cell v1.18.0 [INFO] [stderr] Checking base64 v0.22.0 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking crossbeam-channel v0.5.13 [INFO] [stderr] Checking regex v1.10.5 [INFO] [stderr] Compiling serde_derive v1.0.204 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling tracing-attributes v0.1.26 [INFO] [stderr] Compiling pin-project-internal v1.1.3 [INFO] [stderr] Compiling thiserror-impl v1.0.48 [INFO] [stderr] Checking tokio v1.39.2 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Compiling snafu-derive v0.8.1 [INFO] [stderr] Compiling clap_derive v4.4.7 [INFO] [stderr] Checking pin-project v1.1.3 [INFO] [stderr] Checking env_filter v0.1.0 [INFO] [stderr] Checking simple_asn1 v0.6.2 [INFO] [stderr] Compiling async-trait v0.1.81 [INFO] [stderr] Checking tracing v0.1.37 [INFO] [stderr] Checking env_logger v0.11.5 [INFO] [stderr] Compiling enum_dispatch v0.3.13 [INFO] [stderr] Checking snafu v0.8.1 [INFO] [stderr] Checking clap v4.4.18 [INFO] [stderr] Checking clap_complete v4.4.10 [INFO] [stderr] Checking tokio-util v0.7.9 [INFO] [stderr] Checking hyper v1.1.0 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking http-body-util v0.1.0 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking tower-http v0.5.1 [INFO] [stderr] Checking hyper-util v0.1.3 [INFO] [stderr] Checking rustls-webpki v0.102.2 [INFO] [stderr] Checking hyper-timeout v0.5.1 [INFO] [stderr] Checking toml_datetime v0.6.8 [INFO] [stderr] Checking serde_json v1.0.107 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Checking serde_spanned v0.6.7 [INFO] [stderr] Checking serde_path_to_error v0.1.14 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking toml_edit v0.22.20 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking serde_variant v0.1.3 [INFO] [stderr] Checking jsonwebtoken v9.2.0 [INFO] [stderr] Checking tokio-rustls v0.25.0 [INFO] [stderr] Checking hyper-rustls v0.26.0 [INFO] [stderr] Checking octocrab v0.39.0 [INFO] [stderr] Checking toml v0.8.19 [INFO] [stderr] Checking git2 v0.19.0 [INFO] [stderr] Checking git-collage v0.4.3 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config.rs:46:35 [INFO] [stdout] | [INFO] [stdout] 46 | .filter_map(|p| match fs::read_to_string(p) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config.rs:53:35 [INFO] [stdout] | [INFO] [stdout] 53 | .filter_map(|s| match toml::from_str::(&s) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config.rs:104:24 [INFO] [stdout] | [INFO] [stdout] 103 | .map(|r| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 104 | Ok(RepositoryMapping { [INFO] [stdout] | ________________________^ [INFO] [stdout] 105 | | path: self.path.join(if r.path.has_root() { [INFO] [stdout] 106 | | r.path.strip_prefix("/").unwrap() [INFO] [stdout] 107 | | } else { [INFO] [stdout] ... | [INFO] [stdout] 114 | | git_url: r.git_url, [INFO] [stdout] 115 | | }) [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/operation/mirror.rs:154:8 [INFO] [stdout] | [INFO] [stdout] 93 | let repo = match Repository::open(&config.path) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 94 | Ok(r) => r, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 106 | let mut remote = match repo.find_remote("origin") { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 107 | Ok(r) => r, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 111 | let mut remote2 = remote.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 154 | Ok(MirrorResult { [INFO] [stdout] | ________^ [INFO] [stdout] 155 | | mapping: config.clone(), [INFO] [stdout] 156 | | refs: ref_reports, [INFO] [stdout] 157 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/operation/stale.rs:49:25 [INFO] [stdout] | [INFO] [stdout] 49 | .filter(|i| i.file_type().unwrap().is_dir()) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/source/static_list.rs:27:28 [INFO] [stdout] | [INFO] [stdout] 27 | ref_match: r.ref_match.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config.rs:46:35 [INFO] [stdout] | [INFO] [stdout] 46 | .filter_map(|p| match fs::read_to_string(p) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config.rs:53:35 [INFO] [stdout] | [INFO] [stdout] 53 | .filter_map(|s| match toml::from_str::(&s) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config.rs:104:24 [INFO] [stdout] | [INFO] [stdout] 103 | .map(|r| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 104 | Ok(RepositoryMapping { [INFO] [stdout] | ________________________^ [INFO] [stdout] 105 | | path: self.path.join(if r.path.has_root() { [INFO] [stdout] 106 | | r.path.strip_prefix("/").unwrap() [INFO] [stdout] 107 | | } else { [INFO] [stdout] ... | [INFO] [stdout] 114 | | git_url: r.git_url, [INFO] [stdout] 115 | | }) [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/operation/mirror.rs:154:8 [INFO] [stdout] | [INFO] [stdout] 93 | let repo = match Repository::open(&config.path) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 94 | Ok(r) => r, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 106 | let mut remote = match repo.find_remote("origin") { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 107 | Ok(r) => r, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 111 | let mut remote2 = remote.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 154 | Ok(MirrorResult { [INFO] [stdout] | ________^ [INFO] [stdout] 155 | | mapping: config.clone(), [INFO] [stdout] 156 | | refs: ref_reports, [INFO] [stdout] 157 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/operation/stale.rs:49:25 [INFO] [stdout] | [INFO] [stdout] 49 | .filter(|i| i.file_type().unwrap().is_dir()) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/source/static_list.rs:27:28 [INFO] [stdout] | [INFO] [stdout] 27 | ref_match: r.ref_match.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `git-collage` (bin "git-collage" test) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `git-collage` (bin "git-collage") due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "2bac860d3d19617d425794b0b775bc1dacd62ad24a693dcafdc6f39f5c9448a7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2bac860d3d19617d425794b0b775bc1dacd62ad24a693dcafdc6f39f5c9448a7", kill_on_drop: false }` [INFO] [stdout] 2bac860d3d19617d425794b0b775bc1dacd62ad24a693dcafdc6f39f5c9448a7