[INFO] fetching crate git-branchless-lib 0.9.0... [INFO] checking git-branchless-lib-0.9.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate git-branchless-lib 0.9.0 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate git-branchless-lib 0.9.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate git-branchless-lib 0.9.0 [INFO] finished tweaking crates.io crate git-branchless-lib 0.9.0 [INFO] tweaked toml for crates.io crate git-branchless-lib 0.9.0 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate crates.io crate git-branchless-lib 0.9.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ba95c9e114cc093974e628973863cef7754e02f67892aed8cde1839758ecee4f [INFO] running `Command { std: "docker" "start" "-a" "ba95c9e114cc093974e628973863cef7754e02f67892aed8cde1839758ecee4f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ba95c9e114cc093974e628973863cef7754e02f67892aed8cde1839758ecee4f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ba95c9e114cc093974e628973863cef7754e02f67892aed8cde1839758ecee4f", kill_on_drop: false }` [INFO] [stdout] ba95c9e114cc093974e628973863cef7754e02f67892aed8cde1839758ecee4f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 643d416ed7e4b4c0ac3dd473fccbed477f7c784e1a3e5511ce5c0ccab41d32d7 [INFO] running `Command { std: "docker" "start" "-a" "643d416ed7e4b4c0ac3dd473fccbed477f7c784e1a3e5511ce5c0ccab41d32d7", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Compiling proc-macro2 v1.0.79 [INFO] [stderr] Compiling autocfg v1.2.0 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Checking memchr v2.7.2 [INFO] [stderr] Compiling crossbeam-utils v0.8.19 [INFO] [stderr] Compiling serde v1.0.198 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Compiling version_check v0.9.4 [INFO] [stderr] Checking regex-syntax v0.8.3 [INFO] [stderr] Checking unicode-width v0.1.11 [INFO] [stderr] Checking either v1.11.0 [INFO] [stderr] Checking bitflags v2.5.0 [INFO] [stderr] Checking zerocopy v0.7.32 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Compiling parking_lot_core v0.9.9 [INFO] [stderr] Compiling rustversion v1.0.15 [INFO] [stderr] Compiling signal-hook v0.3.17 [INFO] [stderr] Compiling getrandom v0.1.16 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Compiling fnv v1.0.7 [INFO] [stderr] Compiling ident_case v1.0.1 [INFO] [stderr] Checking regex-syntax v0.6.29 [INFO] [stderr] Checking ryu v1.0.17 [INFO] [stderr] Checking pin-utils v0.1.0 [INFO] [stderr] Compiling thiserror v1.0.59 [INFO] [stderr] Compiling num-traits v0.2.18 [INFO] [stderr] Compiling lock_api v0.4.11 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Checking allocator-api2 v0.2.18 [INFO] [stderr] Compiling rustix v0.38.32 [INFO] [stderr] Checking stable_deref_trait v1.2.0 [INFO] [stderr] Compiling num-rational v0.4.1 [INFO] [stderr] Checking tracing-log v0.1.4 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Checking linux-raw-sys v0.4.13 [INFO] [stderr] Checking unicode-segmentation v1.11.0 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking anstyle v1.0.6 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Compiling serde_json v1.0.116 [INFO] [stderr] Checking tinyvec_macros v0.1.1 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking tinyvec v1.6.0 [INFO] [stderr] Checking crossbeam-channel v0.5.12 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Compiling syn v2.0.58 [INFO] [stderr] Compiling jobserver v0.1.30 [INFO] [stderr] Checking powerfmt v0.2.0 [INFO] [stderr] Checking fastrand v2.0.2 [INFO] [stderr] Compiling paste v1.0.14 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Compiling anyhow v1.0.82 [INFO] [stderr] Checking deranged v0.3.11 [INFO] [stderr] Compiling rayon-core v1.12.1 [INFO] [stderr] Checking castaway v0.2.2 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Checking itertools v0.12.1 [INFO] [stderr] Checking esl01-vlqencoding v0.3.0 [INFO] [stderr] Checking num-conv v0.1.0 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Compiling doc-comment v0.3.3 [INFO] [stderr] Checking time-core v0.1.2 [INFO] [stderr] Compiling cc v1.0.94 [INFO] [stderr] Checking num_threads v0.1.7 [INFO] [stderr] Checking percent-encoding v2.3.1 [INFO] [stderr] Checking gimli v0.28.1 [INFO] [stderr] Compiling portable-atomic v1.6.0 [INFO] [stderr] Checking predicates-core v1.0.6 [INFO] [stderr] Checking unicode-bidi v0.3.15 [INFO] [stderr] Compiling eyre v0.6.12 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking num-complex v0.4.5 [INFO] [stderr] Checking form_urlencoded v1.2.1 [INFO] [stderr] Checking num-iter v0.1.44 [INFO] [stderr] Checking getrandom v0.2.14 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking memmap v0.7.0 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking termios v0.2.2 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking rand v0.4.6 [INFO] [stderr] Checking serial-core v0.4.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking ioctl-rs v0.1.6 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking signal-hook-mio v0.2.3 [INFO] [stderr] Checking is-terminal v0.4.12 [INFO] [stderr] Checking hashbrown v0.14.3 [INFO] [stderr] Checking num v0.4.2 [INFO] [stderr] Checking serial-unix v0.4.0 [INFO] [stderr] Checking console v0.15.8 [INFO] [stderr] Checking crossterm v0.27.0 [INFO] [stderr] Checking fs2 v0.4.3 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking regex-automata v0.4.6 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking miniz_oxide v0.7.2 [INFO] [stderr] Checking parking_lot_core v0.2.14 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking compact_str v0.7.1 [INFO] [stderr] Checking tempfile v3.10.1 [INFO] [stderr] Checking matchers v0.1.0 [INFO] [stderr] Checking lru v0.12.3 [INFO] [stderr] Compiling vte_generate_state_changes v0.1.1 [INFO] [stderr] Checking object v0.32.2 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking crossbeam-queue v0.3.11 [INFO] [stderr] Checking unicode-truncate v1.0.0 [INFO] [stderr] Compiling libz-sys v1.1.16 [INFO] [stderr] Compiling libsqlite3-sys v0.26.0 [INFO] [stderr] Compiling libgit2-sys v0.16.2+1.7.2 [INFO] [stderr] Compiling backtrace v0.3.71 [INFO] [stderr] Checking owning_ref v0.4.1 [INFO] [stderr] Checking owning_ref v0.3.3 [INFO] [stderr] Checking half v2.4.1 [INFO] [stderr] Checking xi-unicode v0.3.0 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Checking arrayvec v0.7.4 [INFO] [stderr] Checking plotters-backend v0.3.5 [INFO] [stderr] Checking ciborium-io v0.2.2 [INFO] [stderr] Checking owo-colors v3.5.0 [INFO] [stderr] Checking hex v0.4.3 [INFO] [stderr] Compiling assert_cmd v2.0.14 [INFO] [stderr] Checking indenter v0.3.3 [INFO] [stderr] Checking difflib v0.4.0 [INFO] [stderr] Checking twox-hash v1.6.3 [INFO] [stderr] Checking termtree v0.4.1 [INFO] [stderr] Checking rustc-demangle v0.1.23 [INFO] [stderr] Checking clap_lex v0.7.0 [INFO] [stderr] Checking cassowary v0.3.0 [INFO] [stderr] Checking ciborium-ll v0.2.2 [INFO] [stderr] Checking predicates v3.1.0 [INFO] [stderr] Checking predicates-tree v1.0.9 [INFO] [stderr] Checking clap_builder v4.5.2 [INFO] [stderr] Checking plotters-svg v0.3.5 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking vte v0.11.1 [INFO] [stderr] Checking parking_lot v0.4.8 [INFO] [stderr] Checking fail v0.4.0 [INFO] [stderr] Checking crossbeam v0.8.4 [INFO] [stderr] Checking hashlink v0.8.4 [INFO] [stderr] Checking nix v0.25.1 [INFO] [stderr] Checking url v2.5.0 [INFO] [stderr] Checking serial v0.4.0 [INFO] [stderr] Checking crossterm v0.25.0 [INFO] [stderr] Checking esl01-renderdag v0.3.0 [INFO] [stderr] Checking wait-timeout v0.2.0 [INFO] [stderr] Checking iana-time-zone v0.1.60 [INFO] [stderr] Checking addr2line v0.21.0 [INFO] [stderr] Checking downcast-rs v1.2.1 [INFO] [stderr] Checking smawk v0.3.2 [INFO] [stderr] Checking json v0.12.4 [INFO] [stderr] Checking unicode-linebreak v0.1.5 [INFO] [stderr] Checking cast v0.3.0 [INFO] [stderr] Checking shell-words v1.1.0 [INFO] [stderr] Checking number_prefix v0.4.0 [INFO] [stderr] Checking esl01-nonblocking v0.3.0 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking concolor-query v0.3.3 [INFO] [stderr] Checking esl01-drawdag v0.3.0 [INFO] [stderr] Checking criterion-plot v0.5.0 [INFO] [stderr] Checking textwrap v0.16.1 [INFO] [stderr] Checking chrono v0.4.34 [INFO] [stderr] Checking concolor v0.1.1 [INFO] [stderr] Checking walkdir v2.5.0 [INFO] [stderr] Checking chashmap v2.2.2 [INFO] [stderr] Checking plotters v0.3.5 [INFO] [stderr] Checking anes v0.1.6 [INFO] [stderr] Checking similar v2.5.0 [INFO] [stderr] Checking oorandom v11.1.3 [INFO] [stderr] Checking indicatif v0.17.8 [INFO] [stderr] Checking linked-hash-map v0.5.6 [INFO] [stderr] Compiling darling_core v0.20.8 [INFO] [stderr] Checking vt100 v0.15.2 [INFO] [stderr] Checking clap v4.5.4 [INFO] [stderr] Checking insta v1.38.0 [INFO] [stderr] Checking regex v1.10.4 [INFO] [stderr] Checking bstr v1.9.1 [INFO] [stderr] Compiling serde_derive v1.0.198 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling thiserror-impl v1.0.59 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling enum-map-derive v0.17.0 [INFO] [stderr] Compiling strum_macros v0.26.2 [INFO] [stderr] Compiling stability v0.2.0 [INFO] [stderr] Compiling async-trait v0.1.80 [INFO] [stderr] Checking enum-map v2.7.3 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking filedescriptor v0.8.2 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking tracing-subscriber v0.3.11 [INFO] [stderr] Compiling darling_macro v0.20.8 [INFO] [stderr] Checking esl01-atomicfile v0.3.0 [INFO] [stderr] Compiling darling v0.20.8 [INFO] [stderr] Compiling enumset_derive v0.8.1 [INFO] [stderr] Checking strum v0.26.2 [INFO] [stderr] Checking ratatui v0.26.3 [INFO] [stderr] Checking enumset v1.1.3 [INFO] [stderr] Checking portable-pty v0.8.1 [INFO] [stderr] Checking cursive_core v0.3.7 [INFO] [stderr] Checking tracing-error v0.2.0 [INFO] [stderr] Checking tracing-chrome v0.6.0 [INFO] [stderr] Checking color-spantrace v0.2.1 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking color-eyre v0.6.3 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking git2 v0.18.3 [INFO] [stderr] Checking cursive v0.20.0 [INFO] [stderr] Checking rusqlite v0.29.0 [INFO] [stderr] Checking bytes v1.6.0 [INFO] [stderr] Checking esl01-mincode v0.3.0 [INFO] [stderr] Checking ciborium v0.2.2 [INFO] [stderr] Checking esl01-minibytes v0.3.0 [INFO] [stderr] Checking esl01-dag-types v0.3.0 [INFO] [stderr] Checking esl01-indexedlog v0.3.0 [INFO] [stderr] Checking scm-record v0.3.0 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking criterion v0.5.1 [INFO] [stderr] Checking esl01-dag v0.3.0 [INFO] [stderr] Checking git-branchless-lib v0.9.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/dag.rs:62:38 [INFO] [stdout] | [INFO] [stdout] 61 | let vertex = CommitVertex::from(oid); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 62 | CommitSet::from_static_names([vertex]) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/dag.rs:73:36 [INFO] [stdout] | [INFO] [stdout] 67 | fn from_iter>(iter: T) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 68 | let oids = iter [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 73 | CommitSet::from_iter(oids, Hints::default()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/dag.rs:90:90 [INFO] [stdout] | [INFO] [stdout] 90 | async fn parent_names(&self, v: CommitVertex) -> eden_dag::Result> { [INFO] [stdout] | __________________________________---------------_________________________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 91 | | use eden_dag::errors::BackendError; [INFO] [stdout] 92 | | trace!(?v, "visiting Git commit"); [INFO] [stdout] ... | [INFO] [stdout] 120 | | .collect()) [INFO] [stdout] 121 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/dag.rs:164:12 [INFO] [stdout] | [INFO] [stdout] 163 | let inner = Self::open_inner_dag(repo)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 164 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 165 | | inner, [INFO] [stdout] 166 | | head_commit: self.head_commit.clone(), [INFO] [stdout] 167 | | main_branch_commit: self.main_branch_commit.clone(), [INFO] [stdout] ... | [INFO] [stdout] 174 | | draft_commits: OnceCell::new(), [INFO] [stdout] 175 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/dag.rs:299:28 [INFO] [stdout] | [INFO] [stdout] 299 | .map(|vertex| (CommitVertex::from(vertex), master_group_options.clone())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/dag.rs:304:28 [INFO] [stdout] | [INFO] [stdout] 304 | .map(|vertex| (CommitVertex::from(vertex), VertexOptions::default())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/effects.rs:517:19 [INFO] [stdout] | [INFO] [stdout] 513 | let root_operation = Default::default(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 514 | let updater_thread_handle = spawn_progress_updater_thread(&root_operation); [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 517 | dest: OutputDest::Stdout, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/effects.rs:519:28 [INFO] [stdout] | [INFO] [stdout] 513 | let root_operation = Default::default(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 514 | let updater_thread_handle = spawn_progress_updater_thread(&root_operation); [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 519 | operation_key: Default::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/effects.rs:559:19 [INFO] [stdout] | [INFO] [stdout] 556 | let mut root_operation = self.root_operation.lock().unwrap(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 559 | dest: OutputDest::Suppress, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/effects.rs:560:15 [INFO] [stdout] | [INFO] [stdout] 556 | let mut root_operation = self.root_operation.lock().unwrap(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 560 | ..self.clone() [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/eventlog.rs:1347:12 [INFO] [stdout] | [INFO] [stdout] 1346 | let branch_oid_to_names = self.get_cursor_branch_oid_to_names(cursor, repo)?; [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1347 | Ok(RepoReferencesSnapshot { [INFO] [stdout] | ____________^ [INFO] [stdout] 1348 | | head_oid, [INFO] [stdout] 1349 | | main_branch_oid, [INFO] [stdout] 1350 | | branch_oid_to_names, [INFO] [stdout] 1351 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/node_descriptors.rs:89:24 [INFO] [stdout] | [INFO] [stdout] 86 | pub fn new(preserved_ref_names: HashSet) -> Self { [INFO] [stdout] | ------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 89 | ref_names: Default::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/repo_ext.rs:52:15 [INFO] [stdout] | [INFO] [stdout] 52 | match self.find_branch(&main_branch_name, BranchType::Local)? { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/repo_ext.rs:71:29 [INFO] [stdout] | [INFO] [stdout] 70 | .map(|branch| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 71 | / branch [INFO] [stdout] 72 | | .into_reference() [INFO] [stdout] 73 | | .get_name() [INFO] [stdout] 74 | | .map(|s| format!("{s:?}")) [INFO] [stdout] | |__________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/repo_ext.rs:121:12 [INFO] [stdout] | [INFO] [stdout] 119 | let branch_oid_to_names = self.get_branch_oid_to_names()?; [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 120 | [INFO] [stdout] 121 | Ok(RepoReferencesSnapshot { [INFO] [stdout] | ____________^ [INFO] [stdout] 122 | | head_oid, [INFO] [stdout] 123 | | main_branch_oid, [INFO] [stdout] 124 | | branch_oid_to_names, [INFO] [stdout] 125 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/rewrite/plan.rs:228:12 [INFO] [stdout] | [INFO] [stdout] 216 | let commits = dag.query_descendants(commits.clone())?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 228 | Ok(Ok(RebasePlanPermissions { [INFO] [stdout] | ____________^ [INFO] [stdout] 229 | | build_options, [INFO] [stdout] 230 | | allowed_commits: commits, [INFO] [stdout] 231 | | })) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/rewrite/plan.rs:733:34 [INFO] [stdout] | [INFO] [stdout] 727 | pub fn new(dag: &'a Dag, permissions: RebasePlanPermissions) -> Self { [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 733 | touched_paths_cache: Default::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/rewrite/plan.rs:1217:12 [INFO] [stdout] | [INFO] [stdout] 1105 | let mut constraints = ConstraintGraph::new(self.dag, &self.permissions); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1106 | constraints.add_constraints(&self.initial_constraints)?; [INFO] [stdout] 1107 | let mut state = BuildState { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1113 | let (effects, _progress) = effects.start_operation(OperationType::BuildRebasePlan); [INFO] [stdout] | ------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1146 | let repo = repo_pool.try_create()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1217 | Ok(Ok(rebase_plan)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/rewrite/plan.rs:1382:49 [INFO] [stdout] | [INFO] [stdout] 1382 | .map(|commit_oid| match touched_paths_cache.get(&commit_oid) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/task.rs:113:24 [INFO] [stdout] | [INFO] [stdout] 110 | pub fn new(factory: R) -> Self { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 113 | resources: Default::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/task.rs:132:12 [INFO] [stdout] | [INFO] [stdout] 121 | let resource = { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 122 | let mut resources = self [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 126 | let resource = resources.pop(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 127 | match resource { [INFO] [stdout] 128 | Some(resource) => resource, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 132 | Ok(ResourceHandle { [INFO] [stdout] | ____________^ [INFO] [stdout] 133 | | parent: self, [INFO] [stdout] 134 | | inner: Some(resource), [INFO] [stdout] 135 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/git/config.rs:175:12 [INFO] [stdout] | [INFO] [stdout] 173 | fn get_or, S: AsRef>(&self, key: S, default: V) -> eyre::Result { [INFO] [stdout] | ------ ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 174 | let result = self.get(key)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 175 | Ok(result.unwrap_or(default)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/git/reference.rs:362:20 [INFO] [stdout] | [INFO] [stdout] 360 | pub fn into_reference(self) -> Reference<'repo> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 361 | Reference { [INFO] [stdout] 362 | inner: self.inner.into_reference(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/git/repo.rs:558:9 [INFO] [stdout] | [INFO] [stdout] 539 | Err(err) if err.kind() == std::io::ErrorKind::NotFound => { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 542 | Err(err) => { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 558 | std::fs::canonicalize(workdir).ok().or_else(|| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/git/repo.rs:569:12 [INFO] [stdout] | [INFO] [stdout] 566 | let mut index = self.inner.index().map_err(Error::ReadIndex)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 569 | Ok(Index { inner: index }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/git/repo.rs:1034:12 [INFO] [stdout] | [INFO] [stdout] 977 | let (effects, _progress) = effects.start_operation(OperationType::QueryWorkingCopy); [INFO] [stdout] | ------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 978 | let _effects = effects; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1032 | let snapshot = WorkingCopySnapshot::create(self, index, head_info, &statuses) [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1033 | .map_err(Error::CreateSnapshot)?; [INFO] [stdout] 1034 | Ok((snapshot, statuses)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/git/repo.rs:1587:46 [INFO] [stdout] | [INFO] [stdout] 1587 | .filter_map(|path| match amended_tree.get_path(path) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/git/run.rs:97:23 [INFO] [stdout] | [INFO] [stdout] 94 | stream: Option, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 95 | mut output: OutputStream, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 96 | ) -> JoinHandle<()> { [INFO] [stdout] 97 | thread::spawn(move || { [INFO] [stdout] | _______________________^ [INFO] [stdout] 98 | | let stream = match stream { [INFO] [stdout] 99 | | Some(stream) => stream, [INFO] [stdout] 100 | | None => return, [INFO] [stdout] ... | [INFO] [stdout] 106 | | } [INFO] [stdout] 107 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/git/tree.rs:207:30 [INFO] [stdout] | [INFO] [stdout] 203 | let entry_tree = repo [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 207 | entry_tree.ok_or(Error::NotATree { oid: entry_oid }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/git/tree.rs:461:5 [INFO] [stdout] | [INFO] [stdout] 461 | / repo.find_tree_or_fail(tree_oid) [INFO] [stdout] 462 | | .map_err(Box::new) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/testing.rs:736:12 [INFO] [stdout] | [INFO] [stdout] 730 | let repo_dir = tempfile::tempdir()?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 736 | Ok(Self { repo_dir, git }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/testing.rs:750:8 [INFO] [stdout] | [INFO] [stdout] 746 | let repo_dir = tempfile::tempdir()?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 750 | Ok(GitWrapper { repo_dir, git }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/testing.rs:783:8 [INFO] [stdout] | [INFO] [stdout] 772 | let temp_dir = tempfile::tempdir()?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 783 | Ok(GitWrapperWithRemoteRepo { [INFO] [stdout] | ________^ [INFO] [stdout] 784 | | temp_dir, [INFO] [stdout] 785 | | original_repo, [INFO] [stdout] 786 | | cloned_repo, [INFO] [stdout] 787 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/testing.rs:814:8 [INFO] [stdout] | [INFO] [stdout] 802 | let temp_dir = tempfile::tempdir()?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 814 | Ok(GitWorktreeWrapper { temp_dir, worktree }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 34 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `git-branchless-lib` (lib) due to 35 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/dag.rs:62:38 [INFO] [stdout] | [INFO] [stdout] 61 | let vertex = CommitVertex::from(oid); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 62 | CommitSet::from_static_names([vertex]) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/dag.rs:73:36 [INFO] [stdout] | [INFO] [stdout] 67 | fn from_iter>(iter: T) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 68 | let oids = iter [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 73 | CommitSet::from_iter(oids, Hints::default()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/dag.rs:90:90 [INFO] [stdout] | [INFO] [stdout] 90 | async fn parent_names(&self, v: CommitVertex) -> eden_dag::Result> { [INFO] [stdout] | __________________________________---------------_________________________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 91 | | use eden_dag::errors::BackendError; [INFO] [stdout] 92 | | trace!(?v, "visiting Git commit"); [INFO] [stdout] ... | [INFO] [stdout] 120 | | .collect()) [INFO] [stdout] 121 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/dag.rs:164:12 [INFO] [stdout] | [INFO] [stdout] 163 | let inner = Self::open_inner_dag(repo)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 164 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 165 | | inner, [INFO] [stdout] 166 | | head_commit: self.head_commit.clone(), [INFO] [stdout] 167 | | main_branch_commit: self.main_branch_commit.clone(), [INFO] [stdout] ... | [INFO] [stdout] 174 | | draft_commits: OnceCell::new(), [INFO] [stdout] 175 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/dag.rs:299:28 [INFO] [stdout] | [INFO] [stdout] 299 | .map(|vertex| (CommitVertex::from(vertex), master_group_options.clone())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/dag.rs:304:28 [INFO] [stdout] | [INFO] [stdout] 304 | .map(|vertex| (CommitVertex::from(vertex), VertexOptions::default())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/effects.rs:517:19 [INFO] [stdout] | [INFO] [stdout] 513 | let root_operation = Default::default(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 514 | let updater_thread_handle = spawn_progress_updater_thread(&root_operation); [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 517 | dest: OutputDest::Stdout, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/effects.rs:519:28 [INFO] [stdout] | [INFO] [stdout] 513 | let root_operation = Default::default(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 514 | let updater_thread_handle = spawn_progress_updater_thread(&root_operation); [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 519 | operation_key: Default::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/effects.rs:559:19 [INFO] [stdout] | [INFO] [stdout] 556 | let mut root_operation = self.root_operation.lock().unwrap(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 559 | dest: OutputDest::Suppress, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/effects.rs:560:15 [INFO] [stdout] | [INFO] [stdout] 556 | let mut root_operation = self.root_operation.lock().unwrap(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 560 | ..self.clone() [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/eventlog.rs:1347:12 [INFO] [stdout] | [INFO] [stdout] 1346 | let branch_oid_to_names = self.get_cursor_branch_oid_to_names(cursor, repo)?; [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1347 | Ok(RepoReferencesSnapshot { [INFO] [stdout] | ____________^ [INFO] [stdout] 1348 | | head_oid, [INFO] [stdout] 1349 | | main_branch_oid, [INFO] [stdout] 1350 | | branch_oid_to_names, [INFO] [stdout] 1351 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/node_descriptors.rs:89:24 [INFO] [stdout] | [INFO] [stdout] 86 | pub fn new(preserved_ref_names: HashSet) -> Self { [INFO] [stdout] | ------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 89 | ref_names: Default::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/repo_ext.rs:52:15 [INFO] [stdout] | [INFO] [stdout] 52 | match self.find_branch(&main_branch_name, BranchType::Local)? { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/repo_ext.rs:71:29 [INFO] [stdout] | [INFO] [stdout] 70 | .map(|branch| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 71 | / branch [INFO] [stdout] 72 | | .into_reference() [INFO] [stdout] 73 | | .get_name() [INFO] [stdout] 74 | | .map(|s| format!("{s:?}")) [INFO] [stdout] | |__________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/repo_ext.rs:121:12 [INFO] [stdout] | [INFO] [stdout] 119 | let branch_oid_to_names = self.get_branch_oid_to_names()?; [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 120 | [INFO] [stdout] 121 | Ok(RepoReferencesSnapshot { [INFO] [stdout] | ____________^ [INFO] [stdout] 122 | | head_oid, [INFO] [stdout] 123 | | main_branch_oid, [INFO] [stdout] 124 | | branch_oid_to_names, [INFO] [stdout] 125 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/rewrite/plan.rs:228:12 [INFO] [stdout] | [INFO] [stdout] 216 | let commits = dag.query_descendants(commits.clone())?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 228 | Ok(Ok(RebasePlanPermissions { [INFO] [stdout] | ____________^ [INFO] [stdout] 229 | | build_options, [INFO] [stdout] 230 | | allowed_commits: commits, [INFO] [stdout] 231 | | })) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/rewrite/plan.rs:733:34 [INFO] [stdout] | [INFO] [stdout] 727 | pub fn new(dag: &'a Dag, permissions: RebasePlanPermissions) -> Self { [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 733 | touched_paths_cache: Default::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/rewrite/plan.rs:1217:12 [INFO] [stdout] | [INFO] [stdout] 1105 | let mut constraints = ConstraintGraph::new(self.dag, &self.permissions); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1106 | constraints.add_constraints(&self.initial_constraints)?; [INFO] [stdout] 1107 | let mut state = BuildState { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1113 | let (effects, _progress) = effects.start_operation(OperationType::BuildRebasePlan); [INFO] [stdout] | ------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1146 | let repo = repo_pool.try_create()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1217 | Ok(Ok(rebase_plan)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/rewrite/plan.rs:1382:49 [INFO] [stdout] | [INFO] [stdout] 1382 | .map(|commit_oid| match touched_paths_cache.get(&commit_oid) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/task.rs:113:24 [INFO] [stdout] | [INFO] [stdout] 110 | pub fn new(factory: R) -> Self { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 113 | resources: Default::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/task.rs:132:12 [INFO] [stdout] | [INFO] [stdout] 121 | let resource = { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 122 | let mut resources = self [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 126 | let resource = resources.pop(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 127 | match resource { [INFO] [stdout] 128 | Some(resource) => resource, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 132 | Ok(ResourceHandle { [INFO] [stdout] | ____________^ [INFO] [stdout] 133 | | parent: self, [INFO] [stdout] 134 | | inner: Some(resource), [INFO] [stdout] 135 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/git/config.rs:175:12 [INFO] [stdout] | [INFO] [stdout] 173 | fn get_or, S: AsRef>(&self, key: S, default: V) -> eyre::Result { [INFO] [stdout] | ------ ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 174 | let result = self.get(key)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 175 | Ok(result.unwrap_or(default)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/git/reference.rs:362:20 [INFO] [stdout] | [INFO] [stdout] 360 | pub fn into_reference(self) -> Reference<'repo> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 361 | Reference { [INFO] [stdout] 362 | inner: self.inner.into_reference(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/git/repo.rs:558:9 [INFO] [stdout] | [INFO] [stdout] 539 | Err(err) if err.kind() == std::io::ErrorKind::NotFound => { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 542 | Err(err) => { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 558 | std::fs::canonicalize(workdir).ok().or_else(|| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/git/repo.rs:569:12 [INFO] [stdout] | [INFO] [stdout] 566 | let mut index = self.inner.index().map_err(Error::ReadIndex)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 569 | Ok(Index { inner: index }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/git/repo.rs:1034:12 [INFO] [stdout] | [INFO] [stdout] 977 | let (effects, _progress) = effects.start_operation(OperationType::QueryWorkingCopy); [INFO] [stdout] | ------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 978 | let _effects = effects; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1032 | let snapshot = WorkingCopySnapshot::create(self, index, head_info, &statuses) [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1033 | .map_err(Error::CreateSnapshot)?; [INFO] [stdout] 1034 | Ok((snapshot, statuses)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/git/repo.rs:1587:46 [INFO] [stdout] | [INFO] [stdout] 1587 | .filter_map(|path| match amended_tree.get_path(path) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/git/run.rs:97:23 [INFO] [stdout] | [INFO] [stdout] 94 | stream: Option, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 95 | mut output: OutputStream, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 96 | ) -> JoinHandle<()> { [INFO] [stdout] 97 | thread::spawn(move || { [INFO] [stdout] | _______________________^ [INFO] [stdout] 98 | | let stream = match stream { [INFO] [stdout] 99 | | Some(stream) => stream, [INFO] [stdout] 100 | | None => return, [INFO] [stdout] ... | [INFO] [stdout] 106 | | } [INFO] [stdout] 107 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/git/tree.rs:207:30 [INFO] [stdout] | [INFO] [stdout] 203 | let entry_tree = repo [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 207 | entry_tree.ok_or(Error::NotATree { oid: entry_oid }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/git/tree.rs:461:5 [INFO] [stdout] | [INFO] [stdout] 461 | / repo.find_tree_or_fail(tree_oid) [INFO] [stdout] 462 | | .map_err(Box::new) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/testing.rs:736:12 [INFO] [stdout] | [INFO] [stdout] 730 | let repo_dir = tempfile::tempdir()?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 736 | Ok(Self { repo_dir, git }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/testing.rs:750:8 [INFO] [stdout] | [INFO] [stdout] 746 | let repo_dir = tempfile::tempdir()?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 750 | Ok(GitWrapper { repo_dir, git }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/testing.rs:783:8 [INFO] [stdout] | [INFO] [stdout] 772 | let temp_dir = tempfile::tempdir()?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 783 | Ok(GitWrapperWithRemoteRepo { [INFO] [stdout] | ________^ [INFO] [stdout] 784 | | temp_dir, [INFO] [stdout] 785 | | original_repo, [INFO] [stdout] 786 | | cloned_repo, [INFO] [stdout] 787 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/testing.rs:814:8 [INFO] [stdout] | [INFO] [stdout] 802 | let temp_dir = tempfile::tempdir()?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 814 | Ok(GitWorktreeWrapper { temp_dir, worktree }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 34 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `git-branchless-lib` (lib test) due to 35 previous errors [INFO] running `Command { std: "docker" "inspect" "643d416ed7e4b4c0ac3dd473fccbed477f7c784e1a3e5511ce5c0ccab41d32d7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "643d416ed7e4b4c0ac3dd473fccbed477f7c784e1a3e5511ce5c0ccab41d32d7", kill_on_drop: false }` [INFO] [stdout] 643d416ed7e4b4c0ac3dd473fccbed477f7c784e1a3e5511ce5c0ccab41d32d7