[INFO] fetching crate gish 0.1.0... [INFO] checking gish-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate gish 0.1.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate gish 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate gish 0.1.0 [INFO] finished tweaking crates.io crate gish 0.1.0 [INFO] tweaked toml for crates.io crate gish 0.1.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate gish 0.1.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e2f8de1f6559712bfb0392b21a0f90b50e6b57531e67580f1c4cd6dcafcb55c7 [INFO] running `Command { std: "docker" "start" "-a" "e2f8de1f6559712bfb0392b21a0f90b50e6b57531e67580f1c4cd6dcafcb55c7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e2f8de1f6559712bfb0392b21a0f90b50e6b57531e67580f1c4cd6dcafcb55c7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e2f8de1f6559712bfb0392b21a0f90b50e6b57531e67580f1c4cd6dcafcb55c7", kill_on_drop: false }` [INFO] [stdout] e2f8de1f6559712bfb0392b21a0f90b50e6b57531e67580f1c4cd6dcafcb55c7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8c4d64b6b49ff3d6b5c589e5599e71e8baebd0a3eeecf93fabde979d09634005 [INFO] running `Command { std: "docker" "start" "-a" "8c4d64b6b49ff3d6b5c589e5599e71e8baebd0a3eeecf93fabde979d09634005", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.140 [INFO] [stderr] Compiling parking_lot_core v0.9.7 [INFO] [stderr] Compiling signal-hook v0.3.15 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Checking smallvec v1.10.0 [INFO] [stderr] Compiling cc v1.0.79 [INFO] [stderr] Compiling lock_api v0.4.9 [INFO] [stderr] Compiling log v0.4.17 [INFO] [stderr] Compiling pkg-config v0.3.26 [INFO] [stderr] Compiling crossbeam-utils v0.8.15 [INFO] [stderr] Compiling anyhow v1.0.70 [INFO] [stderr] Checking unicode-segmentation v1.10.1 [INFO] [stderr] Checking unicode-width v0.1.10 [INFO] [stderr] Checking once_cell v1.17.1 [INFO] [stderr] Checking home v0.5.5 [INFO] [stderr] Checking crossbeam-channel v0.5.7 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Checking mio v0.8.6 [INFO] [stderr] Compiling lua52-sys v0.1.2 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking signal-hook-mio v0.2.3 [INFO] [stderr] Checking crossterm v0.25.0 [INFO] [stderr] Checking crossterm v0.26.1 [INFO] [stderr] Checking tui v0.19.0 [INFO] [stderr] Checking hlua v0.4.1 [INFO] [stderr] Checking gish v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused imports: `HashMap`, `HashSet`, and `fs` [INFO] [stdout] --> src/app/mod.rs:1:30 [INFO] [stdout] | [INFO] [stdout] 1 | use std::{io, cell::RefCell, fs, error::Error, collections::{HashMap, HashSet}}; [INFO] [stdout] | ^^ ^^^^^^^ ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `LuaTable`, `function0`, and `function1` [INFO] [stdout] --> src/app/mod.rs:4:17 [INFO] [stdout] | [INFO] [stdout] 4 | use hlua::{Lua, function1, LuaFunction, function0, LuaTable}; [INFO] [stdout] | ^^^^^^^^^ ^^^^^^^^^ ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `PushGuard` [INFO] [stdout] --> src/ui/mod.rs:1:25 [INFO] [stdout] | [INFO] [stdout] 1 | use hlua::{LuaFunction, PushGuard, LuaTable}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `HashMap`, `HashSet`, and `fs` [INFO] [stdout] --> src/app/mod.rs:1:30 [INFO] [stdout] | [INFO] [stdout] 1 | use std::{io, cell::RefCell, fs, error::Error, collections::{HashMap, HashSet}}; [INFO] [stdout] | ^^ ^^^^^^^ ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `LuaTable`, `function0`, and `function1` [INFO] [stdout] --> src/app/mod.rs:4:17 [INFO] [stdout] | [INFO] [stdout] 4 | use hlua::{Lua, function1, LuaFunction, function0, LuaTable}; [INFO] [stdout] | ^^^^^^^^^ ^^^^^^^^^ ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `PushGuard` [INFO] [stdout] --> src/ui/mod.rs:1:25 [INFO] [stdout] | [INFO] [stdout] 1 | use hlua::{LuaFunction, PushGuard, LuaTable}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `status_bar` is never read [INFO] [stdout] --> src/app/mod.rs:31:9 [INFO] [stdout] | [INFO] [stdout] 25 | pub struct App<'a> { [INFO] [stdout] | --- field in this struct [INFO] [stdout] ... [INFO] [stdout] 31 | pub status_bar: Text<'a>, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `App` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lua/mod.rs:17:10 [INFO] [stdout] | [INFO] [stdout] 8 | pub fn call_internal(app: &App, name: T) -> Option> [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 9 | { [INFO] [stdout] 10 | let mut lua = app.lua.borrow_mut(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 11 | let mut internal: LuaTable<_> = lua.get("_internal").unwrap(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 12 | let mut on_tick: LuaFunction<_> = match internal.get(name.to_string()) { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 13 | Some(v) => v, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 17 | Some(on_tick.call()) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `gish` (bin "gish") due to 2 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: field `status_bar` is never read [INFO] [stdout] --> src/app/mod.rs:31:9 [INFO] [stdout] | [INFO] [stdout] 25 | pub struct App<'a> { [INFO] [stdout] | --- field in this struct [INFO] [stdout] ... [INFO] [stdout] 31 | pub status_bar: Text<'a>, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `App` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lua/mod.rs:17:10 [INFO] [stdout] | [INFO] [stdout] 8 | pub fn call_internal(app: &App, name: T) -> Option> [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 9 | { [INFO] [stdout] 10 | let mut lua = app.lua.borrow_mut(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 11 | let mut internal: LuaTable<_> = lua.get("_internal").unwrap(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 12 | let mut on_tick: LuaFunction<_> = match internal.get(name.to_string()) { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 13 | Some(v) => v, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 17 | Some(on_tick.call()) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `gish` (bin "gish" test) due to 2 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "8c4d64b6b49ff3d6b5c589e5599e71e8baebd0a3eeecf93fabde979d09634005", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8c4d64b6b49ff3d6b5c589e5599e71e8baebd0a3eeecf93fabde979d09634005", kill_on_drop: false }` [INFO] [stdout] 8c4d64b6b49ff3d6b5c589e5599e71e8baebd0a3eeecf93fabde979d09634005