[INFO] fetching crate gift 0.10.6... [INFO] checking gift-0.10.6 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate gift 0.10.6 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate gift 0.10.6 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate gift 0.10.6 [INFO] finished tweaking crates.io crate gift 0.10.6 [INFO] tweaked toml for crates.io crate gift 0.10.6 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate gift 0.10.6 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8ea257018ce6ac3214516239ce12a5ccf4b8b8df87016fbeca51b6d5c364fafe [INFO] running `Command { std: "docker" "start" "-a" "8ea257018ce6ac3214516239ce12a5ccf4b8b8df87016fbeca51b6d5c364fafe", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8ea257018ce6ac3214516239ce12a5ccf4b8b8df87016fbeca51b6d5c364fafe", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8ea257018ce6ac3214516239ce12a5ccf4b8b8df87016fbeca51b6d5c364fafe", kill_on_drop: false }` [INFO] [stdout] 8ea257018ce6ac3214516239ce12a5ccf4b8b8df87016fbeca51b6d5c364fafe [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7faa23710edf5752e76901dd72e05e8de8b61d44891f7c043dd35dab3db1af5b [INFO] running `Command { std: "docker" "start" "-a" "7faa23710edf5752e76901dd72e05e8de8b61d44891f7c043dd35dab3db1af5b", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Compiling crossbeam-utils v0.8.16 [INFO] [stderr] Compiling serde v1.0.188 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Compiling proc-macro2 v1.0.67 [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Checking itoa v1.0.9 [INFO] [stderr] Compiling rayon-core v1.12.0 [INFO] [stderr] Compiling serde_json v1.0.107 [INFO] [stderr] Checking either v1.9.0 [INFO] [stderr] Compiling libc v0.2.148 [INFO] [stderr] Checking ryu v1.0.15 [INFO] [stderr] Checking plotters-backend v0.3.5 [INFO] [stderr] Compiling pix v0.13.3 [INFO] [stderr] Checking regex-syntax v0.7.5 [INFO] [stderr] Checking unicode-width v0.1.11 [INFO] [stderr] Checking memchr v2.6.3 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking half v1.8.2 [INFO] [stderr] Checking cast v0.3.0 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Checking oorandom v11.1.3 [INFO] [stderr] Checking walkdir v2.4.0 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking plotters-svg v0.3.5 [INFO] [stderr] Compiling memoffset v0.9.0 [INFO] [stderr] Compiling crossbeam-epoch v0.9.15 [INFO] [stderr] Compiling num-traits v0.2.16 [INFO] [stderr] Checking csv-core v0.1.10 [INFO] [stderr] Checking gift v0.10.6 (/opt/rustwide/workdir) [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Checking crossbeam-deque v0.8.3 [INFO] [stderr] Compiling syn v2.0.37 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/decode.rs:653:21 [INFO] [stdout] | [INFO] [stdout] 648 | fn new(frames: Frames) -> Self { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 653 | raster: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/decode.rs:702:12 [INFO] [stdout] | [INFO] [stdout] 688 | let raster = if let DisposalMethod::Previous = frame.disposal_method() { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 689 | let raster = self.raster.as_ref().unwrap(); [INFO] [stdout] 690 | let mut raster = Raster::with_raster(raster); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 702 | Ok(Step::with_true_color(raster) [INFO] [stdout] | ____________^ [INFO] [stdout] 703 | | .with_transparent_color(transparent_color)) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |______________________________________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/private.rs:184:29 [INFO] [stdout] | [INFO] [stdout] 183 | pub fn into_frames(self) -> decode::Frames { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 184 | decode::Frames::new(self.into_blocks()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/private.rs:189:33 [INFO] [stdout] | [INFO] [stdout] 188 | pub fn into_steps(self) -> decode::Steps { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 189 | decode::Steps::new_once(self.into_frames()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/private.rs:199:36 [INFO] [stdout] | [INFO] [stdout] 198 | fn into_iter(self) -> Self::IntoIter { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 199 | decode::Steps::new_looping(self.into_frames()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/private.rs:257:31 [INFO] [stdout] | [INFO] [stdout] 256 | pub fn into_frame_enc(self) -> encode::FrameEnc { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 257 | encode::FrameEnc::new(self.into_block_enc()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/private.rs:262:30 [INFO] [stdout] | [INFO] [stdout] 261 | pub fn into_step_enc(self) -> encode::StepEnc { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 262 | encode::StepEnc::new(self.into_frame_enc()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking atty v0.2.14 [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `gift` (lib) due to 8 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "7faa23710edf5752e76901dd72e05e8de8b61d44891f7c043dd35dab3db1af5b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7faa23710edf5752e76901dd72e05e8de8b61d44891f7c043dd35dab3db1af5b", kill_on_drop: false }` [INFO] [stdout] 7faa23710edf5752e76901dd72e05e8de8b61d44891f7c043dd35dab3db1af5b