[INFO] fetching crate ghee 0.6.1... [INFO] checking ghee-0.6.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate ghee 0.6.1 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate ghee 0.6.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate ghee 0.6.1 [INFO] finished tweaking crates.io crate ghee 0.6.1 [INFO] tweaked toml for crates.io crate ghee 0.6.1 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate crates.io crate ghee 0.6.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 95a02ea6e66ebd8d9bb2c61af0c4b637e04143ad6394f19a52a11c9290af0271 [INFO] running `Command { std: "docker" "start" "-a" "95a02ea6e66ebd8d9bb2c61af0c4b637e04143ad6394f19a52a11c9290af0271", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "95a02ea6e66ebd8d9bb2c61af0c4b637e04143ad6394f19a52a11c9290af0271", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "95a02ea6e66ebd8d9bb2c61af0c4b637e04143ad6394f19a52a11c9290af0271", kill_on_drop: false }` [INFO] [stdout] 95a02ea6e66ebd8d9bb2c61af0c4b637e04143ad6394f19a52a11c9290af0271 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] cbc86467121305fb9e8391c698265c5743754b924269e132fe1f0235ab8a6822 [INFO] running `Command { std: "docker" "start" "-a" "cbc86467121305fb9e8391c698265c5743754b924269e132fe1f0235ab8a6822", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.67 [INFO] [stderr] Compiling serde v1.0.188 [INFO] [stderr] Compiling libc v0.2.148 [INFO] [stderr] Compiling minimal-lexical v0.2.1 [INFO] [stderr] Compiling memchr v2.6.4 [INFO] [stderr] Compiling glob v0.3.1 [INFO] [stderr] Compiling thiserror v1.0.49 [INFO] [stderr] Compiling utf8parse v0.2.1 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Compiling anstyle-parse v0.2.2 [INFO] [stderr] Compiling prettyplease v0.2.15 [INFO] [stderr] Compiling anstyle v1.0.4 [INFO] [stderr] Compiling anstyle-query v1.0.0 [INFO] [stderr] Compiling anyhow v1.0.75 [INFO] [stderr] Compiling rustix v0.38.15 [INFO] [stderr] Compiling clang-sys v1.6.1 [INFO] [stderr] Compiling colorchoice v1.0.0 [INFO] [stderr] Compiling serde_json v1.0.107 [INFO] [stderr] Compiling nom v7.1.3 [INFO] [stderr] Compiling anstream v0.6.4 [INFO] [stderr] Compiling clap_lex v0.5.1 [INFO] [stderr] Compiling regex-syntax v0.7.5 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Compiling version_check v0.9.4 [INFO] [stderr] Compiling typenum v1.17.0 [INFO] [stderr] Compiling syn v2.0.37 [INFO] [stderr] Compiling bitflags v2.4.0 [INFO] [stderr] Compiling linux-raw-sys v0.4.8 [INFO] [stderr] Compiling cfg-if v1.0.0 [INFO] [stderr] Compiling strsim v0.10.0 [INFO] [stderr] Compiling libloading v0.7.4 [INFO] [stderr] Compiling clap_builder v4.4.6 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling bindgen v0.66.1 [INFO] [stderr] Compiling home v0.5.5 [INFO] [stderr] Compiling either v1.9.0 [INFO] [stderr] Compiling ryu v1.0.15 [INFO] [stderr] Compiling log v0.4.20 [INFO] [stderr] Compiling itoa v1.0.9 [INFO] [stderr] Compiling lazycell v1.3.0 [INFO] [stderr] Compiling cexpr v0.6.0 [INFO] [stderr] Compiling shlex v1.2.0 [INFO] [stderr] Compiling lazy_static v1.4.0 [INFO] [stderr] Compiling rustc-hash v1.1.0 [INFO] [stderr] Compiling peeking_take_while v0.1.2 [INFO] [stderr] Compiling regex-automata v0.3.9 [INFO] [stderr] Compiling which v4.4.2 [INFO] [stderr] Compiling num-traits v0.2.16 [INFO] [stderr] Checking smallvec v1.11.1 [INFO] [stderr] Compiling regex v1.9.6 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Checking nibble_vec v0.1.0 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking iana-time-zone v0.1.57 [INFO] [stderr] Checking endian-type v0.1.2 [INFO] [stderr] Checking is-terminal v0.4.9 [INFO] [stderr] Checking radix_trie v0.2.1 [INFO] [stderr] Checking fd-lock v3.0.13 [INFO] [stderr] Checking path-dedot v3.1.1 [INFO] [stderr] Checking chrono v0.4.31 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking nix v0.26.4 [INFO] [stderr] Checking nix v0.27.1 [INFO] [stderr] Checking cpufeatures v0.2.9 [INFO] [stderr] Checking unicode-segmentation v1.10.1 [INFO] [stderr] Compiling serde_derive v1.0.188 [INFO] [stderr] Compiling thiserror-impl v1.0.49 [INFO] [stderr] Compiling clap_derive v4.4.2 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking uuid v0.8.2 [INFO] [stderr] Checking unicode-width v0.1.11 [INFO] [stderr] Checking walkdir v2.4.0 [INFO] [stderr] Checking file-owner v0.1.2 [INFO] [stderr] Checking colored v2.0.4 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking rustyline v12.0.0 [INFO] [stderr] Checking path-absolutize v3.1.1 [INFO] [stderr] Checking sudo v0.6.0 [INFO] [stderr] Checking xattr v1.0.1 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking reflink v0.1.3 [INFO] [stderr] Checking xdg v2.5.2 [INFO] [stderr] Checking rand v0.4.6 [INFO] [stderr] Checking remove_dir_all v0.5.3 [INFO] [stderr] Checking tempdir v0.3.7 [INFO] [stderr] Compiling clap v4.4.6 [INFO] [stderr] Compiling clap_complete v4.4.3 [INFO] [stderr] Compiling toml v0.5.11 [INFO] [stderr] Checking ghee-lang v0.6.1 [INFO] [stderr] Compiling btrfsutil-sys v1.3.0 [INFO] [stderr] Compiling ghee-cli v0.6.2 [INFO] [stderr] Checking btrfsutil-fake v0.2.0-8324fe2 [INFO] [stderr] Checking ghee v0.6.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:210:5 [INFO] [stdout] | [INFO] [stdout] 208 | pub fn list_xattrs>(path: P) -> Vec { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 209 | let path: &Path = path.as_ref(); [INFO] [stdout] 210 | / xattr::list(path) [INFO] [stdout] 211 | | .unwrap_or_else(|e| panic!("Could not list xattrs on {}: {}", path.display(), e)) [INFO] [stdout] 212 | | .map(|osstr| osstr.into_string().unwrap().into_bytes()) [INFO] [stdout] 213 | | .map(|field| { [INFO] [stdout] ... | [INFO] [stdout] 216 | | .1 [INFO] [stdout] 217 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cmd/set.rs:31:18 [INFO] [stdout] | [INFO] [stdout] 31 | .map(|p| p.as_ref().absolutize().unwrap().to_path_buf()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cmd/set.rs:61:47 [INFO] [stdout] | [INFO] [stdout] 61 | .filter_map(|(key, path)| key.path_for_record(path.clone(), old_record).ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cmd/set.rs:94:40 [INFO] [stdout] | [INFO] [stdout] 94 | .map(|(key, path)| key.path_for_record(path.clone(), new_record).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/paths.rs:92:9 [INFO] [stdout] | [INFO] [stdout] 91 | fn relativize_if_possible>(&self, base: P) -> PathBuf { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 92 | self.relativize(base).unwrap_or_else(|_e| self.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/paths.rs:96:9 [INFO] [stdout] | [INFO] [stdout] 95 | fn resolve_curdir_if_possible>(&self, new_curdir: P) -> PathBuf { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 96 | self.resolve_curdir(new_curdir) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/walk.rs:123:8 [INFO] [stdout] | [INFO] [stdout] 115 | let mut walker = WalkDir::new(traverse_path).max_depth(max_depth); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 123 | Ok(walker.into_iter().filter_entry(move |e| { [INFO] [stdout] | ________^ [INFO] [stdout] 124 | | // Ignore nested indices but not the initial path [INFO] [stdout] 125 | | // we're walking [INFO] [stdout] 126 | | if !first && is_hidden(e) { [INFO] [stdout] ... | [INFO] [stdout] 143 | | true [INFO] [stdout] 144 | | })) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |______| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ghee` (lib) due to 8 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:210:5 [INFO] [stdout] | [INFO] [stdout] 208 | pub fn list_xattrs>(path: P) -> Vec { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 209 | let path: &Path = path.as_ref(); [INFO] [stdout] 210 | / xattr::list(path) [INFO] [stdout] 211 | | .unwrap_or_else(|e| panic!("Could not list xattrs on {}: {}", path.display(), e)) [INFO] [stdout] 212 | | .map(|osstr| osstr.into_string().unwrap().into_bytes()) [INFO] [stdout] 213 | | .map(|field| { [INFO] [stdout] ... | [INFO] [stdout] 216 | | .1 [INFO] [stdout] 217 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cmd/set.rs:31:18 [INFO] [stdout] | [INFO] [stdout] 31 | .map(|p| p.as_ref().absolutize().unwrap().to_path_buf()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cmd/set.rs:61:47 [INFO] [stdout] | [INFO] [stdout] 61 | .filter_map(|(key, path)| key.path_for_record(path.clone(), old_record).ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cmd/set.rs:94:40 [INFO] [stdout] | [INFO] [stdout] 94 | .map(|(key, path)| key.path_for_record(path.clone(), new_record).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/paths.rs:92:9 [INFO] [stdout] | [INFO] [stdout] 91 | fn relativize_if_possible>(&self, base: P) -> PathBuf { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 92 | self.relativize(base).unwrap_or_else(|_e| self.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/paths.rs:96:9 [INFO] [stdout] | [INFO] [stdout] 95 | fn resolve_curdir_if_possible>(&self, new_curdir: P) -> PathBuf { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 96 | self.resolve_curdir(new_curdir) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/walk.rs:123:8 [INFO] [stdout] | [INFO] [stdout] 115 | let mut walker = WalkDir::new(traverse_path).max_depth(max_depth); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 123 | Ok(walker.into_iter().filter_entry(move |e| { [INFO] [stdout] | ________^ [INFO] [stdout] 124 | | // Ignore nested indices but not the initial path [INFO] [stdout] 125 | | // we're walking [INFO] [stdout] 126 | | if !first && is_hidden(e) { [INFO] [stdout] ... | [INFO] [stdout] 143 | | true [INFO] [stdout] 144 | | })) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |______| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ghee` (lib test) due to 8 previous errors [INFO] running `Command { std: "docker" "inspect" "cbc86467121305fb9e8391c698265c5743754b924269e132fe1f0235ab8a6822", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cbc86467121305fb9e8391c698265c5743754b924269e132fe1f0235ab8a6822", kill_on_drop: false }` [INFO] [stdout] cbc86467121305fb9e8391c698265c5743754b924269e132fe1f0235ab8a6822