[INFO] fetching crate gha-runner 0.2.0... [INFO] checking gha-runner-0.2.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate gha-runner 0.2.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate gha-runner 0.2.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate gha-runner 0.2.0 [INFO] finished tweaking crates.io crate gha-runner 0.2.0 [INFO] tweaked toml for crates.io crate gha-runner 0.2.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate gha-runner 0.2.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 02387814a95db51126191537b039adeb5673349cd0e982d2b3fbf4242ec8aa4b [INFO] running `Command { std: "docker" "start" "-a" "02387814a95db51126191537b039adeb5673349cd0e982d2b3fbf4242ec8aa4b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "02387814a95db51126191537b039adeb5673349cd0e982d2b3fbf4242ec8aa4b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "02387814a95db51126191537b039adeb5673349cd0e982d2b3fbf4242ec8aa4b", kill_on_drop: false }` [INFO] [stdout] 02387814a95db51126191537b039adeb5673349cd0e982d2b3fbf4242ec8aa4b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 79d35d3603cc14f3b0db6e2ee83f21a8cf87e2f1ab1a4a61850e5fcb4740bc64 [INFO] running `Command { std: "docker" "start" "-a" "79d35d3603cc14f3b0db6e2ee83f21a8cf87e2f1ab1a4a61850e5fcb4740bc64", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.3.0 [INFO] [stderr] Compiling libc v0.2.154 [INFO] [stderr] Checking memchr v2.7.2 [INFO] [stderr] Checking pin-project-lite v0.2.14 [INFO] [stderr] Compiling cc v1.0.97 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Compiling serde v1.0.200 [INFO] [stderr] Checking bytes v1.6.0 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Checking pin-utils v0.1.0 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Checking rustls-pki-types v1.5.0 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Checking fnv v1.0.7 [INFO] [stderr] Compiling syn v2.0.60 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Checking untrusted v0.9.0 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking base64 v0.22.1 [INFO] [stderr] Compiling httparse v1.8.0 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking tower-service v0.3.2 [INFO] [stderr] Compiling rustls v0.22.4 [INFO] [stderr] Compiling num-conv v0.1.0 [INFO] [stderr] Checking try-lock v0.2.5 [INFO] [stderr] Checking powerfmt v0.2.0 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking ryu v1.0.17 [INFO] [stderr] Compiling time-core v0.1.2 [INFO] [stderr] Checking tower-layer v0.3.2 [INFO] [stderr] Checking zeroize v1.7.0 [INFO] [stderr] Compiling thiserror v1.0.59 [INFO] [stderr] Checking want v0.3.1 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling num-bigint v0.4.4 [INFO] [stderr] Compiling time-macros v0.2.18 [INFO] [stderr] Checking deranged v0.3.11 [INFO] [stderr] Checking subtle v2.5.0 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Compiling serde_json v1.0.116 [INFO] [stderr] Checking anstyle-parse v0.2.4 [INFO] [stderr] Checking rustls-pemfile v2.1.2 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Checking anstyle v1.0.7 [INFO] [stderr] Checking is_terminal_polyfill v1.70.0 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Checking regex-syntax v0.8.3 [INFO] [stderr] Checking colorchoice v1.0.1 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking anstyle-query v1.0.3 [INFO] [stderr] Checking pem v3.0.4 [INFO] [stderr] Checking rustls-native-certs v0.7.0 [INFO] [stderr] Checking webpki-roots v0.26.1 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking anstream v0.6.14 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking equivalent v1.0.1 [INFO] [stderr] Checking base64 v0.21.7 [INFO] [stderr] Checking gimli v0.28.1 [INFO] [stderr] Checking iana-time-zone v0.1.60 [INFO] [stderr] Checking miniz_oxide v0.7.2 [INFO] [stderr] Checking object v0.32.2 [INFO] [stderr] Checking secrecy v0.8.0 [INFO] [stderr] Checking arc-swap v1.7.1 [INFO] [stderr] Checking rustc-demangle v0.1.23 [INFO] [stderr] Checking unsafe-libyaml v0.2.11 [INFO] [stderr] Checking fastrand v2.1.0 [INFO] [stderr] Checking clap_builder v4.5.2 [INFO] [stderr] Checking indexmap v2.2.6 [INFO] [stderr] Checking hex v0.4.3 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Checking tempfile v3.10.1 [INFO] [stderr] Checking http-body v1.0.0 [INFO] [stderr] Checking http-body-util v0.1.1 [INFO] [stderr] Compiling ring v0.17.8 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Compiling backtrace v0.3.71 [INFO] [stderr] Checking tower-http v0.5.2 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking regex-automata v0.4.6 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking addr2line v0.21.0 [INFO] [stderr] Checking regex v1.10.4 [INFO] [stderr] Compiling serde_derive v1.0.200 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Compiling thiserror-impl v1.0.59 [INFO] [stderr] Compiling snafu-derive v0.8.2 [INFO] [stderr] Compiling async-trait v0.1.80 [INFO] [stderr] Compiling clap_derive v4.5.4 [INFO] [stderr] Checking env_filter v0.1.0 [INFO] [stderr] Checking env_logger v0.11.3 [INFO] [stderr] Checking tokio v1.37.0 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking simple_asn1 v0.6.2 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking snafu v0.8.2 [INFO] [stderr] Checking clap v4.5.4 [INFO] [stderr] Checking rustls-webpki v0.102.3 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking hyper v1.3.1 [INFO] [stderr] Checking tokio-rustls v0.25.0 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking hyper-util v0.1.3 [INFO] [stderr] Checking url v2.5.0 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking linked-hash-map v0.5.6 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking serde_path_to_error v0.1.16 [INFO] [stderr] Checking serde_yaml v0.9.34+deprecated [INFO] [stderr] Checking yaml-rust v0.4.5 [INFO] [stderr] Checking hyper-rustls v0.26.0 [INFO] [stderr] Checking jsonwebtoken v9.3.0 [INFO] [stderr] Checking octocrab v0.38.0 [INFO] [stderr] Checking gha-runner v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:306:24 [INFO] [stdout] | [INFO] [stdout] 304 | .map_err(|e| RunnerErrorKind::ActionDownloadError { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 305 | action: action.to_string(), [INFO] [stdout] 306 | inner: Box::new(e), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:320:24 [INFO] [stdout] | [INFO] [stdout] 318 | .map_err(|e| RunnerErrorKind::ActionDownloadError { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 319 | action: action.to_string(), [INFO] [stdout] 320 | inner: Box::new(e), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:490:9 [INFO] [stdout] | [INFO] [stdout] 487 | let mut step = self.steps[step_index.0 as usize].clone(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 490 | step.take_env_pre(&step_context) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:906:24 [INFO] [stdout] | [INFO] [stdout] 904 | .map_err(|e| RunnerErrorKind::ActionDownloadError { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 905 | action: action.to_string(), [INFO] [stdout] 906 | inner: Box::new(e), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:929:12 [INFO] [stdout] | [INFO] [stdout] 913 | let mut file = match File::open(path.join("action.yml")) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 914 | Ok(f) => Ok(f), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 915 | Err(e) => { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 929 | Ok(Action(serde_yaml::from_slice(&buf).map_err(|e| { [INFO] [stdout] | ____________^ [INFO] [stdout] 930 | | RunnerErrorKind::InvalidActionYaml { [INFO] [stdout] 931 | | action: action.to_string(), [INFO] [stdout] 932 | | inner: e, [INFO] [stdout] 933 | | } [INFO] [stdout] 934 | | })?)) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |____________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:925:20 [INFO] [stdout] | [INFO] [stdout] 923 | .map_err(|_| RunnerErrorKind::ActionDownloadError { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 924 | action: action.to_string(), [INFO] [stdout] 925 | inner: "action.yml not found".into(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/contexts.rs:64:42 [INFO] [stdout] | [INFO] [stdout] 64 | .map(|v| ResolverValue::Yaml(v.clone())) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expressions.rs:182:8 [INFO] [stdout] | [INFO] [stdout] 134 | pub fn expand(resolver: &dyn ContextResolver, value: Value) -> Result { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 137 | Value::Sequence(seq) => { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 138 | let mut ret = Vec::new(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 139 | for v in seq { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 182 | Ok(Value::String(ret)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/local_docker_backend.rs:110:13 [INFO] [stdout] | [INFO] [stdout] 68 | let mut cmd = tokio::process::Command::new("docker"); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 78 | let mut child = match cmd.spawn() { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 79 | Ok(child) => child, [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 80 | Err(e) => panic!("Failed to docker exec: {}", e), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 81 | }; [INFO] [stdout] 82 | let mut stdout = child.stdout.take().unwrap(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 83 | let mut stderr = child.stderr.take().unwrap(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 110 | / child [INFO] [stdout] 111 | | .wait() [INFO] [stdout] 112 | | .await [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/local_docker_backend.rs:177:12 [INFO] [stdout] | [INFO] [stdout] 125 | stdout_handler: OutputHandler, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 126 | stderr_handler: OutputHandler, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 135 | let mut container_instances = Vec::new(); [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 177 | Ok(LocalDockerBackend { [INFO] [stdout] | ____________^ [INFO] [stdout] 178 | | container_instances: container_instances, [INFO] [stdout] 179 | | stdout_handler: stdout_handler, [INFO] [stdout] 180 | | stderr_handler: stderr_handler, [INFO] [stdout] 181 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/models.rs:55:9 [INFO] [stdout] | [INFO] [stdout] 34 | yaml: Value, [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | mut f: F, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 55 | Err(RunnerErrorKind::TypeMismatch { [INFO] [stdout] | _________^ [INFO] [stdout] 56 | | expected: "mapping".to_string(), [INFO] [stdout] 57 | | got: yaml, [INFO] [stdout] 58 | | } [INFO] [stdout] 59 | | .error(context)) [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/models.rs:191:52 [INFO] [stdout] | [INFO] [stdout] 191 | to_string_map(context, yaml, |_, v| Ok(Job(v))) [INFO] [stdout] | - ^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/models.rs:375:12 [INFO] [stdout] | [INFO] [stdout] 374 | let yaml = clone_required_field(context, &self.0, "steps")?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 375 | Ok(if let Value::Sequence(seq) = yaml { [INFO] [stdout] | ____________^ [INFO] [stdout] 376 | | seq.into_iter().map(Step).collect() [INFO] [stdout] 377 | | } else { [INFO] [stdout] 378 | | return Err(RunnerErrorKind::TypeMismatch { [INFO] [stdout] ... | [INFO] [stdout] 382 | | .error(context)); [INFO] [stdout] 383 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 13 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `gha-runner` (lib test) due to 14 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:306:24 [INFO] [stdout] | [INFO] [stdout] 304 | .map_err(|e| RunnerErrorKind::ActionDownloadError { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 305 | action: action.to_string(), [INFO] [stdout] 306 | inner: Box::new(e), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:320:24 [INFO] [stdout] | [INFO] [stdout] 318 | .map_err(|e| RunnerErrorKind::ActionDownloadError { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 319 | action: action.to_string(), [INFO] [stdout] 320 | inner: Box::new(e), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:490:9 [INFO] [stdout] | [INFO] [stdout] 487 | let mut step = self.steps[step_index.0 as usize].clone(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 490 | step.take_env_pre(&step_context) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:906:24 [INFO] [stdout] | [INFO] [stdout] 904 | .map_err(|e| RunnerErrorKind::ActionDownloadError { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 905 | action: action.to_string(), [INFO] [stdout] 906 | inner: Box::new(e), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:929:12 [INFO] [stdout] | [INFO] [stdout] 913 | let mut file = match File::open(path.join("action.yml")) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 914 | Ok(f) => Ok(f), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 915 | Err(e) => { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 929 | Ok(Action(serde_yaml::from_slice(&buf).map_err(|e| { [INFO] [stdout] | ____________^ [INFO] [stdout] 930 | | RunnerErrorKind::InvalidActionYaml { [INFO] [stdout] 931 | | action: action.to_string(), [INFO] [stdout] 932 | | inner: e, [INFO] [stdout] 933 | | } [INFO] [stdout] 934 | | })?)) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |____________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:925:20 [INFO] [stdout] | [INFO] [stdout] 923 | .map_err(|_| RunnerErrorKind::ActionDownloadError { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 924 | action: action.to_string(), [INFO] [stdout] 925 | inner: "action.yml not found".into(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/contexts.rs:64:42 [INFO] [stdout] | [INFO] [stdout] 64 | .map(|v| ResolverValue::Yaml(v.clone())) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expressions.rs:182:8 [INFO] [stdout] | [INFO] [stdout] 134 | pub fn expand(resolver: &dyn ContextResolver, value: Value) -> Result { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 137 | Value::Sequence(seq) => { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 138 | let mut ret = Vec::new(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 139 | for v in seq { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 182 | Ok(Value::String(ret)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/local_docker_backend.rs:110:13 [INFO] [stdout] | [INFO] [stdout] 68 | let mut cmd = tokio::process::Command::new("docker"); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 78 | let mut child = match cmd.spawn() { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 79 | Ok(child) => child, [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 80 | Err(e) => panic!("Failed to docker exec: {}", e), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 81 | }; [INFO] [stdout] 82 | let mut stdout = child.stdout.take().unwrap(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 83 | let mut stderr = child.stderr.take().unwrap(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 110 | / child [INFO] [stdout] 111 | | .wait() [INFO] [stdout] 112 | | .await [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/local_docker_backend.rs:177:12 [INFO] [stdout] | [INFO] [stdout] 125 | stdout_handler: OutputHandler, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 126 | stderr_handler: OutputHandler, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 135 | let mut container_instances = Vec::new(); [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 177 | Ok(LocalDockerBackend { [INFO] [stdout] | ____________^ [INFO] [stdout] 178 | | container_instances: container_instances, [INFO] [stdout] 179 | | stdout_handler: stdout_handler, [INFO] [stdout] 180 | | stderr_handler: stderr_handler, [INFO] [stdout] 181 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/models.rs:55:9 [INFO] [stdout] | [INFO] [stdout] 34 | yaml: Value, [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | mut f: F, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 55 | Err(RunnerErrorKind::TypeMismatch { [INFO] [stdout] | _________^ [INFO] [stdout] 56 | | expected: "mapping".to_string(), [INFO] [stdout] 57 | | got: yaml, [INFO] [stdout] 58 | | } [INFO] [stdout] 59 | | .error(context)) [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/models.rs:191:52 [INFO] [stdout] | [INFO] [stdout] 191 | to_string_map(context, yaml, |_, v| Ok(Job(v))) [INFO] [stdout] | - ^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/models.rs:375:12 [INFO] [stdout] | [INFO] [stdout] 374 | let yaml = clone_required_field(context, &self.0, "steps")?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 375 | Ok(if let Value::Sequence(seq) = yaml { [INFO] [stdout] | ____________^ [INFO] [stdout] 376 | | seq.into_iter().map(Step).collect() [INFO] [stdout] 377 | | } else { [INFO] [stdout] 378 | | return Err(RunnerErrorKind::TypeMismatch { [INFO] [stdout] ... | [INFO] [stdout] 382 | | .error(context)); [INFO] [stdout] 383 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 13 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `gha-runner` (lib) due to 14 previous errors [INFO] running `Command { std: "docker" "inspect" "79d35d3603cc14f3b0db6e2ee83f21a8cf87e2f1ab1a4a61850e5fcb4740bc64", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "79d35d3603cc14f3b0db6e2ee83f21a8cf87e2f1ab1a4a61850e5fcb4740bc64", kill_on_drop: false }` [INFO] [stdout] 79d35d3603cc14f3b0db6e2ee83f21a8cf87e2f1ab1a4a61850e5fcb4740bc64