[INFO] fetching crate ggraphics 0.0.2... [INFO] checking ggraphics-0.0.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate ggraphics 0.0.2 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate ggraphics 0.0.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate ggraphics 0.0.2 [INFO] finished tweaking crates.io crate ggraphics 0.0.2 [INFO] tweaked toml for crates.io crate ggraphics 0.0.2 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate ggraphics 0.0.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 76154e37d43cd748cc7db7680aa780c77e12038016bf9544f4942babed6d7129 [INFO] running `Command { std: "docker" "start" "-a" "76154e37d43cd748cc7db7680aa780c77e12038016bf9544f4942babed6d7129", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "76154e37d43cd748cc7db7680aa780c77e12038016bf9544f4942babed6d7129", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "76154e37d43cd748cc7db7680aa780c77e12038016bf9544f4942babed6d7129", kill_on_drop: false }` [INFO] [stdout] 76154e37d43cd748cc7db7680aa780c77e12038016bf9544f4942babed6d7129 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 90afebbe286133abc60a5f900c03809d335b31ad2771f8f66545bbe40a558123 [INFO] running `Command { std: "docker" "start" "-a" "90afebbe286133abc60a5f900c03809d335b31ad2771f8f66545bbe40a558123", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.66 [INFO] [stderr] Compiling autocfg v0.1.7 [INFO] [stderr] Compiling log v0.4.8 [INFO] [stderr] Compiling xml-rs v0.8.0 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Compiling byteorder v1.3.2 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Compiling cc v1.0.47 [INFO] [stderr] Compiling maybe-uninit v2.0.0 [INFO] [stderr] Compiling nix v0.14.1 [INFO] [stderr] Checking void v1.0.2 [INFO] [stderr] Checking slab v0.4.2 [INFO] [stderr] Checking lazycell v1.2.1 [INFO] [stderr] Compiling num-traits v0.2.10 [INFO] [stderr] Compiling num-integer v0.1.41 [INFO] [stderr] Checking arrayvec v0.5.1 [INFO] [stderr] Compiling pkg-config v0.3.17 [INFO] [stderr] Checking stb_truetype v0.3.1 [INFO] [stderr] Compiling parking_lot_core v0.6.2 [INFO] [stderr] Checking downcast-rs v1.1.1 [INFO] [stderr] Compiling wayland-scanner v0.23.6 [INFO] [stderr] Compiling gl_generator v0.13.1 [INFO] [stderr] Compiling x11-dl v2.18.4 [INFO] [stderr] Checking net2 v0.2.33 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Compiling memchr v2.2.1 [INFO] [stderr] Checking same-file v1.0.5 [INFO] [stderr] Checking walkdir v2.2.9 [INFO] [stderr] Checking mio v0.6.21 [INFO] [stderr] Compiling libloading v0.5.2 [INFO] [stderr] Compiling gl_generator v0.11.0 [INFO] [stderr] Checking approx v0.3.2 [INFO] [stderr] Checking ordered-float v1.0.2 [INFO] [stderr] Checking line_drawing v0.7.0 [INFO] [stderr] Checking rusttype v0.8.2 [INFO] [stderr] Checking dlib v0.4.1 [INFO] [stderr] Checking smallvec v0.6.13 [INFO] [stderr] Checking wayland-sys v0.23.6 [INFO] [stderr] Checking scopeguard v1.0.0 [INFO] [stderr] Checking xdg v2.2.0 [INFO] [stderr] Compiling syn v0.15.44 [INFO] [stderr] Checking rusttype v0.7.9 [INFO] [stderr] Checking lock_api v0.3.2 [INFO] [stderr] Checking mio-extras v2.0.5 [INFO] [stderr] Compiling parking_lot v0.9.0 [INFO] [stderr] Compiling glutin_egl_sys v0.1.4 [INFO] [stderr] Compiling glutin_glx_sys v0.1.5 [INFO] [stderr] Checking memmap v0.7.0 [INFO] [stderr] Checking andrew v0.2.1 [INFO] [stderr] Compiling num-derive v0.2.5 [INFO] [stderr] Compiling wayland-client v0.23.6 [INFO] [stderr] Compiling wayland-protocols v0.23.6 [INFO] [stderr] Compiling crc32fast v1.2.0 [INFO] [stderr] Checking adler32 v1.0.4 [INFO] [stderr] Checking aho-corasick v0.7.6 [INFO] [stderr] Compiling glow v0.3.0-alpha4 [INFO] [stderr] Checking raw-window-handle v0.3.2 [INFO] [stderr] Checking shared_library v0.1.9 [INFO] [stderr] Compiling num-rational v0.2.2 [INFO] [stderr] Compiling num-iter v0.1.39 [INFO] [stderr] Checking thread_local v0.3.6 [INFO] [stderr] Checking regex-syntax v0.6.12 [INFO] [stderr] Checking instant v0.1.2 [INFO] [stderr] Checking quick-error v1.2.2 [INFO] [stderr] Checking percent-encoding v2.1.0 [INFO] [stderr] Checking humantime v1.3.0 [INFO] [stderr] Checking osmesa-sys v0.1.2 [INFO] [stderr] Checking calloop v0.4.4 [INFO] [stderr] Checking wayland-commons v0.23.6 [INFO] [stderr] Checking inflate v0.4.5 [INFO] [stderr] Checking deflate v0.7.20 [INFO] [stderr] Checking time v0.1.42 [INFO] [stderr] Checking atty v0.2.13 [INFO] [stderr] Checking termcolor v1.0.5 [INFO] [stderr] Checking lzw v0.10.0 [INFO] [stderr] Checking png v0.15.1 [INFO] [stderr] Checking chrono v0.4.10 [INFO] [stderr] Checking jpeg-decoder v0.1.16 [INFO] [stderr] Checking bytemuck v1.0.1 [INFO] [stderr] Checking glam v0.8.3 [INFO] [stderr] Checking scoped_threadpool v0.1.9 [INFO] [stderr] Checking oorandom v11.1.0 [INFO] [stderr] Checking regex v1.3.1 [INFO] [stderr] Checking env_logger v0.6.2 [INFO] [stderr] Checking tiff v0.3.1 [INFO] [stderr] Checking pretty_env_logger v0.3.1 [INFO] [stderr] Checking image v0.22.3 [INFO] [stderr] Checking smithay-client-toolkit v0.6.4 [INFO] [stderr] Checking winit v0.20.0-alpha4 [INFO] [stderr] Checking glutin v0.22.0-alpha5 [INFO] [stderr] Checking ggraphics v0.0.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/lib.rs:360:28 [INFO] [stdout] | [INFO] [stdout] 360 | panic!(gl.get_shader_info_log(shader)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: add a "{}" format string to `Display` the message [INFO] [stdout] | [INFO] [stdout] 360 | panic!("{}", gl.get_shader_info_log(shader)); [INFO] [stdout] | +++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/lib.rs:368:24 [INFO] [stdout] | [INFO] [stdout] 368 | panic!(gl.get_program_info_log(program)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: add a "{}" format string to `Display` the message [INFO] [stdout] | [INFO] [stdout] 368 | panic!("{}", gl.get_program_info_log(program)); [INFO] [stdout] | +++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1088:14 [INFO] [stdout] | [INFO] [stdout] 1083 | texture: Texture, [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1086 | let x = QuadDrawCall::new(ctx, texture, sampler, self); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1087 | self.drawcalls.push(x); [INFO] [stdout] 1088 | &mut *self.drawcalls.last_mut().unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1212:14 [INFO] [stdout] | [INFO] [stdout] 1207 | texture: Texture, [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1210 | let x = MeshDrawCall::new(ctx, texture, sampler, self); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1211 | self.drawcalls.push(x); [INFO] [stdout] 1212 | &mut *self.drawcalls.last_mut().unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1322:18 [INFO] [stdout] | [INFO] [stdout] 1259 | let t = TextureHandle::new_empty(ctx, glow::RGBA, glow::UNSIGNED_BYTE, width, height) [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1322 | ctx: ctx.gl.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1409:29 [INFO] [stdout] | [INFO] [stdout] 1408 | pub fn add_pipeline(&mut self, pipeline: impl Pipeline + 'static) { [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1409 | self.pipelines.push(Box::new(pipeline)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ggraphics` (lib test) due to 5 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/lib.rs:360:28 [INFO] [stdout] | [INFO] [stdout] 360 | panic!(gl.get_shader_info_log(shader)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: add a "{}" format string to `Display` the message [INFO] [stdout] | [INFO] [stdout] 360 | panic!("{}", gl.get_shader_info_log(shader)); [INFO] [stdout] | +++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/lib.rs:368:24 [INFO] [stdout] | [INFO] [stdout] 368 | panic!(gl.get_program_info_log(program)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: add a "{}" format string to `Display` the message [INFO] [stdout] | [INFO] [stdout] 368 | panic!("{}", gl.get_program_info_log(program)); [INFO] [stdout] | +++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1088:14 [INFO] [stdout] | [INFO] [stdout] 1083 | texture: Texture, [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1086 | let x = QuadDrawCall::new(ctx, texture, sampler, self); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1087 | self.drawcalls.push(x); [INFO] [stdout] 1088 | &mut *self.drawcalls.last_mut().unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1212:14 [INFO] [stdout] | [INFO] [stdout] 1207 | texture: Texture, [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1210 | let x = MeshDrawCall::new(ctx, texture, sampler, self); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1211 | self.drawcalls.push(x); [INFO] [stdout] 1212 | &mut *self.drawcalls.last_mut().unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1322:18 [INFO] [stdout] | [INFO] [stdout] 1259 | let t = TextureHandle::new_empty(ctx, glow::RGBA, glow::UNSIGNED_BYTE, width, height) [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1322 | ctx: ctx.gl.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1409:29 [INFO] [stdout] | [INFO] [stdout] 1408 | pub fn add_pipeline(&mut self, pipeline: impl Pipeline + 'static) { [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1409 | self.pipelines.push(Box::new(pipeline)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ggraphics` (lib) due to 5 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "90afebbe286133abc60a5f900c03809d335b31ad2771f8f66545bbe40a558123", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "90afebbe286133abc60a5f900c03809d335b31ad2771f8f66545bbe40a558123", kill_on_drop: false }` [INFO] [stdout] 90afebbe286133abc60a5f900c03809d335b31ad2771f8f66545bbe40a558123