[INFO] fetching crate gf 0.6.1... [INFO] checking gf-0.6.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate gf 0.6.1 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate gf 0.6.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate gf 0.6.1 [INFO] finished tweaking crates.io crate gf 0.6.1 [INFO] tweaked toml for crates.io crate gf 0.6.1 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate gf 0.6.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c2dd180f7f975bb50005d3e6979882a24d40df2c984b3d4da3aaa1e85bcf41c8 [INFO] running `Command { std: "docker" "start" "-a" "c2dd180f7f975bb50005d3e6979882a24d40df2c984b3d4da3aaa1e85bcf41c8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c2dd180f7f975bb50005d3e6979882a24d40df2c984b3d4da3aaa1e85bcf41c8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c2dd180f7f975bb50005d3e6979882a24d40df2c984b3d4da3aaa1e85bcf41c8", kill_on_drop: false }` [INFO] [stdout] c2dd180f7f975bb50005d3e6979882a24d40df2c984b3d4da3aaa1e85bcf41c8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6779d4d66c2992b85803680cdfb337efff12f88c409b59c9c323a2719c3c49d9 [INFO] running `Command { std: "docker" "start" "-a" "6779d4d66c2992b85803680cdfb337efff12f88c409b59c9c323a2719c3c49d9", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Compiling proc-macro2 v1.0.28 [INFO] [stderr] Compiling libc v0.2.99 [INFO] [stderr] Compiling unicode-xid v0.2.2 [INFO] [stderr] Checking bytemuck v1.7.2 [INFO] [stderr] Compiling syn v1.0.74 [INFO] [stderr] Compiling typenum v1.13.0 [INFO] [stderr] Checking ppv-lite86 v0.2.10 [INFO] [stderr] Compiling paste v1.0.5 [INFO] [stderr] Checking gf v0.6.1 (/opt/rustwide/workdir) [INFO] [stderr] Checking matrixmultiply v0.3.1 [INFO] [stdout] warning: function `gen_tables_u8` is never used [INFO] [stdout] --> src/gen_table.rs:1:14 [INFO] [stdout] | [INFO] [stdout] 1 | pub const fn gen_tables_u8(genpoly: usize) -> ([usize; 256], [u8; 1023]) { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking safe_arch v0.6.0 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling num-integer v0.1.44 [INFO] [stderr] Compiling num-rational v0.4.0 [INFO] [stderr] Checking wide v0.7.0 [INFO] [stderr] Compiling quote v1.0.9 [INFO] [stderr] Checking getrandom v0.2.3 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking num-complex v0.4.0 [INFO] [stderr] Checking approx v0.5.0 [INFO] [stderr] Checking rand v0.8.4 [INFO] [stderr] Checking simba v0.7.1 [INFO] [stderr] Compiling nalgebra-macros v0.1.0 [INFO] [stderr] Checking nalgebra v0.31.0 [INFO] [stdout] warning: unexpected `cfg` condition value: `simd` [INFO] [stdout] --> examples/test_shamir.rs:1:13 [INFO] [stdout] | [INFO] [stdout] 1 | #![cfg_attr(feature = "simd", feature(portable_simd))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `num-traits` and `unstable_simd` [INFO] [stdout] = help: consider adding `simd` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `simd` [INFO] [stdout] --> examples/test_shamir.rs:68:7 [INFO] [stdout] | [INFO] [stdout] 68 | #[cfg(feature = "simd")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `num-traits` and `unstable_simd` [INFO] [stdout] = help: consider adding `simd` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `simd` [INFO] [stdout] --> examples/test_shamir.rs:85:11 [INFO] [stdout] | [INFO] [stdout] 85 | #[cfg(not(feature = "simd"))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `num-traits` and `unstable_simd` [INFO] [stdout] = help: consider adding `simd` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `rand::Rng` [INFO] [stdout] --> examples/test_shamir.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use rand::Rng; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> examples/test_shamir.rs:112:15 [INFO] [stdout] | [INFO] [stdout] 98 | data: impl AsRef<[u8]>, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 99 | threshold: u8, [INFO] [stdout] 100 | mut rng: impl rand::RngCore + rand::CryptoRng, [INFO] [stdout] | --------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 101 | ) -> impl Iterator)> { [INFO] [stdout] 102 | let mut buf = vec![0u8; data.as_ref().len() * threshold as usize].into_boxed_slice(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 112 | (1..).map(move |x| { [INFO] [stdout] | _______________^ [INFO] [stdout] 113 | | ( [INFO] [stdout] 114 | | x, [INFO] [stdout] 115 | | buf.chunks(threshold as usize) [INFO] [stdout] ... | [INFO] [stdout] 118 | | ) [INFO] [stdout] 119 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> examples/test_shamir.rs:115:13 [INFO] [stdout] | [INFO] [stdout] 102 | let mut buf = vec![0u8; data.as_ref().len() * threshold as usize].into_boxed_slice(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 115 | / buf.chunks(threshold as usize) [INFO] [stdout] 116 | | .map(|chunk| poly(chunk, x)) [INFO] [stdout] 117 | | .collect(), [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> examples/test_shamir.rs:125:5 [INFO] [stdout] | [INFO] [stdout] 124 | fn interpolate(shares: impl Iterator + Clone) -> u8 { [INFO] [stdout] | ---------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 125 | / shares [INFO] [stdout] 126 | | .clone() [INFO] [stdout] 127 | | .enumerate() [INFO] [stdout] 128 | | .map(|(i, (xi, share))| { [INFO] [stdout] ... | [INFO] [stdout] 135 | | .product::>() [INFO] [stdout] 136 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> examples/test_shamir.rs:144:30 [INFO] [stdout] | [INFO] [stdout] 144 | .map(|i| interpolate(shares.clone().map(|(x, bytes)| (x, bytes.as_ref()[i])))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `gf` (example "test_shamir") due to 5 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: comparison is useless due to type limits [INFO] [stdout] --> src/impls.rs:415:21 [INFO] [stdout] | [INFO] [stdout] 415 | assert!(*e <= 255); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_comparisons)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "6779d4d66c2992b85803680cdfb337efff12f88c409b59c9c323a2719c3c49d9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6779d4d66c2992b85803680cdfb337efff12f88c409b59c9c323a2719c3c49d9", kill_on_drop: false }` [INFO] [stdout] 6779d4d66c2992b85803680cdfb337efff12f88c409b59c9c323a2719c3c49d9