[INFO] fetching crate geticons 1.2.2... [INFO] checking geticons-1.2.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate geticons 1.2.2 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate geticons 1.2.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate geticons 1.2.2 [INFO] finished tweaking crates.io crate geticons 1.2.2 [INFO] tweaked toml for crates.io crate geticons 1.2.2 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate geticons 1.2.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f76c33b97babedf55bd871c45fdb1e85b20d64536f96c7c9dbf173852cdfd06f [INFO] running `Command { std: "docker" "start" "-a" "f76c33b97babedf55bd871c45fdb1e85b20d64536f96c7c9dbf173852cdfd06f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f76c33b97babedf55bd871c45fdb1e85b20d64536f96c7c9dbf173852cdfd06f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f76c33b97babedf55bd871c45fdb1e85b20d64536f96c7c9dbf173852cdfd06f", kill_on_drop: false }` [INFO] [stdout] f76c33b97babedf55bd871c45fdb1e85b20d64536f96c7c9dbf173852cdfd06f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] add543f06274cb71d6a71b72fb33cd54a332f56ec2293027ddf7798207135354 [INFO] running `Command { std: "docker" "start" "-a" "add543f06274cb71d6a71b72fb33cd54a332f56ec2293027ddf7798207135354", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.126 [INFO] [stderr] Compiling proc-macro2 v1.0.42 [INFO] [stderr] Compiling unicode-ident v1.0.2 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Checking ahash v0.4.7 [INFO] [stderr] Compiling unicode-segmentation v1.9.0 [INFO] [stderr] Compiling argh_shared v0.1.8 [INFO] [stderr] Checking encode_unicode v1.0.0 [INFO] [stderr] Compiling quote v1.0.20 [INFO] [stderr] Compiling syn v1.0.98 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Checking hashbrown v0.9.1 [INFO] [stderr] Compiling heck v0.3.3 [INFO] [stderr] Checking nom v7.1.1 [INFO] [stderr] Checking getrandom v0.2.7 [INFO] [stderr] Checking dirs-sys-next v0.1.2 [INFO] [stderr] Checking nix v0.23.1 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking memmap2 v0.5.5 [INFO] [stderr] Checking dirs-next v2.0.0 [INFO] [stderr] Checking term v0.7.0 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking prettytable-rs v0.9.0 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking dlv-list v0.2.3 [INFO] [stderr] Compiling thiserror-impl v1.0.31 [INFO] [stderr] Compiling argh_derive v0.1.8 [INFO] [stderr] Checking ordered-multimap v0.3.1 [INFO] [stderr] Checking rust-ini v0.17.0 [INFO] [stderr] Checking thiserror v1.0.31 [INFO] [stderr] Checking argh v0.1.8 [INFO] [stderr] Checking freedesktop_entry_parser v1.3.0 [INFO] [stderr] Checking linicon-theme v1.2.0 [INFO] [stderr] Checking file-locker v1.1.1 [INFO] [stderr] Checking linicon v2.3.0 [INFO] [stderr] Checking geticons v1.2.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/main.rs:93:22 [INFO] [stdout] | [INFO] [stdout] 93 | for error in errors { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 93 | while let Some(error) = errors { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 93 | if let Some(error) = errors { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:247:9 [INFO] [stdout] | [INFO] [stdout] 210 | let mut iter = linicon::lookup_icon(icon_name); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 224 | let (iter, mut error): (Vec<_>, Vec<_>) = iter.partition(Result::is_ok); [INFO] [stdout] | ---- ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 225 | let iter = iter.into_iter().map(Result::unwrap); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 247 | error.pop().map(Result::unwrap_err), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/main.rs:93:22 [INFO] [stdout] | [INFO] [stdout] 93 | for error in errors { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 93 | while let Some(error) = errors { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 93 | if let Some(error) = errors { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:247:9 [INFO] [stdout] | [INFO] [stdout] 210 | let mut iter = linicon::lookup_icon(icon_name); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 224 | let (iter, mut error): (Vec<_>, Vec<_>) = iter.partition(Result::is_ok); [INFO] [stdout] | ---- ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 225 | let iter = iter.into_iter().map(Result::unwrap); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 247 | error.pop().map(Result::unwrap_err), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `geticons` (bin "geticons" test) due to 2 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `geticons` (bin "geticons") due to 2 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "add543f06274cb71d6a71b72fb33cd54a332f56ec2293027ddf7798207135354", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "add543f06274cb71d6a71b72fb33cd54a332f56ec2293027ddf7798207135354", kill_on_drop: false }` [INFO] [stdout] add543f06274cb71d6a71b72fb33cd54a332f56ec2293027ddf7798207135354