[INFO] fetching crate get_sys_info 0.1.21... [INFO] checking get_sys_info-0.1.21 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate get_sys_info 0.1.21 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate get_sys_info 0.1.21 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate get_sys_info 0.1.21 [INFO] finished tweaking crates.io crate get_sys_info 0.1.21 [INFO] tweaked toml for crates.io crate get_sys_info 0.1.21 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 47 packages to latest compatible versions [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 63edc6b5ecc1c4a516b66c329adbdd5fc16087c595214be8fdf89cb556943fa1 [INFO] running `Command { std: "docker" "start" "-a" "63edc6b5ecc1c4a516b66c329adbdd5fc16087c595214be8fdf89cb556943fa1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "63edc6b5ecc1c4a516b66c329adbdd5fc16087c595214be8fdf89cb556943fa1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "63edc6b5ecc1c4a516b66c329adbdd5fc16087c595214be8fdf89cb556943fa1", kill_on_drop: false }` [INFO] [stdout] 63edc6b5ecc1c4a516b66c329adbdd5fc16087c595214be8fdf89cb556943fa1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7f381263a7ef57ea82be9f411005ee8769f85eb582baf33fad4332481176c447 [INFO] running `Command { std: "docker" "start" "-a" "7f381263a7ef57ea82be9f411005ee8769f85eb582baf33fad4332481176c447", kill_on_drop: false }` [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking readable_byte v0.1.14 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking get_sys_info v0.1.21 (/opt/rustwide/workdir) [INFO] [stdout] warning: private item shadows public glob re-export [INFO] [stdout] --> src/lib.rs:13:1 [INFO] [stdout] | [INFO] [stdout] 13 | extern crate readable_byte; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the name `readable_byte` in the type namespace is supposed to be publicly re-exported here [INFO] [stdout] --> src/lib.rs:22:9 [INFO] [stdout] | [INFO] [stdout] 22 | pub use self::data::*; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] note: but the private item here shadows it [INFO] [stdout] --> src/lib.rs:13:1 [INFO] [stdout] | [INFO] [stdout] 13 | extern crate readable_byte; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(hidden_glob_reexports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: private item shadows public glob re-export [INFO] [stdout] --> src/lib.rs:13:1 [INFO] [stdout] | [INFO] [stdout] 13 | extern crate readable_byte; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the name `readable_byte` in the type namespace is supposed to be publicly re-exported here [INFO] [stdout] --> src/lib.rs:22:9 [INFO] [stdout] | [INFO] [stdout] 22 | pub use self::data::*; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] note: but the private item here shadows it [INFO] [stdout] --> src/lib.rs:13:1 [INFO] [stdout] | [INFO] [stdout] 13 | extern crate readable_byte; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(hidden_glob_reexports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `chrono::TimeZone::datetime_from_str`: use `DateTime::parse_from_str` or `NaiveDateTime::parse_from_str` with `and_utc()` or `and_local_timezone()` instead [INFO] [stdout] --> src/platform/linux.rs:619:25 [INFO] [stdout] | [INFO] [stdout] 619 | Utc.datetime_from_str(line, "btime %s") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `chrono::TimeZone::datetime_from_str`: use `DateTime::parse_from_str` or `NaiveDateTime::parse_from_str` with `and_utc()` or `and_local_timezone()` instead [INFO] [stdout] --> src/platform/linux.rs:619:25 [INFO] [stdout] | [INFO] [stdout] 619 | Utc.datetime_from_str(line, "btime %s") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/platform/common.rs:22:12 [INFO] [stdout] | [INFO] [stdout] 21 | let measurement = self.cpu_load()?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 22 | Ok(DelayedMeasurement::new(Box::new(move || { [INFO] [stdout] | ____________^ [INFO] [stdout] 23 | | measurement.done().map(|ls| { [INFO] [stdout] 24 | | let mut it = ls.iter(); [INFO] [stdout] 25 | | let first = it.next().unwrap().clone(); // has to be a variable, rust moves the iterator otherwise [INFO] [stdout] 26 | | it.fold(first, |acc, l| acc.avg_add(l)) [INFO] [stdout] 27 | | }) [INFO] [stdout] 28 | | }))) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |___________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/platform/common.rs:23:13 [INFO] [stdout] | [INFO] [stdout] 21 | let measurement = self.cpu_load()?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 22 | Ok(DelayedMeasurement::new(Box::new(move || { [INFO] [stdout] 23 | measurement.done().map(|ls| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/platform/common.rs:67:9 [INFO] [stdout] | [INFO] [stdout] 66 | fn mount_at>(&self, path: P) -> io::Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 67 | self.mounts().and_then(|mounts| { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/platform/linux.rs:687:41 [INFO] [stdout] | [INFO] [stdout] 687 | .filter_map(|mount| stat_mount(mount).ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/platform/linux.rs:693:9 [INFO] [stdout] | [INFO] [stdout] 692 | fn mount_at>(&self, path: P) -> io::Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 693 | / read_file("/proc/mounts") [INFO] [stdout] 694 | | .and_then(|data| { [INFO] [stdout] 695 | | proc_mounts(&data) [INFO] [stdout] 696 | | .map(|(_, res)| res) [INFO] [stdout] ... | [INFO] [stdout] 703 | | .ok_or_else(|| io::Error::new(io::ErrorKind::NotFound, "No such mount")) [INFO] [stdout] 704 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/platform/common.rs:22:12 [INFO] [stdout] | [INFO] [stdout] 21 | let measurement = self.cpu_load()?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 22 | Ok(DelayedMeasurement::new(Box::new(move || { [INFO] [stdout] | ____________^ [INFO] [stdout] 23 | | measurement.done().map(|ls| { [INFO] [stdout] 24 | | let mut it = ls.iter(); [INFO] [stdout] 25 | | let first = it.next().unwrap().clone(); // has to be a variable, rust moves the iterator otherwise [INFO] [stdout] 26 | | it.fold(first, |acc, l| acc.avg_add(l)) [INFO] [stdout] 27 | | }) [INFO] [stdout] 28 | | }))) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |___________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/platform/common.rs:23:13 [INFO] [stdout] | [INFO] [stdout] 21 | let measurement = self.cpu_load()?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 22 | Ok(DelayedMeasurement::new(Box::new(move || { [INFO] [stdout] 23 | measurement.done().map(|ls| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/platform/common.rs:67:9 [INFO] [stdout] | [INFO] [stdout] 66 | fn mount_at>(&self, path: P) -> io::Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 67 | self.mounts().and_then(|mounts| { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/platform/linux.rs:687:41 [INFO] [stdout] | [INFO] [stdout] 687 | .filter_map(|mount| stat_mount(mount).ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/platform/linux.rs:693:9 [INFO] [stdout] | [INFO] [stdout] 692 | fn mount_at>(&self, path: P) -> io::Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 693 | / read_file("/proc/mounts") [INFO] [stdout] 694 | | .and_then(|data| { [INFO] [stdout] 695 | | proc_mounts(&data) [INFO] [stdout] 696 | | .map(|(_, res)| res) [INFO] [stdout] ... | [INFO] [stdout] 703 | | .ok_or_else(|| io::Error::new(io::ErrorKind::NotFound, "No such mount")) [INFO] [stdout] 704 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `get_sys_info` (lib) due to 6 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `get_sys_info` (lib test) due to 6 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "7f381263a7ef57ea82be9f411005ee8769f85eb582baf33fad4332481176c447", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7f381263a7ef57ea82be9f411005ee8769f85eb582baf33fad4332481176c447", kill_on_drop: false }` [INFO] [stdout] 7f381263a7ef57ea82be9f411005ee8769f85eb582baf33fad4332481176c447