[INFO] fetching crate get-all-crates 0.1.17... [INFO] checking get-all-crates-0.1.17 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate get-all-crates 0.1.17 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate get-all-crates 0.1.17 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate get-all-crates 0.1.17 [INFO] finished tweaking crates.io crate get-all-crates 0.1.17 [INFO] tweaked toml for crates.io crate get-all-crates 0.1.17 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate crates.io crate get-all-crates 0.1.17 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 2fcbed76edec1600a267fe4eff96ba4c2853badf16f8435835f16df5947ff636 [INFO] running `Command { std: "docker" "start" "-a" "2fcbed76edec1600a267fe4eff96ba4c2853badf16f8435835f16df5947ff636", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "2fcbed76edec1600a267fe4eff96ba4c2853badf16f8435835f16df5947ff636", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2fcbed76edec1600a267fe4eff96ba4c2853badf16f8435835f16df5947ff636", kill_on_drop: false }` [INFO] [stdout] 2fcbed76edec1600a267fe4eff96ba4c2853badf16f8435835f16df5947ff636 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8128b33581491c608868c586c85e9255b928e10f5cc52425349e9a9285698adc [INFO] running `Command { std: "docker" "start" "-a" "8128b33581491c608868c586c85e9255b928e10f5cc52425349e9a9285698adc", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Compiling cc v1.1.3 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking bytes v1.6.1 [INFO] [stderr] Compiling version_check v0.9.4 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking tinyvec v1.8.0 [INFO] [stderr] Compiling serde v1.0.204 [INFO] [stderr] Checking fnv v1.0.7 [INFO] [stderr] Checking rustls-pki-types v1.7.0 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Checking unicode-bidi v0.3.15 [INFO] [stderr] Compiling httparse v1.9.4 [INFO] [stderr] Checking untrusted v0.9.0 [INFO] [stderr] Compiling pkg-config v0.3.30 [INFO] [stderr] Checking percent-encoding v2.3.1 [INFO] [stderr] Compiling vcpkg v0.2.15 [INFO] [stderr] Compiling num-conv v0.1.0 [INFO] [stderr] Checking arrayvec v0.7.4 [INFO] [stderr] Compiling rustls v0.23.11 [INFO] [stderr] Checking try-lock v0.2.5 [INFO] [stderr] Checking powerfmt v0.2.0 [INFO] [stderr] Compiling syn v2.0.71 [INFO] [stderr] Checking alloc-no-stdlib v2.0.4 [INFO] [stderr] Compiling unicase v2.7.0 [INFO] [stderr] Compiling time-core v0.1.2 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Checking alloc-stdlib v0.2.2 [INFO] [stderr] Compiling vte_generate_state_changes v0.1.2 [INFO] [stderr] Compiling time-macros v0.2.18 [INFO] [stderr] Checking deranged v0.3.11 [INFO] [stderr] Compiling cookie v0.18.1 [INFO] [stderr] Checking want v0.3.1 [INFO] [stderr] Checking form_urlencoded v1.2.1 [INFO] [stderr] Checking tower-service v0.3.2 [INFO] [stderr] Checking subtle v2.6.1 [INFO] [stderr] Checking tower-layer v0.3.2 [INFO] [stderr] Checking unicode-width v0.1.13 [INFO] [stderr] Compiling portable-atomic v1.6.0 [INFO] [stderr] Checking zeroize v1.8.1 [INFO] [stderr] Compiling serde_json v1.0.120 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Checking miniz_oxide v0.7.4 [INFO] [stderr] Checking vte v0.11.1 [INFO] [stderr] Compiling mime_guess v2.0.5 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Checking brotli-decompressor v4.0.1 [INFO] [stderr] Checking anstyle-parse v0.2.4 [INFO] [stderr] Checking anstyle-query v1.1.0 [INFO] [stderr] Compiling openssl v0.10.64 [INFO] [stderr] Checking colorchoice v1.0.1 [INFO] [stderr] Checking is_terminal_polyfill v1.70.0 [INFO] [stderr] Checking foreign-types-shared v0.1.1 [INFO] [stderr] Checking anstyle v1.0.7 [INFO] [stderr] Compiling rayon-core v1.12.1 [INFO] [stderr] Checking psl-types v2.0.11 [INFO] [stderr] Checking foreign-types v0.3.2 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking regex v1.10.5 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking flate2 v1.0.30 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Checking anstream v0.6.14 [INFO] [stderr] Checking console v0.15.8 [INFO] [stderr] Checking idna v0.3.0 [INFO] [stderr] Compiling ring v0.17.8 [INFO] [stderr] Compiling openssl-sys v0.9.102 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking webpki-roots v0.26.3 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking mime v0.3.17 [INFO] [stderr] Checking clap_lex v0.7.1 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Checking number_prefix v0.4.0 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Checking rustls-pemfile v2.1.2 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking clap_builder v4.5.9 [INFO] [stderr] Checking vt100 v0.15.2 [INFO] [stderr] Checking sync_wrapper v1.0.1 [INFO] [stderr] Checking publicsuffix v2.2.3 [INFO] [stderr] Checking ipnet v2.9.0 [INFO] [stderr] Checking hex v0.3.2 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking walkdir v2.5.0 [INFO] [stderr] Checking memmap2 v0.9.4 [INFO] [stderr] Checking brotli v6.0.0 [INFO] [stderr] Checking num-format v0.4.4 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking bytesize v1.3.0 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking indicatif v0.17.8 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking hex v0.4.3 [INFO] [stderr] Compiling tokio-macros v2.3.0 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Compiling serde_derive v1.0.204 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling clap_derive v4.5.8 [INFO] [stderr] Checking tokio v1.38.0 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking rustls-webpki v0.102.5 [INFO] [stderr] Checking clap v4.5.9 [INFO] [stderr] Checking tracing-indicatif v0.3.6 [INFO] [stderr] Checking cookie_store v0.21.0 [INFO] [stderr] Checking crypto-hash v0.3.4 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking http-body-util v0.1.2 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking hyper v1.4.1 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking tokio-rustls v0.26.0 [INFO] [stderr] Checking async-compression v0.4.11 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking hyper-util v0.1.6 [INFO] [stderr] Checking hyper-rustls v0.27.2 [INFO] [stderr] Checking reqwest v0.12.5 [INFO] [stderr] Checking get-all-crates v0.1.17 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:200:8 [INFO] [stdout] | [INFO] [stdout] 169 | let mut vec = Vec::new(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 200 | Ok(CrateVersions { [INFO] [stdout] | ________^ [INFO] [stdout] 201 | | name: crate_name [INFO] [stdout] 202 | | .unwrap_or_else(|| path.file_name().unwrap().to_str().unwrap()) [INFO] [stdout] 203 | | .to_owned(), [INFO] [stdout] 204 | | versions: vec, [INFO] [stdout] 205 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:284:8 [INFO] [stdout] | [INFO] [stdout] 215 | let thread_pool = ThreadPoolBuilder::new().num_threads(num_threads).build()?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 216 | [INFO] [stdout] 217 | let crate_versions = Mutex::new(Vec::new()); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 274 | let crate_versions = crate_versions.into_inner(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 284 | Ok(AllCrateVersions { [INFO] [stdout] | ________^ [INFO] [stdout] 285 | | vec: crate_versions, [INFO] [stdout] 286 | | count: n_versions, [INFO] [stdout] 287 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:463:17 [INFO] [stdout] | [INFO] [stdout] 454 | let mut versions = get_all_crate_versions(&config)?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 459 | let rt = tokio::runtime::Builder::new_multi_thread() [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 463 | rt.block_on(async { [INFO] [stdout] | _________________^ [INFO] [stdout] 464 | | download_versions(&config, versions).await?; [INFO] [stdout] 465 | | info!("finished in {:?}", millis(begin.elapsed())); [INFO] [stdout] 466 | | Ok(()) [INFO] [stdout] 467 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `get-all-crates` (bin "get-all-crates") due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:200:8 [INFO] [stdout] | [INFO] [stdout] 169 | let mut vec = Vec::new(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 200 | Ok(CrateVersions { [INFO] [stdout] | ________^ [INFO] [stdout] 201 | | name: crate_name [INFO] [stdout] 202 | | .unwrap_or_else(|| path.file_name().unwrap().to_str().unwrap()) [INFO] [stdout] 203 | | .to_owned(), [INFO] [stdout] 204 | | versions: vec, [INFO] [stdout] 205 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:284:8 [INFO] [stdout] | [INFO] [stdout] 215 | let thread_pool = ThreadPoolBuilder::new().num_threads(num_threads).build()?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 216 | [INFO] [stdout] 217 | let crate_versions = Mutex::new(Vec::new()); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 274 | let crate_versions = crate_versions.into_inner(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 284 | Ok(AllCrateVersions { [INFO] [stdout] | ________^ [INFO] [stdout] 285 | | vec: crate_versions, [INFO] [stdout] 286 | | count: n_versions, [INFO] [stdout] 287 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:463:17 [INFO] [stdout] | [INFO] [stdout] 454 | let mut versions = get_all_crate_versions(&config)?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 459 | let rt = tokio::runtime::Builder::new_multi_thread() [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 463 | rt.block_on(async { [INFO] [stdout] | _________________^ [INFO] [stdout] 464 | | download_versions(&config, versions).await?; [INFO] [stdout] 465 | | info!("finished in {:?}", millis(begin.elapsed())); [INFO] [stdout] 466 | | Ok(()) [INFO] [stdout] 467 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `get-all-crates` (bin "get-all-crates" test) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "8128b33581491c608868c586c85e9255b928e10f5cc52425349e9a9285698adc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8128b33581491c608868c586c85e9255b928e10f5cc52425349e9a9285698adc", kill_on_drop: false }` [INFO] [stdout] 8128b33581491c608868c586c85e9255b928e10f5cc52425349e9a9285698adc