[INFO] fetching crate geo-booleanop 0.3.2... [INFO] checking geo-booleanop-0.3.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate geo-booleanop 0.3.2 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate geo-booleanop 0.3.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate geo-booleanop 0.3.2 [INFO] finished tweaking crates.io crate geo-booleanop 0.3.2 [INFO] tweaked toml for crates.io crate geo-booleanop 0.3.2 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 17 packages to latest compatible versions [INFO] [stderr] Adding approx v0.3.2 (latest: v0.5.1) [INFO] [stderr] Adding float_next_after v0.1.5 (latest: v1.0.0) [INFO] [stderr] Adding geo-types v0.6.2 (latest: v0.7.13) [INFO] [stderr] Adding rand v0.3.23 (latest: v0.8.5) [INFO] [stderr] Adding rand v0.4.6 (latest: v0.8.5) [INFO] [stderr] Adding rand_core v0.3.1 (latest: v0.6.4) [INFO] [stderr] Adding rand_core v0.4.2 (latest: v0.6.4) [INFO] [stderr] Adding rdrand v0.4.0 (latest: v0.8.3) [INFO] [stderr] Adding robust v0.1.2 (latest: v1.1.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 62775568892e1ebb5e7408cbb58dec1ea8dbb6d4cade29f560bc7ab9976806c8 [INFO] running `Command { std: "docker" "start" "-a" "62775568892e1ebb5e7408cbb58dec1ea8dbb6d4cade29f560bc7ab9976806c8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "62775568892e1ebb5e7408cbb58dec1ea8dbb6d4cade29f560bc7ab9976806c8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "62775568892e1ebb5e7408cbb58dec1ea8dbb6d4cade29f560bc7ab9976806c8", kill_on_drop: false }` [INFO] [stdout] 62775568892e1ebb5e7408cbb58dec1ea8dbb6d4cade29f560bc7ab9976806c8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 43b923c2bafbc6a787d0cc8856978eeeb8c9f5b333539f3da8e1e126e321936f [INFO] running `Command { std: "docker" "start" "-a" "43b923c2bafbc6a787d0cc8856978eeeb8c9f5b333539f3da8e1e126e321936f", kill_on_drop: false }` [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking robust v0.1.2 [INFO] [stderr] Checking rand v0.4.6 [INFO] [stderr] Checking rand v0.3.23 [INFO] [stderr] Checking approx v0.3.2 [INFO] [stderr] Checking float_next_after v0.1.5 [INFO] [stderr] Checking geo-types v0.6.2 [INFO] [stderr] Checking geo-booleanop v0.3.2 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/boolean/sweep_event.rs:65:17 [INFO] [stdout] | [INFO] [stdout] 61 | other_event: Weak>, [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 65 | Rc::new(SweepEvent { [INFO] [stdout] | _________________^ [INFO] [stdout] 66 | | mutable: RefCell::new(MutablePart { [INFO] [stdout] 67 | | left, [INFO] [stdout] 68 | | other_event, [INFO] [stdout] ... | [INFO] [stdout] 80 | | is_exterior_ring, [INFO] [stdout] 81 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/splay/node.rs:11:18 [INFO] [stdout] | [INFO] [stdout] 10 | pub fn new_boxed(k: K, v: V, l: Option>>, r: Option>>) -> Box> { [INFO] [stdout] | ---- ---- -------------------------- -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | | [INFO] [stdout] | | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 11 | Box::new(Node { [INFO] [stdout] | __________________^ [INFO] [stdout] 12 | | key: k, [INFO] [stdout] 13 | | value: v, [INFO] [stdout] 14 | | left: l, [INFO] [stdout] 15 | | right: r, [INFO] [stdout] 16 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/splay/set.rs:18:19 [INFO] [stdout] | [INFO] [stdout] 16 | pub fn new(comparator: C) -> SplaySet { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | SplaySet { [INFO] [stdout] 18 | tree: SplayTree::new(comparator), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/splay/set.rs:74:20 [INFO] [stdout] | [INFO] [stdout] 72 | fn into_iter(self) -> Self::IntoIter { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | IntoIter { [INFO] [stdout] 74 | inner: self.tree.into_iter(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/splay/tree.rs:24:19 [INFO] [stdout] | [INFO] [stdout] 21 | pub fn new(comparator: C) -> SplayTree { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 24 | root: UnsafeCell::new(None), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/splay/tree.rs:299:18 [INFO] [stdout] | [INFO] [stdout] 297 | fn into_iter(self) -> Self::IntoIter { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 298 | IntoIter { [INFO] [stdout] 299 | cur: self.root_mut().take(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `geo-booleanop` (lib) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/boolean/sweep_event.rs:65:17 [INFO] [stdout] | [INFO] [stdout] 61 | other_event: Weak>, [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 65 | Rc::new(SweepEvent { [INFO] [stdout] | _________________^ [INFO] [stdout] 66 | | mutable: RefCell::new(MutablePart { [INFO] [stdout] 67 | | left, [INFO] [stdout] 68 | | other_event, [INFO] [stdout] ... | [INFO] [stdout] 80 | | is_exterior_ring, [INFO] [stdout] 81 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/splay/node.rs:11:18 [INFO] [stdout] | [INFO] [stdout] 10 | pub fn new_boxed(k: K, v: V, l: Option>>, r: Option>>) -> Box> { [INFO] [stdout] | ---- ---- -------------------------- -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | | [INFO] [stdout] | | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 11 | Box::new(Node { [INFO] [stdout] | __________________^ [INFO] [stdout] 12 | | key: k, [INFO] [stdout] 13 | | value: v, [INFO] [stdout] 14 | | left: l, [INFO] [stdout] 15 | | right: r, [INFO] [stdout] 16 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/splay/set.rs:18:19 [INFO] [stdout] | [INFO] [stdout] 16 | pub fn new(comparator: C) -> SplaySet { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | SplaySet { [INFO] [stdout] 18 | tree: SplayTree::new(comparator), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/splay/set.rs:74:20 [INFO] [stdout] | [INFO] [stdout] 72 | fn into_iter(self) -> Self::IntoIter { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | IntoIter { [INFO] [stdout] 74 | inner: self.tree.into_iter(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/splay/tree.rs:24:19 [INFO] [stdout] | [INFO] [stdout] 21 | pub fn new(comparator: C) -> SplayTree { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 24 | root: UnsafeCell::new(None), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/splay/tree.rs:299:18 [INFO] [stdout] | [INFO] [stdout] 297 | fn into_iter(self) -> Self::IntoIter { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 298 | IntoIter { [INFO] [stdout] 299 | cur: self.root_mut().take(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `geo-booleanop` (lib test) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "43b923c2bafbc6a787d0cc8856978eeeb8c9f5b333539f3da8e1e126e321936f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "43b923c2bafbc6a787d0cc8856978eeeb8c9f5b333539f3da8e1e126e321936f", kill_on_drop: false }` [INFO] [stdout] 43b923c2bafbc6a787d0cc8856978eeeb8c9f5b333539f3da8e1e126e321936f