[INFO] fetching crate genref 0.8.0... [INFO] checking genref-0.8.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate genref 0.8.0 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate genref 0.8.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate genref 0.8.0 [INFO] finished tweaking crates.io crate genref 0.8.0 [INFO] tweaked toml for crates.io crate genref 0.8.0 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 21 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 562072ea3bec538a589e5c4d02e1eb8be44e804e294f84cdf3f4768aafea2004 [INFO] running `Command { std: "docker" "start" "-a" "562072ea3bec538a589e5c4d02e1eb8be44e804e294f84cdf3f4768aafea2004", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "562072ea3bec538a589e5c4d02e1eb8be44e804e294f84cdf3f4768aafea2004", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "562072ea3bec538a589e5c4d02e1eb8be44e804e294f84cdf3f4768aafea2004", kill_on_drop: false }` [INFO] [stdout] 562072ea3bec538a589e5c4d02e1eb8be44e804e294f84cdf3f4768aafea2004 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7608b0c5fa11ce64b4751566a167228a3cd1237bae6babff7e9bf4423b1d0282 [INFO] running `Command { std: "docker" "start" "-a" "7608b0c5fa11ce64b4751566a167228a3cd1237bae6babff7e9bf4423b1d0282", kill_on_drop: false }` [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking genref v0.8.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: creating a mutable reference to mutable static is discouraged [INFO] [stdout] --> src/lib.rs:298:52 [INFO] [stdout] | [INFO] [stdout] 298 | gen: Generation(NonNull::from(unsafe { &mut ZERO })), [INFO] [stdout] | ^^^^^^^^^ mutable reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #114447 [INFO] [stdout] = note: this will be a hard error in the 2024 edition [INFO] [stdout] = note: this mutable reference has lifetime `'static`, but if the static gets accessed (read or written) by any other means, or any other reference is created, then any further use of this mutable reference is Undefined Behavior [INFO] [stdout] = note: `#[warn(static_mut_refs)]` on by default [INFO] [stdout] help: use `addr_of_mut!` instead to create a raw pointer [INFO] [stdout] | [INFO] [stdout] 298 | gen: Generation(NonNull::from(unsafe { addr_of_mut!(ZERO) })), [INFO] [stdout] | ~~~~~~~~~~~~~ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `dq` is assigned to, but never used [INFO] [stdout] --> src/global.rs:123:13 [INFO] [stdout] | [INFO] [stdout] 123 | let dq; [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = note: consider using `_dq` instead [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `dq` is never read [INFO] [stdout] --> src/global.rs:125:27 [INFO] [stdout] | [INFO] [stdout] 125 | Ok(mut wl) => dq = DropQueue::clear(&mut wl), [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `try_reading` is never used [INFO] [stdout] --> src/global.rs:52:8 [INFO] [stdout] | [INFO] [stdout] 52 | pub fn try_reading() -> Option { Lock::try_reading() } [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `writing` is never used [INFO] [stdout] --> src/global.rs:62:8 [INFO] [stdout] | [INFO] [stdout] 62 | pub fn writing() -> Writing { Lock::writing() } [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `try_writing` is never used [INFO] [stdout] --> src/global.rs:63:8 [INFO] [stdout] | [INFO] [stdout] 63 | pub fn try_writing() -> Option { Lock::try_writing() } [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated functions `writing` and `try_reading` are never used [INFO] [stdout] --> src/global.rs:75:8 [INFO] [stdout] | [INFO] [stdout] 65 | impl Lock [INFO] [stdout] | --------- associated functions in this implementation [INFO] [stdout] ... [INFO] [stdout] 75 | fn writing() -> Writing [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 81 | fn try_reading() -> Option [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `genref`, `gen`, and `ptr` are never read [INFO] [stdout] --> src/global.rs:233:5 [INFO] [stdout] | [INFO] [stdout] 231 | pub struct Weak [INFO] [stdout] | ---- fields in this struct [INFO] [stdout] 232 | { [INFO] [stdout] 233 | genref: u32, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 234 | gen: Generation, [INFO] [stdout] | ^^^ [INFO] [stdout] 235 | ptr: NonNull, [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new`, `take`, `as_ref`, `as_mut`, and `map` are never used [INFO] [stdout] --> src/global.rs:255:12 [INFO] [stdout] | [INFO] [stdout] 253 | impl Strong [INFO] [stdout] | ---------------------------------------- associated items in this implementation [INFO] [stdout] 254 | { [INFO] [stdout] 255 | pub fn new(t: T) -> Self { Self::from(Box::new(t)) } [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 266 | pub fn take(mut self, _wl: &mut Writing) -> Box [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 274 | pub fn as_ref(&self, _rl: &Reading) -> &T { &self.ptr } [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 275 | pub fn as_mut(&mut self, _wl: &mut Writing) -> &mut T { &mut self.ptr } [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 276 | [INFO] [stdout] 277 | pub fn map(&self, rl: &Reading, f: F) -> Weak [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `dangling`, `is_valid`, `try_ref`, `try_mut`, and `try_map` are never used [INFO] [stdout] --> src/global.rs:303:12 [INFO] [stdout] | [INFO] [stdout] 301 | impl Weak [INFO] [stdout] | -------------------------------------- associated items in this implementation [INFO] [stdout] 302 | { [INFO] [stdout] 303 | pub fn dangling() -> Self [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 313 | pub fn is_valid(&self) -> bool { self.genref == self.gen.get() } [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 314 | [INFO] [stdout] 315 | pub fn try_ref(&self, _rl: &Reading) -> Option<&T> [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 324 | pub fn try_mut(&mut self, _wl: &mut Writing) -> Option<&mut T> [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 333 | pub fn try_map(&self, rl: &Reading, f: F) -> Option> [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: multiple associated items are never used [INFO] [stdout] --> src/global.rs:366:12 [INFO] [stdout] | [INFO] [stdout] 363 | impl Ref [INFO] [stdout] | ------------------------------------- associated items in this implementation [INFO] [stdout] ... [INFO] [stdout] 366 | pub fn new(t: T) -> Self { Self::Strong(Strong::new(t)) } [INFO] [stdout] | ^^^ [INFO] [stdout] 367 | [INFO] [stdout] 368 | pub fn try_as_ref(&self, rl: &Reading) -> Option<&T> [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 376 | pub fn try_mut(&mut self, wl: &mut Writing) -> Option<&mut T> [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 384 | pub fn try_map(&self, rl: &Reading, f: F) -> Option> [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 395 | pub fn is_weak(&self) -> bool [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 403 | pub fn is_strong(&self) -> bool [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 411 | pub fn is_valid(&self) -> bool [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:152:51 [INFO] [stdout] | [INFO] [stdout] 152 | fn free(gen: Generation) { FREELIST.with(|fl| fl.borrow_mut().free_(gen)) } [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:155:60 [INFO] [stdout] | [INFO] [stdout] 155 | fn unfree() -> Option { FREELIST.with(|fl| fl.borrow_mut().unfree_()) } [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:172:52 [INFO] [stdout] | [INFO] [stdout] 172 | fn fresh() -> Generation { FRESHLIST.with(|fl| fl.borrow_mut().fresh_()) } [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:198:67 [INFO] [stdout] | [INFO] [stdout] 198 | fn clear(wl: &mut Writing) -> impl Drop { DROPQUEUE.with(|dq| dq.borrow_mut().clear_(wl)) } [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:201:56 [INFO] [stdout] | [INFO] [stdout] 201 | fn defer(val: Box) { DROPQUEUE.with(|dq| dq.borrow_mut().defer_(val)) } [INFO] [stdout] | ----------------------- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:201:61 [INFO] [stdout] | [INFO] [stdout] 201 | fn defer(val: Box) { DROPQUEUE.with(|dq| dq.borrow_mut().defer_(val)) } [INFO] [stdout] | --- ^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:246:43 [INFO] [stdout] | [INFO] [stdout] 246 | pub fn new(t: T) -> Self { Self::from(Box::new(t)) } [INFO] [stdout] | ---- ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:355:45 [INFO] [stdout] | [INFO] [stdout] 355 | pub fn new(t: T) -> Self { Self::Strong(Strong::new(t)) } [INFO] [stdout] | ---- ^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/global.rs:210:41 [INFO] [stdout] | [INFO] [stdout] 210 | fn defer(val: Box) { DROPQUEUE.lock().defer_(val) } [INFO] [stdout] | ----------------------- ^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/global.rs:255:43 [INFO] [stdout] | [INFO] [stdout] 255 | pub fn new(t: T) -> Self { Self::from(Box::new(t)) } [INFO] [stdout] | ---- ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/global.rs:366:45 [INFO] [stdout] | [INFO] [stdout] 366 | pub fn new(t: T) -> Self { Self::Strong(Strong::new(t)) } [INFO] [stdout] | ---- ^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 11 previous errors; 11 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `genref` (lib) due to 12 previous errors; 11 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: creating a mutable reference to mutable static is discouraged [INFO] [stdout] --> src/lib.rs:298:52 [INFO] [stdout] | [INFO] [stdout] 298 | gen: Generation(NonNull::from(unsafe { &mut ZERO })), [INFO] [stdout] | ^^^^^^^^^ mutable reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #114447 [INFO] [stdout] = note: this will be a hard error in the 2024 edition [INFO] [stdout] = note: this mutable reference has lifetime `'static`, but if the static gets accessed (read or written) by any other means, or any other reference is created, then any further use of this mutable reference is Undefined Behavior [INFO] [stdout] = note: `#[warn(static_mut_refs)]` on by default [INFO] [stdout] help: use `addr_of_mut!` instead to create a raw pointer [INFO] [stdout] | [INFO] [stdout] 298 | gen: Generation(NonNull::from(unsafe { addr_of_mut!(ZERO) })), [INFO] [stdout] | ~~~~~~~~~~~~~ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `dq` is assigned to, but never used [INFO] [stdout] --> src/global.rs:123:13 [INFO] [stdout] | [INFO] [stdout] 123 | let dq; [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = note: consider using `_dq` instead [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `dq` is never read [INFO] [stdout] --> src/global.rs:125:27 [INFO] [stdout] | [INFO] [stdout] 125 | Ok(mut wl) => dq = DropQueue::clear(&mut wl), [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `try_reading` is never used [INFO] [stdout] --> src/global.rs:52:8 [INFO] [stdout] | [INFO] [stdout] 52 | pub fn try_reading() -> Option { Lock::try_reading() } [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `writing` is never used [INFO] [stdout] --> src/global.rs:62:8 [INFO] [stdout] | [INFO] [stdout] 62 | pub fn writing() -> Writing { Lock::writing() } [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `try_writing` is never used [INFO] [stdout] --> src/global.rs:63:8 [INFO] [stdout] | [INFO] [stdout] 63 | pub fn try_writing() -> Option { Lock::try_writing() } [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated functions `writing` and `try_reading` are never used [INFO] [stdout] --> src/global.rs:75:8 [INFO] [stdout] | [INFO] [stdout] 65 | impl Lock [INFO] [stdout] | --------- associated functions in this implementation [INFO] [stdout] ... [INFO] [stdout] 75 | fn writing() -> Writing [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 81 | fn try_reading() -> Option [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `genref`, `gen`, and `ptr` are never read [INFO] [stdout] --> src/global.rs:233:5 [INFO] [stdout] | [INFO] [stdout] 231 | pub struct Weak [INFO] [stdout] | ---- fields in this struct [INFO] [stdout] 232 | { [INFO] [stdout] 233 | genref: u32, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 234 | gen: Generation, [INFO] [stdout] | ^^^ [INFO] [stdout] 235 | ptr: NonNull, [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new`, `take`, `as_ref`, `as_mut`, and `map` are never used [INFO] [stdout] --> src/global.rs:255:12 [INFO] [stdout] | [INFO] [stdout] 253 | impl Strong [INFO] [stdout] | ---------------------------------------- associated items in this implementation [INFO] [stdout] 254 | { [INFO] [stdout] 255 | pub fn new(t: T) -> Self { Self::from(Box::new(t)) } [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 266 | pub fn take(mut self, _wl: &mut Writing) -> Box [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 274 | pub fn as_ref(&self, _rl: &Reading) -> &T { &self.ptr } [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 275 | pub fn as_mut(&mut self, _wl: &mut Writing) -> &mut T { &mut self.ptr } [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 276 | [INFO] [stdout] 277 | pub fn map(&self, rl: &Reading, f: F) -> Weak [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `dangling`, `is_valid`, `try_ref`, `try_mut`, and `try_map` are never used [INFO] [stdout] --> src/global.rs:303:12 [INFO] [stdout] | [INFO] [stdout] 301 | impl Weak [INFO] [stdout] | -------------------------------------- associated items in this implementation [INFO] [stdout] 302 | { [INFO] [stdout] 303 | pub fn dangling() -> Self [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 313 | pub fn is_valid(&self) -> bool { self.genref == self.gen.get() } [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 314 | [INFO] [stdout] 315 | pub fn try_ref(&self, _rl: &Reading) -> Option<&T> [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 324 | pub fn try_mut(&mut self, _wl: &mut Writing) -> Option<&mut T> [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 333 | pub fn try_map(&self, rl: &Reading, f: F) -> Option> [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: multiple associated items are never used [INFO] [stdout] --> src/global.rs:366:12 [INFO] [stdout] | [INFO] [stdout] 363 | impl Ref [INFO] [stdout] | ------------------------------------- associated items in this implementation [INFO] [stdout] ... [INFO] [stdout] 366 | pub fn new(t: T) -> Self { Self::Strong(Strong::new(t)) } [INFO] [stdout] | ^^^ [INFO] [stdout] 367 | [INFO] [stdout] 368 | pub fn try_as_ref(&self, rl: &Reading) -> Option<&T> [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 376 | pub fn try_mut(&mut self, wl: &mut Writing) -> Option<&mut T> [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 384 | pub fn try_map(&self, rl: &Reading, f: F) -> Option> [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 395 | pub fn is_weak(&self) -> bool [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 403 | pub fn is_strong(&self) -> bool [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 411 | pub fn is_valid(&self) -> bool [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:152:51 [INFO] [stdout] | [INFO] [stdout] 152 | fn free(gen: Generation) { FREELIST.with(|fl| fl.borrow_mut().free_(gen)) } [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:155:60 [INFO] [stdout] | [INFO] [stdout] 155 | fn unfree() -> Option { FREELIST.with(|fl| fl.borrow_mut().unfree_()) } [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:172:52 [INFO] [stdout] | [INFO] [stdout] 172 | fn fresh() -> Generation { FRESHLIST.with(|fl| fl.borrow_mut().fresh_()) } [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:198:67 [INFO] [stdout] | [INFO] [stdout] 198 | fn clear(wl: &mut Writing) -> impl Drop { DROPQUEUE.with(|dq| dq.borrow_mut().clear_(wl)) } [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:201:56 [INFO] [stdout] | [INFO] [stdout] 201 | fn defer(val: Box) { DROPQUEUE.with(|dq| dq.borrow_mut().defer_(val)) } [INFO] [stdout] | ----------------------- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:201:61 [INFO] [stdout] | [INFO] [stdout] 201 | fn defer(val: Box) { DROPQUEUE.with(|dq| dq.borrow_mut().defer_(val)) } [INFO] [stdout] | --- ^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:246:43 [INFO] [stdout] | [INFO] [stdout] 246 | pub fn new(t: T) -> Self { Self::from(Box::new(t)) } [INFO] [stdout] | ---- ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:355:45 [INFO] [stdout] | [INFO] [stdout] 355 | pub fn new(t: T) -> Self { Self::Strong(Strong::new(t)) } [INFO] [stdout] | ---- ^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/global.rs:210:41 [INFO] [stdout] | [INFO] [stdout] 210 | fn defer(val: Box) { DROPQUEUE.lock().defer_(val) } [INFO] [stdout] | ----------------------- ^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/global.rs:255:43 [INFO] [stdout] | [INFO] [stdout] 255 | pub fn new(t: T) -> Self { Self::from(Box::new(t)) } [INFO] [stdout] | ---- ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/global.rs:366:45 [INFO] [stdout] | [INFO] [stdout] 366 | pub fn new(t: T) -> Self { Self::Strong(Strong::new(t)) } [INFO] [stdout] | ---- ^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 11 previous errors; 11 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `genref` (lib test) due to 12 previous errors; 11 warnings emitted [INFO] running `Command { std: "docker" "inspect" "7608b0c5fa11ce64b4751566a167228a3cd1237bae6babff7e9bf4423b1d0282", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7608b0c5fa11ce64b4751566a167228a3cd1237bae6babff7e9bf4423b1d0282", kill_on_drop: false }` [INFO] [stdout] 7608b0c5fa11ce64b4751566a167228a3cd1237bae6babff7e9bf4423b1d0282