[INFO] fetching crate genr 0.1.0... [INFO] checking genr-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate genr 0.1.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate genr 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate genr 0.1.0 [INFO] finished tweaking crates.io crate genr 0.1.0 [INFO] tweaked toml for crates.io crate genr 0.1.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] edbade3b2fadd66cd4f8df479b948a137db2177c45c0a1ce395385999ada335c [INFO] running `Command { std: "docker" "start" "-a" "edbade3b2fadd66cd4f8df479b948a137db2177c45c0a1ce395385999ada335c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "edbade3b2fadd66cd4f8df479b948a137db2177c45c0a1ce395385999ada335c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "edbade3b2fadd66cd4f8df479b948a137db2177c45c0a1ce395385999ada335c", kill_on_drop: false }` [INFO] [stdout] edbade3b2fadd66cd4f8df479b948a137db2177c45c0a1ce395385999ada335c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ad88216b46a6f389eb8cc5fb2dfde12bde755d8d9fc64fea693e27bf847e77c7 [INFO] running `Command { std: "docker" "start" "-a" "ad88216b46a6f389eb8cc5fb2dfde12bde755d8d9fc64fea693e27bf847e77c7", kill_on_drop: false }` [INFO] [stderr] Checking genr v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/generational.rs:102:9 [INFO] [stdout] | [INFO] [stdout] 101 | fn insert_arr(&mut self, items: [T; N]) -> [Self::InsertResult; N] { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 102 | / items.into_iter().zip(0..N).fold( [INFO] [stdout] 103 | | std::array::from_fn(|_| None), [INFO] [stdout] 104 | | |mut acc, (item, idx)| { [INFO] [stdout] 105 | | acc[idx] = Some(self.insert(item)); acc [INFO] [stdout] 106 | | } [INFO] [stdout] 107 | | ).map(|gidx| gidx.unwrap()) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/generational.rs:124:9 [INFO] [stdout] | [INFO] [stdout] 123 | fn insert_vec(&mut self, items: Vec) -> Vec { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 124 | items.into_iter().fold( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gvec.rs:87:13 [INFO] [stdout] | [INFO] [stdout] 85 | pub fn from(value: [T; N]) -> (Self, [GIdx; N]) { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 86 | ( [INFO] [stdout] 87 | / Self { [INFO] [stdout] 88 | | data: Vec::from(value.map(|v| Some(v))), [INFO] [stdout] 89 | | gens: Vec::from([0; N]), [INFO] [stdout] 90 | | dead: Vec::new(), [INFO] [stdout] 91 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gvec.rs:118:20 [INFO] [stdout] | [INFO] [stdout] 116 | fn into_iter(self) -> Self::IntoIter { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 117 | IntoIter { [INFO] [stdout] 118 | inner: self.data.into_iter(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gvec.rs:295:34 [INFO] [stdout] | [INFO] [stdout] 294 | fn set(&mut self, gidx: GIdx, value: T) -> Option { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 295 | self.contains(gidx).then(|| self.data[gidx.idx].replace(value).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gvec.rs:295:37 [INFO] [stdout] | [INFO] [stdout] 294 | fn set(&mut self, gidx: GIdx, value: T) -> Option { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 295 | self.contains(gidx).then(|| self.data[gidx.idx].replace(value).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/garr.rs:105:13 [INFO] [stdout] | [INFO] [stdout] 103 | pub fn from(value: [T; N]) -> (Self, [GIdx; N]) { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 104 | ( [INFO] [stdout] 105 | / Self { [INFO] [stdout] 106 | | data: value.map(|i| Some(i)), [INFO] [stdout] 107 | | gens: [0; N], [INFO] [stdout] 108 | | dead: Vec::with_capacity(N), [INFO] [stdout] 109 | | used: N, [INFO] [stdout] 110 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/garr.rs:176:20 [INFO] [stdout] | [INFO] [stdout] 174 | fn into_iter(self) -> Self::IntoIter { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 175 | IntoIter { [INFO] [stdout] 176 | inner: self.data.into_iter(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/garr.rs:357:34 [INFO] [stdout] | [INFO] [stdout] 356 | fn set(&mut self, gidx: GIdx, value: T) -> Option { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 357 | self.contains(gidx).then(|| self.data[gidx.idx].replace(value).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/garr.rs:357:37 [INFO] [stdout] | [INFO] [stdout] 356 | fn set(&mut self, gidx: GIdx, value: T) -> Option { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 357 | self.contains(gidx).then(|| self.data[gidx.idx].replace(value).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 10 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/generational.rs:102:9 [INFO] [stdout] | [INFO] [stdout] 101 | fn insert_arr(&mut self, items: [T; N]) -> [Self::InsertResult; N] { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 102 | / items.into_iter().zip(0..N).fold( [INFO] [stdout] 103 | | std::array::from_fn(|_| None), [INFO] [stdout] 104 | | |mut acc, (item, idx)| { [INFO] [stdout] 105 | | acc[idx] = Some(self.insert(item)); acc [INFO] [stdout] 106 | | } [INFO] [stdout] 107 | | ).map(|gidx| gidx.unwrap()) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/generational.rs:124:9 [INFO] [stdout] | [INFO] [stdout] 123 | fn insert_vec(&mut self, items: Vec) -> Vec { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 124 | items.into_iter().fold( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gvec.rs:87:13 [INFO] [stdout] | [INFO] [stdout] 85 | pub fn from(value: [T; N]) -> (Self, [GIdx; N]) { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 86 | ( [INFO] [stdout] 87 | / Self { [INFO] [stdout] 88 | | data: Vec::from(value.map(|v| Some(v))), [INFO] [stdout] 89 | | gens: Vec::from([0; N]), [INFO] [stdout] 90 | | dead: Vec::new(), [INFO] [stdout] 91 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gvec.rs:118:20 [INFO] [stdout] | [INFO] [stdout] 116 | fn into_iter(self) -> Self::IntoIter { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 117 | IntoIter { [INFO] [stdout] 118 | inner: self.data.into_iter(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gvec.rs:295:34 [INFO] [stdout] | [INFO] [stdout] 294 | fn set(&mut self, gidx: GIdx, value: T) -> Option { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 295 | self.contains(gidx).then(|| self.data[gidx.idx].replace(value).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gvec.rs:295:37 [INFO] [stdout] | [INFO] [stdout] 294 | fn set(&mut self, gidx: GIdx, value: T) -> Option { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 295 | self.contains(gidx).then(|| self.data[gidx.idx].replace(value).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/garr.rs:105:13 [INFO] [stdout] | [INFO] [stdout] 103 | pub fn from(value: [T; N]) -> (Self, [GIdx; N]) { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 104 | ( [INFO] [stdout] 105 | / Self { [INFO] [stdout] 106 | | data: value.map(|i| Some(i)), [INFO] [stdout] 107 | | gens: [0; N], [INFO] [stdout] 108 | | dead: Vec::with_capacity(N), [INFO] [stdout] 109 | | used: N, [INFO] [stdout] 110 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `genr` (lib) due to 11 previous errors [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/garr.rs:176:20 [INFO] [stdout] | [INFO] [stdout] 174 | fn into_iter(self) -> Self::IntoIter { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 175 | IntoIter { [INFO] [stdout] 176 | inner: self.data.into_iter(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/garr.rs:357:34 [INFO] [stdout] | [INFO] [stdout] 356 | fn set(&mut self, gidx: GIdx, value: T) -> Option { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 357 | self.contains(gidx).then(|| self.data[gidx.idx].replace(value).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/garr.rs:357:37 [INFO] [stdout] | [INFO] [stdout] 356 | fn set(&mut self, gidx: GIdx, value: T) -> Option { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 357 | self.contains(gidx).then(|| self.data[gidx.idx].replace(value).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 10 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `genr` (lib test) due to 11 previous errors [INFO] running `Command { std: "docker" "inspect" "ad88216b46a6f389eb8cc5fb2dfde12bde755d8d9fc64fea693e27bf847e77c7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ad88216b46a6f389eb8cc5fb2dfde12bde755d8d9fc64fea693e27bf847e77c7", kill_on_drop: false }` [INFO] [stdout] ad88216b46a6f389eb8cc5fb2dfde12bde755d8d9fc64fea693e27bf847e77c7