[INFO] fetching crate gen-vec 0.3.0... [INFO] checking gen-vec-0.3.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate gen-vec 0.3.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate gen-vec 0.3.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate gen-vec 0.3.0 [INFO] finished tweaking crates.io crate gen-vec 0.3.0 [INFO] tweaked toml for crates.io crate gen-vec 0.3.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 7 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5d03d9d7820cb58da36f99b8544b3bc6a1a4494c7ccfa4885ecfb09b249a32ec [INFO] running `Command { std: "docker" "start" "-a" "5d03d9d7820cb58da36f99b8544b3bc6a1a4494c7ccfa4885ecfb09b249a32ec", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5d03d9d7820cb58da36f99b8544b3bc6a1a4494c7ccfa4885ecfb09b249a32ec", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5d03d9d7820cb58da36f99b8544b3bc6a1a4494c7ccfa4885ecfb09b249a32ec", kill_on_drop: false }` [INFO] [stdout] 5d03d9d7820cb58da36f99b8544b3bc6a1a4494c7ccfa4885ecfb09b249a32ec [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 10d8a67ddf5626d57d4530cc538f47484744abd8e3995752549b2482f5e6572e [INFO] running `Command { std: "docker" "start" "-a" "10d8a67ddf5626d57d4530cc538f47484744abd8e3995752549b2482f5e6572e", kill_on_drop: false }` [INFO] [stderr] Checking gen-vec v0.3.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: ambiguous glob re-exports [INFO] [stdout] --> src/exposed/mod.rs:22:9 [INFO] [stdout] | [INFO] [stdout] 22 | pub use self::gen_vec::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ the name `IntoIter` in the type namespace is first re-exported here [INFO] [stdout] 23 | pub mod index_allocator; [INFO] [stdout] 24 | pub use self::index_allocator::*; [INFO] [stdout] | ------------------------ but the name `IntoIter` in the type namespace is also re-exported here [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(ambiguous_glob_reexports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: ambiguous glob re-exports [INFO] [stdout] --> src/exposed/mod.rs:22:9 [INFO] [stdout] | [INFO] [stdout] 22 | pub use self::gen_vec::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ the name `Iter` in the type namespace is first re-exported here [INFO] [stdout] 23 | pub mod index_allocator; [INFO] [stdout] 24 | pub use self::index_allocator::*; [INFO] [stdout] | ------------------------ but the name `Iter` in the type namespace is also re-exported here [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: ambiguous glob re-exports [INFO] [stdout] --> src/exposed/mod.rs:22:9 [INFO] [stdout] | [INFO] [stdout] 22 | pub use self::gen_vec::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ the name `IntoIter` in the type namespace is first re-exported here [INFO] [stdout] 23 | pub mod index_allocator; [INFO] [stdout] 24 | pub use self::index_allocator::*; [INFO] [stdout] | ------------------------ but the name `IntoIter` in the type namespace is also re-exported here [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(ambiguous_glob_reexports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: ambiguous glob re-exports [INFO] [stdout] --> src/exposed/mod.rs:22:9 [INFO] [stdout] | [INFO] [stdout] 22 | pub use self::gen_vec::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ the name `Iter` in the type namespace is first re-exported here [INFO] [stdout] 23 | pub mod index_allocator; [INFO] [stdout] 24 | pub use self::index_allocator::*; [INFO] [stdout] | ------------------------ but the name `Iter` in the type namespace is also re-exported here [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/exposed/gen_vec.rs:163:25 [INFO] [stdout] | [INFO] [stdout] 163 | _ => panic!(format!("Index is out of bounds despite internal vec being resized: {:?}", index)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `panic!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 163 - _ => panic!(format!("Index is out of bounds despite internal vec being resized: {:?}", index)) [INFO] [stdout] 163 + _ => panic!("Index is out of bounds despite internal vec being resized: {:?}", index) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/exposed/gen_vec.rs:355:23 [INFO] [stdout] | [INFO] [stdout] 351 | fn into_iter(self) -> Self::IntoIter [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 355 | internal: self.items.into_iter().enumerate() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `gen-vec` (lib) due to 2 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/exposed/gen_vec.rs:163:25 [INFO] [stdout] | [INFO] [stdout] 163 | _ => panic!(format!("Index is out of bounds despite internal vec being resized: {:?}", index)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `panic!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 163 - _ => panic!(format!("Index is out of bounds despite internal vec being resized: {:?}", index)) [INFO] [stdout] 163 + _ => panic!("Index is out of bounds despite internal vec being resized: {:?}", index) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/exposed/gen_vec.rs:355:23 [INFO] [stdout] | [INFO] [stdout] 351 | fn into_iter(self) -> Self::IntoIter [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 355 | internal: self.items.into_iter().enumerate() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `gen-vec` (lib test) due to 2 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "10d8a67ddf5626d57d4530cc538f47484744abd8e3995752549b2482f5e6572e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "10d8a67ddf5626d57d4530cc538f47484744abd8e3995752549b2482f5e6572e", kill_on_drop: false }` [INFO] [stdout] 10d8a67ddf5626d57d4530cc538f47484744abd8e3995752549b2482f5e6572e