[INFO] fetching crate gdeh0154d67 0.2.0... [INFO] checking gdeh0154d67-0.2.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate gdeh0154d67 0.2.0 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate gdeh0154d67 0.2.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate gdeh0154d67 0.2.0 [INFO] finished tweaking crates.io crate gdeh0154d67 0.2.0 [INFO] tweaked toml for crates.io crate gdeh0154d67 0.2.0 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 22 packages to latest compatible versions [INFO] [stderr] Adding embedded-hal v1.0.0-rc.1 (latest: v1.0.0) [INFO] [stderr] Adding radium v0.7.0 (latest: v1.1.0) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding wyz v0.5.1 (latest: v0.6.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3268e5a9cef1b7fe06d180baf50b61356651a5032ddeafb7060d22082c5e4de8 [INFO] running `Command { std: "docker" "start" "-a" "3268e5a9cef1b7fe06d180baf50b61356651a5032ddeafb7060d22082c5e4de8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3268e5a9cef1b7fe06d180baf50b61356651a5032ddeafb7060d22082c5e4de8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3268e5a9cef1b7fe06d180baf50b61356651a5032ddeafb7060d22082c5e4de8", kill_on_drop: false }` [INFO] [stdout] 3268e5a9cef1b7fe06d180baf50b61356651a5032ddeafb7060d22082c5e4de8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] db998255f97adb8fc6a9db17afb8157367ebf998ddcb86f8e7903c8ef6fae9ce [INFO] running `Command { std: "docker" "start" "-a" "db998255f97adb8fc6a9db17afb8157367ebf998ddcb86f8e7903c8ef6fae9ce", kill_on_drop: false }` [INFO] [stderr] Compiling az v1.2.1 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling radium v0.7.0 [INFO] [stderr] Checking tap v1.0.1 [INFO] [stderr] Checking funty v2.0.0 [INFO] [stderr] Checking micromath v2.1.0 [INFO] [stderr] Checking embedded-hal v1.0.0-rc.1 [INFO] [stderr] Checking float-cmp v0.9.0 [INFO] [stderr] Checking wyz v0.5.1 [INFO] [stderr] Checking bitvec v1.0.1 [INFO] [stderr] Checking embedded-graphics-core v0.4.0 [INFO] [stderr] Checking embedded-graphics v0.8.1 [INFO] [stderr] Compiling thiserror-impl-no-std v2.0.2 [INFO] [stderr] Checking thiserror-no-std v2.0.2 [INFO] [stderr] Checking gdeh0154d67 v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/command.rs:115:68 [INFO] [stdout] | [INFO] [stdout] 115 | pub struct TemperatureSensorWrite(/** 2 bytes command argument. */ pub [u8; 2]); [INFO] [stdout] | ---------------------- field in this struct ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider removing this field [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:79:12 [INFO] [stdout] | [INFO] [stdout] 78 | pub fn new(interface: SPI, dc: DC, reset: RST, busy: BSY, delay: DLY) -> Result { [INFO] [stdout] | -------------- ------ ---------- --------- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | | | [INFO] [stdout] | | | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 79 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 80 | | interface, [INFO] [stdout] 81 | | #[cfg(feature = "heap_buffer")] [INFO] [stdout] 82 | | buffer: Box::new(Buffer { [INFO] [stdout] ... | [INFO] [stdout] 95 | | state: NotInitialized, [INFO] [stdout] 96 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:129:12 [INFO] [stdout] | [INFO] [stdout] 101 | pub fn init(mut self) -> Result, Error> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 129 | Ok(GDEH0154D67 { [INFO] [stdout] | ____________^ [INFO] [stdout] 130 | | interface: self.interface, [INFO] [stdout] 131 | | buffer: self.buffer, [INFO] [stdout] 132 | | dc: self.dc, [INFO] [stdout] ... | [INFO] [stdout] 136 | | state: Initialized, [INFO] [stdout] 137 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:142:12 [INFO] [stdout] | [INFO] [stdout] 141 | pub fn release(self) -> Result<(SPI, DC, RST, BSY), Error> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 142 | Ok((self.interface, self.dc, self.reset, self.busy)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:217:12 [INFO] [stdout] | [INFO] [stdout] 215 | pub fn release(self) -> Result<(SPI, DC, RST, BSY), Error> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 216 | let display = self.turn_off().unwrap(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 217 | Ok((display.interface, display.dc, display.reset, display.busy)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:234:12 [INFO] [stdout] | [INFO] [stdout] 230 | pub fn turn_off(mut self) -> Result, Error> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 234 | Ok(GDEH0154D67 { [INFO] [stdout] | ____________^ [INFO] [stdout] 235 | | interface: self.interface, [INFO] [stdout] 236 | | buffer: self.buffer, [INFO] [stdout] 237 | | dc: self.dc, [INFO] [stdout] ... | [INFO] [stdout] 241 | | state: NotInitialized, [INFO] [stdout] 242 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `gdeh0154d67` (lib) due to 6 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/command.rs:115:68 [INFO] [stdout] | [INFO] [stdout] 115 | pub struct TemperatureSensorWrite(/** 2 bytes command argument. */ pub [u8; 2]); [INFO] [stdout] | ---------------------- field in this struct ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider removing this field [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:79:12 [INFO] [stdout] | [INFO] [stdout] 78 | pub fn new(interface: SPI, dc: DC, reset: RST, busy: BSY, delay: DLY) -> Result { [INFO] [stdout] | -------------- ------ ---------- --------- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | | | [INFO] [stdout] | | | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 79 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 80 | | interface, [INFO] [stdout] 81 | | #[cfg(feature = "heap_buffer")] [INFO] [stdout] 82 | | buffer: Box::new(Buffer { [INFO] [stdout] ... | [INFO] [stdout] 95 | | state: NotInitialized, [INFO] [stdout] 96 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:129:12 [INFO] [stdout] | [INFO] [stdout] 101 | pub fn init(mut self) -> Result, Error> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 129 | Ok(GDEH0154D67 { [INFO] [stdout] | ____________^ [INFO] [stdout] 130 | | interface: self.interface, [INFO] [stdout] 131 | | buffer: self.buffer, [INFO] [stdout] 132 | | dc: self.dc, [INFO] [stdout] ... | [INFO] [stdout] 136 | | state: Initialized, [INFO] [stdout] 137 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:142:12 [INFO] [stdout] | [INFO] [stdout] 141 | pub fn release(self) -> Result<(SPI, DC, RST, BSY), Error> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 142 | Ok((self.interface, self.dc, self.reset, self.busy)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:217:12 [INFO] [stdout] | [INFO] [stdout] 215 | pub fn release(self) -> Result<(SPI, DC, RST, BSY), Error> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 216 | let display = self.turn_off().unwrap(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 217 | Ok((display.interface, display.dc, display.reset, display.busy)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:234:12 [INFO] [stdout] | [INFO] [stdout] 230 | pub fn turn_off(mut self) -> Result, Error> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 234 | Ok(GDEH0154D67 { [INFO] [stdout] | ____________^ [INFO] [stdout] 235 | | interface: self.interface, [INFO] [stdout] 236 | | buffer: self.buffer, [INFO] [stdout] 237 | | dc: self.dc, [INFO] [stdout] ... | [INFO] [stdout] 241 | | state: NotInitialized, [INFO] [stdout] 242 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `gdeh0154d67` (lib test) due to 6 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "db998255f97adb8fc6a9db17afb8157367ebf998ddcb86f8e7903c8ef6fae9ce", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "db998255f97adb8fc6a9db17afb8157367ebf998ddcb86f8e7903c8ef6fae9ce", kill_on_drop: false }` [INFO] [stdout] db998255f97adb8fc6a9db17afb8157367ebf998ddcb86f8e7903c8ef6fae9ce