[INFO] fetching crate gchemol-readwrite 0.1.11... [INFO] checking gchemol-readwrite-0.1.11 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate gchemol-readwrite 0.1.11 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate gchemol-readwrite 0.1.11 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate gchemol-readwrite 0.1.11 [INFO] finished tweaking crates.io crate gchemol-readwrite 0.1.11 [INFO] tweaked toml for crates.io crate gchemol-readwrite 0.1.11 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 207 packages to latest compatible versions [INFO] [stderr] Adding base64 v0.20.0 (latest: v0.22.1) [INFO] [stderr] Adding env_logger v0.10.2 (latest: v0.11.5) [INFO] [stderr] Adding fixedbitset v0.4.2 (latest: v0.5.7) [INFO] [stderr] Adding gchemol-parser v0.4.6 (latest: v0.5.1) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding grep v0.2.13 (latest: v0.3.1) [INFO] [stderr] Adding grep-printer v0.1.7 (latest: v0.2.1) [INFO] [stderr] Adding handlebars v4.0.1 (latest: v6.0.0) [INFO] [stderr] Adding hashbrown v0.12.3 (latest: v0.14.5) [INFO] [stderr] Adding indexmap v1.9.3 (latest: v2.5.0) [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0) [INFO] [stderr] Adding lazy-regex v2.5.0 (latest: v3.3.0) [INFO] [stderr] Adding lazy-regex-proc_macros v2.4.1 (latest: v3.3.0) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding minijinja v1.0.21 (latest: v2.2.0) [INFO] [stderr] Adding nalgebra v0.31.4 (latest: v0.33.0) [INFO] [stderr] Adding nalgebra-macros v0.1.0 (latest: v0.2.2) [INFO] [stderr] Adding ordered-float v3.9.2 (latest: v4.2.2) [INFO] [stderr] Adding roxmltree v0.18.1 (latest: v0.20.0) [INFO] [stderr] Adding simba v0.7.3 (latest: v0.9.0) [INFO] [stderr] Adding siphasher v0.3.11 (latest: v1.0.1) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding toml v0.7.8 (latest: v0.8.19) [INFO] [stderr] Adding toml_edit v0.19.15 (latest: v0.22.20) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] [stderr] Adding winnow v0.5.40 (latest: v0.6.18) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 2a944f093da54e99d31a5ef4563e48da05040be4500a233c9d74e5c5e74d91a4 [INFO] running `Command { std: "docker" "start" "-a" "2a944f093da54e99d31a5ef4563e48da05040be4500a233c9d74e5c5e74d91a4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "2a944f093da54e99d31a5ef4563e48da05040be4500a233c9d74e5c5e74d91a4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2a944f093da54e99d31a5ef4563e48da05040be4500a233c9d74e5c5e74d91a4", kill_on_drop: false }` [INFO] [stdout] 2a944f093da54e99d31a5ef4563e48da05040be4500a233c9d74e5c5e74d91a4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] fc608f49b068d85a1df56fbf857c9a92b0ae97754a22a82964d692d57db587cc [INFO] running `Command { std: "docker" "start" "-a" "fc608f49b068d85a1df56fbf857c9a92b0ae97754a22a82964d692d57db587cc", kill_on_drop: false }` [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling byteorder v1.5.0 [INFO] [stderr] Checking indexmap v2.5.0 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling zerocopy v0.7.35 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Compiling regex-syntax v0.8.4 [INFO] [stderr] Compiling paste v1.0.15 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Checking bytemuck v1.17.1 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking safe_arch v0.7.2 [INFO] [stderr] Compiling ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking grep-matcher v0.1.7 [INFO] [stderr] Compiling matrixmultiply v0.3.9 [INFO] [stderr] Compiling rustix v0.38.35 [INFO] [stderr] Checking winnow v0.5.40 [INFO] [stderr] Checking anstream v0.6.15 [INFO] [stderr] Compiling phf_shared v0.11.2 [INFO] [stderr] Checking encoding_rs_io v0.1.7 [INFO] [stderr] Checking wide v0.7.28 [INFO] [stderr] Checking approx v0.5.1 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking serde_spanned v0.6.7 [INFO] [stderr] Checking toml_datetime v0.6.8 [INFO] [stderr] Checking memmap2 v0.9.4 [INFO] [stderr] Checking powerfmt v0.2.0 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Checking clap_builder v4.5.15 [INFO] [stderr] Checking bstr v1.10.0 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking toml_edit v0.19.15 [INFO] [stderr] Checking simba v0.7.3 [INFO] [stderr] Checking deranged v0.3.11 [INFO] [stderr] Checking globset v0.4.14 [INFO] [stderr] Checking grep-searcher v0.1.13 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Compiling clap_derive v4.5.13 [INFO] [stderr] Compiling nalgebra-macros v0.1.0 [INFO] [stderr] Checking is-terminal v0.4.13 [INFO] [stderr] Checking shared_child v1.0.1 [INFO] [stderr] Checking os_pipe v1.2.1 [INFO] [stderr] Checking time-core v0.1.2 [INFO] [stderr] Checking num-conv v0.1.0 [INFO] [stderr] Checking tempfile v3.12.0 [INFO] [stderr] Checking env_logger v0.10.2 [INFO] [stderr] Checking duct v0.13.7 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Compiling phf_generator v0.11.2 [INFO] [stderr] Checking ordered-float v3.9.2 [INFO] [stderr] Checking shell-escape v0.1.5 [INFO] [stderr] Compiling phf_codegen v0.11.2 [INFO] [stderr] Checking grep-cli v0.1.10 [INFO] [stderr] Checking toml v0.7.8 [INFO] [stderr] Checking grep-regex v0.1.12 [INFO] [stderr] Compiling phf v0.11.2 [INFO] [stderr] Checking unic-common v0.9.0 [INFO] [stderr] Checking unic-char-range v0.9.0 [INFO] [stderr] Checking unic-ucd-version v0.9.0 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Checking grep-printer v0.2.1 [INFO] [stderr] Checking unic-char-property v0.9.0 [INFO] [stderr] Checking base64 v0.20.0 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking unic-ucd-segment v0.9.0 [INFO] [stderr] Checking petgraph v0.6.5 [INFO] [stderr] Checking grep-printer v0.1.7 [INFO] [stderr] Checking grep v0.3.1 [INFO] [stderr] Checking ignore v0.4.22 [INFO] [stderr] Checking rand_distr v0.4.3 [INFO] [stderr] Compiling parse-zoneinfo v0.3.1 [INFO] [stderr] Checking minimal-lexical v0.2.1 [INFO] [stderr] Checking str_indices v0.4.3 [INFO] [stderr] Checking globwalk v0.9.1 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking clap v4.5.16 [INFO] [stderr] Checking ropey v1.6.1 [INFO] [stderr] Checking gchemol-gut v0.4.4 [INFO] [stderr] Compiling chrono-tz-build v0.3.0 [INFO] [stderr] Checking grep v0.2.13 [INFO] [stderr] Checking grep-reader v0.1.3 [INFO] [stderr] Checking unic-segment v0.9.0 [INFO] [stderr] Checking bimap v0.6.3 [INFO] [stderr] Checking envy v0.4.2 [INFO] [stderr] Checking humansize v2.1.3 [INFO] [stderr] Checking quick-error v2.0.1 [INFO] [stderr] Checking xmlparser v0.13.6 [INFO] [stderr] Checking extxyz v0.2.0 [INFO] [stderr] Checking handlebars v4.0.1 [INFO] [stderr] Checking minijinja v1.0.21 [INFO] [stderr] Checking roxmltree v0.18.1 [INFO] [stderr] Checking gchemol-graph v0.1.6 [INFO] [stderr] Compiling chrono-tz v0.9.0 [INFO] [stderr] Compiling lazy-regex-proc_macros v2.4.1 [INFO] [stderr] Checking gchemol-parser v0.4.6 [INFO] [stderr] Checking lazy-regex v2.5.0 [INFO] [stderr] Checking nalgebra v0.31.4 [INFO] [stderr] Checking tera v1.20.0 [INFO] [stderr] Checking vecfx v0.1.6 [INFO] [stderr] Checking gchemol-lattice v0.1.2 [INFO] [stderr] Checking octree v0.1.0 [INFO] [stderr] Checking gchemol-geometry v0.1.1 [INFO] [stderr] Checking gchemol-neighbors v0.1.3 [INFO] [stderr] Checking gchemol-core v0.1.7 [INFO] [stderr] Checking gchemol-readwrite v0.1.11 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `PathBuf` [INFO] [stdout] --> src/template/jinja.rs:3:23 [INFO] [stdout] | [INFO] [stdout] 3 | use std::path::{Path, PathBuf}; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `PathBuf` [INFO] [stdout] --> src/template/jinja.rs:3:23 [INFO] [stdout] | [INFO] [stdout] 3 | use std::path::{Path, PathBuf}; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `gchemol_core::Atom::label`: use get_label instead [INFO] [stdout] --> src/formats/mol2.rs:113:18 [INFO] [stdout] | [INFO] [stdout] 113 | name = a.label(), [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `gchemol_core::Atom::label`: use get_label instead [INFO] [stdout] --> src/formats/pdb.rs:150:16 [INFO] [stdout] | [INFO] [stdout] 150 | name=a.label(), [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `gchemol_core::Atom::label`: use get_label instead [INFO] [stdout] --> src/formats/mol2.rs:113:18 [INFO] [stdout] | [INFO] [stdout] 113 | name = a.label(), [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `gchemol_core::Atom::label`: use get_label instead [INFO] [stdout] --> src/formats/pdb.rs:150:16 [INFO] [stdout] | [INFO] [stdout] 150 | name=a.label(), [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `rc` [INFO] [stdout] --> src/template/hbs.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 19 | rc: &mut RenderContext, [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_rc` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/template/jinja.rs:126:9 [INFO] [stdout] | [INFO] [stdout] 126 | let mut env = Environment::new(); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: static `GLOBAL_REX` is never used [INFO] [stdout] --> src/template/jinja.rs:11:8 [INFO] [stdout] | [INFO] [stdout] 11 | static GLOBAL_REX: Lazy = lazy_regex!("^ab+$"i); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `render` is never used [INFO] [stdout] --> src/template/jinja.rs:125:8 [INFO] [stdout] | [INFO] [stdout] 125 | pub fn render(json_source: &str, template: &str) -> Result { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/formats.rs:123:12 [INFO] [stdout] | [INFO] [stdout] 91 | pub fn parse_molecules_from(&self, r: TextReader) -> Result> [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 95 | let mut p1 = None; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 96 | let mut p2 = None; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 97 | let mut p3 = None; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 98 | let mut p4 = None; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 99 | let mut p5 = None; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 100 | let mut p6 = None; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 101 | let mut p7 = None; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 102 | let mut p8 = None; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 103 | let mut p9 = None; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 104 | let mut p10 = None; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 105 | let mut p11 = None; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 106 | let mut p12 = None; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 123 | Ok(p1 [INFO] [stdout] | ____________^ [INFO] [stdout] 124 | | .into_iter() [INFO] [stdout] 125 | | .flatten() [INFO] [stdout] 126 | | .chain(p2.into_iter().flatten()) [INFO] [stdout] ... | [INFO] [stdout] 142 | | } [INFO] [stdout] 143 | | })) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/formats/cif.rs:408:12 [INFO] [stdout] | [INFO] [stdout] 406 | pub fn partitions(&self, mut r: TextReader) -> Result> { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 407 | r.seek_line(|line| line.starts_with("data_")); [INFO] [stdout] 408 | Ok(r.partitions(*self)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/formats/mol2.rs:435:12 [INFO] [stdout] | [INFO] [stdout] 433 | pub fn partitions(&self, mut r: TextReader) -> Result> { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 434 | r.seek_line(|line| line.starts_with("@MOLECULE"))?; [INFO] [stdout] 435 | Ok(r.partitions(*self)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/formats/pdb.rs:467:12 [INFO] [stdout] | [INFO] [stdout] 466 | pub fn partitions(&self, mut r: TextReader) -> Result> { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 467 | Ok(r.partitions(*self)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/formats/sdf.rs:233:12 [INFO] [stdout] | [INFO] [stdout] 232 | pub fn partitions(&self, mut r: TextReader) -> Result> { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 233 | Ok(r.partitions(*self)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/formats/gaussian_input.rs:261:5 [INFO] [stdout] | [INFO] [stdout] 260 | let params = separated_list1(tag(","), atom_param); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 261 | delimited(tag("("), params, tag(")"))(s) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/formats/gaussian_input.rs:275:5 [INFO] [stdout] | [INFO] [stdout] 273 | let mm_type = preceded(tag("-"), is_not("- \t")); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 274 | let mm_charge = preceded(tag("-"), double); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 275 | pair(mm_type, opt(mm_charge))(s) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/formats/gaussian_input.rs:734:12 [INFO] [stdout] | [INFO] [stdout] 733 | pub fn partitions(&self, mut r: TextReader) -> Result> { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 734 | Ok(r.partitions(*self)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io.rs:83:9 [INFO] [stdout] | [INFO] [stdout] 82 | fn parse_from>(s: R, fmt: S) -> Result { [INFO] [stdout] | ---- ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 83 | read_from(s, &fmt)? [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io.rs:126:9 [INFO] [stdout] | [INFO] [stdout] 122 | let mut walk = WalkDir::new(root).follow_links(false).sort_by_file_name(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 126 | walk.into_iter() [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/template/hbs.rs:92:5 [INFO] [stdout] | [INFO] [stdout] 87 | let mut h = Handlebars::new(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 92 | h.render_template(template, &data) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/template/tera.rs:61:5 [INFO] [stdout] | [INFO] [stdout] 55 | let mut tera = Tera::default(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 61 | tera.render("molecule", &context) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 12 previous errors; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `gchemol-readwrite` (lib) due to 13 previous errors; 7 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unused variable: `rc` [INFO] [stdout] --> src/template/hbs.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 19 | rc: &mut RenderContext, [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_rc` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `x` [INFO] [stdout] --> src/template/hbs.rs:108:9 [INFO] [stdout] | [INFO] [stdout] 108 | let x = render_molecule_with(&mol, &template).unwrap(); [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_x` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/template/jinja.rs:126:9 [INFO] [stdout] | [INFO] [stdout] 126 | let mut env = Environment::new(); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: static `GLOBAL_REX` is never used [INFO] [stdout] --> src/template/jinja.rs:11:8 [INFO] [stdout] | [INFO] [stdout] 11 | static GLOBAL_REX: Lazy = lazy_regex!("^ab+$"i); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `render` is never used [INFO] [stdout] --> src/template/jinja.rs:125:8 [INFO] [stdout] | [INFO] [stdout] 125 | pub fn render(json_source: &str, template: &str) -> Result { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/formats.rs:123:12 [INFO] [stdout] | [INFO] [stdout] 91 | pub fn parse_molecules_from(&self, r: TextReader) -> Result> [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 95 | let mut p1 = None; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 96 | let mut p2 = None; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 97 | let mut p3 = None; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 98 | let mut p4 = None; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 99 | let mut p5 = None; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 100 | let mut p6 = None; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 101 | let mut p7 = None; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 102 | let mut p8 = None; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 103 | let mut p9 = None; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 104 | let mut p10 = None; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 105 | let mut p11 = None; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 106 | let mut p12 = None; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 123 | Ok(p1 [INFO] [stdout] | ____________^ [INFO] [stdout] 124 | | .into_iter() [INFO] [stdout] 125 | | .flatten() [INFO] [stdout] 126 | | .chain(p2.into_iter().flatten()) [INFO] [stdout] ... | [INFO] [stdout] 142 | | } [INFO] [stdout] 143 | | })) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/formats/cif.rs:408:12 [INFO] [stdout] | [INFO] [stdout] 406 | pub fn partitions(&self, mut r: TextReader) -> Result> { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 407 | r.seek_line(|line| line.starts_with("data_")); [INFO] [stdout] 408 | Ok(r.partitions(*self)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/formats/mol2.rs:435:12 [INFO] [stdout] | [INFO] [stdout] 433 | pub fn partitions(&self, mut r: TextReader) -> Result> { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 434 | r.seek_line(|line| line.starts_with("@MOLECULE"))?; [INFO] [stdout] 435 | Ok(r.partitions(*self)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/formats/pdb.rs:467:12 [INFO] [stdout] | [INFO] [stdout] 466 | pub fn partitions(&self, mut r: TextReader) -> Result> { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 467 | Ok(r.partitions(*self)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/formats/sdf.rs:233:12 [INFO] [stdout] | [INFO] [stdout] 232 | pub fn partitions(&self, mut r: TextReader) -> Result> { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 233 | Ok(r.partitions(*self)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/formats/gaussian_input.rs:261:5 [INFO] [stdout] | [INFO] [stdout] 260 | let params = separated_list1(tag(","), atom_param); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 261 | delimited(tag("("), params, tag(")"))(s) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/formats/gaussian_input.rs:275:5 [INFO] [stdout] | [INFO] [stdout] 273 | let mm_type = preceded(tag("-"), is_not("- \t")); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 274 | let mm_charge = preceded(tag("-"), double); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 275 | pair(mm_type, opt(mm_charge))(s) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/formats/gaussian_input.rs:734:12 [INFO] [stdout] | [INFO] [stdout] 733 | pub fn partitions(&self, mut r: TextReader) -> Result> { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 734 | Ok(r.partitions(*self)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io.rs:83:9 [INFO] [stdout] | [INFO] [stdout] 82 | fn parse_from>(s: R, fmt: S) -> Result { [INFO] [stdout] | ---- ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 83 | read_from(s, &fmt)? [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io.rs:126:9 [INFO] [stdout] | [INFO] [stdout] 122 | let mut walk = WalkDir::new(root).follow_links(false).sort_by_file_name(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 126 | walk.into_iter() [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/template/hbs.rs:92:5 [INFO] [stdout] | [INFO] [stdout] 87 | let mut h = Handlebars::new(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 92 | h.render_template(template, &data) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/template/tera.rs:61:5 [INFO] [stdout] | [INFO] [stdout] 55 | let mut tera = Tera::default(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 61 | tera.render("molecule", &context) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 12 previous errors; 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `gchemol-readwrite` (lib test) due to 13 previous errors; 8 warnings emitted [INFO] running `Command { std: "docker" "inspect" "fc608f49b068d85a1df56fbf857c9a92b0ae97754a22a82964d692d57db587cc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fc608f49b068d85a1df56fbf857c9a92b0ae97754a22a82964d692d57db587cc", kill_on_drop: false }` [INFO] [stdout] fc608f49b068d85a1df56fbf857c9a92b0ae97754a22a82964d692d57db587cc