[INFO] fetching crate gchemol-parser 0.5.1... [INFO] checking gchemol-parser-0.5.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate gchemol-parser 0.5.1 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate gchemol-parser 0.5.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate gchemol-parser 0.5.1 [INFO] finished tweaking crates.io crate gchemol-parser 0.5.1 [INFO] tweaked toml for crates.io crate gchemol-parser 0.5.1 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 99 packages to latest compatible versions [INFO] [stderr] Adding env_logger v0.10.2 (latest: v0.11.5) [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding toml v0.7.8 (latest: v0.8.19) [INFO] [stderr] Adding toml_edit v0.19.15 (latest: v0.22.20) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] [stderr] Adding winnow v0.5.40 (latest: v0.6.18) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c4e322f790c740ffe47216521c5f9706268e53d660c851dade94cf300909c55b [INFO] running `Command { std: "docker" "start" "-a" "c4e322f790c740ffe47216521c5f9706268e53d660c851dade94cf300909c55b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c4e322f790c740ffe47216521c5f9706268e53d660c851dade94cf300909c55b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c4e322f790c740ffe47216521c5f9706268e53d660c851dade94cf300909c55b", kill_on_drop: false }` [INFO] [stdout] c4e322f790c740ffe47216521c5f9706268e53d660c851dade94cf300909c55b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c1929647d3f836947d252710dcac3aeda6d840a509fb8cab7bf58eaf0c749af8 [INFO] running `Command { std: "docker" "start" "-a" "c1929647d3f836947d252710dcac3aeda6d840a509fb8cab7bf58eaf0c749af8", kill_on_drop: false }` [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking grep-matcher v0.1.7 [INFO] [stderr] Checking memmap2 v0.9.4 [INFO] [stderr] Checking encoding_rs_io v0.1.7 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking winnow v0.5.40 [INFO] [stderr] Checking clap_builder v4.5.15 [INFO] [stderr] Checking is-terminal v0.4.13 [INFO] [stderr] Checking os_pipe v1.2.1 [INFO] [stderr] Checking shared_child v1.0.1 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking shell-escape v0.1.5 [INFO] [stderr] Checking duct v0.13.7 [INFO] [stderr] Checking str_indices v0.4.3 [INFO] [stderr] Checking ropey v1.6.1 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking clap v4.5.16 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking serde_spanned v0.6.7 [INFO] [stderr] Checking toml_datetime v0.6.8 [INFO] [stderr] Checking toml_edit v0.19.15 [INFO] [stderr] Checking bstr v1.10.0 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking env_logger v0.10.2 [INFO] [stderr] Checking globset v0.4.14 [INFO] [stderr] Checking grep-searcher v0.1.13 [INFO] [stderr] Checking grep-regex v0.1.12 [INFO] [stderr] Checking grep-cli v0.1.10 [INFO] [stderr] Checking grep-printer v0.2.1 [INFO] [stderr] Checking toml v0.7.8 [INFO] [stderr] Checking grep v0.3.1 [INFO] [stderr] Checking grep-reader v0.1.3 [INFO] [stderr] Checking gchemol-gut v0.4.4 [INFO] [stderr] Checking gchemol-parser v0.5.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `winnow::stream::Stream` [INFO] [stdout] --> src/parsers.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | use winnow::stream::Stream; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `winnow::stream::Located` [INFO] [stdout] --> src/parsers.rs:154:9 [INFO] [stdout] | [INFO] [stdout] 154 | use winnow::stream::Located; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `winnow::stream::Stream` [INFO] [stdout] --> src/parsers.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | use winnow::stream::Stream; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `winnow::stream::Located` [INFO] [stdout] --> src/parsers.rs:154:9 [INFO] [stdout] | [INFO] [stdout] 154 | use winnow::stream::Located; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable expression [INFO] [stdout] --> src/reader.rs:114:9 [INFO] [stdout] | [INFO] [stdout] 98 | / loop { [INFO] [stdout] 99 | | let n = self.inner.read_line(&mut line)?; [INFO] [stdout] 100 | | if n == 0 { [INFO] [stdout] 101 | | // EOF [INFO] [stdout] ... | [INFO] [stdout] 111 | | line.clear(); [INFO] [stdout] 112 | | } [INFO] [stdout] | |_________- any code following this expression is unreachable [INFO] [stdout] 113 | [INFO] [stdout] 114 | Ok(m) [INFO] [stdout] | ^^^^^ unreachable expression [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unreachable_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable expression [INFO] [stdout] --> src/reader.rs:142:9 [INFO] [stdout] | [INFO] [stdout] 127 | / loop { [INFO] [stdout] 128 | | let n = self.inner.read_line(buf)?; [INFO] [stdout] 129 | | if n == 0 { [INFO] [stdout] 130 | | // EOF [INFO] [stdout] ... | [INFO] [stdout] 139 | | m += n; [INFO] [stdout] 140 | | } [INFO] [stdout] | |_________- any code following this expression is unreachable [INFO] [stdout] 141 | [INFO] [stdout] 142 | Ok(m) [INFO] [stdout] | ^^^^^ unreachable expression [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable expression [INFO] [stdout] --> src/reader.rs:114:9 [INFO] [stdout] | [INFO] [stdout] 98 | / loop { [INFO] [stdout] 99 | | let n = self.inner.read_line(&mut line)?; [INFO] [stdout] 100 | | if n == 0 { [INFO] [stdout] 101 | | // EOF [INFO] [stdout] ... | [INFO] [stdout] 111 | | line.clear(); [INFO] [stdout] 112 | | } [INFO] [stdout] | |_________- any code following this expression is unreachable [INFO] [stdout] 113 | [INFO] [stdout] 114 | Ok(m) [INFO] [stdout] | ^^^^^ unreachable expression [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unreachable_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable expression [INFO] [stdout] --> src/reader.rs:142:9 [INFO] [stdout] | [INFO] [stdout] 127 | / loop { [INFO] [stdout] 128 | | let n = self.inner.read_line(buf)?; [INFO] [stdout] 129 | | if n == 0 { [INFO] [stdout] 130 | | // EOF [INFO] [stdout] ... | [INFO] [stdout] 139 | | m += n; [INFO] [stdout] 140 | | } [INFO] [stdout] | |_________- any code following this expression is unreachable [INFO] [stdout] 141 | [INFO] [stdout] 142 | Ok(m) [INFO] [stdout] | ^^^^^ unreachable expression [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `winnow::Parser::recognize`: Replaced with `Parser::take` [INFO] [stdout] --> src/parsers.rs:52:10 [INFO] [stdout] | [INFO] [stdout] 52 | .recognize() [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `winnow::Parser::recognize`: Replaced with `Parser::take` [INFO] [stdout] --> src/parsers.rs:105:56 [INFO] [stdout] | [INFO] [stdout] 105 | let r = (opt(one_of(['+', '-'])), cut_err(digit1)).recognize().parse_next(input)?; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `winnow::Parser::recognize`: Replaced with `Parser::take` [INFO] [stdout] --> src/parsers.rs:52:10 [INFO] [stdout] | [INFO] [stdout] 52 | .recognize() [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `winnow::Parser::recognize`: Replaced with `Parser::take` [INFO] [stdout] --> src/parsers.rs:162:10 [INFO] [stdout] | [INFO] [stdout] 162 | .recognize() [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `winnow::Parser::recognize`: Replaced with `Parser::take` [INFO] [stdout] --> src/parsers.rs:105:56 [INFO] [stdout] | [INFO] [stdout] 105 | let r = (opt(one_of(['+', '-'])), cut_err(digit1)).recognize().parse_next(input)?; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `e` [INFO] [stdout] --> src/reader.rs:57:44 [INFO] [stdout] | [INFO] [stdout] 57 | self.inner.read_line(buf).map_err(|e| anyhow!("Read line failure")) [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_e` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `winnow::Parser::recognize`: Replaced with `Parser::take` [INFO] [stdout] --> src/parsers.rs:162:10 [INFO] [stdout] | [INFO] [stdout] 162 | .recognize() [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `pos` [INFO] [stdout] --> src/reader.rs:163:13 [INFO] [stdout] | [INFO] [stdout] 163 | let pos = self.inner.seek(SeekFrom::Start(pos))?; [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_pos` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `e` [INFO] [stdout] --> src/reader.rs:57:44 [INFO] [stdout] | [INFO] [stdout] 57 | self.inner.read_line(buf).map_err(|e| anyhow!("Read line failure")) [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_e` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `pos` [INFO] [stdout] --> src/reader.rs:163:13 [INFO] [stdout] | [INFO] [stdout] 163 | let pos = self.inner.seek(SeekFrom::Start(pos))?; [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_pos` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `n` [INFO] [stdout] --> src/reader.rs:204:9 [INFO] [stdout] | [INFO] [stdout] 204 | let n = reader.read_until(&mut buf, |line| line.starts_with("here"))?; [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_n` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reader.rs:46:23 [INFO] [stdout] | [INFO] [stdout] 45 | pub fn new(r: R) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | Self { inner: BufReader::new(r) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reader.rs:64:9 [INFO] [stdout] | [INFO] [stdout] 62 | pub fn lines(self) -> impl Iterator { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 63 | // silently ignore UTF-8 error [INFO] [stdout] 64 | self.inner.lines().filter_map(|s| if let Ok(line) = s { Some(line) } else { None }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/reader.rs:147:9 [INFO] [stdout] | [INFO] [stdout] 147 | self.inner.rewind(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 147 | let _ = self.inner.rewind(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/reader.rs:152:9 [INFO] [stdout] | [INFO] [stdout] 152 | self.inner.seek(SeekFrom::End(0)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 152 | let _ = self.inner.seek(SeekFrom::End(0)); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parsers.rs:95:5 [INFO] [stdout] | [INFO] [stdout] 94 | pub fn skip_line_till<'a, O>(inner: impl Parser<&'a str, O, ContextError>) -> impl Parser<&'a str, (), ContextError> { [INFO] [stdout] | -------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 95 | repeat_till(0.., rest_line, inner).map(|_: (Vec<_>, _)| ()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parsers.rs:123:5 [INFO] [stdout] | [INFO] [stdout] 122 | let p = delimited(space0, unsigned_integer, space0); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 123 | terminated(p, line_ending).parse_next(s) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parsers.rs:185:5 [INFO] [stdout] | [INFO] [stdout] 184 | let p = delimited(space0, double, space0); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 185 | terminated(p, line_ending).parse_next(s) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 11 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `gchemol-parser` (lib) due to 6 previous errors; 11 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reader.rs:46:23 [INFO] [stdout] | [INFO] [stdout] 45 | pub fn new(r: R) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | Self { inner: BufReader::new(r) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reader.rs:64:9 [INFO] [stdout] | [INFO] [stdout] 62 | pub fn lines(self) -> impl Iterator { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 63 | // silently ignore UTF-8 error [INFO] [stdout] 64 | self.inner.lines().filter_map(|s| if let Ok(line) = s { Some(line) } else { None }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/reader.rs:147:9 [INFO] [stdout] | [INFO] [stdout] 147 | self.inner.rewind(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 147 | let _ = self.inner.rewind(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/reader.rs:152:9 [INFO] [stdout] | [INFO] [stdout] 152 | self.inner.seek(SeekFrom::End(0)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 152 | let _ = self.inner.seek(SeekFrom::End(0)); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/reader.rs:207:5 [INFO] [stdout] | [INFO] [stdout] 207 | reader.read_line(&mut buf); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 207 | let _ = reader.read_line(&mut buf); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/view.rs:187:5 [INFO] [stdout] | [INFO] [stdout] 187 | view.search_backward("^523 "); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 187 | let _ = view.search_backward("^523 "); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parsers.rs:95:5 [INFO] [stdout] | [INFO] [stdout] 94 | pub fn skip_line_till<'a, O>(inner: impl Parser<&'a str, O, ContextError>) -> impl Parser<&'a str, (), ContextError> { [INFO] [stdout] | -------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 95 | repeat_till(0.., rest_line, inner).map(|_: (Vec<_>, _)| ()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parsers.rs:123:5 [INFO] [stdout] | [INFO] [stdout] 122 | let p = delimited(space0, unsigned_integer, space0); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 123 | terminated(p, line_ending).parse_next(s) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parsers.rs:185:5 [INFO] [stdout] | [INFO] [stdout] 184 | let p = delimited(space0, double, space0); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 185 | terminated(p, line_ending).parse_next(s) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 14 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `gchemol-parser` (lib test) due to 6 previous errors; 14 warnings emitted [INFO] running `Command { std: "docker" "inspect" "c1929647d3f836947d252710dcac3aeda6d840a509fb8cab7bf58eaf0c749af8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c1929647d3f836947d252710dcac3aeda6d840a509fb8cab7bf58eaf0c749af8", kill_on_drop: false }` [INFO] [stdout] c1929647d3f836947d252710dcac3aeda6d840a509fb8cab7bf58eaf0c749af8