[INFO] fetching crate gbps 0.2.0... [INFO] checking gbps-0.2.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate gbps 0.2.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate gbps 0.2.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate gbps 0.2.0 [INFO] finished tweaking crates.io crate gbps 0.2.0 [INFO] tweaked toml for crates.io crate gbps 0.2.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 18 packages to latest compatible versions [INFO] [stderr] Adding getrandom v0.1.16 (latest: v0.2.15) [INFO] [stderr] Adding rand v0.7.3 (latest: v0.8.5) [INFO] [stderr] Adding rand_chacha v0.2.2 (latest: v0.3.1) [INFO] [stderr] Adding rand_core v0.5.1 (latest: v0.6.4) [INFO] [stderr] Adding rand_hc v0.2.0 (latest: v0.3.2) [INFO] [stderr] Adding wasi v0.9.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5b8530e77d16f15ee9369b8914af83bf1c068c9630106190eb245910f7037dba [INFO] running `Command { std: "docker" "start" "-a" "5b8530e77d16f15ee9369b8914af83bf1c068c9630106190eb245910f7037dba", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5b8530e77d16f15ee9369b8914af83bf1c068c9630106190eb245910f7037dba", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5b8530e77d16f15ee9369b8914af83bf1c068c9630106190eb245910f7037dba", kill_on_drop: false }` [INFO] [stdout] 5b8530e77d16f15ee9369b8914af83bf1c068c9630106190eb245910f7037dba [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] cc8a92a54769f44c5b9ded4d6ce523424de2e5fd87a63c6d85841e2a6cdeb3cf [INFO] running `Command { std: "docker" "start" "-a" "cc8a92a54769f44c5b9ded4d6ce523424de2e5fd87a63c6d85841e2a6cdeb3cf", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking getrandom v0.1.16 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking gbps v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/network.rs:26:5 [INFO] [stdout] | [INFO] [stdout] 17 | pub fn start_listener(bind_address: &SocketAddr, sender: Sender, shutdown_handle: &Arc) -> JoinHandle<()> { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | [INFO] [stdout] 19 | let listener = TcpListener::bind(bind_address) [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 24 | let shutdown_requested = Arc::clone(shutdown_handle); [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | [INFO] [stdout] 26 | / std::thread::Builder::new().name(format!("{} - TCP listener", bind_address)).spawn(move || { [INFO] [stdout] 27 | | log::info!("Started listener thread"); [INFO] [stdout] 28 | | // TOD: handle hanging connections wher peer connect but does not write [INFO] [stdout] 29 | | for incoming_stream in listener.incoming() { [INFO] [stdout] ... | [INFO] [stdout] 47 | | log::info!("Listener thread exiting"); [INFO] [stdout] 48 | | }).unwrap() [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `std::mem::replace` that must be used [INFO] [stdout] --> src/peer.rs:82:13 [INFO] [stdout] | [INFO] [stdout] 82 | std::mem::replace(&mut self.peers, new_view_start); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if you don't need the old value, you can just assign the new value directly [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 82 | let _ = std::mem::replace(&mut self.peers, new_view_start); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `std::mem::replace` that must be used [INFO] [stdout] --> src/peer.rs:155:9 [INFO] [stdout] | [INFO] [stdout] 155 | std::mem::replace(&mut self.peers, new_view); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if you don't need the old value, you can just assign the new value directly [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 155 | let _ = std::mem::replace(&mut self.peers, new_view); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `std::mem::replace` that must be used [INFO] [stdout] --> src/peer.rs:177:13 [INFO] [stdout] | [INFO] [stdout] 177 | std::mem::replace(&mut self.peers, new_view); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if you don't need the old value, you can just assign the new value directly [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 177 | let _ = std::mem::replace(&mut self.peers, new_view); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/peer.rs:452:9 [INFO] [stdout] | [INFO] [stdout] 449 | fn start_receiver(&self, receiver: Receiver) -> JoinHandle<()>{ [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 450 | let config = self.config.clone(); [INFO] [stdout] 451 | let view_arc = self.view.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 452 | / std::thread::Builder::new().name(format!("{} - message handler", config.address())).spawn(move|| { [INFO] [stdout] 453 | | log::info!("Started message handling thread"); [INFO] [stdout] 454 | | while let Ok(message) = receiver.recv() { [INFO] [stdout] 455 | | log::debug!("Received: {:?}", message); [INFO] [stdout] ... | [INFO] [stdout] 482 | | log::info!("Message handling thread exiting"); [INFO] [stdout] 483 | | }).unwrap() [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/peer.rs:491:9 [INFO] [stdout] | [INFO] [stdout] 489 | let view_arc = self.view.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 490 | let shutdown_requested = Arc::clone(&self.shutdown_peer_sampling); [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 491 | / std::thread::Builder::new().name(format!("{} - peer sampling", config.address())).spawn(move || { [INFO] [stdout] 492 | | log::info!("Started peer sampling thread"); [INFO] [stdout] 493 | | loop { [INFO] [stdout] 494 | | // Compute time for sleep cycle [INFO] [stdout] ... | [INFO] [stdout] 541 | | log::info!("Peer sampling thread exiting"); [INFO] [stdout] 542 | | }).unwrap() [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `gbps` (lib test) due to 4 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/network.rs:26:5 [INFO] [stdout] | [INFO] [stdout] 17 | pub fn start_listener(bind_address: &SocketAddr, sender: Sender, shutdown_handle: &Arc) -> JoinHandle<()> { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | [INFO] [stdout] 19 | let listener = TcpListener::bind(bind_address) [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 24 | let shutdown_requested = Arc::clone(shutdown_handle); [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | [INFO] [stdout] 26 | / std::thread::Builder::new().name(format!("{} - TCP listener", bind_address)).spawn(move || { [INFO] [stdout] 27 | | log::info!("Started listener thread"); [INFO] [stdout] 28 | | // TOD: handle hanging connections wher peer connect but does not write [INFO] [stdout] 29 | | for incoming_stream in listener.incoming() { [INFO] [stdout] ... | [INFO] [stdout] 47 | | log::info!("Listener thread exiting"); [INFO] [stdout] 48 | | }).unwrap() [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `std::mem::replace` that must be used [INFO] [stdout] --> src/peer.rs:82:13 [INFO] [stdout] | [INFO] [stdout] 82 | std::mem::replace(&mut self.peers, new_view_start); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if you don't need the old value, you can just assign the new value directly [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 82 | let _ = std::mem::replace(&mut self.peers, new_view_start); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `std::mem::replace` that must be used [INFO] [stdout] --> src/peer.rs:155:9 [INFO] [stdout] | [INFO] [stdout] 155 | std::mem::replace(&mut self.peers, new_view); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if you don't need the old value, you can just assign the new value directly [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 155 | let _ = std::mem::replace(&mut self.peers, new_view); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `std::mem::replace` that must be used [INFO] [stdout] --> src/peer.rs:177:13 [INFO] [stdout] | [INFO] [stdout] 177 | std::mem::replace(&mut self.peers, new_view); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if you don't need the old value, you can just assign the new value directly [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 177 | let _ = std::mem::replace(&mut self.peers, new_view); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/peer.rs:452:9 [INFO] [stdout] | [INFO] [stdout] 449 | fn start_receiver(&self, receiver: Receiver) -> JoinHandle<()>{ [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 450 | let config = self.config.clone(); [INFO] [stdout] 451 | let view_arc = self.view.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 452 | / std::thread::Builder::new().name(format!("{} - message handler", config.address())).spawn(move|| { [INFO] [stdout] 453 | | log::info!("Started message handling thread"); [INFO] [stdout] 454 | | while let Ok(message) = receiver.recv() { [INFO] [stdout] 455 | | log::debug!("Received: {:?}", message); [INFO] [stdout] ... | [INFO] [stdout] 482 | | log::info!("Message handling thread exiting"); [INFO] [stdout] 483 | | }).unwrap() [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/peer.rs:491:9 [INFO] [stdout] | [INFO] [stdout] 489 | let view_arc = self.view.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 490 | let shutdown_requested = Arc::clone(&self.shutdown_peer_sampling); [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 491 | / std::thread::Builder::new().name(format!("{} - peer sampling", config.address())).spawn(move || { [INFO] [stdout] 492 | | log::info!("Started peer sampling thread"); [INFO] [stdout] 493 | | loop { [INFO] [stdout] 494 | | // Compute time for sleep cycle [INFO] [stdout] ... | [INFO] [stdout] 541 | | log::info!("Peer sampling thread exiting"); [INFO] [stdout] 542 | | }).unwrap() [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `gbps` (lib) due to 4 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "cc8a92a54769f44c5b9ded4d6ce523424de2e5fd87a63c6d85841e2a6cdeb3cf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cc8a92a54769f44c5b9ded4d6ce523424de2e5fd87a63c6d85841e2a6cdeb3cf", kill_on_drop: false }` [INFO] [stdout] cc8a92a54769f44c5b9ded4d6ce523424de2e5fd87a63c6d85841e2a6cdeb3cf