[INFO] fetching crate gavle 0.1.1... [INFO] checking gavle-0.1.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate gavle 0.1.1 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate gavle 0.1.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate gavle 0.1.1 [INFO] finished tweaking crates.io crate gavle 0.1.1 [INFO] tweaked toml for crates.io crate gavle 0.1.1 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 35 packages to latest compatible versions [INFO] [stderr] Adding arrayvec v0.6.1 (latest: v0.7.6) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding glow v0.11.2 (latest: v0.14.0) [INFO] [stderr] Adding image v0.23.14 (latest: v0.25.2) [INFO] [stderr] Adding num-rational v0.3.2 (latest: v0.4.2) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ef88885e2a56cb3521bfb49cd3606878118784731d3b663f8605284e97d996da [INFO] running `Command { std: "docker" "start" "-a" "ef88885e2a56cb3521bfb49cd3606878118784731d3b663f8605284e97d996da", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ef88885e2a56cb3521bfb49cd3606878118784731d3b663f8605284e97d996da", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ef88885e2a56cb3521bfb49cd3606878118784731d3b663f8605284e97d996da", kill_on_drop: false }` [INFO] [stdout] ef88885e2a56cb3521bfb49cd3606878118784731d3b663f8605284e97d996da [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 86fb505887d4dc3c42cd9f1f3c5102b4ca3607e93c87598bcb913090c6eef89e [INFO] running `Command { std: "docker" "start" "-a" "86fb505887d4dc3c42cd9f1f3c5102b4ca3607e93c87598bcb913090c6eef89e", kill_on_drop: false }` [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Checking tinyvec v1.8.0 [INFO] [stderr] Checking arrayvec v0.6.1 [INFO] [stderr] Checking glow v0.11.2 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking generational-arena v0.2.9 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Checking gavle v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:172:6 [INFO] [stdout] | [INFO] [stdout] 167 | pub fn new_from_context(context: Context) -> Result { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 171 | let context = Rc::new(context); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 172 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 173 | | pipeline_lock: Rc::new(RefCell::new(())), [INFO] [stdout] 174 | | information: Rc::new(information), [INFO] [stdout] 175 | | context, [INFO] [stdout] 176 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:279:13 [INFO] [stdout] | [INFO] [stdout] 193 | let mut entries = Vec::with_capacity(description.entries.len()); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 279 | entries: Rc::new(entries) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:436:6 [INFO] [stdout] | [INFO] [stdout] 307 | let _atom = self.pipeline_lock.borrow_mut(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 341 | let (framebuffer, color_attachments, depth_stencil) = unsafe { [INFO] [stdout] | ----------------- ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 378 | let mut color_attachments = SmallVec::<[Texture; 32]>::default(); [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 379 | let mut draw_buffers = SmallVec::<[u32; 128]>::default(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 380 | let mut depth_stencil = None; [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 436 | Ok(Framebuffer { [INFO] [stdout] | ____________^ [INFO] [stdout] 437 | | variants: FramebufferVariants::Custom { [INFO] [stdout] 438 | | inner: Rc::new(InnerFramebuffer { [INFO] [stdout] 439 | | context: self.context.clone(), [INFO] [stdout] ... | [INFO] [stdout] 454 | | } [INFO] [stdout] 455 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/lib.rs:402:19 [INFO] [stdout] | [INFO] [stdout] 402 | for texture in attachments { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 402 | while let Some(texture) = attachments { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 402 | if let Some(texture) = attachments { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:905:6 [INFO] [stdout] | [INFO] [stdout] 497 | let _atom = self.pipeline_lock.borrow_mut(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 905 | Ok(Texture { [INFO] [stdout] | ____________^ [INFO] [stdout] 906 | | inner: Rc::new(InnerTexture { [INFO] [stdout] 907 | | context: self.context.clone(), [INFO] [stdout] 908 | | texture, [INFO] [stdout] ... | [INFO] [stdout] 912 | | }) [INFO] [stdout] 913 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:991:6 [INFO] [stdout] | [INFO] [stdout] 946 | let _atom = self.pipeline_lock.borrow_mut(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 991 | Ok(RenderPipeline { [INFO] [stdout] | ____________^ [INFO] [stdout] 992 | | inner: Rc::new(InnerRenderPipeline { [INFO] [stdout] 993 | | context: self.context.clone(), [INFO] [stdout] 994 | | access: Default::default(), [INFO] [stdout] ... | [INFO] [stdout] 1006 | | }) [INFO] [stdout] 1007 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/lib.rs:954:48 [INFO] [stdout] | [INFO] [stdout] 954 | let vertex_shader = descriptor.vertex.shader.clone(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `shader::VertexShader` does not implement `Clone`, so calling `clone` on `&shader::VertexShader` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 954 - let vertex_shader = descriptor.vertex.shader.clone(); [INFO] [stdout] 954 + let vertex_shader = descriptor.vertex.shader; [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `shader::VertexShader`, implement `Clone` for it [INFO] [stdout] --> src/shader.rs:61:3 [INFO] [stdout] | [INFO] [stdout] 61 + #[derive(Clone)] [INFO] [stdout] 62 | pub struct $name { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/lib.rs:959:49 [INFO] [stdout] | [INFO] [stdout] 959 | let fragment_shader = fragment_state.shader.clone(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `shader::FragmentShader` does not implement `Clone`, so calling `clone` on `&shader::FragmentShader` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 959 - let fragment_shader = fragment_state.shader.clone(); [INFO] [stdout] 959 + let fragment_shader = fragment_state.shader; [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `shader::FragmentShader`, implement `Clone` for it [INFO] [stdout] --> src/shader.rs:61:3 [INFO] [stdout] | [INFO] [stdout] 61 + #[derive(Clone)] [INFO] [stdout] 62 | pub struct $name { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1001:14 [INFO] [stdout] | [INFO] [stdout] 1001 | inner: fragment_shader.inner.clone() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:115:7 [INFO] [stdout] | [INFO] [stdout] 83 | data_: A) [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 115 | Ok($buffer { [INFO] [stdout] | ________________^ [INFO] [stdout] 116 | | inner: Rc::new(InnerBuffer { [INFO] [stdout] 117 | | context: self.context.clone(), [INFO] [stdout] 118 | | information: self.information.clone(), [INFO] [stdout] ... | [INFO] [stdout] 124 | | }) [INFO] [stdout] 125 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] ... [INFO] [stdout] 1017 | / instance_initialized_buffer_creation_functions! { [INFO] [stdout] 1018 | | #[doc = "Tries to create a new vertex buffer with the given data."] [INFO] [stdout] 1019 | | pub fn create_vertex_buffer_with_data: VertexBuffer; [INFO] [stdout] 1020 | | #[doc = "Tries to create a new index buffer with the given data."] [INFO] [stdout] ... | [INFO] [stdout] 1023 | | pub fn create_uniform_buffer_with_data: UniformBuffer; [INFO] [stdout] 1024 | | } [INFO] [stdout] | |_____- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `instance_initialized_buffer_creation_functions` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/buffer.rs:326:6 [INFO] [stdout] | [INFO] [stdout] 270 | let buffer_lock = self.buffer.acquire_read_guarded(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 271 | let pipeline_lock = self.buffer.pipeline.borrow_mut(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 272 | [INFO] [stdout] 273 | let mut map = self.buffer.map.borrow_mut(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 281 | let data = if len == 0 { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 326 | Ok(BufferView { [INFO] [stdout] | ____________^ [INFO] [stdout] 327 | | slice: *self, [INFO] [stdout] 328 | | data, [INFO] [stdout] 329 | | _pipeline_lock: pipeline_lock, [INFO] [stdout] 330 | | _buffer_lock: buffer_lock [INFO] [stdout] 331 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/buffer.rs:436:6 [INFO] [stdout] | [INFO] [stdout] 353 | let buffer_lock = self.buffer.acquire_write_guarded(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 354 | let pipeline_lock = self.buffer.pipeline.borrow_mut(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 355 | [INFO] [stdout] 356 | let mut map = self.buffer.map.borrow_mut(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 364 | let data = if len == 0 { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 436 | Ok(BufferViewMut { [INFO] [stdout] | ____________^ [INFO] [stdout] 437 | | slice: *self, [INFO] [stdout] 438 | | data, [INFO] [stdout] 439 | | _pipeline_lock: pipeline_lock, [INFO] [stdout] 440 | | _buffer_lock: buffer_lock [INFO] [stdout] 441 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/pipeline.rs:254:19 [INFO] [stdout] | [INFO] [stdout] 254 | for texture in &fb.depth_stencil { texture.acquire_write() } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 254 | while let Some(texture) = &fb.depth_stencil { texture.acquire_write() } [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 254 | if let Some(texture) = &fb.depth_stencil { texture.acquire_write() } [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/pipeline.rs:256:19 [INFO] [stdout] | [INFO] [stdout] 256 | for texture in &fb.depth_stencil { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 256 | while let Some(texture) = &fb.depth_stencil { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 256 | if let Some(texture) = &fb.depth_stencil { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/pipeline.rs:292:19 [INFO] [stdout] | [INFO] [stdout] 292 | for texture in &fb.depth_stencil { texture.release_write() } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 292 | while let Some(texture) = &fb.depth_stencil { texture.release_write() } [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 292 | if let Some(texture) = &fb.depth_stencil { texture.release_write() } [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/pipeline.rs:294:19 [INFO] [stdout] | [INFO] [stdout] 294 | for texture in &fb.depth_stencil { texture.release_read() } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 294 | while let Some(texture) = &fb.depth_stencil { texture.release_read() } [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 294 | if let Some(texture) = &fb.depth_stencil { texture.release_read() } [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/framebuffer.rs:31:18 [INFO] [stdout] | [INFO] [stdout] 31 | for texture in &self.depth_stencil { assert_eq!(texture.write_locks(), a) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 31 | while let Some(texture) = &self.depth_stencil { assert_eq!(texture.write_locks(), a) } [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 31 | if let Some(texture) = &self.depth_stencil { assert_eq!(texture.write_locks(), a) } [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/framebuffer.rs:38:18 [INFO] [stdout] | [INFO] [stdout] 38 | for texture in &self.depth_stencil { assert_eq!(texture.read_locks(), a) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 38 | while let Some(texture) = &self.depth_stencil { assert_eq!(texture.read_locks(), a) } [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 38 | if let Some(texture) = &self.depth_stencil { assert_eq!(texture.read_locks(), a) } [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/framebuffer.rs:45:18 [INFO] [stdout] | [INFO] [stdout] 45 | for texture in &self.depth_stencil { texture.acquire_write(); } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 45 | while let Some(texture) = &self.depth_stencil { texture.acquire_write(); } [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 45 | if let Some(texture) = &self.depth_stencil { texture.acquire_write(); } [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/framebuffer.rs:50:18 [INFO] [stdout] | [INFO] [stdout] 50 | for texture in &self.depth_stencil { texture.release_write(); } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 50 | while let Some(texture) = &self.depth_stencil { texture.release_write(); } [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 50 | if let Some(texture) = &self.depth_stencil { texture.release_write(); } [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/framebuffer.rs:55:18 [INFO] [stdout] | [INFO] [stdout] 55 | for texture in &self.depth_stencil { texture.acquire_read(); } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 55 | while let Some(texture) = &self.depth_stencil { texture.acquire_read(); } [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 55 | if let Some(texture) = &self.depth_stencil { texture.acquire_read(); } [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/framebuffer.rs:60:18 [INFO] [stdout] | [INFO] [stdout] 60 | for texture in &self.depth_stencil { texture.release_read(); } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 60 | while let Some(texture) = &self.depth_stencil { texture.release_read(); } [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 60 | if let Some(texture) = &self.depth_stencil { texture.release_read(); } [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors; 13 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `gavle` (lib test) due to 10 previous errors; 13 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:172:6 [INFO] [stdout] | [INFO] [stdout] 167 | pub fn new_from_context(context: Context) -> Result { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 171 | let context = Rc::new(context); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 172 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 173 | | pipeline_lock: Rc::new(RefCell::new(())), [INFO] [stdout] 174 | | information: Rc::new(information), [INFO] [stdout] 175 | | context, [INFO] [stdout] 176 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:279:13 [INFO] [stdout] | [INFO] [stdout] 193 | let mut entries = Vec::with_capacity(description.entries.len()); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 279 | entries: Rc::new(entries) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:436:6 [INFO] [stdout] | [INFO] [stdout] 307 | let _atom = self.pipeline_lock.borrow_mut(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 341 | let (framebuffer, color_attachments, depth_stencil) = unsafe { [INFO] [stdout] | ----------------- ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 378 | let mut color_attachments = SmallVec::<[Texture; 32]>::default(); [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 379 | let mut draw_buffers = SmallVec::<[u32; 128]>::default(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 380 | let mut depth_stencil = None; [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 436 | Ok(Framebuffer { [INFO] [stdout] | ____________^ [INFO] [stdout] 437 | | variants: FramebufferVariants::Custom { [INFO] [stdout] 438 | | inner: Rc::new(InnerFramebuffer { [INFO] [stdout] 439 | | context: self.context.clone(), [INFO] [stdout] ... | [INFO] [stdout] 454 | | } [INFO] [stdout] 455 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/lib.rs:402:19 [INFO] [stdout] | [INFO] [stdout] 402 | for texture in attachments { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 402 | while let Some(texture) = attachments { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 402 | if let Some(texture) = attachments { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:905:6 [INFO] [stdout] | [INFO] [stdout] 497 | let _atom = self.pipeline_lock.borrow_mut(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 905 | Ok(Texture { [INFO] [stdout] | ____________^ [INFO] [stdout] 906 | | inner: Rc::new(InnerTexture { [INFO] [stdout] 907 | | context: self.context.clone(), [INFO] [stdout] 908 | | texture, [INFO] [stdout] ... | [INFO] [stdout] 912 | | }) [INFO] [stdout] 913 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:991:6 [INFO] [stdout] | [INFO] [stdout] 946 | let _atom = self.pipeline_lock.borrow_mut(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 991 | Ok(RenderPipeline { [INFO] [stdout] | ____________^ [INFO] [stdout] 992 | | inner: Rc::new(InnerRenderPipeline { [INFO] [stdout] 993 | | context: self.context.clone(), [INFO] [stdout] 994 | | access: Default::default(), [INFO] [stdout] ... | [INFO] [stdout] 1006 | | }) [INFO] [stdout] 1007 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/lib.rs:954:48 [INFO] [stdout] | [INFO] [stdout] 954 | let vertex_shader = descriptor.vertex.shader.clone(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `shader::VertexShader` does not implement `Clone`, so calling `clone` on `&shader::VertexShader` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 954 - let vertex_shader = descriptor.vertex.shader.clone(); [INFO] [stdout] 954 + let vertex_shader = descriptor.vertex.shader; [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `shader::VertexShader`, implement `Clone` for it [INFO] [stdout] --> src/shader.rs:61:3 [INFO] [stdout] | [INFO] [stdout] 61 + #[derive(Clone)] [INFO] [stdout] 62 | pub struct $name { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/lib.rs:959:49 [INFO] [stdout] | [INFO] [stdout] 959 | let fragment_shader = fragment_state.shader.clone(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `shader::FragmentShader` does not implement `Clone`, so calling `clone` on `&shader::FragmentShader` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 959 - let fragment_shader = fragment_state.shader.clone(); [INFO] [stdout] 959 + let fragment_shader = fragment_state.shader; [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `shader::FragmentShader`, implement `Clone` for it [INFO] [stdout] --> src/shader.rs:61:3 [INFO] [stdout] | [INFO] [stdout] 61 + #[derive(Clone)] [INFO] [stdout] 62 | pub struct $name { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1001:14 [INFO] [stdout] | [INFO] [stdout] 1001 | inner: fragment_shader.inner.clone() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:115:7 [INFO] [stdout] | [INFO] [stdout] 83 | data_: A) [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 115 | Ok($buffer { [INFO] [stdout] | ________________^ [INFO] [stdout] 116 | | inner: Rc::new(InnerBuffer { [INFO] [stdout] 117 | | context: self.context.clone(), [INFO] [stdout] 118 | | information: self.information.clone(), [INFO] [stdout] ... | [INFO] [stdout] 124 | | }) [INFO] [stdout] 125 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] ... [INFO] [stdout] 1017 | / instance_initialized_buffer_creation_functions! { [INFO] [stdout] 1018 | | #[doc = "Tries to create a new vertex buffer with the given data."] [INFO] [stdout] 1019 | | pub fn create_vertex_buffer_with_data: VertexBuffer; [INFO] [stdout] 1020 | | #[doc = "Tries to create a new index buffer with the given data."] [INFO] [stdout] ... | [INFO] [stdout] 1023 | | pub fn create_uniform_buffer_with_data: UniformBuffer; [INFO] [stdout] 1024 | | } [INFO] [stdout] | |_____- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `instance_initialized_buffer_creation_functions` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/buffer.rs:326:6 [INFO] [stdout] | [INFO] [stdout] 270 | let buffer_lock = self.buffer.acquire_read_guarded(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 271 | let pipeline_lock = self.buffer.pipeline.borrow_mut(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 272 | [INFO] [stdout] 273 | let mut map = self.buffer.map.borrow_mut(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 281 | let data = if len == 0 { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 326 | Ok(BufferView { [INFO] [stdout] | ____________^ [INFO] [stdout] 327 | | slice: *self, [INFO] [stdout] 328 | | data, [INFO] [stdout] 329 | | _pipeline_lock: pipeline_lock, [INFO] [stdout] 330 | | _buffer_lock: buffer_lock [INFO] [stdout] 331 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/buffer.rs:436:6 [INFO] [stdout] | [INFO] [stdout] 353 | let buffer_lock = self.buffer.acquire_write_guarded(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 354 | let pipeline_lock = self.buffer.pipeline.borrow_mut(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 355 | [INFO] [stdout] 356 | let mut map = self.buffer.map.borrow_mut(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 364 | let data = if len == 0 { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 436 | Ok(BufferViewMut { [INFO] [stdout] | ____________^ [INFO] [stdout] 437 | | slice: *self, [INFO] [stdout] 438 | | data, [INFO] [stdout] 439 | | _pipeline_lock: pipeline_lock, [INFO] [stdout] 440 | | _buffer_lock: buffer_lock [INFO] [stdout] 441 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/pipeline.rs:254:19 [INFO] [stdout] | [INFO] [stdout] 254 | for texture in &fb.depth_stencil { texture.acquire_write() } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 254 | while let Some(texture) = &fb.depth_stencil { texture.acquire_write() } [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 254 | if let Some(texture) = &fb.depth_stencil { texture.acquire_write() } [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/pipeline.rs:256:19 [INFO] [stdout] | [INFO] [stdout] 256 | for texture in &fb.depth_stencil { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 256 | while let Some(texture) = &fb.depth_stencil { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 256 | if let Some(texture) = &fb.depth_stencil { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/pipeline.rs:292:19 [INFO] [stdout] | [INFO] [stdout] 292 | for texture in &fb.depth_stencil { texture.release_write() } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 292 | while let Some(texture) = &fb.depth_stencil { texture.release_write() } [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 292 | if let Some(texture) = &fb.depth_stencil { texture.release_write() } [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/pipeline.rs:294:19 [INFO] [stdout] | [INFO] [stdout] 294 | for texture in &fb.depth_stencil { texture.release_read() } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 294 | while let Some(texture) = &fb.depth_stencil { texture.release_read() } [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 294 | if let Some(texture) = &fb.depth_stencil { texture.release_read() } [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/framebuffer.rs:31:18 [INFO] [stdout] | [INFO] [stdout] 31 | for texture in &self.depth_stencil { assert_eq!(texture.write_locks(), a) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 31 | while let Some(texture) = &self.depth_stencil { assert_eq!(texture.write_locks(), a) } [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 31 | if let Some(texture) = &self.depth_stencil { assert_eq!(texture.write_locks(), a) } [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/framebuffer.rs:38:18 [INFO] [stdout] | [INFO] [stdout] 38 | for texture in &self.depth_stencil { assert_eq!(texture.read_locks(), a) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 38 | while let Some(texture) = &self.depth_stencil { assert_eq!(texture.read_locks(), a) } [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 38 | if let Some(texture) = &self.depth_stencil { assert_eq!(texture.read_locks(), a) } [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/framebuffer.rs:45:18 [INFO] [stdout] | [INFO] [stdout] 45 | for texture in &self.depth_stencil { texture.acquire_write(); } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 45 | while let Some(texture) = &self.depth_stencil { texture.acquire_write(); } [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 45 | if let Some(texture) = &self.depth_stencil { texture.acquire_write(); } [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/framebuffer.rs:50:18 [INFO] [stdout] | [INFO] [stdout] 50 | for texture in &self.depth_stencil { texture.release_write(); } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 50 | while let Some(texture) = &self.depth_stencil { texture.release_write(); } [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 50 | if let Some(texture) = &self.depth_stencil { texture.release_write(); } [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/framebuffer.rs:55:18 [INFO] [stdout] | [INFO] [stdout] 55 | for texture in &self.depth_stencil { texture.acquire_read(); } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 55 | while let Some(texture) = &self.depth_stencil { texture.acquire_read(); } [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 55 | if let Some(texture) = &self.depth_stencil { texture.acquire_read(); } [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/framebuffer.rs:60:18 [INFO] [stdout] | [INFO] [stdout] 60 | for texture in &self.depth_stencil { texture.release_read(); } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 60 | while let Some(texture) = &self.depth_stencil { texture.release_read(); } [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 60 | if let Some(texture) = &self.depth_stencil { texture.release_read(); } [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors; 13 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `gavle` (lib) due to 10 previous errors; 13 warnings emitted [INFO] running `Command { std: "docker" "inspect" "86fb505887d4dc3c42cd9f1f3c5102b4ca3607e93c87598bcb913090c6eef89e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "86fb505887d4dc3c42cd9f1f3c5102b4ca3607e93c87598bcb913090c6eef89e", kill_on_drop: false }` [INFO] [stdout] 86fb505887d4dc3c42cd9f1f3c5102b4ca3607e93c87598bcb913090c6eef89e