[INFO] fetching crate gatherr 0.1.0... [INFO] checking gatherr-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate gatherr 0.1.0 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate gatherr 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate gatherr 0.1.0 [INFO] finished tweaking crates.io crate gatherr 0.1.0 [INFO] tweaked toml for crates.io crate gatherr 0.1.0 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] cdbb85c5ca4a103c131f29caa8f1250704b4a8f53bdcfebfd330f9a34835a9cc [INFO] running `Command { std: "docker" "start" "-a" "cdbb85c5ca4a103c131f29caa8f1250704b4a8f53bdcfebfd330f9a34835a9cc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "cdbb85c5ca4a103c131f29caa8f1250704b4a8f53bdcfebfd330f9a34835a9cc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cdbb85c5ca4a103c131f29caa8f1250704b4a8f53bdcfebfd330f9a34835a9cc", kill_on_drop: false }` [INFO] [stdout] cdbb85c5ca4a103c131f29caa8f1250704b4a8f53bdcfebfd330f9a34835a9cc [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2cf3e1dd3865e64eeadb66f35b49518665c86da6808c8326fd8340fb55c089bc [INFO] running `Command { std: "docker" "start" "-a" "2cf3e1dd3865e64eeadb66f35b49518665c86da6808c8326fd8340fb55c089bc", kill_on_drop: false }` [INFO] [stderr] Checking gatherr v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:37:17 [INFO] [stdout] | [INFO] [stdout] 25 | fn from_iter>>(iter: I) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | let mut iter = iter.into_iter(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | let mut first_err = None; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | let ok = (&mut iter) [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 37 | Gatherr(if let Some(first_err) = first_err { [INFO] [stdout] | _________________^ [INFO] [stdout] 38 | | drop(ok); [INFO] [stdout] 39 | | Err(std::iter::once(first_err) [INFO] [stdout] 40 | | .chain(iter.filter_map(|r| r.err())) [INFO] [stdout] ... | [INFO] [stdout] 43 | | Ok(ok) [INFO] [stdout] 44 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `gatherr` (lib test) due to 2 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:37:17 [INFO] [stdout] | [INFO] [stdout] 25 | fn from_iter>>(iter: I) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | let mut iter = iter.into_iter(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | let mut first_err = None; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | let ok = (&mut iter) [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 37 | Gatherr(if let Some(first_err) = first_err { [INFO] [stdout] | _________________^ [INFO] [stdout] 38 | | drop(ok); [INFO] [stdout] 39 | | Err(std::iter::once(first_err) [INFO] [stdout] 40 | | .chain(iter.filter_map(|r| r.err())) [INFO] [stdout] ... | [INFO] [stdout] 43 | | Ok(ok) [INFO] [stdout] 44 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `gatherr` (lib) due to 2 previous errors [INFO] running `Command { std: "docker" "inspect" "2cf3e1dd3865e64eeadb66f35b49518665c86da6808c8326fd8340fb55c089bc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2cf3e1dd3865e64eeadb66f35b49518665c86da6808c8326fd8340fb55c089bc", kill_on_drop: false }` [INFO] [stdout] 2cf3e1dd3865e64eeadb66f35b49518665c86da6808c8326fd8340fb55c089bc