[INFO] fetching crate garden-lang 0.16.0... [INFO] checking garden-lang-0.16.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate garden-lang 0.16.0 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate garden-lang 0.16.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate garden-lang 0.16.0 [INFO] finished tweaking crates.io crate garden-lang 0.16.0 [INFO] tweaked toml for crates.io crate garden-lang 0.16.0 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate garden-lang 0.16.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 19b10a8301bd7d9a2f68f97ccdd123baa43385962017f2839a7f6c58485c77d6 [INFO] running `Command { std: "docker" "start" "-a" "19b10a8301bd7d9a2f68f97ccdd123baa43385962017f2839a7f6c58485c77d6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "19b10a8301bd7d9a2f68f97ccdd123baa43385962017f2839a7f6c58485c77d6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "19b10a8301bd7d9a2f68f97ccdd123baa43385962017f2839a7f6c58485c77d6", kill_on_drop: false }` [INFO] [stdout] 19b10a8301bd7d9a2f68f97ccdd123baa43385962017f2839a7f6c58485c77d6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 06373c35ce522629b8b6ed4b792445ed697c503aaca5c4297e19a8984d1b2583 [INFO] running `Command { std: "docker" "start" "-a" "06373c35ce522629b8b6ed4b792445ed697c503aaca5c4297e19a8984d1b2583", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.154 [INFO] [stderr] Compiling proc-macro2 v1.0.82 [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Checking memchr v2.7.2 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Compiling crossbeam-utils v0.8.19 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Checking bitflags v2.5.0 [INFO] [stderr] Checking anstyle v1.0.7 [INFO] [stderr] Checking regex-syntax v0.8.3 [INFO] [stderr] Compiling serde v1.0.202 [INFO] [stderr] Compiling cfg_aliases v0.1.1 [INFO] [stderr] Compiling autocfg v1.3.0 [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling rustversion v1.0.17 [INFO] [stderr] Compiling nix v0.28.0 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking anstyle-parse v0.2.4 [INFO] [stderr] Checking either v1.11.0 [INFO] [stderr] Checking is_terminal_polyfill v1.70.0 [INFO] [stderr] Compiling rayon-core v1.12.1 [INFO] [stderr] Checking colorchoice v1.0.1 [INFO] [stderr] Checking linux-raw-sys v0.4.13 [INFO] [stderr] Checking anstyle-query v1.0.3 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Compiling doc-comment v0.3.3 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Checking nibble_vec v0.1.0 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Checking endian-type v0.1.2 [INFO] [stderr] Checking clap_lex v0.7.0 [INFO] [stderr] Checking anstream v0.6.14 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Checking predicates-core v1.0.6 [INFO] [stderr] Checking is_ci v1.2.0 [INFO] [stderr] Compiling serde_json v1.0.117 [INFO] [stderr] Checking radix_trie v0.2.1 [INFO] [stderr] Checking strum v0.24.1 [INFO] [stderr] Checking difflib v0.4.0 [INFO] [stderr] Compiling assert_cmd v2.0.14 [INFO] [stderr] Checking clap_builder v4.5.2 [INFO] [stderr] Checking unicode-width v0.1.12 [INFO] [stderr] Checking unicode-segmentation v1.11.0 [INFO] [stderr] Checking line-numbers v0.2.2 [INFO] [stderr] Checking termtree v0.4.1 [INFO] [stderr] Checking ryu v1.0.18 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Checking itoa v1.0.11 [INFO] [stderr] Checking predicates-tree v1.0.9 [INFO] [stderr] Checking predicates v3.1.0 [INFO] [stderr] Checking colored v2.1.0 [INFO] [stderr] Checking itertools v0.11.0 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Checking shlex v1.3.0 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Checking similar v2.5.0 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking ordered-float v3.9.2 [INFO] [stderr] Compiling syn v2.0.63 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking dirs-sys-next v0.1.2 [INFO] [stderr] Checking is-terminal v0.4.12 [INFO] [stderr] Checking nix v0.25.1 [INFO] [stderr] Checking wait-timeout v0.2.0 [INFO] [stderr] Checking supports-color v2.1.0 [INFO] [stderr] Checking dirs-next v2.0.0 [INFO] [stderr] Checking owo-colors v4.0.0 [INFO] [stderr] Checking regex-automata v0.4.6 [INFO] [stderr] Checking ctrlc v3.4.4 [INFO] [stderr] Checking fd-lock v3.0.13 [INFO] [stderr] Checking rustyline v10.1.1 [INFO] [stderr] Checking goldentests v1.1.1 [INFO] [stderr] Compiling strum_macros v0.24.3 [INFO] [stderr] Checking regex v1.10.4 [INFO] [stderr] Checking bstr v1.9.1 [INFO] [stderr] Compiling serde_derive v1.0.202 [INFO] [stderr] Compiling clap_derive v4.5.4 [INFO] [stderr] Checking clap v4.5.4 [INFO] [stderr] Checking garden-lang-parser v0.16.0 [INFO] [stderr] Checking garden-lang v0.16.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:234:11 [INFO] [stdout] | [INFO] [stdout] 188 | let mut env = Env::default(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 197 | let (items, mut errors) = parse_toplevel_items(path, src, &mut env.id_gen); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 234 | match eval_up_to(&mut env, &mut session, &items, offset) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/checks/type_checker.rs:260:22 [INFO] [stdout] | [INFO] [stdout] 209 | let expected_return_ty = match &fun_info.return_hint { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 210 | Some(hint) => { [INFO] [stdout] 211 | let ty = Type::from_hint(hint, self.env, type_bindings).unwrap_or_err_ty(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 218 | let body_ty = self.check_block(&fun_info.body, type_bindings, expected_return_ty.as_ref()); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 223 | let mut param_tys = vec![]; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 232 | let return_ty = match &fun_info.return_hint { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 233 | Some(hint) => { [INFO] [stdout] 234 | let return_ty = Type::from_hint(hint, self.env, type_bindings).unwrap_or_err_ty(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 260 | return_: Box::new(return_ty), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/eval.rs:2009:18 [INFO] [stdout] | [INFO] [stdout] 1982 | let enum_type_param_names: HashSet<&TypeName> = [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1985 | let arg_ty = if enum_type_param_names.contains(&payload_hint.sym.name) { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1993 | let type_args: Vec = enum_info [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1999 | let return_ = Type::UserDefined { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 2009 | return_: Box::new(return_), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/eval.rs:2217:8 [INFO] [stdout] | [INFO] [stdout] 2109 | let mut arg_values: Vec = vec![]; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 2120 | let receiver_value = stack_frame [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 2142 | let mut saved_values = vec![receiver_value.clone()]; [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 2158 | let mut saved_values = vec![receiver_value.clone()]; [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 2171 | let fun_info = match &receiver_method.kind { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 2187 | let mut method_subexprs: Vec<(bool, Expression)> = vec![]; [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 2204 | let mut fun_bindings: HashMap = HashMap::new(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 2211 | let mut type_bindings = TypeVarEnv::new(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 2217 | Ok(Some(StackFrame { [INFO] [stdout] | ________^ [INFO] [stdout] 2218 | | enclosing_fun: Some(fun_info.clone()), [INFO] [stdout] 2219 | | enclosing_name: EnclosingSymbol::Method(receiver_type_name, meth_name.clone()), [INFO] [stdout] 2220 | | src: fun_info.src_string.clone(), [INFO] [stdout] ... | [INFO] [stdout] 2227 | | evalled_values: vec![Value::unit()], [INFO] [stdout] 2228 | | })) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |______| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/garden_type.rs:246:12 [INFO] [stdout] | [INFO] [stdout] 219 | let mut type_bindings = type_bindings.clone(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 232 | let mut param_types = vec![]; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 241 | let return_ = match &fun_info.return_hint { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 246 | Ok(Type::Fun { [INFO] [stdout] | ____________^ [INFO] [stdout] 247 | | type_params, [INFO] [stdout] 248 | | params: param_types, [INFO] [stdout] 249 | | return_: Box::new(return_), [INFO] [stdout] 250 | | name: fun_info.name.clone(), [INFO] [stdout] 251 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/json_session.rs:155:11 [INFO] [stdout] | [INFO] [stdout] 104 | let (items, mut errors) = parse_toplevel_items_from_span( [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 155 | match eval_all_toplevel_items(&items, env, session) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/json_session.rs:274:11 [INFO] [stdout] | [INFO] [stdout] 226 | let (items, mut errors) = parse_toplevel_items( [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 274 | match eval_up_to(env, session, &items, offset) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/values.rs:91:22 [INFO] [stdout] | [INFO] [stdout] 81 | pub(crate) fn ok(v: Value, env: &Env) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 82 | let value_type = Type::from_value(&v, env, &env.stack.type_bindings()); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 91 | payload: Some(Box::new(v)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/values.rs:92:27 [INFO] [stdout] | [INFO] [stdout] 81 | pub(crate) fn ok(v: Value, env: &Env) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 82 | let value_type = Type::from_value(&v, env, &env.stack.type_bindings()); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 92 | runtime_type: Type::UserDefined { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 93 | | kind: TypeDefKind::Enum, [INFO] [stdout] 94 | | name_sym: TypeSymbol { [INFO] [stdout] 95 | | name: TypeName { [INFO] [stdout] ... | [INFO] [stdout] 101 | | args: vec![value_type, Type::no_value()], [INFO] [stdout] 102 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/values.rs:115:27 [INFO] [stdout] | [INFO] [stdout] 106 | pub(crate) fn err(v: Value, env: &Env) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 107 | let value_type = Type::from_value(&v, env, &env.stack.type_bindings()); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 115 | runtime_type: Type::UserDefined { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 116 | | kind: TypeDefKind::Enum, [INFO] [stdout] 117 | | name_sym: TypeSymbol { [INFO] [stdout] 118 | | name: TypeName { [INFO] [stdout] ... | [INFO] [stdout] 124 | | args: vec![Type::no_value(), value_type], [INFO] [stdout] 125 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/values.rs:127:22 [INFO] [stdout] | [INFO] [stdout] 106 | pub(crate) fn err(v: Value, env: &Env) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 107 | let value_type = Type::from_value(&v, env, &env.stack.type_bindings()); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 127 | payload: Some(Box::new(v)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 11 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `garden-lang` (bin "garden") due to 12 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:234:11 [INFO] [stdout] | [INFO] [stdout] 188 | let mut env = Env::default(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 197 | let (items, mut errors) = parse_toplevel_items(path, src, &mut env.id_gen); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 234 | match eval_up_to(&mut env, &mut session, &items, offset) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/checks/type_checker.rs:260:22 [INFO] [stdout] | [INFO] [stdout] 209 | let expected_return_ty = match &fun_info.return_hint { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 210 | Some(hint) => { [INFO] [stdout] 211 | let ty = Type::from_hint(hint, self.env, type_bindings).unwrap_or_err_ty(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 218 | let body_ty = self.check_block(&fun_info.body, type_bindings, expected_return_ty.as_ref()); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 223 | let mut param_tys = vec![]; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 232 | let return_ty = match &fun_info.return_hint { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 233 | Some(hint) => { [INFO] [stdout] 234 | let return_ty = Type::from_hint(hint, self.env, type_bindings).unwrap_or_err_ty(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 260 | return_: Box::new(return_ty), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/eval.rs:2009:18 [INFO] [stdout] | [INFO] [stdout] 1982 | let enum_type_param_names: HashSet<&TypeName> = [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1985 | let arg_ty = if enum_type_param_names.contains(&payload_hint.sym.name) { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1993 | let type_args: Vec = enum_info [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1999 | let return_ = Type::UserDefined { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 2009 | return_: Box::new(return_), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/eval.rs:2217:8 [INFO] [stdout] | [INFO] [stdout] 2109 | let mut arg_values: Vec = vec![]; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 2120 | let receiver_value = stack_frame [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 2142 | let mut saved_values = vec![receiver_value.clone()]; [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 2158 | let mut saved_values = vec![receiver_value.clone()]; [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 2171 | let fun_info = match &receiver_method.kind { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 2187 | let mut method_subexprs: Vec<(bool, Expression)> = vec![]; [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 2204 | let mut fun_bindings: HashMap = HashMap::new(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 2211 | let mut type_bindings = TypeVarEnv::new(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 2217 | Ok(Some(StackFrame { [INFO] [stdout] | ________^ [INFO] [stdout] 2218 | | enclosing_fun: Some(fun_info.clone()), [INFO] [stdout] 2219 | | enclosing_name: EnclosingSymbol::Method(receiver_type_name, meth_name.clone()), [INFO] [stdout] 2220 | | src: fun_info.src_string.clone(), [INFO] [stdout] ... | [INFO] [stdout] 2227 | | evalled_values: vec![Value::unit()], [INFO] [stdout] 2228 | | })) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |______| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/garden_type.rs:246:12 [INFO] [stdout] | [INFO] [stdout] 219 | let mut type_bindings = type_bindings.clone(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 232 | let mut param_types = vec![]; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 241 | let return_ = match &fun_info.return_hint { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 246 | Ok(Type::Fun { [INFO] [stdout] | ____________^ [INFO] [stdout] 247 | | type_params, [INFO] [stdout] 248 | | params: param_types, [INFO] [stdout] 249 | | return_: Box::new(return_), [INFO] [stdout] 250 | | name: fun_info.name.clone(), [INFO] [stdout] 251 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/json_session.rs:155:11 [INFO] [stdout] | [INFO] [stdout] 104 | let (items, mut errors) = parse_toplevel_items_from_span( [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 155 | match eval_all_toplevel_items(&items, env, session) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/json_session.rs:274:11 [INFO] [stdout] | [INFO] [stdout] 226 | let (items, mut errors) = parse_toplevel_items( [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 274 | match eval_up_to(env, session, &items, offset) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/values.rs:91:22 [INFO] [stdout] | [INFO] [stdout] 81 | pub(crate) fn ok(v: Value, env: &Env) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 82 | let value_type = Type::from_value(&v, env, &env.stack.type_bindings()); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 91 | payload: Some(Box::new(v)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/values.rs:92:27 [INFO] [stdout] | [INFO] [stdout] 81 | pub(crate) fn ok(v: Value, env: &Env) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 82 | let value_type = Type::from_value(&v, env, &env.stack.type_bindings()); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 92 | runtime_type: Type::UserDefined { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 93 | | kind: TypeDefKind::Enum, [INFO] [stdout] 94 | | name_sym: TypeSymbol { [INFO] [stdout] 95 | | name: TypeName { [INFO] [stdout] ... | [INFO] [stdout] 101 | | args: vec![value_type, Type::no_value()], [INFO] [stdout] 102 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/values.rs:115:27 [INFO] [stdout] | [INFO] [stdout] 106 | pub(crate) fn err(v: Value, env: &Env) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 107 | let value_type = Type::from_value(&v, env, &env.stack.type_bindings()); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 115 | runtime_type: Type::UserDefined { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 116 | | kind: TypeDefKind::Enum, [INFO] [stdout] 117 | | name_sym: TypeSymbol { [INFO] [stdout] 118 | | name: TypeName { [INFO] [stdout] ... | [INFO] [stdout] 124 | | args: vec![Type::no_value(), value_type], [INFO] [stdout] 125 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/values.rs:127:22 [INFO] [stdout] | [INFO] [stdout] 106 | pub(crate) fn err(v: Value, env: &Env) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 107 | let value_type = Type::from_value(&v, env, &env.stack.type_bindings()); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 127 | payload: Some(Box::new(v)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 11 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `garden-lang` (bin "garden" test) due to 12 previous errors [INFO] running `Command { std: "docker" "inspect" "06373c35ce522629b8b6ed4b792445ed697c503aaca5c4297e19a8984d1b2583", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "06373c35ce522629b8b6ed4b792445ed697c503aaca5c4297e19a8984d1b2583", kill_on_drop: false }` [INFO] [stdout] 06373c35ce522629b8b6ed4b792445ed697c503aaca5c4297e19a8984d1b2583