[INFO] fetching crate garbage 0.4.3... [INFO] checking garbage-0.4.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate garbage 0.4.3 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate garbage 0.4.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-0-tc2/source/.cargo/config.toml [INFO] started tweaking crates.io crate garbage 0.4.3 [INFO] finished tweaking crates.io crate garbage 0.4.3 [INFO] tweaked toml for crates.io crate garbage 0.4.3 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate garbage 0.4.3 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6968d94bcf33f02be2d64915c2aa211d234bd6d8856676268770c96489937166 [INFO] running `Command { std: "docker" "start" "-a" "6968d94bcf33f02be2d64915c2aa211d234bd6d8856676268770c96489937166", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6968d94bcf33f02be2d64915c2aa211d234bd6d8856676268770c96489937166", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6968d94bcf33f02be2d64915c2aa211d234bd6d8856676268770c96489937166", kill_on_drop: false }` [INFO] [stdout] 6968d94bcf33f02be2d64915c2aa211d234bd6d8856676268770c96489937166 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] aa85a28cf79a6013ad1c27672ebba6af6577227432eab422d3a929625b135ebd [INFO] running `Command { std: "docker" "start" "-a" "aa85a28cf79a6013ad1c27672ebba6af6577227432eab422d3a929625b135ebd", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.84 [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Compiling serde v1.0.203 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Compiling cc v1.0.98 [INFO] [stderr] Checking anstyle-query v1.0.3 [INFO] [stderr] Checking clap_lex v0.7.0 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Compiling cfg_aliases v0.2.1 [INFO] [stderr] Checking anstyle-parse v0.2.4 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Checking gimli v0.28.1 [INFO] [stderr] Checking memchr v2.7.2 [INFO] [stderr] Checking miniz_oxide v0.7.3 [INFO] [stderr] Checking anstream v0.6.14 [INFO] [stderr] Compiling nix v0.29.0 [INFO] [stderr] Compiling serde_json v1.0.117 [INFO] [stderr] Checking clap_builder v4.5.2 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Checking object v0.32.2 [INFO] [stderr] Checking rustc-demangle v0.1.24 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking bitflags v2.5.0 [INFO] [stderr] Compiling syn v2.0.66 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Compiling garbage v0.4.3 (/opt/rustwide/workdir) [INFO] [stderr] Checking encode_unicode v1.0.0 [INFO] [stderr] Compiling backtrace v0.3.71 [INFO] [stderr] Checking dirs-sys-next v0.1.2 [INFO] [stderr] Checking is-terminal v0.4.12 [INFO] [stderr] Checking unicode-width v0.1.12 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking dirs-next v2.0.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking term v0.7.0 [INFO] [stderr] Checking walkdir v2.5.0 [INFO] [stderr] Checking prettytable-rs v0.10.0 [INFO] [stderr] Checking xdg v2.5.2 [INFO] [stderr] Checking garbage-fs v0.1.0 [INFO] [stderr] Checking addr2line v0.21.0 [INFO] [stderr] Compiling serde_derive v1.0.203 [INFO] [stderr] Compiling clap_derive v4.5.4 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking clap v4.5.4 [INFO] [stderr] Checking clap_complete v4.5.2 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking chrono-humanize v0.2.3 [INFO] [stdout] warning: this function depends on never type fallback being `()` [INFO] [stdout] --> src/ops/empty.rs:38:1 [INFO] [stdout] | [INFO] [stdout] 38 | pub fn empty(options: EmptyOptions, fs: &impl Filesystem) -> Result<()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stdout] = note: for more information, see issue #123748 [INFO] [stdout] = help: specify the types explicitly [INFO] [stdout] note: in edition 2024, the requirement `!: FromIterator<()>` will fail [INFO] [stdout] --> src/ops/empty.rs:81:16 [INFO] [stdout] | [INFO] [stdout] 81 | .collect::>()?; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] = note: `#[warn(dependency_on_unit_never_type_fallback)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function depends on never type fallback being `()` [INFO] [stdout] --> src/ops/empty.rs:38:1 [INFO] [stdout] | [INFO] [stdout] 38 | pub fn empty(options: EmptyOptions, fs: &impl Filesystem) -> Result<()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stdout] = note: for more information, see issue #123748 [INFO] [stdout] = help: specify the types explicitly [INFO] [stdout] note: in edition 2024, the requirement `!: FromIterator<()>` will fail [INFO] [stdout] --> src/ops/empty.rs:81:16 [INFO] [stdout] | [INFO] [stdout] 81 | .collect::>()?; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] = note: `#[warn(dependency_on_unit_never_type_fallback)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `mount_id`, `parent_id`, `major`, `minor`, and `root` are never read [INFO] [stdout] --> src/mounts.rs:16:7 [INFO] [stdout] | [INFO] [stdout] 15 | pub struct MountPoint { [INFO] [stdout] | ---------- fields in this struct [INFO] [stdout] 16 | pub mount_id: c_ulong, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 17 | pub parent_id: c_ulong, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 18 | pub major: c_ulong, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 19 | pub minor: c_ulong, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 20 | pub root: PathBuf, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `MountPoint` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dir.rs:102:8 [INFO] [stdout] | [INFO] [stdout] 95 | let iter = WalkDir::new(&self.info_dir(fs)?) [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 102 | Ok(TrashDirIter(self.path.clone(), Box::new(iter))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dir.rs:148:7 [INFO] [stdout] | [INFO] [stdout] 120 | Some(Err(err)) => { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 148 | / TrashInfo::from_files(entry.path(), deleted_path) [INFO] [stdout] 149 | | .map_err(|err| err.into()), [INFO] [stdout] | |__________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `garbage` (lib) due to 3 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: fields `mount_id`, `parent_id`, `major`, `minor`, and `root` are never read [INFO] [stdout] --> src/mounts.rs:16:7 [INFO] [stdout] | [INFO] [stdout] 15 | pub struct MountPoint { [INFO] [stdout] | ---------- fields in this struct [INFO] [stdout] 16 | pub mount_id: c_ulong, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 17 | pub parent_id: c_ulong, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 18 | pub major: c_ulong, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 19 | pub minor: c_ulong, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 20 | pub root: PathBuf, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `MountPoint` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dir.rs:102:8 [INFO] [stdout] | [INFO] [stdout] 95 | let iter = WalkDir::new(&self.info_dir(fs)?) [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 102 | Ok(TrashDirIter(self.path.clone(), Box::new(iter))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dir.rs:148:7 [INFO] [stdout] | [INFO] [stdout] 120 | Some(Err(err)) => { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 148 | / TrashInfo::from_files(entry.path(), deleted_path) [INFO] [stdout] 149 | | .map_err(|err| err.into()), [INFO] [stdout] | |__________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `garbage` (lib test) due to 3 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "aa85a28cf79a6013ad1c27672ebba6af6577227432eab422d3a929625b135ebd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "aa85a28cf79a6013ad1c27672ebba6af6577227432eab422d3a929625b135ebd", kill_on_drop: false }` [INFO] [stdout] aa85a28cf79a6013ad1c27672ebba6af6577227432eab422d3a929625b135ebd