[INFO] fetching crate garage_rpc 1.0.0... [INFO] checking garage_rpc-1.0.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate garage_rpc 1.0.0 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate garage_rpc 1.0.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate garage_rpc 1.0.0 [INFO] finished tweaking crates.io crate garage_rpc 1.0.0 [INFO] tweaked toml for crates.io crate garage_rpc 1.0.0 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 266 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding arrayvec v0.5.2 (latest: v0.7.6) [INFO] [stderr] Adding base64 v0.21.7 (latest: v0.22.1) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding core-foundation v0.9.4 (latest: v0.10.0) [INFO] [stderr] Adding dashmap v4.0.2 (latest: v6.0.1) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding gethostname v0.4.3 (latest: v0.5.0) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding h2 v0.3.26 (latest: v0.4.6) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding http v0.2.12 (latest: v1.1.0) [INFO] [stderr] Adding http-body v0.4.6 (latest: v1.0.1) [INFO] [stderr] Adding http-range-header v0.3.1 (latest: v0.4.1) [INFO] [stderr] Adding hyper v0.14.30 (latest: v1.4.1) [INFO] [stderr] Adding hyper-rustls v0.24.2 (latest: v0.27.2) [INFO] [stderr] Adding hyper-timeout v0.4.1 (latest: v0.5.1) [INFO] [stderr] Adding idna v0.5.0 (latest: v1.0.2) [INFO] [stderr] Adding itertools v0.12.1 (latest: v0.13.0) [INFO] [stderr] Adding json-patch v1.4.0 (latest: v2.0.0) [INFO] [stderr] Adding jsonpath-rust v0.4.0 (latest: v0.7.0) [INFO] [stderr] Adding k8s-openapi v0.21.1 (latest: v0.22.0) [INFO] [stderr] Adding kube v0.88.1 (latest: v0.93.1) [INFO] [stderr] Adding kube-client v0.88.1 (latest: v0.93.1) [INFO] [stderr] Adding kube-core v0.88.1 (latest: v0.93.1) [INFO] [stderr] Adding kube-derive v0.88.1 (latest: v0.93.1) [INFO] [stderr] Adding kube-runtime v0.88.1 (latest: v0.93.1) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding nix v0.27.1 (latest: v0.29.0) [INFO] [stderr] Adding opentelemetry v0.17.0 (latest: v0.24.0) [INFO] [stderr] Adding ordered-float v2.10.1 (latest: v4.2.2) [INFO] [stderr] Adding pnet_base v0.34.0 (latest: v0.35.0) [INFO] [stderr] Adding pnet_datalink v0.34.0 (latest: v0.35.0) [INFO] [stderr] Adding pnet_sys v0.34.0 (latest: v0.35.0) [INFO] [stderr] Adding reqwest v0.11.27 (latest: v0.12.7) [INFO] [stderr] Adding rustls v0.21.12 (latest: v0.23.12) [INFO] [stderr] Adding rustls-native-certs v0.6.3 (latest: v0.8.0) [INFO] [stderr] Adding rustls-pemfile v1.0.4 (latest: v2.1.3) [INFO] [stderr] Adding rustls-webpki v0.101.7 (latest: v0.102.7) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding sync_wrapper v0.1.2 (latest: v1.0.1) [INFO] [stderr] Adding synstructure v0.12.6 (latest: v0.13.1) [INFO] [stderr] Adding system-configuration v0.5.1 (latest: v0.6.1) [INFO] [stderr] Adding system-configuration-sys v0.5.0 (latest: v0.6.0) [INFO] [stderr] Adding tokio-rustls v0.24.1 (latest: v0.26.0) [INFO] [stderr] Adding tower v0.4.13 (latest: v0.5.0) [INFO] [stderr] Adding tower-http v0.4.4 (latest: v0.5.2) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] [stderr] Adding windows-sys v0.48.0 (latest: v0.59.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] [stderr] Adding windows-targets v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_gnullvm v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_gnu v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnu v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnullvm v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding winreg v0.50.0 (latest: v0.52.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3c01ab2bbfca53b9965ba0901a4b7909d03726bc95177f0e7b9b7d9d478b2cec [INFO] running `Command { std: "docker" "start" "-a" "3c01ab2bbfca53b9965ba0901a4b7909d03726bc95177f0e7b9b7d9d478b2cec", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3c01ab2bbfca53b9965ba0901a4b7909d03726bc95177f0e7b9b7d9d478b2cec", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3c01ab2bbfca53b9965ba0901a4b7909d03726bc95177f0e7b9b7d9d478b2cec", kill_on_drop: false }` [INFO] [stdout] 3c01ab2bbfca53b9965ba0901a4b7909d03726bc95177f0e7b9b7d9d478b2cec [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a322c1a1af4a968b5a47d2638926cd454527ceac6f2aa255dead7daef21aff46 [INFO] running `Command { std: "docker" "start" "-a" "a322c1a1af4a968b5a47d2638926cd454527ceac6f2aa255dead7daef21aff46", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling version_check v0.9.5 [INFO] [stderr] Compiling autocfg v1.3.0 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Compiling typenum v1.17.0 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking bytes v1.7.1 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling same-file v1.0.6 [INFO] [stderr] Compiling rustversion v1.0.17 [INFO] [stderr] Compiling cc v1.1.15 [INFO] [stderr] Checking pin-utils v0.1.0 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Compiling pkg-config v0.3.30 [INFO] [stderr] Compiling paste v1.0.15 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Compiling walkdir v2.5.0 [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Checking itoa v1.0.11 [INFO] [stderr] Compiling unicode-xid v0.2.5 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking fnv v1.0.7 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking equivalent v1.0.1 [INFO] [stderr] Checking subtle v2.6.1 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking hex v0.4.3 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Checking winnow v0.6.18 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Compiling serde_json v1.0.127 [INFO] [stderr] Compiling rustc_version v0.4.1 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking arrayvec v0.5.2 [INFO] [stderr] Checking crossbeam-channel v0.5.13 [INFO] [stderr] Compiling err-derive v0.3.1 [INFO] [stderr] Checking percent-encoding v2.3.1 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Checking ryu v1.0.18 [INFO] [stderr] Checking no-std-net v0.6.0 [INFO] [stderr] Compiling garage_util v1.0.0 [INFO] [stderr] Checking arc-swap v1.7.1 [INFO] [stderr] Checking iana-time-zone v0.1.60 [INFO] [stderr] Checking indexmap v2.5.0 [INFO] [stderr] Checking pnet_base v0.34.0 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Checking hexdump v0.1.2 [INFO] [stderr] Checking xxhash-rust v0.8.12 [INFO] [stderr] Checking bytesize v1.3.0 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking format_table v0.1.1 [INFO] [stderr] Compiling libsodium-sys v0.2.7 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Checking itertools v0.12.1 [INFO] [stderr] Checking rmp v0.8.14 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking mio v1.0.2 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking pnet_sys v0.34.0 [INFO] [stderr] Checking gethostname v0.4.3 [INFO] [stderr] Checking nix v0.27.1 [INFO] [stderr] Checking dashmap v4.0.2 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking blake2 v0.10.6 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Compiling synstructure v0.12.6 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling async-trait v0.1.81 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking garage_db v1.0.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking tokio-stream v0.1.15 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking hyper v1.4.1 [INFO] [stderr] Checking opentelemetry v0.17.0 [INFO] [stderr] Checking toml_datetime v0.6.8 [INFO] [stderr] Checking serde_spanned v0.6.7 [INFO] [stderr] Checking rmp-serde v1.3.0 [INFO] [stderr] Checking ipnetwork v0.20.0 [INFO] [stderr] Checking serde_bytes v0.11.15 [INFO] [stderr] Checking toml_edit v0.22.20 [INFO] [stderr] Checking pnet_datalink v0.34.0 [INFO] [stderr] Checking toml v0.8.19 [INFO] [stderr] Checking kuska-sodiumoxide v0.2.5-0 [INFO] [stderr] Checking kuska-handshake v0.2.0 [INFO] [stderr] Checking garage_net v1.0.0 [INFO] [stderr] Checking garage_rpc v1.0.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> metrics.rs:16:17 [INFO] [stdout] | [INFO] [stdout] 14 | let meter = global::meter("garage_rpc"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 15 | RpcMetrics { [INFO] [stdout] 16 | rpc_counter: meter [INFO] [stdout] | __________________________^ [INFO] [stdout] 17 | | .u64_counter("rpc.request_counter") [INFO] [stdout] 18 | | .with_description("Number of RPC requests emitted") [INFO] [stdout] 19 | | .init(), [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> metrics.rs:20:25 [INFO] [stdout] | [INFO] [stdout] 14 | let meter = global::meter("garage_rpc"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 20 | rpc_timeout_counter: meter [INFO] [stdout] | __________________________________^ [INFO] [stdout] 21 | | .u64_counter("rpc.timeout_counter") [INFO] [stdout] 22 | | .with_description("Number of RPC timeouts") [INFO] [stdout] 23 | | .init(), [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> metrics.rs:24:30 [INFO] [stdout] | [INFO] [stdout] 14 | let meter = global::meter("garage_rpc"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 24 | rpc_netapp_error_counter: meter [INFO] [stdout] | _______________________________________^ [INFO] [stdout] 25 | | .u64_counter("rpc.netapp_error_counter") [INFO] [stdout] 26 | | .with_description("Number of communication errors (errors in the Netapp library)") [INFO] [stdout] 27 | | .init(), [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> metrics.rs:28:30 [INFO] [stdout] | [INFO] [stdout] 14 | let meter = global::meter("garage_rpc"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 28 | rpc_garage_error_counter: meter [INFO] [stdout] | _______________________________________^ [INFO] [stdout] 29 | | .u64_counter("rpc.garage_error_counter") [INFO] [stdout] 30 | | .with_description("Number of RPC errors (errors happening when handling the RPC)") [INFO] [stdout] 31 | | .init(), [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> metrics.rs:32:18 [INFO] [stdout] | [INFO] [stdout] 14 | let meter = global::meter("garage_rpc"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | rpc_duration: meter [INFO] [stdout] | ___________________________^ [INFO] [stdout] 33 | | .f64_value_recorder("rpc.duration") [INFO] [stdout] 34 | | .with_description("Duration of RPCs") [INFO] [stdout] 35 | | .init(), [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> system_metrics.rs:55:24 [INFO] [stdout] | [INFO] [stdout] 35 | pub fn new(system: Arc) -> Self { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | let meter = global::meter("garage_system"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | let system2 = system.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | let get_health = Arc::new(move || { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 55 | _garage_build_info: meter [INFO] [stdout] | _________________________________^ [INFO] [stdout] 56 | | .u64_value_observer("garage_build_info", move |observer| { [INFO] [stdout] 57 | | observer.observe( [INFO] [stdout] 58 | | 1, [INFO] [stdout] ... | [INFO] [stdout] 65 | | .with_description("Garage build info") [INFO] [stdout] 66 | | .init(), [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> system_metrics.rs:67:25 [INFO] [stdout] | [INFO] [stdout] 35 | pub fn new(system: Arc) -> Self { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | let meter = global::meter("garage_system"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | let system2 = system.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | let get_health = Arc::new(move || { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 67 | _replication_factor: { [INFO] [stdout] | __________________________________^ [INFO] [stdout] 68 | | let replication_factor = system.replication_factor; [INFO] [stdout] 69 | | meter [INFO] [stdout] 70 | | .u64_value_observer("garage_replication_factor", move |observer| { [INFO] [stdout] ... | [INFO] [stdout] 74 | | .init() [INFO] [stdout] 75 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> system_metrics.rs:78:17 [INFO] [stdout] | [INFO] [stdout] 35 | pub fn new(system: Arc) -> Self { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | let meter = global::meter("garage_system"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | let system2 = system.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | let get_health = Arc::new(move || { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 78 | _disk_avail: { [INFO] [stdout] | __________________________^ [INFO] [stdout] 79 | | let system = system.clone(); [INFO] [stdout] 80 | | meter [INFO] [stdout] 81 | | .u64_value_observer("garage_local_disk_avail", move |observer| { [INFO] [stdout] ... | [INFO] [stdout] 91 | | .init() [INFO] [stdout] 92 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> system_metrics.rs:93:17 [INFO] [stdout] | [INFO] [stdout] 35 | pub fn new(system: Arc) -> Self { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | let meter = global::meter("garage_system"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | let system2 = system.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | let get_health = Arc::new(move || { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 93 | _disk_total: { [INFO] [stdout] | __________________________^ [INFO] [stdout] 94 | | let system = system.clone(); [INFO] [stdout] 95 | | meter [INFO] [stdout] 96 | | .u64_value_observer("garage_local_disk_total", move |observer| { [INFO] [stdout] ... | [INFO] [stdout] 106 | | .init() [INFO] [stdout] 107 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> system_metrics.rs:110:22 [INFO] [stdout] | [INFO] [stdout] 35 | pub fn new(system: Arc) -> Self { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | let meter = global::meter("garage_system"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | let system2 = system.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | let get_health = Arc::new(move || { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 110 | _cluster_healthy: { [INFO] [stdout] | _______________________________^ [INFO] [stdout] 111 | | let get_health = get_health.clone(); [INFO] [stdout] 112 | | meter [INFO] [stdout] 113 | | .u64_value_observer("cluster_healthy", move |observer| { [INFO] [stdout] ... | [INFO] [stdout] 122 | | .init() [INFO] [stdout] 123 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> system_metrics.rs:124:24 [INFO] [stdout] | [INFO] [stdout] 35 | pub fn new(system: Arc) -> Self { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | let meter = global::meter("garage_system"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | let system2 = system.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | let get_health = Arc::new(move || { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 124 | _cluster_available: { [INFO] [stdout] | _________________________________^ [INFO] [stdout] 125 | | let get_health = get_health.clone(); [INFO] [stdout] 126 | | meter.u64_value_observer("cluster_available", move |observer| { [INFO] [stdout] 127 | | let h = get_health(); [INFO] [stdout] ... | [INFO] [stdout] 135 | | .init() [INFO] [stdout] 136 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> system_metrics.rs:137:18 [INFO] [stdout] | [INFO] [stdout] 35 | pub fn new(system: Arc) -> Self { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | let meter = global::meter("garage_system"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | let system2 = system.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | let get_health = Arc::new(move || { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 137 | _known_nodes: { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 138 | | let get_health = get_health.clone(); [INFO] [stdout] 139 | | meter [INFO] [stdout] 140 | | .u64_value_observer("cluster_known_nodes", move |observer| { [INFO] [stdout] ... | [INFO] [stdout] 145 | | .init() [INFO] [stdout] 146 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> system_metrics.rs:147:22 [INFO] [stdout] | [INFO] [stdout] 35 | pub fn new(system: Arc) -> Self { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | let meter = global::meter("garage_system"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | let system2 = system.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | let get_health = Arc::new(move || { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 147 | _connected_nodes: { [INFO] [stdout] | _______________________________^ [INFO] [stdout] 148 | | let get_health = get_health.clone(); [INFO] [stdout] 149 | | meter [INFO] [stdout] 150 | | .u64_value_observer("cluster_connected_nodes", move |observer| { [INFO] [stdout] ... | [INFO] [stdout] 155 | | .init() [INFO] [stdout] 156 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> system_metrics.rs:157:20 [INFO] [stdout] | [INFO] [stdout] 35 | pub fn new(system: Arc) -> Self { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | let meter = global::meter("garage_system"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | let system2 = system.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | let get_health = Arc::new(move || { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 157 | _storage_nodes: { [INFO] [stdout] | _____________________________^ [INFO] [stdout] 158 | | let get_health = get_health.clone(); [INFO] [stdout] 159 | | meter [INFO] [stdout] 160 | | .u64_value_observer("cluster_storage_nodes", move |observer| { [INFO] [stdout] ... | [INFO] [stdout] 165 | | .init() [INFO] [stdout] 166 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> system_metrics.rs:167:23 [INFO] [stdout] | [INFO] [stdout] 35 | pub fn new(system: Arc) -> Self { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | let meter = global::meter("garage_system"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | let system2 = system.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | let get_health = Arc::new(move || { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 167 | _storage_nodes_ok: { [INFO] [stdout] | ________________________________^ [INFO] [stdout] 168 | | let get_health = get_health.clone(); [INFO] [stdout] 169 | | meter [INFO] [stdout] 170 | | .u64_value_observer("cluster_storage_nodes_ok", move |observer| { [INFO] [stdout] ... | [INFO] [stdout] 175 | | .init() [INFO] [stdout] 176 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> system_metrics.rs:177:17 [INFO] [stdout] | [INFO] [stdout] 35 | pub fn new(system: Arc) -> Self { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | let meter = global::meter("garage_system"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | let system2 = system.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | let get_health = Arc::new(move || { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 177 | _partitions: { [INFO] [stdout] | __________________________^ [INFO] [stdout] 178 | | let get_health = get_health.clone(); [INFO] [stdout] 179 | | meter [INFO] [stdout] 180 | | .u64_value_observer("cluster_partitions", move |observer| { [INFO] [stdout] ... | [INFO] [stdout] 185 | | .init() [INFO] [stdout] 186 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> system_metrics.rs:187:24 [INFO] [stdout] | [INFO] [stdout] 35 | pub fn new(system: Arc) -> Self { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | let meter = global::meter("garage_system"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | let system2 = system.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | let get_health = Arc::new(move || { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 187 | _partitions_quorum: { [INFO] [stdout] | _________________________________^ [INFO] [stdout] 188 | | let get_health = get_health.clone(); [INFO] [stdout] 189 | | meter [INFO] [stdout] 190 | | .u64_value_observer("cluster_partitions_quorum", move |observer| { [INFO] [stdout] ... | [INFO] [stdout] 197 | | .init() [INFO] [stdout] 198 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> system_metrics.rs:199:24 [INFO] [stdout] | [INFO] [stdout] 35 | pub fn new(system: Arc) -> Self { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | let meter = global::meter("garage_system"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | let system2 = system.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | let get_health = Arc::new(move || { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 199 | _partitions_all_ok: { [INFO] [stdout] | _________________________________^ [INFO] [stdout] 200 | | let get_health = get_health.clone(); [INFO] [stdout] 201 | | meter [INFO] [stdout] 202 | | .u64_value_observer("cluster_partitions_all_ok", move |observer| { [INFO] [stdout] ... | [INFO] [stdout] 209 | | .init() [INFO] [stdout] 210 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> system_metrics.rs:213:28 [INFO] [stdout] | [INFO] [stdout] 35 | pub fn new(system: Arc) -> Self { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | let meter = global::meter("garage_system"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | let system2 = system.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | let get_health = Arc::new(move || { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 213 | _layout_node_connected: { [INFO] [stdout] | _____________________________________^ [INFO] [stdout] 214 | | let system = system.clone(); [INFO] [stdout] 215 | | meter [INFO] [stdout] 216 | | .u64_value_observer("cluster_layout_node_connected", move |observer| { [INFO] [stdout] ... | [INFO] [stdout] 255 | | .init() [INFO] [stdout] 256 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> system_metrics.rs:257:36 [INFO] [stdout] | [INFO] [stdout] 35 | pub fn new(system: Arc) -> Self { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | let meter = global::meter("garage_system"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | let system2 = system.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | let get_health = Arc::new(move || { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 257 | _layout_node_disconnected_time: { [INFO] [stdout] | _____________________________________________^ [INFO] [stdout] 258 | | let system = system.clone(); [INFO] [stdout] 259 | | meter [INFO] [stdout] 260 | | .u64_value_observer("cluster_layout_node_disconnected_time", move |observer| { [INFO] [stdout] ... | [INFO] [stdout] 298 | | .init() [INFO] [stdout] 299 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> layout/helper.rs:208:13 [INFO] [stdout] | [INFO] [stdout] 208 | .map(|x| x.nodes_of(position, x.replication_factor).collect()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> layout/manager.rs:85:6 [INFO] [stdout] | [INFO] [stdout] 39 | system_endpoint: Arc>, [INFO] [stdout] | ------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | peering: Arc, [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | Err(e) => { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 75 | let layout = Arc::new(RwLock::new(cluster_layout)); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 76 | let change_notify = Arc::new(Notify::new()); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 77 | [INFO] [stdout] 78 | let rpc_helper = RpcHelper::new( [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 85 | Ok(Arc::new(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 86 | | node_id: node_id.into(), [INFO] [stdout] 87 | | replication_factor, [INFO] [stdout] 88 | | persist_cluster_layout, [INFO] [stdout] ... | [INFO] [stdout] 93 | | rpc_helper, [INFO] [stdout] 94 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> layout/manager.rs:270:49 [INFO] [stdout] | [INFO] [stdout] 269 | let this = self.clone(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 270 | async move { this.pull_cluster_layout(from).await } [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> layout/manager.rs:275:58 [INFO] [stdout] | [INFO] [stdout] 274 | let this = self.clone(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 275 | async move { this.pull_cluster_layout_trackers(from).await } [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> layout/manager.rs:350:20 [INFO] [stdout] | [INFO] [stdout] 347 | fn new(version: u64, layout_manager: &Arc, value: T) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 350 | layout_manager: layout_manager.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> system.rs:478:16 [INFO] [stdout] | [INFO] [stdout] 478 | .all(|set| set.filter(|x| node_up(x)).count() >= quorum); [INFO] [stdout] | --- ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> rpc_helper.rs:147:8 [INFO] [stdout] | [INFO] [stdout] 141 | peering: Arc, [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 142 | layout: Arc>, [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 145 | let metrics = RpcMetrics::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 146 | [INFO] [stdout] 147 | Self(Arc::new(RpcHelperInner { [INFO] [stdout] | ______________^ [INFO] [stdout] 148 | | our_node_id, [INFO] [stdout] 149 | | peering, [INFO] [stdout] 150 | | layout, [INFO] [stdout] 151 | | metrics, [INFO] [stdout] 152 | | rpc_timeout: rpc_timeout.unwrap_or(DEFAULT_TIMEOUT), [INFO] [stdout] 153 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> rpc_helper.rs:240:40 [INFO] [stdout] | [INFO] [stdout] 240 | .map(|to| self.call(endpoint, *to, msg.clone(), strat.clone())), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> rpc_helper.rs:360:59 [INFO] [stdout] | [INFO] [stdout] 356 | let self2 = self.clone(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 357 | let msg = msg.clone(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 358 | let endpoint2 = endpoint.clone(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 359 | let strategy = strategy.clone(); [INFO] [stdout] 360 | async move { self2.call(&endpoint2, to, msg, strategy).await } [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> rpc_helper.rs:497:22 [INFO] [stdout] | [INFO] [stdout] 492 | let self2 = self.clone(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 493 | let msg = msg.clone(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 494 | let endpoint2 = endpoint.clone(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 497 | async move { (to, self2.call(&endpoint2, to, msg, strategy).await) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> rpc_helper.rs:691:3 [INFO] [stdout] | [INFO] [stdout] 690 | pub fn success_values(self) -> Vec { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 691 | / self.successes [INFO] [stdout] 692 | | .into_iter() [INFO] [stdout] 693 | | .map(|(_, x)| x) [INFO] [stdout] | |____________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 31 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> metrics.rs:16:17 [INFO] [stdout] | [INFO] [stdout] 14 | let meter = global::meter("garage_rpc"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 15 | RpcMetrics { [INFO] [stdout] 16 | rpc_counter: meter [INFO] [stdout] | __________________________^ [INFO] [stdout] 17 | | .u64_counter("rpc.request_counter") [INFO] [stdout] 18 | | .with_description("Number of RPC requests emitted") [INFO] [stdout] 19 | | .init(), [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> metrics.rs:20:25 [INFO] [stdout] | [INFO] [stdout] 14 | let meter = global::meter("garage_rpc"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 20 | rpc_timeout_counter: meter [INFO] [stdout] | __________________________________^ [INFO] [stdout] 21 | | .u64_counter("rpc.timeout_counter") [INFO] [stdout] 22 | | .with_description("Number of RPC timeouts") [INFO] [stdout] 23 | | .init(), [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> metrics.rs:24:30 [INFO] [stdout] | [INFO] [stdout] 14 | let meter = global::meter("garage_rpc"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 24 | rpc_netapp_error_counter: meter [INFO] [stdout] | _______________________________________^ [INFO] [stdout] 25 | | .u64_counter("rpc.netapp_error_counter") [INFO] [stdout] 26 | | .with_description("Number of communication errors (errors in the Netapp library)") [INFO] [stdout] 27 | | .init(), [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> metrics.rs:28:30 [INFO] [stdout] | [INFO] [stdout] 14 | let meter = global::meter("garage_rpc"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 28 | rpc_garage_error_counter: meter [INFO] [stdout] | _______________________________________^ [INFO] [stdout] 29 | | .u64_counter("rpc.garage_error_counter") [INFO] [stdout] 30 | | .with_description("Number of RPC errors (errors happening when handling the RPC)") [INFO] [stdout] 31 | | .init(), [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> metrics.rs:32:18 [INFO] [stdout] | [INFO] [stdout] 14 | let meter = global::meter("garage_rpc"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | rpc_duration: meter [INFO] [stdout] | ___________________________^ [INFO] [stdout] 33 | | .f64_value_recorder("rpc.duration") [INFO] [stdout] 34 | | .with_description("Duration of RPCs") [INFO] [stdout] 35 | | .init(), [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> system_metrics.rs:55:24 [INFO] [stdout] | [INFO] [stdout] 35 | pub fn new(system: Arc) -> Self { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | let meter = global::meter("garage_system"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | let system2 = system.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | let get_health = Arc::new(move || { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 55 | _garage_build_info: meter [INFO] [stdout] | _________________________________^ [INFO] [stdout] 56 | | .u64_value_observer("garage_build_info", move |observer| { [INFO] [stdout] 57 | | observer.observe( [INFO] [stdout] 58 | | 1, [INFO] [stdout] ... | [INFO] [stdout] 65 | | .with_description("Garage build info") [INFO] [stdout] 66 | | .init(), [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> system_metrics.rs:67:25 [INFO] [stdout] | [INFO] [stdout] 35 | pub fn new(system: Arc) -> Self { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | let meter = global::meter("garage_system"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | let system2 = system.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | let get_health = Arc::new(move || { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 67 | _replication_factor: { [INFO] [stdout] | __________________________________^ [INFO] [stdout] 68 | | let replication_factor = system.replication_factor; [INFO] [stdout] 69 | | meter [INFO] [stdout] 70 | | .u64_value_observer("garage_replication_factor", move |observer| { [INFO] [stdout] ... | [INFO] [stdout] 74 | | .init() [INFO] [stdout] 75 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> system_metrics.rs:78:17 [INFO] [stdout] | [INFO] [stdout] 35 | pub fn new(system: Arc) -> Self { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | let meter = global::meter("garage_system"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | let system2 = system.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | let get_health = Arc::new(move || { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 78 | _disk_avail: { [INFO] [stdout] | __________________________^ [INFO] [stdout] 79 | | let system = system.clone(); [INFO] [stdout] 80 | | meter [INFO] [stdout] 81 | | .u64_value_observer("garage_local_disk_avail", move |observer| { [INFO] [stdout] ... | [INFO] [stdout] 91 | | .init() [INFO] [stdout] 92 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> system_metrics.rs:93:17 [INFO] [stdout] | [INFO] [stdout] 35 | pub fn new(system: Arc) -> Self { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | let meter = global::meter("garage_system"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | let system2 = system.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | let get_health = Arc::new(move || { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 93 | _disk_total: { [INFO] [stdout] | __________________________^ [INFO] [stdout] 94 | | let system = system.clone(); [INFO] [stdout] 95 | | meter [INFO] [stdout] 96 | | .u64_value_observer("garage_local_disk_total", move |observer| { [INFO] [stdout] ... | [INFO] [stdout] 106 | | .init() [INFO] [stdout] 107 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> system_metrics.rs:110:22 [INFO] [stdout] | [INFO] [stdout] 35 | pub fn new(system: Arc) -> Self { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | let meter = global::meter("garage_system"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | let system2 = system.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | let get_health = Arc::new(move || { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 110 | _cluster_healthy: { [INFO] [stdout] | _______________________________^ [INFO] [stdout] 111 | | let get_health = get_health.clone(); [INFO] [stdout] 112 | | meter [INFO] [stdout] 113 | | .u64_value_observer("cluster_healthy", move |observer| { [INFO] [stdout] ... | [INFO] [stdout] 122 | | .init() [INFO] [stdout] 123 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> system_metrics.rs:124:24 [INFO] [stdout] | [INFO] [stdout] 35 | pub fn new(system: Arc) -> Self { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | let meter = global::meter("garage_system"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | let system2 = system.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | let get_health = Arc::new(move || { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 124 | _cluster_available: { [INFO] [stdout] | _________________________________^ [INFO] [stdout] 125 | | let get_health = get_health.clone(); [INFO] [stdout] 126 | | meter.u64_value_observer("cluster_available", move |observer| { [INFO] [stdout] 127 | | let h = get_health(); [INFO] [stdout] ... | [INFO] [stdout] 135 | | .init() [INFO] [stdout] 136 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> system_metrics.rs:137:18 [INFO] [stdout] | [INFO] [stdout] 35 | pub fn new(system: Arc) -> Self { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | let meter = global::meter("garage_system"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | let system2 = system.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | let get_health = Arc::new(move || { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 137 | _known_nodes: { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 138 | | let get_health = get_health.clone(); [INFO] [stdout] 139 | | meter [INFO] [stdout] 140 | | .u64_value_observer("cluster_known_nodes", move |observer| { [INFO] [stdout] ... | [INFO] [stdout] 145 | | .init() [INFO] [stdout] 146 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> system_metrics.rs:147:22 [INFO] [stdout] | [INFO] [stdout] 35 | pub fn new(system: Arc) -> Self { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | let meter = global::meter("garage_system"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | let system2 = system.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | let get_health = Arc::new(move || { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 147 | _connected_nodes: { [INFO] [stdout] | _______________________________^ [INFO] [stdout] 148 | | let get_health = get_health.clone(); [INFO] [stdout] 149 | | meter [INFO] [stdout] 150 | | .u64_value_observer("cluster_connected_nodes", move |observer| { [INFO] [stdout] ... | [INFO] [stdout] 155 | | .init() [INFO] [stdout] 156 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> system_metrics.rs:157:20 [INFO] [stdout] | [INFO] [stdout] 35 | pub fn new(system: Arc) -> Self { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | let meter = global::meter("garage_system"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | let system2 = system.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | let get_health = Arc::new(move || { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 157 | _storage_nodes: { [INFO] [stdout] | _____________________________^ [INFO] [stdout] 158 | | let get_health = get_health.clone(); [INFO] [stdout] 159 | | meter [INFO] [stdout] 160 | | .u64_value_observer("cluster_storage_nodes", move |observer| { [INFO] [stdout] ... | [INFO] [stdout] 165 | | .init() [INFO] [stdout] 166 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> system_metrics.rs:167:23 [INFO] [stdout] | [INFO] [stdout] 35 | pub fn new(system: Arc) -> Self { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | let meter = global::meter("garage_system"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | let system2 = system.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | let get_health = Arc::new(move || { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 167 | _storage_nodes_ok: { [INFO] [stdout] | ________________________________^ [INFO] [stdout] 168 | | let get_health = get_health.clone(); [INFO] [stdout] 169 | | meter [INFO] [stdout] 170 | | .u64_value_observer("cluster_storage_nodes_ok", move |observer| { [INFO] [stdout] ... | [INFO] [stdout] 175 | | .init() [INFO] [stdout] 176 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> system_metrics.rs:177:17 [INFO] [stdout] | [INFO] [stdout] 35 | pub fn new(system: Arc) -> Self { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | let meter = global::meter("garage_system"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | let system2 = system.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | let get_health = Arc::new(move || { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 177 | _partitions: { [INFO] [stdout] | __________________________^ [INFO] [stdout] 178 | | let get_health = get_health.clone(); [INFO] [stdout] 179 | | meter [INFO] [stdout] 180 | | .u64_value_observer("cluster_partitions", move |observer| { [INFO] [stdout] ... | [INFO] [stdout] 185 | | .init() [INFO] [stdout] 186 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> system_metrics.rs:187:24 [INFO] [stdout] | [INFO] [stdout] 35 | pub fn new(system: Arc) -> Self { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | let meter = global::meter("garage_system"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | let system2 = system.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | let get_health = Arc::new(move || { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 187 | _partitions_quorum: { [INFO] [stdout] | _________________________________^ [INFO] [stdout] 188 | | let get_health = get_health.clone(); [INFO] [stdout] 189 | | meter [INFO] [stdout] 190 | | .u64_value_observer("cluster_partitions_quorum", move |observer| { [INFO] [stdout] ... | [INFO] [stdout] 197 | | .init() [INFO] [stdout] 198 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> system_metrics.rs:199:24 [INFO] [stdout] | [INFO] [stdout] 35 | pub fn new(system: Arc) -> Self { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | let meter = global::meter("garage_system"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | let system2 = system.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | let get_health = Arc::new(move || { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 199 | _partitions_all_ok: { [INFO] [stdout] | _________________________________^ [INFO] [stdout] 200 | | let get_health = get_health.clone(); [INFO] [stdout] 201 | | meter [INFO] [stdout] 202 | | .u64_value_observer("cluster_partitions_all_ok", move |observer| { [INFO] [stdout] ... | [INFO] [stdout] 209 | | .init() [INFO] [stdout] 210 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> system_metrics.rs:213:28 [INFO] [stdout] | [INFO] [stdout] 35 | pub fn new(system: Arc) -> Self { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | let meter = global::meter("garage_system"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | let system2 = system.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | let get_health = Arc::new(move || { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 213 | _layout_node_connected: { [INFO] [stdout] | _____________________________________^ [INFO] [stdout] 214 | | let system = system.clone(); [INFO] [stdout] 215 | | meter [INFO] [stdout] 216 | | .u64_value_observer("cluster_layout_node_connected", move |observer| { [INFO] [stdout] ... | [INFO] [stdout] 255 | | .init() [INFO] [stdout] 256 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> system_metrics.rs:257:36 [INFO] [stdout] | [INFO] [stdout] 35 | pub fn new(system: Arc) -> Self { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | let meter = global::meter("garage_system"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | let system2 = system.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | let get_health = Arc::new(move || { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 257 | _layout_node_disconnected_time: { [INFO] [stdout] | _____________________________________________^ [INFO] [stdout] 258 | | let system = system.clone(); [INFO] [stdout] 259 | | meter [INFO] [stdout] 260 | | .u64_value_observer("cluster_layout_node_disconnected_time", move |observer| { [INFO] [stdout] ... | [INFO] [stdout] 298 | | .init() [INFO] [stdout] 299 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> layout/helper.rs:208:13 [INFO] [stdout] | [INFO] [stdout] 208 | .map(|x| x.nodes_of(position, x.replication_factor).collect()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> layout/manager.rs:85:6 [INFO] [stdout] | [INFO] [stdout] 39 | system_endpoint: Arc>, [INFO] [stdout] | ------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | peering: Arc, [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | Err(e) => { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 75 | let layout = Arc::new(RwLock::new(cluster_layout)); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 76 | let change_notify = Arc::new(Notify::new()); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 77 | [INFO] [stdout] 78 | let rpc_helper = RpcHelper::new( [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 85 | Ok(Arc::new(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 86 | | node_id: node_id.into(), [INFO] [stdout] 87 | | replication_factor, [INFO] [stdout] 88 | | persist_cluster_layout, [INFO] [stdout] ... | [INFO] [stdout] 93 | | rpc_helper, [INFO] [stdout] 94 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> layout/manager.rs:270:49 [INFO] [stdout] | [INFO] [stdout] 269 | let this = self.clone(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 270 | async move { this.pull_cluster_layout(from).await } [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> layout/manager.rs:275:58 [INFO] [stdout] | [INFO] [stdout] 274 | let this = self.clone(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 275 | async move { this.pull_cluster_layout_trackers(from).await } [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> layout/manager.rs:350:20 [INFO] [stdout] | [INFO] [stdout] 347 | fn new(version: u64, layout_manager: &Arc, value: T) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 350 | layout_manager: layout_manager.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> system.rs:478:16 [INFO] [stdout] | [INFO] [stdout] 478 | .all(|set| set.filter(|x| node_up(x)).count() >= quorum); [INFO] [stdout] | --- ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `garage_rpc` (lib test) due to 32 previous errors [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> rpc_helper.rs:147:8 [INFO] [stdout] | [INFO] [stdout] 141 | peering: Arc, [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 142 | layout: Arc>, [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 145 | let metrics = RpcMetrics::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 146 | [INFO] [stdout] 147 | Self(Arc::new(RpcHelperInner { [INFO] [stdout] | ______________^ [INFO] [stdout] 148 | | our_node_id, [INFO] [stdout] 149 | | peering, [INFO] [stdout] 150 | | layout, [INFO] [stdout] 151 | | metrics, [INFO] [stdout] 152 | | rpc_timeout: rpc_timeout.unwrap_or(DEFAULT_TIMEOUT), [INFO] [stdout] 153 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> rpc_helper.rs:240:40 [INFO] [stdout] | [INFO] [stdout] 240 | .map(|to| self.call(endpoint, *to, msg.clone(), strat.clone())), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> rpc_helper.rs:360:59 [INFO] [stdout] | [INFO] [stdout] 356 | let self2 = self.clone(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 357 | let msg = msg.clone(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 358 | let endpoint2 = endpoint.clone(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 359 | let strategy = strategy.clone(); [INFO] [stdout] 360 | async move { self2.call(&endpoint2, to, msg, strategy).await } [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> rpc_helper.rs:497:22 [INFO] [stdout] | [INFO] [stdout] 492 | let self2 = self.clone(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 493 | let msg = msg.clone(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 494 | let endpoint2 = endpoint.clone(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 497 | async move { (to, self2.call(&endpoint2, to, msg, strategy).await) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> rpc_helper.rs:691:3 [INFO] [stdout] | [INFO] [stdout] 690 | pub fn success_values(self) -> Vec { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 691 | / self.successes [INFO] [stdout] 692 | | .into_iter() [INFO] [stdout] 693 | | .map(|(_, x)| x) [INFO] [stdout] | |____________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 31 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `garage_rpc` (lib) due to 32 previous errors [INFO] running `Command { std: "docker" "inspect" "a322c1a1af4a968b5a47d2638926cd454527ceac6f2aa255dead7daef21aff46", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a322c1a1af4a968b5a47d2638926cd454527ceac6f2aa255dead7daef21aff46", kill_on_drop: false }` [INFO] [stdout] a322c1a1af4a968b5a47d2638926cd454527ceac6f2aa255dead7daef21aff46