[INFO] fetching crate garage_net 1.0.0... [INFO] checking garage_net-1.0.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate garage_net 1.0.0 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate garage_net 1.0.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate garage_net 1.0.0 [INFO] finished tweaking crates.io crate garage_net 1.0.0 [INFO] tweaked toml for crates.io crate garage_net 1.0.0 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 115 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding dashmap v4.0.2 (latest: v6.0.1) [INFO] [stderr] Adding env_logger v0.10.2 (latest: v0.11.5) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding opentelemetry v0.17.0 (latest: v0.24.0) [INFO] [stderr] Adding opentelemetry-contrib v0.9.0 (latest: v0.16.0) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding synstructure v0.12.6 (latest: v0.13.1) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 18c00b4b5ced776b59fd1ad14f174cb86c680c15594d9bb926c8c1dd002704c3 [INFO] running `Command { std: "docker" "start" "-a" "18c00b4b5ced776b59fd1ad14f174cb86c680c15594d9bb926c8c1dd002704c3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "18c00b4b5ced776b59fd1ad14f174cb86c680c15594d9bb926c8c1dd002704c3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "18c00b4b5ced776b59fd1ad14f174cb86c680c15594d9bb926c8c1dd002704c3", kill_on_drop: false }` [INFO] [stdout] 18c00b4b5ced776b59fd1ad14f174cb86c680c15594d9bb926c8c1dd002704c3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 578887a5838dd2305cb98a330a5d4cd11fcbce37bf91c71f149e56660ac36214 [INFO] running `Command { std: "docker" "start" "-a" "578887a5838dd2305cb98a330a5d4cd11fcbce37bf91c71f149e56660ac36214", kill_on_drop: false }` [INFO] [stderr] Compiling same-file v1.0.6 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling err-derive v0.3.1 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking arc-swap v1.7.1 [INFO] [stderr] Checking pretty_env_logger v0.5.0 [INFO] [stderr] Compiling walkdir v2.5.0 [INFO] [stderr] Compiling libsodium-sys v0.2.7 [INFO] [stderr] Checking rmp v0.8.14 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Compiling async-trait v0.1.81 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking tokio-stream v0.1.15 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking rmp-serde v1.3.0 [INFO] [stderr] Checking kuska-sodiumoxide v0.2.5-0 [INFO] [stderr] Checking kuska-handshake v0.2.0 [INFO] [stderr] Checking garage_net v1.0.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> bytes_buf.rs:133:12 [INFO] [stdout] | [INFO] [stdout] 131 | pub fn into_stream(self) -> ByteStream { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 132 | use futures::stream::StreamExt; [INFO] [stdout] 133 | Box::pin(futures::stream::iter(self.buf).map(|x| Ok(x))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> stream.rs:41:9 [INFO] [stdout] | [INFO] [stdout] 38 | pub fn new(stream: ByteStream) -> Self { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 41 | buf: BytesBuf::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> stream.rs:43:9 [INFO] [stdout] | [INFO] [stdout] 38 | pub fn new(stream: ByteStream) -> Self { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 43 | err: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> stream.rs:196:11 [INFO] [stdout] | [INFO] [stdout] 195 | pub fn asyncread_stream(reader: R) -> ByteStream { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 196 | Box::pin(tokio_util::io::ReaderStream::new(reader)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> endpoint.rs:55:76 [INFO] [stdout] | [INFO] [stdout] 55 | async fn handle(self: &Arc, mut m: Req, from: NodeID) -> Resp { [INFO] [stdout] | ___________________________________________---------___________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | | // Immediately drop stream to ignore all data that comes in, [INFO] [stdout] 57 | | // instead of buffering it indefinitely [INFO] [stdout] 58 | | drop(m.take_stream()); [INFO] [stdout] 59 | | Resp::new(EndpointHandler::handle(self, m.msg(), from).await) [INFO] [stdout] 60 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> endpoint.rs:96:13 [INFO] [stdout] | [INFO] [stdout] 91 | pub(crate) fn new(netapp: Arc, path: String) -> Self { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 96 | handler: ArcSwapOption::from(None), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> endpoint.rs:183:82 [INFO] [stdout] | [INFO] [stdout] 183 | async fn handle(&self, req_enc: ReqEnc, from: NodeID) -> Result { [INFO] [stdout] | ____________________________---------------__________________________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 184 | | match self.0.handler.load_full() { [INFO] [stdout] 185 | | None => Err(Error::NoHandler), [INFO] [stdout] 186 | | Some(h) => { [INFO] [stdout] ... | [INFO] [stdout] 191 | | } [INFO] [stdout] 192 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> message.rs:117:6 [INFO] [stdout] | [INFO] [stdout] 116 | pub fn new(v: M) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 117 | Ok(v.into_req()?) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> message.rs:124:12 [INFO] [stdout] | [INFO] [stdout] 122 | pub fn with_stream_from_buffer(self, b: Bytes) -> Self { [INFO] [stdout] | ---- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 123 | Self { [INFO] [stdout] 124 | stream: AttachedStream::Fixed(b), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> message.rs:135:12 [INFO] [stdout] | [INFO] [stdout] 133 | pub fn with_stream(self, b: ByteStream) -> Self { [INFO] [stdout] | ---- ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 134 | Self { [INFO] [stdout] 135 | stream: AttachedStream::Stream(b), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> message.rs:169:9 [INFO] [stdout] | [INFO] [stdout] 160 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 161 | prio: RequestPriority, [INFO] [stdout] 162 | path: Bytes, [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 163 | telemetry_id: Bytes, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 169 | msg: self.msg_ser.unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> message.rs:170:12 [INFO] [stdout] | [INFO] [stdout] 160 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 161 | prio: RequestPriority, [INFO] [stdout] 162 | path: Bytes, [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 163 | telemetry_id: Bytes, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 170 | stream: self.stream.into_stream(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> message.rs:177:6 [INFO] [stdout] | [INFO] [stdout] 175 | pub(crate) fn from_enc(enc: ReqEnc) -> Result { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 176 | let msg = rmp_serde::decode::from_slice(&enc.msg)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 177 | Ok(Req { [INFO] [stdout] | ____________^ [INFO] [stdout] 178 | | msg: Arc::new(msg), [INFO] [stdout] 179 | | msg_ser: Some(enc.msg), [INFO] [stdout] 180 | | stream: enc [INFO] [stdout] ... | [INFO] [stdout] 184 | | order_tag: enc.order_tag, [INFO] [stdout] 185 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> message.rs:203:6 [INFO] [stdout] | [INFO] [stdout] 201 | fn into_req(self) -> Result, rmp_serde::encode::Error> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 202 | let msg_ser = rmp_to_vec_all_named(&self)?; [INFO] [stdout] 203 | Ok(Req { [INFO] [stdout] | ____________^ [INFO] [stdout] 204 | | msg: Arc::new(self), [INFO] [stdout] 205 | | msg_ser: Some(Bytes::from(msg_ser)), [INFO] [stdout] 206 | | stream: AttachedStream::None, [INFO] [stdout] 207 | | order_tag: None, [INFO] [stdout] 208 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> message.rs:212:9 [INFO] [stdout] | [INFO] [stdout] 210 | fn into_req_local(self) -> Req { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 211 | Req { [INFO] [stdout] 212 | msg: Arc::new(self), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> message.rs:213:13 [INFO] [stdout] | [INFO] [stdout] 210 | fn into_req_local(self) -> Req { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 213 | msg_ser: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> message.rs:214:12 [INFO] [stdout] | [INFO] [stdout] 210 | fn into_req_local(self) -> Req { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 214 | stream: AttachedStream::None, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> message.rs:239:9 [INFO] [stdout] | [INFO] [stdout] 231 | let stream = match &self.stream { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 239 | msg: self.msg.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> message.rs:240:13 [INFO] [stdout] | [INFO] [stdout] 231 | let stream = match &self.stream { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 240 | msg_ser: self.msg_ser.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> message.rs:278:12 [INFO] [stdout] | [INFO] [stdout] 274 | pub fn new(v: M::Response) -> Self { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 278 | stream: AttachedStream::None, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> message.rs:287:12 [INFO] [stdout] | [INFO] [stdout] 285 | pub fn with_stream_from_buffer(self, b: Bytes) -> Self { [INFO] [stdout] | ---- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 286 | Self { [INFO] [stdout] 287 | stream: AttachedStream::Fixed(b), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> message.rs:296:12 [INFO] [stdout] | [INFO] [stdout] 294 | pub fn with_stream(self, b: ByteStream) -> Self { [INFO] [stdout] | ---- ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 295 | Self { [INFO] [stdout] 296 | stream: AttachedStream::Stream(b), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> message.rs:325:14 [INFO] [stdout] | [INFO] [stdout] 324 | pub fn into_parts(self) -> (M::Response, Option) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 325 | (self.msg, self.stream.into_stream()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> message.rs:329:6 [INFO] [stdout] | [INFO] [stdout] 328 | pub(crate) fn into_enc(self) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 329 | Ok(RespEnc { [INFO] [stdout] | ____________^ [INFO] [stdout] 330 | | msg: rmp_to_vec_all_named(&self.msg)?.into(), [INFO] [stdout] 331 | | stream: self.stream.into_stream(), [INFO] [stdout] 332 | | order_tag: self.order_tag, [INFO] [stdout] 333 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> message.rs:338:6 [INFO] [stdout] | [INFO] [stdout] 336 | pub(crate) fn from_enc(enc: RespEnc) -> Result { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 337 | let msg = rmp_serde::decode::from_slice(&enc.msg)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 338 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 339 | | _phantom: Default::default(), [INFO] [stdout] 340 | | msg, [INFO] [stdout] 341 | | stream: enc [INFO] [stdout] ... | [INFO] [stdout] 345 | | order_tag: enc.order_tag, [INFO] [stdout] 346 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> client.rs:252:12 [INFO] [stdout] | [INFO] [stdout] 250 | fn for_stream(self, stream: ByteStream) -> CancelOnDropStream { [INFO] [stdout] | ---- ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 251 | CancelOnDropStream { [INFO] [stdout] 252 | cancel: Some(self), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> recv.rs:23:19 [INFO] [stdout] | [INFO] [stdout] 22 | fn new(inner: mpsc::UnboundedSender) -> Self { [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 23 | Sender { inner: Some(inner) } [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> recv.rs:61:2 [INFO] [stdout] | [INFO] [stdout] 58 | async fn recv_loop(self: Arc, mut read: R, debug_name: String) -> Result<(), Error> [INFO] [stdout] | ---- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 61 | / { [INFO] [stdout] 62 | | let mut streams: HashMap = HashMap::new(); [INFO] [stdout] 63 | | loop { [INFO] [stdout] 64 | | trace!( [INFO] [stdout] ... | [INFO] [stdout] 151 | | Ok(()) [INFO] [stdout] 152 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> send.rs:286:2 [INFO] [stdout] | [INFO] [stdout] 279 | self: Arc, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 280 | msg_recv: mpsc::UnboundedReceiver, [INFO] [stdout] | ------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 281 | mut write: BoxStreamWrite, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 286 | / { [INFO] [stdout] 287 | | let mut sending = SendQueue::new(); [INFO] [stdout] 288 | | let mut msg_recv = Some(msg_recv); [INFO] [stdout] 289 | | while msg_recv.is_some() || !sending.is_empty() { [INFO] [stdout] ... | [INFO] [stdout] 359 | | Ok(()) [INFO] [stdout] 360 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 29 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `garage_net` (lib test) due to 30 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> bytes_buf.rs:133:12 [INFO] [stdout] | [INFO] [stdout] 131 | pub fn into_stream(self) -> ByteStream { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 132 | use futures::stream::StreamExt; [INFO] [stdout] 133 | Box::pin(futures::stream::iter(self.buf).map(|x| Ok(x))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> stream.rs:41:9 [INFO] [stdout] | [INFO] [stdout] 38 | pub fn new(stream: ByteStream) -> Self { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 41 | buf: BytesBuf::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> stream.rs:43:9 [INFO] [stdout] | [INFO] [stdout] 38 | pub fn new(stream: ByteStream) -> Self { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 43 | err: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> stream.rs:196:11 [INFO] [stdout] | [INFO] [stdout] 195 | pub fn asyncread_stream(reader: R) -> ByteStream { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 196 | Box::pin(tokio_util::io::ReaderStream::new(reader)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> endpoint.rs:55:76 [INFO] [stdout] | [INFO] [stdout] 55 | async fn handle(self: &Arc, mut m: Req, from: NodeID) -> Resp { [INFO] [stdout] | ___________________________________________---------___________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | | // Immediately drop stream to ignore all data that comes in, [INFO] [stdout] 57 | | // instead of buffering it indefinitely [INFO] [stdout] 58 | | drop(m.take_stream()); [INFO] [stdout] 59 | | Resp::new(EndpointHandler::handle(self, m.msg(), from).await) [INFO] [stdout] 60 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> endpoint.rs:96:13 [INFO] [stdout] | [INFO] [stdout] 91 | pub(crate) fn new(netapp: Arc, path: String) -> Self { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 96 | handler: ArcSwapOption::from(None), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> endpoint.rs:183:82 [INFO] [stdout] | [INFO] [stdout] 183 | async fn handle(&self, req_enc: ReqEnc, from: NodeID) -> Result { [INFO] [stdout] | ____________________________---------------__________________________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 184 | | match self.0.handler.load_full() { [INFO] [stdout] 185 | | None => Err(Error::NoHandler), [INFO] [stdout] 186 | | Some(h) => { [INFO] [stdout] ... | [INFO] [stdout] 191 | | } [INFO] [stdout] 192 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> message.rs:117:6 [INFO] [stdout] | [INFO] [stdout] 116 | pub fn new(v: M) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 117 | Ok(v.into_req()?) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> message.rs:124:12 [INFO] [stdout] | [INFO] [stdout] 122 | pub fn with_stream_from_buffer(self, b: Bytes) -> Self { [INFO] [stdout] | ---- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 123 | Self { [INFO] [stdout] 124 | stream: AttachedStream::Fixed(b), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> message.rs:135:12 [INFO] [stdout] | [INFO] [stdout] 133 | pub fn with_stream(self, b: ByteStream) -> Self { [INFO] [stdout] | ---- ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 134 | Self { [INFO] [stdout] 135 | stream: AttachedStream::Stream(b), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> message.rs:169:9 [INFO] [stdout] | [INFO] [stdout] 160 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 161 | prio: RequestPriority, [INFO] [stdout] 162 | path: Bytes, [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 163 | telemetry_id: Bytes, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 169 | msg: self.msg_ser.unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> message.rs:170:12 [INFO] [stdout] | [INFO] [stdout] 160 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 161 | prio: RequestPriority, [INFO] [stdout] 162 | path: Bytes, [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 163 | telemetry_id: Bytes, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 170 | stream: self.stream.into_stream(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> message.rs:177:6 [INFO] [stdout] | [INFO] [stdout] 175 | pub(crate) fn from_enc(enc: ReqEnc) -> Result { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 176 | let msg = rmp_serde::decode::from_slice(&enc.msg)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 177 | Ok(Req { [INFO] [stdout] | ____________^ [INFO] [stdout] 178 | | msg: Arc::new(msg), [INFO] [stdout] 179 | | msg_ser: Some(enc.msg), [INFO] [stdout] 180 | | stream: enc [INFO] [stdout] ... | [INFO] [stdout] 184 | | order_tag: enc.order_tag, [INFO] [stdout] 185 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> message.rs:203:6 [INFO] [stdout] | [INFO] [stdout] 201 | fn into_req(self) -> Result, rmp_serde::encode::Error> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 202 | let msg_ser = rmp_to_vec_all_named(&self)?; [INFO] [stdout] 203 | Ok(Req { [INFO] [stdout] | ____________^ [INFO] [stdout] 204 | | msg: Arc::new(self), [INFO] [stdout] 205 | | msg_ser: Some(Bytes::from(msg_ser)), [INFO] [stdout] 206 | | stream: AttachedStream::None, [INFO] [stdout] 207 | | order_tag: None, [INFO] [stdout] 208 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> message.rs:212:9 [INFO] [stdout] | [INFO] [stdout] 210 | fn into_req_local(self) -> Req { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 211 | Req { [INFO] [stdout] 212 | msg: Arc::new(self), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> message.rs:213:13 [INFO] [stdout] | [INFO] [stdout] 210 | fn into_req_local(self) -> Req { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 213 | msg_ser: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> message.rs:214:12 [INFO] [stdout] | [INFO] [stdout] 210 | fn into_req_local(self) -> Req { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 214 | stream: AttachedStream::None, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> message.rs:239:9 [INFO] [stdout] | [INFO] [stdout] 231 | let stream = match &self.stream { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 239 | msg: self.msg.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> message.rs:240:13 [INFO] [stdout] | [INFO] [stdout] 231 | let stream = match &self.stream { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 240 | msg_ser: self.msg_ser.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> message.rs:278:12 [INFO] [stdout] | [INFO] [stdout] 274 | pub fn new(v: M::Response) -> Self { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 278 | stream: AttachedStream::None, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> message.rs:287:12 [INFO] [stdout] | [INFO] [stdout] 285 | pub fn with_stream_from_buffer(self, b: Bytes) -> Self { [INFO] [stdout] | ---- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 286 | Self { [INFO] [stdout] 287 | stream: AttachedStream::Fixed(b), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> message.rs:296:12 [INFO] [stdout] | [INFO] [stdout] 294 | pub fn with_stream(self, b: ByteStream) -> Self { [INFO] [stdout] | ---- ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 295 | Self { [INFO] [stdout] 296 | stream: AttachedStream::Stream(b), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> message.rs:325:14 [INFO] [stdout] | [INFO] [stdout] 324 | pub fn into_parts(self) -> (M::Response, Option) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 325 | (self.msg, self.stream.into_stream()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> message.rs:329:6 [INFO] [stdout] | [INFO] [stdout] 328 | pub(crate) fn into_enc(self) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 329 | Ok(RespEnc { [INFO] [stdout] | ____________^ [INFO] [stdout] 330 | | msg: rmp_to_vec_all_named(&self.msg)?.into(), [INFO] [stdout] 331 | | stream: self.stream.into_stream(), [INFO] [stdout] 332 | | order_tag: self.order_tag, [INFO] [stdout] 333 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> message.rs:338:6 [INFO] [stdout] | [INFO] [stdout] 336 | pub(crate) fn from_enc(enc: RespEnc) -> Result { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 337 | let msg = rmp_serde::decode::from_slice(&enc.msg)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 338 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 339 | | _phantom: Default::default(), [INFO] [stdout] 340 | | msg, [INFO] [stdout] 341 | | stream: enc [INFO] [stdout] ... | [INFO] [stdout] 345 | | order_tag: enc.order_tag, [INFO] [stdout] 346 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> client.rs:252:12 [INFO] [stdout] | [INFO] [stdout] 250 | fn for_stream(self, stream: ByteStream) -> CancelOnDropStream { [INFO] [stdout] | ---- ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 251 | CancelOnDropStream { [INFO] [stdout] 252 | cancel: Some(self), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> recv.rs:23:19 [INFO] [stdout] | [INFO] [stdout] 22 | fn new(inner: mpsc::UnboundedSender) -> Self { [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 23 | Sender { inner: Some(inner) } [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> recv.rs:61:2 [INFO] [stdout] | [INFO] [stdout] 58 | async fn recv_loop(self: Arc, mut read: R, debug_name: String) -> Result<(), Error> [INFO] [stdout] | ---- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 61 | / { [INFO] [stdout] 62 | | let mut streams: HashMap = HashMap::new(); [INFO] [stdout] 63 | | loop { [INFO] [stdout] 64 | | trace!( [INFO] [stdout] ... | [INFO] [stdout] 151 | | Ok(()) [INFO] [stdout] 152 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> send.rs:286:2 [INFO] [stdout] | [INFO] [stdout] 279 | self: Arc, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 280 | msg_recv: mpsc::UnboundedReceiver, [INFO] [stdout] | ------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 281 | mut write: BoxStreamWrite, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 286 | / { [INFO] [stdout] 287 | | let mut sending = SendQueue::new(); [INFO] [stdout] 288 | | let mut msg_recv = Some(msg_recv); [INFO] [stdout] 289 | | while msg_recv.is_some() || !sending.is_empty() { [INFO] [stdout] ... | [INFO] [stdout] 359 | | Ok(()) [INFO] [stdout] 360 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 29 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `garage_net` (lib) due to 30 previous errors [INFO] running `Command { std: "docker" "inspect" "578887a5838dd2305cb98a330a5d4cd11fcbce37bf91c71f149e56660ac36214", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "578887a5838dd2305cb98a330a5d4cd11fcbce37bf91c71f149e56660ac36214", kill_on_drop: false }` [INFO] [stdout] 578887a5838dd2305cb98a330a5d4cd11fcbce37bf91c71f149e56660ac36214