[INFO] fetching crate garage_model 1.0.0... [INFO] checking garage_model-1.0.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate garage_model 1.0.0 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate garage_model 1.0.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate garage_model 1.0.0 [INFO] finished tweaking crates.io crate garage_model 1.0.0 [INFO] tweaked toml for crates.io crate garage_model 1.0.0 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 222 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding arrayvec v0.5.2 (latest: v0.7.6) [INFO] [stderr] Adding base64 v0.21.7 (latest: v0.22.1) [INFO] [stderr] Adding dashmap v4.0.2 (latest: v6.0.1) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding gethostname v0.4.3 (latest: v0.5.0) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding heed v0.11.0 (latest: v0.20.5) [INFO] [stderr] Adding heed-traits v0.8.0 (latest: v0.20.0) [INFO] [stderr] Adding heed-types v0.8.0 (latest: v0.20.1) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding idna v0.5.0 (latest: v1.0.2) [INFO] [stderr] Adding itertools v0.12.1 (latest: v0.13.0) [INFO] [stderr] Adding libsqlite3-sys v0.28.0 (latest: v0.30.1) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding nix v0.27.1 (latest: v0.29.0) [INFO] [stderr] Adding num v0.2.1 (latest: v0.4.3) [INFO] [stderr] Adding num-bigint v0.2.6 (latest: v0.4.6) [INFO] [stderr] Adding num-complex v0.2.4 (latest: v0.4.6) [INFO] [stderr] Adding num-rational v0.2.4 (latest: v0.4.2) [INFO] [stderr] Adding opentelemetry v0.17.0 (latest: v0.24.0) [INFO] [stderr] Adding page_size v0.4.2 (latest: v0.6.0) [INFO] [stderr] Adding pnet_base v0.34.0 (latest: v0.35.0) [INFO] [stderr] Adding pnet_datalink v0.34.0 (latest: v0.35.0) [INFO] [stderr] Adding pnet_sys v0.34.0 (latest: v0.35.0) [INFO] [stderr] Adding r2d2_sqlite v0.24.0 (latest: v0.25.0) [INFO] [stderr] Adding rusqlite v0.31.0 (latest: v0.32.1) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding synstructure v0.12.6 (latest: v0.13.1) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] [stderr] Adding windows-targets v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_gnullvm v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_gnu v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnu v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnullvm v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_msvc v0.48.5 (latest: v0.52.6) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d7d83163055e6ceaaa60850fcf8e3e3948deb33faaf079439df65632402a80bc [INFO] running `Command { std: "docker" "start" "-a" "d7d83163055e6ceaaa60850fcf8e3e3948deb33faaf079439df65632402a80bc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d7d83163055e6ceaaa60850fcf8e3e3948deb33faaf079439df65632402a80bc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d7d83163055e6ceaaa60850fcf8e3e3948deb33faaf079439df65632402a80bc", kill_on_drop: false }` [INFO] [stdout] d7d83163055e6ceaaa60850fcf8e3e3948deb33faaf079439df65632402a80bc [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 386cc70affeccb9419944bb4cd81df9b6137a50b4a2626908c08fbf3dd429720 [INFO] running `Command { std: "docker" "start" "-a" "386cc70affeccb9419944bb4cd81df9b6137a50b4a2626908c08fbf3dd429720", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Checking ahash v0.8.11 [INFO] [stderr] Compiling walkdir v2.5.0 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Compiling libsqlite3-sys v0.28.0 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Compiling err-derive v0.3.1 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Checking scheduled-thread-pool v0.2.7 [INFO] [stderr] Checking crossbeam-queue v0.3.11 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Checking bytemuck v1.17.1 [INFO] [stderr] Compiling jobserver v0.1.32 [INFO] [stderr] Checking fallible-iterator v0.3.0 [INFO] [stderr] Checking heed-traits v0.8.0 [INFO] [stderr] Checking fallible-streaming-iterator v0.1.9 [INFO] [stderr] Checking hashlink v0.9.1 [INFO] [stderr] Compiling cc v1.1.15 [INFO] [stderr] Checking indexmap v2.5.0 [INFO] [stderr] Checking rusqlite v0.31.0 [INFO] [stderr] Checking synchronoise v1.0.1 [INFO] [stderr] Checking rmp v0.8.14 [INFO] [stderr] Checking r2d2 v0.8.10 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking uuid v1.10.0 [INFO] [stderr] Checking page_size v0.4.2 [INFO] [stderr] Checking winnow v0.6.18 [INFO] [stderr] Checking arrayvec v0.5.2 [INFO] [stderr] Checking dashmap v4.0.2 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking hexdump v0.1.2 [INFO] [stderr] Compiling garage_util v1.0.0 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Compiling num-bigint v0.2.6 [INFO] [stderr] Checking r2d2_sqlite v0.24.0 [INFO] [stderr] Compiling zstd-safe v7.2.1 [INFO] [stderr] Checking no-std-net v0.6.0 [INFO] [stderr] Checking arc-swap v1.7.1 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking pnet_base v0.34.0 [INFO] [stderr] Checking blake2 v0.10.6 [INFO] [stderr] Compiling libsodium-sys v0.2.7 [INFO] [stderr] Compiling lmdb-rkv-sys v0.11.2 [INFO] [stderr] Compiling zstd-sys v2.0.13+zstd.1.5.6 [INFO] [stderr] Checking pnet_sys v0.34.0 [INFO] [stderr] Compiling num-rational v0.2.4 [INFO] [stderr] Compiling num-complex v0.2.4 [INFO] [stderr] Checking xxhash-rust v0.8.12 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking toml_datetime v0.6.8 [INFO] [stderr] Checking serde_spanned v0.6.7 [INFO] [stderr] Checking rmp-serde v1.3.0 [INFO] [stderr] Checking toml_edit v0.22.20 [INFO] [stderr] Checking ipnetwork v0.20.0 [INFO] [stderr] Checking itertools v0.12.1 [INFO] [stderr] Checking pnet_datalink v0.34.0 [INFO] [stderr] Checking tokio-stream v0.1.15 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking heed-types v0.8.0 [INFO] [stderr] Checking hyper v1.4.1 [INFO] [stderr] Checking serde_bytes v0.11.15 [INFO] [stderr] Checking heed v0.11.0 [INFO] [stderr] Checking nix v0.27.1 [INFO] [stderr] Checking opentelemetry v0.17.0 [INFO] [stderr] Checking garage_db v1.0.0 [INFO] [stderr] Checking gethostname v0.4.3 [INFO] [stderr] Checking format_table v0.1.1 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking toml v0.8.19 [INFO] [stderr] Checking num v0.2.1 [INFO] [stderr] Checking parse_duration v2.1.1 [INFO] [stderr] Checking zstd v0.13.2 [INFO] [stderr] Checking async-compression v0.4.12 [INFO] [stderr] Checking kuska-sodiumoxide v0.2.5-0 [INFO] [stderr] Checking kuska-handshake v0.2.0 [INFO] [stderr] Checking garage_net v1.0.0 [INFO] [stderr] Checking garage_rpc v1.0.0 [INFO] [stderr] Checking garage_table v1.0.0 [INFO] [stderr] Checking garage_block v1.0.0 [INFO] [stderr] Checking garage_model v1.0.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: use of deprecated method `chrono::NaiveDateTime::timestamp_millis`: use `.and_utc().timestamp_millis()` instead [INFO] [stdout] --> s3/lifecycle_worker.rs:391:4 [INFO] [stdout] | [INFO] [stdout] 391 | .timestamp_millis() as u64 [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `chrono::NaiveDateTime::from_timestamp_millis`: use `DateTime::from_timestamp_millis` instead [INFO] [stdout] --> s3/lifecycle_worker.rs:395:17 [INFO] [stdout] | [INFO] [stdout] 395 | NaiveDateTime::from_timestamp_millis(ts as i64) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `chrono::NaiveDateTime::timestamp_millis`: use `.and_utc().timestamp_millis()` instead [INFO] [stdout] --> s3/lifecycle_worker.rs:391:4 [INFO] [stdout] | [INFO] [stdout] 391 | .timestamp_millis() as u64 [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `chrono::NaiveDateTime::from_timestamp_millis`: use `DateTime::from_timestamp_millis` instead [INFO] [stdout] --> s3/lifecycle_worker.rs:395:17 [INFO] [stdout] | [INFO] [stdout] 395 | NaiveDateTime::from_timestamp_millis(ts as i64) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `1` is never read [INFO] [stdout] --> helper/locked.rs:30:2 [INFO] [stdout] | [INFO] [stdout] 28 | pub struct LockedHelper<'a>( [INFO] [stdout] | ------------ field in this struct [INFO] [stdout] 29 | pub(crate) &'a Garage, [INFO] [stdout] 30 | pub(crate) tokio::sync::MutexGuard<'a, ()>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider removing this field [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> index_counter.rs:177:12 [INFO] [stdout] | [INFO] [stdout] 173 | system: Arc, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 174 | replication: TableShardedReplication, [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 177 | Arc::new(Self { [INFO] [stdout] | __________________^ [INFO] [stdout] 178 | | this_node: system.id, [INFO] [stdout] 179 | | local_counter: db [INFO] [stdout] 180 | | .open_tree(format!("local_counter_v2:{}", T::COUNTER_TABLE_NAME)) [INFO] [stdout] ... | [INFO] [stdout] 189 | | ), [INFO] [stdout] 190 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> s3/block_ref_table.rs:96:11 [INFO] [stdout] | [INFO] [stdout] 95 | let table = Arc::downgrade(block_ref_table); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 96 | Box::new(move |tx: &db::Transaction, block: &Hash| { [INFO] [stdout] | ______________^ [INFO] [stdout] 97 | | let table = table [INFO] [stdout] 98 | | .upgrade() [INFO] [stdout] 99 | | .ok_or_message("cannot upgrade weak ptr to block_ref_table") [INFO] [stdout] 100 | | .map_err(db::TxError::Abort)?; [INFO] [stdout] 101 | | Ok(calculate_refcount(&table, tx, block)?) [INFO] [stdout] 102 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> garage.rs:259:6 [INFO] [stdout] | [INFO] [stdout] 135 | let db = db::open_db(&db_path, db_engine, &db_opt) [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 139 | let network_key = hex::decode(config.rpc_secret.as_ref().ok_or_message( [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 149 | let mut bg_vars = vars::BgVars::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 152 | let system = System::new(network_key, replication_factor, consistency_mode, &config)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 153 | [INFO] [stdout] 154 | let data_rep_param = TableShardedReplication { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 161 | let meta_rep_param = TableShardedReplication { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 168 | let control_rep_param = TableFullReplication { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 173 | let block_manager = BlockManager::new(&db, &config, data_rep_param, system.clone())?; [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 178 | let bucket_table = Table::new(BucketTable, control_rep_param.clone(), system.clone(), &db); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 181 | let bucket_alias_table = Table::new( [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 188 | let key_table = Table::new(KeyTable, control_rep_param, system.clone(), &db); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 192 | let block_ref_table = Table::new( [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 202 | let version_table = Table::new( [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 212 | let mpu_counter_table = IndexCounter::new(system.clone(), meta_rep_param.clone(), &db); [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 215 | let mpu_table = Table::new( [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 226 | let object_counter_table = IndexCounter::new(system.clone(), meta_rep_param.clone(), &db); [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 230 | let object_table = Table::new( [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 242 | let lifecycle_persister = [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 259 | Ok(Arc::new(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 260 | | config, [INFO] [stdout] 261 | | bg_vars, [INFO] [stdout] 262 | | replication_factor, [INFO] [stdout] ... | [INFO] [stdout] 278 | | k2v, [INFO] [stdout] 279 | | })) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> helper/error.rs:27:19 [INFO] [stdout] | [INFO] [stdout] 26 | fn from(e: garage_net::error::Error) -> Self { [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | Error::Internal(GarageError::Net(e)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `garage_model` (lib test) due to 5 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: field `1` is never read [INFO] [stdout] --> helper/locked.rs:30:2 [INFO] [stdout] | [INFO] [stdout] 28 | pub struct LockedHelper<'a>( [INFO] [stdout] | ------------ field in this struct [INFO] [stdout] 29 | pub(crate) &'a Garage, [INFO] [stdout] 30 | pub(crate) tokio::sync::MutexGuard<'a, ()>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider removing this field [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> index_counter.rs:177:12 [INFO] [stdout] | [INFO] [stdout] 173 | system: Arc, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 174 | replication: TableShardedReplication, [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 177 | Arc::new(Self { [INFO] [stdout] | __________________^ [INFO] [stdout] 178 | | this_node: system.id, [INFO] [stdout] 179 | | local_counter: db [INFO] [stdout] 180 | | .open_tree(format!("local_counter_v2:{}", T::COUNTER_TABLE_NAME)) [INFO] [stdout] ... | [INFO] [stdout] 189 | | ), [INFO] [stdout] 190 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> s3/block_ref_table.rs:96:11 [INFO] [stdout] | [INFO] [stdout] 95 | let table = Arc::downgrade(block_ref_table); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 96 | Box::new(move |tx: &db::Transaction, block: &Hash| { [INFO] [stdout] | ______________^ [INFO] [stdout] 97 | | let table = table [INFO] [stdout] 98 | | .upgrade() [INFO] [stdout] 99 | | .ok_or_message("cannot upgrade weak ptr to block_ref_table") [INFO] [stdout] 100 | | .map_err(db::TxError::Abort)?; [INFO] [stdout] 101 | | Ok(calculate_refcount(&table, tx, block)?) [INFO] [stdout] 102 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> garage.rs:259:6 [INFO] [stdout] | [INFO] [stdout] 135 | let db = db::open_db(&db_path, db_engine, &db_opt) [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 139 | let network_key = hex::decode(config.rpc_secret.as_ref().ok_or_message( [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 149 | let mut bg_vars = vars::BgVars::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 152 | let system = System::new(network_key, replication_factor, consistency_mode, &config)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 153 | [INFO] [stdout] 154 | let data_rep_param = TableShardedReplication { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 161 | let meta_rep_param = TableShardedReplication { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 168 | let control_rep_param = TableFullReplication { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 173 | let block_manager = BlockManager::new(&db, &config, data_rep_param, system.clone())?; [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 178 | let bucket_table = Table::new(BucketTable, control_rep_param.clone(), system.clone(), &db); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 181 | let bucket_alias_table = Table::new( [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 188 | let key_table = Table::new(KeyTable, control_rep_param, system.clone(), &db); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 192 | let block_ref_table = Table::new( [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 202 | let version_table = Table::new( [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 212 | let mpu_counter_table = IndexCounter::new(system.clone(), meta_rep_param.clone(), &db); [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 215 | let mpu_table = Table::new( [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 226 | let object_counter_table = IndexCounter::new(system.clone(), meta_rep_param.clone(), &db); [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 230 | let object_table = Table::new( [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 242 | let lifecycle_persister = [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 259 | Ok(Arc::new(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 260 | | config, [INFO] [stdout] 261 | | bg_vars, [INFO] [stdout] 262 | | replication_factor, [INFO] [stdout] ... | [INFO] [stdout] 278 | | k2v, [INFO] [stdout] 279 | | })) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> helper/error.rs:27:19 [INFO] [stdout] | [INFO] [stdout] 26 | fn from(e: garage_net::error::Error) -> Self { [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | Error::Internal(GarageError::Net(e)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `garage_model` (lib) due to 5 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "386cc70affeccb9419944bb4cd81df9b6137a50b4a2626908c08fbf3dd429720", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "386cc70affeccb9419944bb4cd81df9b6137a50b4a2626908c08fbf3dd429720", kill_on_drop: false }` [INFO] [stdout] 386cc70affeccb9419944bb4cd81df9b6137a50b4a2626908c08fbf3dd429720