[INFO] fetching crate garage_block 1.0.0... [INFO] checking garage_block-1.0.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate garage_block 1.0.0 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate garage_block 1.0.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate garage_block 1.0.0 [INFO] finished tweaking crates.io crate garage_block 1.0.0 [INFO] tweaked toml for crates.io crate garage_block 1.0.0 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 176 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding arrayvec v0.5.2 (latest: v0.7.6) [INFO] [stderr] Adding dashmap v4.0.2 (latest: v6.0.1) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding gethostname v0.4.3 (latest: v0.5.0) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding itertools v0.12.1 (latest: v0.13.0) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding nix v0.27.1 (latest: v0.29.0) [INFO] [stderr] Adding opentelemetry v0.17.0 (latest: v0.24.0) [INFO] [stderr] Adding pnet_base v0.34.0 (latest: v0.35.0) [INFO] [stderr] Adding pnet_datalink v0.34.0 (latest: v0.35.0) [INFO] [stderr] Adding pnet_sys v0.34.0 (latest: v0.35.0) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding synstructure v0.12.6 (latest: v0.13.1) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] [stderr] Adding windows-targets v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_gnullvm v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_gnu v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnu v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnullvm v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_msvc v0.48.5 (latest: v0.52.6) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 441374db46b7659d3ad7dc6330ddefb7202584281487a38a8e74057102e27671 [INFO] running `Command { std: "docker" "start" "-a" "441374db46b7659d3ad7dc6330ddefb7202584281487a38a8e74057102e27671", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "441374db46b7659d3ad7dc6330ddefb7202584281487a38a8e74057102e27671", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "441374db46b7659d3ad7dc6330ddefb7202584281487a38a8e74057102e27671", kill_on_drop: false }` [INFO] [stdout] 441374db46b7659d3ad7dc6330ddefb7202584281487a38a8e74057102e27671 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9e42eebfaa0f963204f5ef63ba319498cc91cfffe6ada948fff30ba0d25defc9 [INFO] running `Command { std: "docker" "start" "-a" "9e42eebfaa0f963204f5ef63ba319498cc91cfffe6ada948fff30ba0d25defc9", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling version_check v0.9.5 [INFO] [stderr] Compiling autocfg v1.3.0 [INFO] [stderr] Compiling shlex v1.3.0 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Checking pin-project-lite v0.2.14 [INFO] [stderr] Compiling pkg-config v0.3.30 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Checking bytes v1.7.1 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Compiling typenum v1.17.0 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Compiling same-file v1.0.6 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling rustversion v1.0.17 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Compiling walkdir v2.5.0 [INFO] [stderr] Checking pin-utils v0.1.0 [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling paste v1.0.15 [INFO] [stderr] Checking itoa v1.0.11 [INFO] [stderr] Compiling unicode-xid v0.2.5 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Checking subtle v2.6.1 [INFO] [stderr] Checking equivalent v1.0.1 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Checking arrayvec v0.5.2 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Compiling serde_json v1.0.127 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Compiling rustc_version v0.4.1 [INFO] [stderr] Checking winnow v0.6.18 [INFO] [stderr] Compiling jobserver v0.1.32 [INFO] [stderr] Checking hex v0.4.3 [INFO] [stderr] Compiling zstd-safe v7.2.1 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Checking hexdump v0.1.2 [INFO] [stderr] Compiling garage_util v1.0.0 [INFO] [stderr] Compiling cc v1.1.15 [INFO] [stderr] Checking percent-encoding v2.3.1 [INFO] [stderr] Checking ryu v1.0.18 [INFO] [stderr] Checking no-std-net v0.6.0 [INFO] [stderr] Compiling err-derive v0.3.1 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking arc-swap v1.7.1 [INFO] [stderr] Checking iana-time-zone v0.1.60 [INFO] [stderr] Checking indexmap v2.5.0 [INFO] [stderr] Checking cpufeatures v0.2.13 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking mio v1.0.2 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking crossbeam-channel v0.5.13 [INFO] [stderr] Checking pnet_sys v0.34.0 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking dashmap v4.0.2 [INFO] [stderr] Checking pnet_base v0.34.0 [INFO] [stderr] Checking rmp v0.8.14 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking bytesize v1.3.0 [INFO] [stderr] Checking xxhash-rust v0.8.12 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Checking itertools v0.12.1 [INFO] [stderr] Checking gethostname v0.4.3 [INFO] [stderr] Checking format_table v0.1.1 [INFO] [stderr] Checking nix v0.27.1 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Compiling libsodium-sys v0.2.7 [INFO] [stderr] Compiling zstd-sys v2.0.13+zstd.1.5.6 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking blake2 v0.10.6 [INFO] [stderr] Compiling synstructure v0.12.6 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling async-trait v0.1.81 [INFO] [stderr] Checking zstd v0.13.2 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking garage_db v1.0.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking tokio-stream v0.1.15 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking hyper v1.4.1 [INFO] [stderr] Checking async-compression v0.4.12 [INFO] [stderr] Checking opentelemetry v0.17.0 [INFO] [stderr] Checking toml_datetime v0.6.8 [INFO] [stderr] Checking serde_spanned v0.6.7 [INFO] [stderr] Checking rmp-serde v1.3.0 [INFO] [stderr] Checking ipnetwork v0.20.0 [INFO] [stderr] Checking serde_bytes v0.11.15 [INFO] [stderr] Checking pnet_datalink v0.34.0 [INFO] [stderr] Checking toml_edit v0.22.20 [INFO] [stderr] Checking toml v0.8.19 [INFO] [stderr] Checking kuska-sodiumoxide v0.2.5-0 [INFO] [stderr] Checking kuska-handshake v0.2.0 [INFO] [stderr] Checking garage_net v1.0.0 [INFO] [stderr] Checking garage_rpc v1.0.0 [INFO] [stderr] Checking garage_table v1.0.0 [INFO] [stderr] Checking garage_block v1.0.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> manager.rs:269:4 [INFO] [stdout] | [INFO] [stdout] 267 | self.rpc_get_raw_block_internal(hash, priority, order_tag, |block_stream| async move { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 268 | let (header, stream) = block_stream.into_parts(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 269 | / read_stream_to_end(stream) [INFO] [stdout] 270 | | .await [INFO] [stdout] 271 | | .err_context("error in block data stream") [INFO] [stdout] | |__________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> manager.rs:272:47 [INFO] [stdout] | [INFO] [stdout] 272 | .map(|data| DataBlock::from_parts(header, data.into_bytes())) [INFO] [stdout] | ---- ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> manager.rs:693:97 [INFO] [stdout] | [INFO] [stdout] 693 | async fn handle(self: &Arc, mut message: Req, _from: NodeID) -> Resp { [INFO] [stdout] | ___________________________________________----------------------___________________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 694 | | match message.msg() { [INFO] [stdout] 695 | | BlockRpc::PutBlock { hash, header } => Resp::new( [INFO] [stdout] 696 | | self.handle_put_block(*hash, *header, message.take_stream()) [INFO] [stdout] ... | [INFO] [stdout] 705 | | } [INFO] [stdout] 706 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> resync.rs:101:12 [INFO] [stdout] | [INFO] [stdout] 89 | let queue = db [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 93 | let errors = db [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 97 | let persister = PersisterShared::new(&system.metadata_dir, "resync_cfg"); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 101 | notify: Arc::new(Notify::new()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> resync.rs:103:14 [INFO] [stdout] | [INFO] [stdout] 89 | let queue = db [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 93 | let errors = db [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 97 | let persister = PersisterShared::new(&system.metadata_dir, "resync_cfg"); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 103 | busy_set: Arc::new(Mutex::new(HashSet::new())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> resync.rs:351:6 [INFO] [stdout] | [INFO] [stdout] 339 | let mut busy = self.busy_set.lock().unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 351 | Ok(None) [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> block.rs:92:21 [INFO] [stdout] | [INFO] [stdout] 85 | pub async fn from_buffer(data: Bytes, level: Option) -> DataBlock { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 92 | DataBlock::plain(data.into()) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> metrics.rs:42:24 [INFO] [stdout] | [INFO] [stdout] 35 | rc_tree: db::Tree, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | resync_queue: db::Tree, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | resync_errors: db::Tree, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | buffer_semaphore: Arc, [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | ) -> Self { [INFO] [stdout] 40 | let meter = global::meter("garage_model/block"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | Self { [INFO] [stdout] 42 | _compression_level: meter [INFO] [stdout] | _________________________________^ [INFO] [stdout] 43 | | .u64_value_observer("block.compression_level", move |observer| { [INFO] [stdout] 44 | | match compression_level { [INFO] [stdout] 45 | | Some(v) => observer.observe(v as u64, &[]), [INFO] [stdout] ... | [INFO] [stdout] 49 | | .with_description("Garage compression level for node") [INFO] [stdout] 50 | | .init(), [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> metrics.rs:51:14 [INFO] [stdout] | [INFO] [stdout] 35 | rc_tree: db::Tree, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | resync_queue: db::Tree, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | resync_errors: db::Tree, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | buffer_semaphore: Arc, [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | ) -> Self { [INFO] [stdout] 40 | let meter = global::meter("garage_model/block"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 51 | _rc_size: meter [INFO] [stdout] | _______________________^ [INFO] [stdout] 52 | | .u64_value_observer("block.rc_size", move |observer| { [INFO] [stdout] 53 | | if let Ok(value) = rc_tree.len() { [INFO] [stdout] 54 | | observer.observe(value as u64, &[]) [INFO] [stdout] ... | [INFO] [stdout] 57 | | .with_description("Number of blocks known to the reference counter") [INFO] [stdout] 58 | | .init(), [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> metrics.rs:59:23 [INFO] [stdout] | [INFO] [stdout] 35 | rc_tree: db::Tree, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | resync_queue: db::Tree, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | resync_errors: db::Tree, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | buffer_semaphore: Arc, [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | ) -> Self { [INFO] [stdout] 40 | let meter = global::meter("garage_model/block"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | _resync_queue_len: meter [INFO] [stdout] | ________________________________^ [INFO] [stdout] 60 | | .u64_value_observer("block.resync_queue_length", move |observer| { [INFO] [stdout] 61 | | if let Ok(value) = resync_queue.len() { [INFO] [stdout] 62 | | observer.observe(value as u64, &[]); [INFO] [stdout] ... | [INFO] [stdout] 67 | | ) [INFO] [stdout] 68 | | .init(), [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> metrics.rs:69:28 [INFO] [stdout] | [INFO] [stdout] 35 | rc_tree: db::Tree, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | resync_queue: db::Tree, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | resync_errors: db::Tree, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | buffer_semaphore: Arc, [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | ) -> Self { [INFO] [stdout] 40 | let meter = global::meter("garage_model/block"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 69 | _resync_errored_blocks: meter [INFO] [stdout] | _____________________________________^ [INFO] [stdout] 70 | | .u64_value_observer("block.resync_errored_blocks", move |observer| { [INFO] [stdout] 71 | | if let Ok(value) = resync_errors.len() { [INFO] [stdout] 72 | | observer.observe(value as u64, &[]); [INFO] [stdout] ... | [INFO] [stdout] 75 | | .with_description("Number of block hashes whose last resync resulted in an error") [INFO] [stdout] 76 | | .init(), [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> metrics.rs:78:21 [INFO] [stdout] | [INFO] [stdout] 35 | rc_tree: db::Tree, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | resync_queue: db::Tree, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | resync_errors: db::Tree, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | buffer_semaphore: Arc, [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | ) -> Self { [INFO] [stdout] 40 | let meter = global::meter("garage_model/block"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 78 | _buffer_free_kb: meter [INFO] [stdout] | ______________________________^ [INFO] [stdout] 79 | | .u64_value_observer("block.ram_buffer_free_kb", move |observer| { [INFO] [stdout] 80 | | observer.observe(buffer_semaphore.available_permits() as u64, &[]) [INFO] [stdout] 81 | | }) [INFO] [stdout] ... | [INFO] [stdout] 84 | | ) [INFO] [stdout] 85 | | .init(), [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> metrics.rs:87:20 [INFO] [stdout] | [INFO] [stdout] 35 | rc_tree: db::Tree, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | resync_queue: db::Tree, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | resync_errors: db::Tree, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | buffer_semaphore: Arc, [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | ) -> Self { [INFO] [stdout] 40 | let meter = global::meter("garage_model/block"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 87 | resync_counter: meter [INFO] [stdout] | _____________________________^ [INFO] [stdout] 88 | | .u64_counter("block.resync_counter") [INFO] [stdout] 89 | | .with_description("Number of calls to resync_block") [INFO] [stdout] 90 | | .init() [INFO] [stdout] 91 | | .bind(&[]), [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> metrics.rs:92:26 [INFO] [stdout] | [INFO] [stdout] 35 | rc_tree: db::Tree, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | resync_queue: db::Tree, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | resync_errors: db::Tree, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | buffer_semaphore: Arc, [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | ) -> Self { [INFO] [stdout] 40 | let meter = global::meter("garage_model/block"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 92 | resync_error_counter: meter [INFO] [stdout] | ___________________________________^ [INFO] [stdout] 93 | | .u64_counter("block.resync_error_counter") [INFO] [stdout] 94 | | .with_description("Number of calls to resync_block that returned an error") [INFO] [stdout] 95 | | .init() [INFO] [stdout] 96 | | .bind(&[]), [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> metrics.rs:97:21 [INFO] [stdout] | [INFO] [stdout] 35 | rc_tree: db::Tree, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | resync_queue: db::Tree, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | resync_errors: db::Tree, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | buffer_semaphore: Arc, [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | ) -> Self { [INFO] [stdout] 40 | let meter = global::meter("garage_model/block"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 97 | resync_duration: meter [INFO] [stdout] | ______________________________^ [INFO] [stdout] 98 | | .f64_value_recorder("block.resync_duration") [INFO] [stdout] 99 | | .with_description("Duration of resync_block operations") [INFO] [stdout] 100 | | .init() [INFO] [stdout] 101 | | .bind(&[]), [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> metrics.rs:102:25 [INFO] [stdout] | [INFO] [stdout] 35 | rc_tree: db::Tree, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | resync_queue: db::Tree, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | resync_errors: db::Tree, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | buffer_semaphore: Arc, [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | ) -> Self { [INFO] [stdout] 40 | let meter = global::meter("garage_model/block"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 102 | resync_send_counter: meter [INFO] [stdout] | __________________________________^ [INFO] [stdout] 103 | | .u64_counter("block.resync_send_counter") [INFO] [stdout] 104 | | .with_description("Number of blocks sent to another node in resync operations") [INFO] [stdout] 105 | | .init(), [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> metrics.rs:106:25 [INFO] [stdout] | [INFO] [stdout] 35 | rc_tree: db::Tree, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | resync_queue: db::Tree, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | resync_errors: db::Tree, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | buffer_semaphore: Arc, [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | ) -> Self { [INFO] [stdout] 40 | let meter = global::meter("garage_model/block"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 106 | resync_recv_counter: meter [INFO] [stdout] | __________________________________^ [INFO] [stdout] 107 | | .u64_counter("block.resync_recv_counter") [INFO] [stdout] 108 | | .with_description("Number of blocks received from other nodes in resync operations") [INFO] [stdout] 109 | | .init() [INFO] [stdout] 110 | | .bind(&[]), [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> metrics.rs:112:16 [INFO] [stdout] | [INFO] [stdout] 35 | rc_tree: db::Tree, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | resync_queue: db::Tree, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | resync_errors: db::Tree, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | buffer_semaphore: Arc, [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | ) -> Self { [INFO] [stdout] 40 | let meter = global::meter("garage_model/block"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 112 | bytes_read: meter [INFO] [stdout] | _________________________^ [INFO] [stdout] 113 | | .u64_counter("block.bytes_read") [INFO] [stdout] 114 | | .with_description("Number of bytes read from disk") [INFO] [stdout] 115 | | .init() [INFO] [stdout] 116 | | .bind(&[]), [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> metrics.rs:117:25 [INFO] [stdout] | [INFO] [stdout] 35 | rc_tree: db::Tree, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | resync_queue: db::Tree, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | resync_errors: db::Tree, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | buffer_semaphore: Arc, [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | ) -> Self { [INFO] [stdout] 40 | let meter = global::meter("garage_model/block"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 117 | block_read_duration: meter [INFO] [stdout] | __________________________________^ [INFO] [stdout] 118 | | .f64_value_recorder("block.read_duration") [INFO] [stdout] 119 | | .with_description("Duration of block read operations") [INFO] [stdout] 120 | | .init() [INFO] [stdout] 121 | | .bind(&[]), [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> metrics.rs:122:19 [INFO] [stdout] | [INFO] [stdout] 35 | rc_tree: db::Tree, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | resync_queue: db::Tree, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | resync_errors: db::Tree, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | buffer_semaphore: Arc, [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | ) -> Self { [INFO] [stdout] 40 | let meter = global::meter("garage_model/block"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 122 | bytes_written: meter [INFO] [stdout] | ____________________________^ [INFO] [stdout] 123 | | .u64_counter("block.bytes_written") [INFO] [stdout] 124 | | .with_description("Number of bytes written to disk") [INFO] [stdout] 125 | | .init() [INFO] [stdout] 126 | | .bind(&[]), [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> metrics.rs:127:26 [INFO] [stdout] | [INFO] [stdout] 35 | rc_tree: db::Tree, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | resync_queue: db::Tree, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | resync_errors: db::Tree, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | buffer_semaphore: Arc, [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | ) -> Self { [INFO] [stdout] 40 | let meter = global::meter("garage_model/block"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 127 | block_write_duration: meter [INFO] [stdout] | ___________________________________^ [INFO] [stdout] 128 | | .f64_value_recorder("block.write_duration") [INFO] [stdout] 129 | | .with_description("Duration of block write operations") [INFO] [stdout] 130 | | .init() [INFO] [stdout] 131 | | .bind(&[]), [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> metrics.rs:132:20 [INFO] [stdout] | [INFO] [stdout] 35 | rc_tree: db::Tree, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | resync_queue: db::Tree, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | resync_errors: db::Tree, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | buffer_semaphore: Arc, [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | ) -> Self { [INFO] [stdout] 40 | let meter = global::meter("garage_model/block"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 132 | delete_counter: meter [INFO] [stdout] | _____________________________^ [INFO] [stdout] 133 | | .u64_counter("block.delete_counter") [INFO] [stdout] 134 | | .with_description("Number of blocks deleted") [INFO] [stdout] 135 | | .init() [INFO] [stdout] 136 | | .bind(&[]), [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> metrics.rs:138:24 [INFO] [stdout] | [INFO] [stdout] 35 | rc_tree: db::Tree, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | resync_queue: db::Tree, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | resync_errors: db::Tree, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | buffer_semaphore: Arc, [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | ) -> Self { [INFO] [stdout] 40 | let meter = global::meter("garage_model/block"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 138 | corruption_counter: meter [INFO] [stdout] | _________________________________^ [INFO] [stdout] 139 | | .u64_counter("block.corruption_counter") [INFO] [stdout] 140 | | .with_description("Data corruptions detected on block reads") [INFO] [stdout] 141 | | .init() [INFO] [stdout] 142 | | .bind(&[]), [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> rc.rs:25:15 [INFO] [stdout] | [INFO] [stdout] 22 | pub(crate) fn new(rc: db::Tree) -> Self { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 25 | recalc_rc: ArcSwapOption::new(None), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 24 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `garage_block` (lib) due to 25 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> manager.rs:269:4 [INFO] [stdout] | [INFO] [stdout] 267 | self.rpc_get_raw_block_internal(hash, priority, order_tag, |block_stream| async move { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 268 | let (header, stream) = block_stream.into_parts(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 269 | / read_stream_to_end(stream) [INFO] [stdout] 270 | | .await [INFO] [stdout] 271 | | .err_context("error in block data stream") [INFO] [stdout] | |__________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> manager.rs:272:47 [INFO] [stdout] | [INFO] [stdout] 272 | .map(|data| DataBlock::from_parts(header, data.into_bytes())) [INFO] [stdout] | ---- ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> manager.rs:693:97 [INFO] [stdout] | [INFO] [stdout] 693 | async fn handle(self: &Arc, mut message: Req, _from: NodeID) -> Resp { [INFO] [stdout] | ___________________________________________----------------------___________________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 694 | | match message.msg() { [INFO] [stdout] 695 | | BlockRpc::PutBlock { hash, header } => Resp::new( [INFO] [stdout] 696 | | self.handle_put_block(*hash, *header, message.take_stream()) [INFO] [stdout] ... | [INFO] [stdout] 705 | | } [INFO] [stdout] 706 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> resync.rs:101:12 [INFO] [stdout] | [INFO] [stdout] 89 | let queue = db [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 93 | let errors = db [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 97 | let persister = PersisterShared::new(&system.metadata_dir, "resync_cfg"); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 101 | notify: Arc::new(Notify::new()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> resync.rs:103:14 [INFO] [stdout] | [INFO] [stdout] 89 | let queue = db [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 93 | let errors = db [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 97 | let persister = PersisterShared::new(&system.metadata_dir, "resync_cfg"); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 103 | busy_set: Arc::new(Mutex::new(HashSet::new())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> resync.rs:351:6 [INFO] [stdout] | [INFO] [stdout] 339 | let mut busy = self.busy_set.lock().unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 351 | Ok(None) [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> block.rs:92:21 [INFO] [stdout] | [INFO] [stdout] 85 | pub async fn from_buffer(data: Bytes, level: Option) -> DataBlock { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 92 | DataBlock::plain(data.into()) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> metrics.rs:42:24 [INFO] [stdout] | [INFO] [stdout] 35 | rc_tree: db::Tree, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | resync_queue: db::Tree, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | resync_errors: db::Tree, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | buffer_semaphore: Arc, [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | ) -> Self { [INFO] [stdout] 40 | let meter = global::meter("garage_model/block"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | Self { [INFO] [stdout] 42 | _compression_level: meter [INFO] [stdout] | _________________________________^ [INFO] [stdout] 43 | | .u64_value_observer("block.compression_level", move |observer| { [INFO] [stdout] 44 | | match compression_level { [INFO] [stdout] 45 | | Some(v) => observer.observe(v as u64, &[]), [INFO] [stdout] ... | [INFO] [stdout] 49 | | .with_description("Garage compression level for node") [INFO] [stdout] 50 | | .init(), [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> metrics.rs:51:14 [INFO] [stdout] | [INFO] [stdout] 35 | rc_tree: db::Tree, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | resync_queue: db::Tree, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | resync_errors: db::Tree, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | buffer_semaphore: Arc, [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | ) -> Self { [INFO] [stdout] 40 | let meter = global::meter("garage_model/block"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 51 | _rc_size: meter [INFO] [stdout] | _______________________^ [INFO] [stdout] 52 | | .u64_value_observer("block.rc_size", move |observer| { [INFO] [stdout] 53 | | if let Ok(value) = rc_tree.len() { [INFO] [stdout] 54 | | observer.observe(value as u64, &[]) [INFO] [stdout] ... | [INFO] [stdout] 57 | | .with_description("Number of blocks known to the reference counter") [INFO] [stdout] 58 | | .init(), [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> metrics.rs:59:23 [INFO] [stdout] | [INFO] [stdout] 35 | rc_tree: db::Tree, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | resync_queue: db::Tree, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | resync_errors: db::Tree, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | buffer_semaphore: Arc, [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | ) -> Self { [INFO] [stdout] 40 | let meter = global::meter("garage_model/block"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | _resync_queue_len: meter [INFO] [stdout] | ________________________________^ [INFO] [stdout] 60 | | .u64_value_observer("block.resync_queue_length", move |observer| { [INFO] [stdout] 61 | | if let Ok(value) = resync_queue.len() { [INFO] [stdout] 62 | | observer.observe(value as u64, &[]); [INFO] [stdout] ... | [INFO] [stdout] 67 | | ) [INFO] [stdout] 68 | | .init(), [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> metrics.rs:69:28 [INFO] [stdout] | [INFO] [stdout] 35 | rc_tree: db::Tree, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | resync_queue: db::Tree, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | resync_errors: db::Tree, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | buffer_semaphore: Arc, [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | ) -> Self { [INFO] [stdout] 40 | let meter = global::meter("garage_model/block"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 69 | _resync_errored_blocks: meter [INFO] [stdout] | _____________________________________^ [INFO] [stdout] 70 | | .u64_value_observer("block.resync_errored_blocks", move |observer| { [INFO] [stdout] 71 | | if let Ok(value) = resync_errors.len() { [INFO] [stdout] 72 | | observer.observe(value as u64, &[]); [INFO] [stdout] ... | [INFO] [stdout] 75 | | .with_description("Number of block hashes whose last resync resulted in an error") [INFO] [stdout] 76 | | .init(), [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> metrics.rs:78:21 [INFO] [stdout] | [INFO] [stdout] 35 | rc_tree: db::Tree, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | resync_queue: db::Tree, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | resync_errors: db::Tree, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | buffer_semaphore: Arc, [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | ) -> Self { [INFO] [stdout] 40 | let meter = global::meter("garage_model/block"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 78 | _buffer_free_kb: meter [INFO] [stdout] | ______________________________^ [INFO] [stdout] 79 | | .u64_value_observer("block.ram_buffer_free_kb", move |observer| { [INFO] [stdout] 80 | | observer.observe(buffer_semaphore.available_permits() as u64, &[]) [INFO] [stdout] 81 | | }) [INFO] [stdout] ... | [INFO] [stdout] 84 | | ) [INFO] [stdout] 85 | | .init(), [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> metrics.rs:87:20 [INFO] [stdout] | [INFO] [stdout] 35 | rc_tree: db::Tree, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | resync_queue: db::Tree, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | resync_errors: db::Tree, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | buffer_semaphore: Arc, [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | ) -> Self { [INFO] [stdout] 40 | let meter = global::meter("garage_model/block"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 87 | resync_counter: meter [INFO] [stdout] | _____________________________^ [INFO] [stdout] 88 | | .u64_counter("block.resync_counter") [INFO] [stdout] 89 | | .with_description("Number of calls to resync_block") [INFO] [stdout] 90 | | .init() [INFO] [stdout] 91 | | .bind(&[]), [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> metrics.rs:92:26 [INFO] [stdout] | [INFO] [stdout] 35 | rc_tree: db::Tree, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | resync_queue: db::Tree, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | resync_errors: db::Tree, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | buffer_semaphore: Arc, [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | ) -> Self { [INFO] [stdout] 40 | let meter = global::meter("garage_model/block"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 92 | resync_error_counter: meter [INFO] [stdout] | ___________________________________^ [INFO] [stdout] 93 | | .u64_counter("block.resync_error_counter") [INFO] [stdout] 94 | | .with_description("Number of calls to resync_block that returned an error") [INFO] [stdout] 95 | | .init() [INFO] [stdout] 96 | | .bind(&[]), [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> metrics.rs:97:21 [INFO] [stdout] | [INFO] [stdout] 35 | rc_tree: db::Tree, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | resync_queue: db::Tree, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | resync_errors: db::Tree, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | buffer_semaphore: Arc, [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | ) -> Self { [INFO] [stdout] 40 | let meter = global::meter("garage_model/block"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 97 | resync_duration: meter [INFO] [stdout] | ______________________________^ [INFO] [stdout] 98 | | .f64_value_recorder("block.resync_duration") [INFO] [stdout] 99 | | .with_description("Duration of resync_block operations") [INFO] [stdout] 100 | | .init() [INFO] [stdout] 101 | | .bind(&[]), [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> metrics.rs:102:25 [INFO] [stdout] | [INFO] [stdout] 35 | rc_tree: db::Tree, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | resync_queue: db::Tree, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | resync_errors: db::Tree, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | buffer_semaphore: Arc, [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | ) -> Self { [INFO] [stdout] 40 | let meter = global::meter("garage_model/block"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 102 | resync_send_counter: meter [INFO] [stdout] | __________________________________^ [INFO] [stdout] 103 | | .u64_counter("block.resync_send_counter") [INFO] [stdout] 104 | | .with_description("Number of blocks sent to another node in resync operations") [INFO] [stdout] 105 | | .init(), [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> metrics.rs:106:25 [INFO] [stdout] | [INFO] [stdout] 35 | rc_tree: db::Tree, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | resync_queue: db::Tree, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | resync_errors: db::Tree, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | buffer_semaphore: Arc, [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | ) -> Self { [INFO] [stdout] 40 | let meter = global::meter("garage_model/block"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 106 | resync_recv_counter: meter [INFO] [stdout] | __________________________________^ [INFO] [stdout] 107 | | .u64_counter("block.resync_recv_counter") [INFO] [stdout] 108 | | .with_description("Number of blocks received from other nodes in resync operations") [INFO] [stdout] 109 | | .init() [INFO] [stdout] 110 | | .bind(&[]), [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> metrics.rs:112:16 [INFO] [stdout] | [INFO] [stdout] 35 | rc_tree: db::Tree, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | resync_queue: db::Tree, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | resync_errors: db::Tree, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | buffer_semaphore: Arc, [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | ) -> Self { [INFO] [stdout] 40 | let meter = global::meter("garage_model/block"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 112 | bytes_read: meter [INFO] [stdout] | _________________________^ [INFO] [stdout] 113 | | .u64_counter("block.bytes_read") [INFO] [stdout] 114 | | .with_description("Number of bytes read from disk") [INFO] [stdout] 115 | | .init() [INFO] [stdout] 116 | | .bind(&[]), [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> metrics.rs:117:25 [INFO] [stdout] | [INFO] [stdout] 35 | rc_tree: db::Tree, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | resync_queue: db::Tree, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | resync_errors: db::Tree, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | buffer_semaphore: Arc, [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | ) -> Self { [INFO] [stdout] 40 | let meter = global::meter("garage_model/block"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 117 | block_read_duration: meter [INFO] [stdout] | __________________________________^ [INFO] [stdout] 118 | | .f64_value_recorder("block.read_duration") [INFO] [stdout] 119 | | .with_description("Duration of block read operations") [INFO] [stdout] 120 | | .init() [INFO] [stdout] 121 | | .bind(&[]), [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> metrics.rs:122:19 [INFO] [stdout] | [INFO] [stdout] 35 | rc_tree: db::Tree, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | resync_queue: db::Tree, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | resync_errors: db::Tree, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | buffer_semaphore: Arc, [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | ) -> Self { [INFO] [stdout] 40 | let meter = global::meter("garage_model/block"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 122 | bytes_written: meter [INFO] [stdout] | ____________________________^ [INFO] [stdout] 123 | | .u64_counter("block.bytes_written") [INFO] [stdout] 124 | | .with_description("Number of bytes written to disk") [INFO] [stdout] 125 | | .init() [INFO] [stdout] 126 | | .bind(&[]), [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> metrics.rs:127:26 [INFO] [stdout] | [INFO] [stdout] 35 | rc_tree: db::Tree, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | resync_queue: db::Tree, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | resync_errors: db::Tree, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | buffer_semaphore: Arc, [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | ) -> Self { [INFO] [stdout] 40 | let meter = global::meter("garage_model/block"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 127 | block_write_duration: meter [INFO] [stdout] | ___________________________________^ [INFO] [stdout] 128 | | .f64_value_recorder("block.write_duration") [INFO] [stdout] 129 | | .with_description("Duration of block write operations") [INFO] [stdout] 130 | | .init() [INFO] [stdout] 131 | | .bind(&[]), [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> metrics.rs:132:20 [INFO] [stdout] | [INFO] [stdout] 35 | rc_tree: db::Tree, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | resync_queue: db::Tree, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | resync_errors: db::Tree, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | buffer_semaphore: Arc, [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | ) -> Self { [INFO] [stdout] 40 | let meter = global::meter("garage_model/block"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 132 | delete_counter: meter [INFO] [stdout] | _____________________________^ [INFO] [stdout] 133 | | .u64_counter("block.delete_counter") [INFO] [stdout] 134 | | .with_description("Number of blocks deleted") [INFO] [stdout] 135 | | .init() [INFO] [stdout] 136 | | .bind(&[]), [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> metrics.rs:138:24 [INFO] [stdout] | [INFO] [stdout] 35 | rc_tree: db::Tree, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | resync_queue: db::Tree, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | resync_errors: db::Tree, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | buffer_semaphore: Arc, [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | ) -> Self { [INFO] [stdout] 40 | let meter = global::meter("garage_model/block"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 138 | corruption_counter: meter [INFO] [stdout] | _________________________________^ [INFO] [stdout] 139 | | .u64_counter("block.corruption_counter") [INFO] [stdout] 140 | | .with_description("Data corruptions detected on block reads") [INFO] [stdout] 141 | | .init() [INFO] [stdout] 142 | | .bind(&[]), [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> rc.rs:25:15 [INFO] [stdout] | [INFO] [stdout] 22 | pub(crate) fn new(rc: db::Tree) -> Self { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 25 | recalc_rc: ArcSwapOption::new(None), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 24 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `garage_block` (lib test) due to 25 previous errors [INFO] running `Command { std: "docker" "inspect" "9e42eebfaa0f963204f5ef63ba319498cc91cfffe6ada948fff30ba0d25defc9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9e42eebfaa0f963204f5ef63ba319498cc91cfffe6ada948fff30ba0d25defc9", kill_on_drop: false }` [INFO] [stdout] 9e42eebfaa0f963204f5ef63ba319498cc91cfffe6ada948fff30ba0d25defc9