[INFO] fetching crate game-detector 0.1.4... [INFO] checking game-detector-0.1.4 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate game-detector 0.1.4 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate game-detector 0.1.4 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate game-detector 0.1.4 [INFO] finished tweaking crates.io crate game-detector 0.1.4 [INFO] tweaked toml for crates.io crate game-detector 0.1.4 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate game-detector 0.1.4 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7fcc955d973d8c87445df757f04e882a2ef02604338e3d349469331c15058805 [INFO] running `Command { std: "docker" "start" "-a" "7fcc955d973d8c87445df757f04e882a2ef02604338e3d349469331c15058805", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7fcc955d973d8c87445df757f04e882a2ef02604338e3d349469331c15058805", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7fcc955d973d8c87445df757f04e882a2ef02604338e3d349469331c15058805", kill_on_drop: false }` [INFO] [stdout] 7fcc955d973d8c87445df757f04e882a2ef02604338e3d349469331c15058805 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 957ce0b33c31ab60ad5b579011aed954838eaf110bf4f8838c79ddf1c9c395fc [INFO] running `Command { std: "docker" "start" "-a" "957ce0b33c31ab60ad5b579011aed954838eaf110bf4f8838c79ddf1c9c395fc", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.78 [INFO] [stderr] Compiling thiserror v1.0.56 [INFO] [stderr] Compiling memchr v2.7.1 [INFO] [stderr] Compiling serde v1.0.195 [INFO] [stderr] Checking aho-corasick v1.1.2 [INFO] [stderr] Compiling fs-err v2.11.0 [INFO] [stderr] Compiling anyhow v1.0.79 [INFO] [stderr] Compiling serde_json v1.0.111 [INFO] [stderr] Checking anstyle-parse v0.2.3 [INFO] [stderr] Checking anstyle v1.0.4 [INFO] [stderr] Checking anstyle-query v1.0.2 [INFO] [stderr] Checking glob v0.3.1 [INFO] [stderr] Checking anstream v0.6.11 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Compiling syn v2.0.48 [INFO] [stderr] Checking regex-automata v0.4.4 [INFO] [stderr] Compiling thiserror-impl v1.0.56 [INFO] [stderr] Compiling serde_derive v1.0.195 [INFO] [stderr] Checking regex v1.10.3 [INFO] [stderr] Checking env_filter v0.1.0 [INFO] [stderr] Checking pest v2.7.6 [INFO] [stderr] Checking env_logger v0.11.0 [INFO] [stderr] Compiling pest_meta v2.7.6 [INFO] [stderr] Compiling pest_generator v2.7.6 [INFO] [stderr] Compiling pest_derive v2.7.6 [INFO] [stderr] Checking keyvalues-parser v0.2.0 [INFO] [stderr] Checking keyvalues-serde v0.2.1 [INFO] [stderr] Checking game-detector v0.1.4 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `log::warn` [INFO] [stdout] --> src/ms_store.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use log::warn; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::path::Path` [INFO] [stdout] --> src/ms_store.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use std::path::Path; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `fs_err::File` [INFO] [stdout] --> src/steam.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use fs_err::File; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `error` and `warn` [INFO] [stdout] --> src/steam.rs:2:11 [INFO] [stdout] | [INFO] [stdout] 2 | use log::{error, warn}; [INFO] [stdout] | ^^^^^ ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::path::Path` [INFO] [stdout] --> src/steam.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use std::path::Path; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `log::warn` [INFO] [stdout] --> src/ms_store.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use log::warn; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::path::Path` [INFO] [stdout] --> src/ms_store.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use std::path::Path; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `fs_err::File` [INFO] [stdout] --> src/steam.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use fs_err::File; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `error` and `warn` [INFO] [stdout] --> src/steam.rs:2:11 [INFO] [stdout] | [INFO] [stdout] 2 | use log::{error, warn}; [INFO] [stdout] | ^^^^^ ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::path::Path` [INFO] [stdout] --> src/steam.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use std::path::Path; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `GAMING_SERVICES_PACKAGE_REPOSITORY` is never used [INFO] [stdout] --> src/ms_store.rs:5:7 [INFO] [stdout] | [INFO] [stdout] 5 | const GAMING_SERVICES_PACKAGE_REPOSITORY: &str = [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `FULL_PACKAGE_REPOSITORY` is never used [INFO] [stdout] --> src/ms_store.rs:7:7 [INFO] [stdout] | [INFO] [stdout] 7 | const FULL_PACKAGE_REPOSITORY: &str = [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `parse_app_id` is never used [INFO] [stdout] --> src/ms_store.rs:25:4 [INFO] [stdout] | [INFO] [stdout] 25 | fn parse_app_id(s: &str) -> anyhow::Result<[String; 5]> { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `STEAM_REGKEY_PATH` is never used [INFO] [stdout] --> src/steam.rs:75:7 [INFO] [stdout] | [INFO] [stdout] 75 | const STEAM_REGKEY_PATH: &str = "SOFTWARE\\Valve\\Steam"; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:40:64 [INFO] [stdout] | [INFO] [stdout] 40 | .map(|p| InstalledGame::MicrosoftStore(Box::new(p))), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:53:76 [INFO] [stdout] | [INFO] [stdout] 53 | games.extend(apps.into_iter().map(|a| InstalledGame::Steam(Box::new(a)))); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:68:59 [INFO] [stdout] | [INFO] [stdout] 68 | .map(|m| InstalledGame::EpicGames(Box::new(m))), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 9 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `game-detector` (lib) due to 4 previous errors; 9 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: constant `GAMING_SERVICES_PACKAGE_REPOSITORY` is never used [INFO] [stdout] --> src/ms_store.rs:5:7 [INFO] [stdout] | [INFO] [stdout] 5 | const GAMING_SERVICES_PACKAGE_REPOSITORY: &str = [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `FULL_PACKAGE_REPOSITORY` is never used [INFO] [stdout] --> src/ms_store.rs:7:7 [INFO] [stdout] | [INFO] [stdout] 7 | const FULL_PACKAGE_REPOSITORY: &str = [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `parse_app_id` is never used [INFO] [stdout] --> src/ms_store.rs:25:4 [INFO] [stdout] | [INFO] [stdout] 25 | fn parse_app_id(s: &str) -> anyhow::Result<[String; 5]> { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `STEAM_REGKEY_PATH` is never used [INFO] [stdout] --> src/steam.rs:75:7 [INFO] [stdout] | [INFO] [stdout] 75 | const STEAM_REGKEY_PATH: &str = "SOFTWARE\\Valve\\Steam"; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:40:64 [INFO] [stdout] | [INFO] [stdout] 40 | .map(|p| InstalledGame::MicrosoftStore(Box::new(p))), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:53:76 [INFO] [stdout] | [INFO] [stdout] 53 | games.extend(apps.into_iter().map(|a| InstalledGame::Steam(Box::new(a)))); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:68:59 [INFO] [stdout] | [INFO] [stdout] 68 | .map(|m| InstalledGame::EpicGames(Box::new(m))), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 9 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `game-detector` (lib test) due to 4 previous errors; 9 warnings emitted [INFO] running `Command { std: "docker" "inspect" "957ce0b33c31ab60ad5b579011aed954838eaf110bf4f8838c79ddf1c9c395fc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "957ce0b33c31ab60ad5b579011aed954838eaf110bf4f8838c79ddf1c9c395fc", kill_on_drop: false }` [INFO] [stdout] 957ce0b33c31ab60ad5b579011aed954838eaf110bf4f8838c79ddf1c9c395fc