[INFO] fetching crate game-boy-inator 0.0.1... [INFO] checking game-boy-inator-0.0.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate game-boy-inator 0.0.1 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate game-boy-inator 0.0.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate game-boy-inator 0.0.1 [INFO] finished tweaking crates.io crate game-boy-inator 0.0.1 [INFO] tweaked toml for crates.io crate game-boy-inator 0.0.1 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4a6e19933486a6480a9648d505f6cedce5444816c79be0d2a05302e33e0cd966 [INFO] running `Command { std: "docker" "start" "-a" "4a6e19933486a6480a9648d505f6cedce5444816c79be0d2a05302e33e0cd966", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4a6e19933486a6480a9648d505f6cedce5444816c79be0d2a05302e33e0cd966", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4a6e19933486a6480a9648d505f6cedce5444816c79be0d2a05302e33e0cd966", kill_on_drop: false }` [INFO] [stdout] 4a6e19933486a6480a9648d505f6cedce5444816c79be0d2a05302e33e0cd966 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f4a798b243394c4c5f5d2fb32f0dced6f2c360adf4cff1ec54545134eb75d3e2 [INFO] running `Command { std: "docker" "start" "-a" "f4a798b243394c4c5f5d2fb32f0dced6f2c360adf4cff1ec54545134eb75d3e2", kill_on_drop: false }` [INFO] [stderr] Checking game-boy-inator v0.0.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `self` [INFO] [stdout] --> src/cpu/alu_tests.rs:4:22 [INFO] [stdout] | [INFO] [stdout] 4 | use crate::cpu::{self, *}; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `cpu::Cpu` and `ram::Ram` [INFO] [stdout] --> src/tests.rs:4:17 [INFO] [stdout] | [INFO] [stdout] 4 | use crate::{ram::Ram, cpu::Cpu}; [INFO] [stdout] | ^^^^^^^^ ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `cpu` [INFO] [stdout] --> src/cpu/alu_tests.rs:22:17 [INFO] [stdout] | [INFO] [stdout] 22 | let mut cpu = Cpu::new(); [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_cpu` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/cpu/alu_tests.rs:22:13 [INFO] [stdout] | [INFO] [stdout] 22 | let mut cpu = Cpu::new(); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `cpu` [INFO] [stdout] --> src/cpu/alu_tests.rs:30:17 [INFO] [stdout] | [INFO] [stdout] 30 | let mut cpu = Cpu::new(); [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_cpu` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/cpu/alu_tests.rs:30:13 [INFO] [stdout] | [INFO] [stdout] 30 | let mut cpu = Cpu::new(); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `cpu` [INFO] [stdout] --> src/cpu/alu_tests.rs:39:17 [INFO] [stdout] | [INFO] [stdout] 39 | let mut cpu = Cpu::new(); [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_cpu` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/cpu/alu_tests.rs:39:13 [INFO] [stdout] | [INFO] [stdout] 39 | let mut cpu = Cpu::new(); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `cpu` [INFO] [stdout] --> src/cpu/alu_tests.rs:48:17 [INFO] [stdout] | [INFO] [stdout] 48 | let mut cpu = Cpu::new(); [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_cpu` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/cpu/alu_tests.rs:48:13 [INFO] [stdout] | [INFO] [stdout] 48 | let mut cpu = Cpu::new(); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `cpu` [INFO] [stdout] --> src/cpu/alu_tests.rs:57:17 [INFO] [stdout] | [INFO] [stdout] 57 | let mut cpu = Cpu::new(); [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_cpu` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/cpu/alu_tests.rs:57:13 [INFO] [stdout] | [INFO] [stdout] 57 | let mut cpu = Cpu::new(); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `cpu` [INFO] [stdout] --> src/cpu/alu_tests.rs:66:17 [INFO] [stdout] | [INFO] [stdout] 66 | let mut cpu = Cpu::new(); [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_cpu` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/cpu/alu_tests.rs:66:13 [INFO] [stdout] | [INFO] [stdout] 66 | let mut cpu = Cpu::new(); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `cpu` [INFO] [stdout] --> src/cpu/alu_tests.rs:75:17 [INFO] [stdout] | [INFO] [stdout] 75 | let mut cpu = Cpu::new(); [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_cpu` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/cpu/alu_tests.rs:75:13 [INFO] [stdout] | [INFO] [stdout] 75 | let mut cpu = Cpu::new(); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `cpu` [INFO] [stdout] --> src/cpu/alu_tests.rs:84:17 [INFO] [stdout] | [INFO] [stdout] 84 | let mut cpu = Cpu::new(); [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_cpu` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/cpu/alu_tests.rs:84:13 [INFO] [stdout] | [INFO] [stdout] 84 | let mut cpu = Cpu::new(); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `STAT_MODE` is never used [INFO] [stdout] --> src/ppu.rs:18:7 [INFO] [stdout] | [INFO] [stdout] 18 | const STAT_MODE:u8 = 0b00000011; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `STAT_MATCH` is never used [INFO] [stdout] --> src/ppu.rs:19:7 [INFO] [stdout] | [INFO] [stdout] 19 | const STAT_MATCH:u8 = 1 << 2; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `PALETTE_DOT_00` is never used [INFO] [stdout] --> src/ppu.rs:21:7 [INFO] [stdout] | [INFO] [stdout] 21 | const PALETTE_DOT_00:u8 = 0b00000011; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `PALETTE_DOT_01` is never used [INFO] [stdout] --> src/ppu.rs:22:7 [INFO] [stdout] | [INFO] [stdout] 22 | const PALETTE_DOT_01:u8 = 0b00001100; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `PALETTE_DOT_10` is never used [INFO] [stdout] --> src/ppu.rs:23:7 [INFO] [stdout] | [INFO] [stdout] 23 | const PALETTE_DOT_10:u8 = 0b00110000; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `PALETTE_DOT_11` is never used [INFO] [stdout] --> src/ppu.rs:24:7 [INFO] [stdout] | [INFO] [stdout] 24 | const PALETTE_DOT_11:u8 = 0b11000000; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `new_frame` is never read [INFO] [stdout] --> src/ppu.rs:50:5 [INFO] [stdout] | [INFO] [stdout] 46 | pub struct Ppu [INFO] [stdout] | --- field in this struct [INFO] [stdout] ... [INFO] [stdout] 50 | new_frame: bool, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mainboard.rs:33:30 [INFO] [stdout] | [INFO] [stdout] 21 | pub fn new(hardware_handle: T) -> Mainboard [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 33 | hardware_handle: Rc::new(RefCell::new(hardware_handle)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `game-boy-inator` (lib) due to 2 previous errors; 7 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: function `test_jp_nflag_pc_16` is never used [INFO] [stdout] --> src/cpu/jump_branch_tests.rs:29:8 [INFO] [stdout] | [INFO] [stdout] 29 | fn test_jp_nflag_pc_16() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `STAT_MODE` is never used [INFO] [stdout] --> src/ppu.rs:18:7 [INFO] [stdout] | [INFO] [stdout] 18 | const STAT_MODE:u8 = 0b00000011; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `STAT_MATCH` is never used [INFO] [stdout] --> src/ppu.rs:19:7 [INFO] [stdout] | [INFO] [stdout] 19 | const STAT_MATCH:u8 = 1 << 2; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `PALETTE_DOT_00` is never used [INFO] [stdout] --> src/ppu.rs:21:7 [INFO] [stdout] | [INFO] [stdout] 21 | const PALETTE_DOT_00:u8 = 0b00000011; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `PALETTE_DOT_01` is never used [INFO] [stdout] --> src/ppu.rs:22:7 [INFO] [stdout] | [INFO] [stdout] 22 | const PALETTE_DOT_01:u8 = 0b00001100; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `PALETTE_DOT_10` is never used [INFO] [stdout] --> src/ppu.rs:23:7 [INFO] [stdout] | [INFO] [stdout] 23 | const PALETTE_DOT_10:u8 = 0b00110000; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `PALETTE_DOT_11` is never used [INFO] [stdout] --> src/ppu.rs:24:7 [INFO] [stdout] | [INFO] [stdout] 24 | const PALETTE_DOT_11:u8 = 0b11000000; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `new_frame` is never read [INFO] [stdout] --> src/ppu.rs:50:5 [INFO] [stdout] | [INFO] [stdout] 46 | pub struct Ppu [INFO] [stdout] | --- field in this struct [INFO] [stdout] ... [INFO] [stdout] 50 | new_frame: bool, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mainboard.rs:33:30 [INFO] [stdout] | [INFO] [stdout] 21 | pub fn new(hardware_handle: T) -> Mainboard [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 33 | hardware_handle: Rc::new(RefCell::new(hardware_handle)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 26 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `game-boy-inator` (lib test) due to 2 previous errors; 26 warnings emitted [INFO] running `Command { std: "docker" "inspect" "f4a798b243394c4c5f5d2fb32f0dced6f2c360adf4cff1ec54545134eb75d3e2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f4a798b243394c4c5f5d2fb32f0dced6f2c360adf4cff1ec54545134eb75d3e2", kill_on_drop: false }` [INFO] [stdout] f4a798b243394c4c5f5d2fb32f0dced6f2c360adf4cff1ec54545134eb75d3e2