[INFO] fetching crate galbi 0.3.0... [INFO] checking galbi-0.3.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate galbi 0.3.0 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate galbi 0.3.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate galbi 0.3.0 [INFO] finished tweaking crates.io crate galbi 0.3.0 [INFO] tweaked toml for crates.io crate galbi 0.3.0 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate crates.io crate galbi 0.3.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8aa62d9a9f36dc6f201c2910c610f8723088d0221de8af00d2fb31912d98580c [INFO] running `Command { std: "docker" "start" "-a" "8aa62d9a9f36dc6f201c2910c610f8723088d0221de8af00d2fb31912d98580c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8aa62d9a9f36dc6f201c2910c610f8723088d0221de8af00d2fb31912d98580c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8aa62d9a9f36dc6f201c2910c610f8723088d0221de8af00d2fb31912d98580c", kill_on_drop: false }` [INFO] [stdout] 8aa62d9a9f36dc6f201c2910c610f8723088d0221de8af00d2fb31912d98580c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f574781a25bbae131cd08693ebef2038570586d3ea876691ceb856c0e5e9912c [INFO] running `Command { std: "docker" "start" "-a" "f574781a25bbae131cd08693ebef2038570586d3ea876691ceb856c0e5e9912c", kill_on_drop: false }` [INFO] [stderr] Checking galbi v0.3.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/./impl/option_box.rs:21:18 [INFO] [stdout] | [INFO] [stdout] 19 | pub fn new(x: Option) -> OptionBox { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | OptionBox { [INFO] [stdout] 21 | ptr: if x.is_some() { [INFO] [stdout] | __________________^ [INFO] [stdout] 22 | | Some(Box::new(x.unwrap())) [INFO] [stdout] 23 | | } else { [INFO] [stdout] 24 | | None [INFO] [stdout] 25 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/./impl/option_box.rs:38:18 [INFO] [stdout] | [INFO] [stdout] 36 | pub fn some(x: T) -> OptionBox { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | OptionBox { [INFO] [stdout] 38 | ptr: Some(Box::new(x)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/./impl/rc_cell.rs:24:18 [INFO] [stdout] | [INFO] [stdout] 22 | pub fn new(x: T) -> RcCell { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 23 | RcCell { [INFO] [stdout] 24 | ptr: Rc::new(RefCell::new(x)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/./impl/arc_mutex.rs:23:18 [INFO] [stdout] | [INFO] [stdout] 21 | pub fn new(x: T) -> ArcMutex { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 22 | ArcMutex { [INFO] [stdout] 23 | ptr: Arc::new(Mutex::new(x)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/./impl/option_box.rs:21:18 [INFO] [stdout] | [INFO] [stdout] 19 | pub fn new(x: Option) -> OptionBox { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | OptionBox { [INFO] [stdout] 21 | ptr: if x.is_some() { [INFO] [stdout] | __________________^ [INFO] [stdout] 22 | | Some(Box::new(x.unwrap())) [INFO] [stdout] 23 | | } else { [INFO] [stdout] 24 | | None [INFO] [stdout] 25 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/./impl/option_box.rs:38:18 [INFO] [stdout] | [INFO] [stdout] 36 | pub fn some(x: T) -> OptionBox { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | OptionBox { [INFO] [stdout] 38 | ptr: Some(Box::new(x)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/./impl/rc_cell.rs:24:18 [INFO] [stdout] | [INFO] [stdout] 22 | pub fn new(x: T) -> RcCell { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 23 | RcCell { [INFO] [stdout] 24 | ptr: Rc::new(RefCell::new(x)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `galbi` (lib test) due to 5 previous errors [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/./impl/arc_mutex.rs:23:18 [INFO] [stdout] | [INFO] [stdout] 21 | pub fn new(x: T) -> ArcMutex { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 22 | ArcMutex { [INFO] [stdout] 23 | ptr: Arc::new(Mutex::new(x)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `galbi` (lib) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "f574781a25bbae131cd08693ebef2038570586d3ea876691ceb856c0e5e9912c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f574781a25bbae131cd08693ebef2038570586d3ea876691ceb856c0e5e9912c", kill_on_drop: false }` [INFO] [stdout] f574781a25bbae131cd08693ebef2038570586d3ea876691ceb856c0e5e9912c