[INFO] fetching crate gaffer 0.2.0... [INFO] checking gaffer-0.2.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate gaffer 0.2.0 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate gaffer 0.2.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate gaffer 0.2.0 [INFO] finished tweaking crates.io crate gaffer 0.2.0 [INFO] tweaked toml for crates.io crate gaffer 0.2.0 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate crates.io crate gaffer 0.2.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0e708d2cc7cec1ed615e1958a2be1f8e2c8a9ef6fd51501555e8e4c1cba427d2 [INFO] running `Command { std: "docker" "start" "-a" "0e708d2cc7cec1ed615e1958a2be1f8e2c8a9ef6fd51501555e8e4c1cba427d2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0e708d2cc7cec1ed615e1958a2be1f8e2c8a9ef6fd51501555e8e4c1cba427d2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0e708d2cc7cec1ed615e1958a2be1f8e2c8a9ef6fd51501555e8e4c1cba427d2", kill_on_drop: false }` [INFO] [stdout] 0e708d2cc7cec1ed615e1958a2be1f8e2c8a9ef6fd51501555e8e4c1cba427d2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d070dc7a8f7c968e9915e99be82d409dbd859bd3304837d7be329faf01dc6092 [INFO] running `Command { std: "docker" "start" "-a" "d070dc7a8f7c968e9915e99be82d409dbd859bd3304837d7be329faf01dc6092", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.30 [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Compiling memchr v2.4.1 [INFO] [stderr] Compiling unicode-xid v0.2.2 [INFO] [stderr] Compiling libc v0.2.105 [INFO] [stderr] Compiling syn v1.0.80 [INFO] [stderr] Compiling proc-macro-hack v0.5.19 [INFO] [stderr] Compiling futures-core v0.3.17 [INFO] [stderr] Compiling proc-macro-nested v0.1.7 [INFO] [stderr] Compiling futures-channel v0.3.17 [INFO] [stderr] Compiling futures-task v0.3.17 [INFO] [stderr] Compiling crossbeam-utils v0.8.5 [INFO] [stderr] Compiling parking_lot_core v0.8.5 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Checking futures-sink v0.3.17 [INFO] [stderr] Compiling futures-macro v0.3.17 [INFO] [stderr] Compiling futures-util v0.3.17 [INFO] [stderr] Checking instant v0.1.12 [INFO] [stderr] Checking smallvec v1.7.0 [INFO] [stderr] Checking futures-io v0.3.17 [INFO] [stderr] Compiling quote v1.0.10 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking pin-project-lite v0.2.7 [INFO] [stderr] Checking slab v0.4.5 [INFO] [stderr] Checking lock_api v0.4.5 [INFO] [stderr] Checking aho-corasick v0.7.18 [INFO] [stderr] Checking regex-syntax v0.6.25 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Checking termcolor v1.1.2 [INFO] [stderr] Checking crossbeam-channel v0.5.1 [INFO] [stderr] Checking parking_lot v0.11.2 [INFO] [stderr] Checking gaffer v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: enum `NeverRecur` is never used [INFO] [stdout] --> src/source.rs:186:6 [INFO] [stdout] | [INFO] [stdout] 186 | enum NeverRecur {} [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/future.rs:104:13 [INFO] [stdout] | [INFO] [stdout] 102 | let shared = Default::default(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 103 | ( [INFO] [stdout] 104 | / Self { [INFO] [stdout] 105 | | shared: Arc::clone(&shared), [INFO] [stdout] 106 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/future.rs:107:13 [INFO] [stdout] | [INFO] [stdout] 102 | let shared = Default::default(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 107 | PromiseFuture { shared }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runner.rs:35:5 [INFO] [stdout] | [INFO] [stdout] 26 | jobs: Arc>>, [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | concurrency_limit: Box>, [INFO] [stdout] | --------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 33 | let queue = jobs.lock().queue(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | let barrier = Arc::new(Barrier::new(thread_num)); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | / RunnerState::new(thread_num, concurrency_limit) [INFO] [stdout] 36 | | .map(move |(recv, state)| { [INFO] [stdout] 37 | | let jobs = jobs.clone(); [INFO] [stdout] 38 | | let queue = queue.clone(); [INFO] [stdout] ... | [INFO] [stdout] 45 | | .unwrap() [INFO] [stdout] 46 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runner.rs:40:13 [INFO] [stdout] | [INFO] [stdout] 26 | jobs: Arc>>, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 33 | let queue = jobs.lock().queue(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | let barrier = Arc::new(Barrier::new(thread_num)); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | RunnerState::new(thread_num, concurrency_limit) [INFO] [stdout] 36 | .map(move |(recv, state)| { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | let jobs = jobs.clone(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | let queue = queue.clone(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | let barrier = barrier.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | / thread::Builder::new() [INFO] [stdout] 41 | | .name(format!("gaffer#{}", state.worker_index)) [INFO] [stdout] 42 | | .spawn(move || { [INFO] [stdout] 43 | | Runner::new(state, jobs, queue).run(barrier, recv); [INFO] [stdout] 44 | | }) [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runner.rs:167:9 [INFO] [stdout] | [INFO] [stdout] 161 | concurrency_limit: impl Into>>, [INFO] [stdout] | -------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 162 | ) -> impl Iterator, Self)> { [INFO] [stdout] 163 | let (receivers, worker_state): (Vec<_>, _) = [INFO] [stdout] | --------- ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 164 | iter::repeat_with(WorkerState::available).take(num).unzip(); [INFO] [stdout] 165 | let worker_state = Arc::new(Mutex::new(worker_state)); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 166 | let concurrency_limit = concurrency_limit.into(); [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 167 | receivers.into_iter().enumerate().map(move |(idx, recv)| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runner.rs:167:47 [INFO] [stdout] | [INFO] [stdout] 161 | concurrency_limit: impl Into>>, [INFO] [stdout] | -------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 162 | ) -> impl Iterator, Self)> { [INFO] [stdout] 163 | let (receivers, worker_state): (Vec<_>, _) = [INFO] [stdout] | --------- ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 164 | iter::repeat_with(WorkerState::available).take(num).unzip(); [INFO] [stdout] 165 | let worker_state = Arc::new(Mutex::new(worker_state)); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 166 | let concurrency_limit = concurrency_limit.into(); [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 167 | receivers.into_iter().enumerate().map(move |(idx, recv)| { [INFO] [stdout] | _______________________________________________^ [INFO] [stdout] 168 | | ( [INFO] [stdout] 169 | | recv, [INFO] [stdout] 170 | | Self { [INFO] [stdout] ... | [INFO] [stdout] 175 | | ) [INFO] [stdout] 176 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runner.rs:170:17 [INFO] [stdout] | [INFO] [stdout] 165 | let worker_state = Arc::new(Mutex::new(worker_state)); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 166 | let concurrency_limit = concurrency_limit.into(); [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 167 | receivers.into_iter().enumerate().map(move |(idx, recv)| { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 170 | / Self { [INFO] [stdout] 171 | | workers: worker_state.clone(), [INFO] [stdout] 172 | | worker_index: idx, [INFO] [stdout] 173 | | concurrency_limit: concurrency_limit.clone(), [INFO] [stdout] 174 | | }, [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runner.rs:314:16 [INFO] [stdout] | [INFO] [stdout] 313 | let (send, recv) = crossbeam_channel::bounded(1); [INFO] [stdout] | ---- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 314 | (recv, Self::Available(send)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/source.rs:68:13 [INFO] [stdout] | [INFO] [stdout] 62 | recurring: Vec, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 65 | let (send, recv) = prioritized_mpsc::channel(merge_fn); [INFO] [stdout] | ---- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 68 | / SourceManager { [INFO] [stdout] 69 | | queue: recv, [INFO] [stdout] 70 | | recurring, [INFO] [stdout] 71 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/source/util.rs:208:13 [INFO] [stdout] | [INFO] [stdout] 206 | pub fn into_inner(mut self) -> I::Item { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 207 | self.taken = true; [INFO] [stdout] 208 | self.iter.take().unwrap() // `SkipableNext` is only created after a `has_next()` check, so safe to unwrap [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/source/util.rs:447:13 [INFO] [stdout] | [INFO] [stdout] 444 | let (send, recv) = crossbeam_channel::unbounded(); [INFO] [stdout] | ---- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 447 | / Receiver { [INFO] [stdout] 448 | | queue: Arc::new(Mutex::new(PriorityQueue::new(merge_fn))), [INFO] [stdout] 449 | | recv, [INFO] [stdout] 450 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 11 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `gaffer` (lib) due to 12 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "d070dc7a8f7c968e9915e99be82d409dbd859bd3304837d7be329faf01dc6092", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d070dc7a8f7c968e9915e99be82d409dbd859bd3304837d7be329faf01dc6092", kill_on_drop: false }` [INFO] [stdout] d070dc7a8f7c968e9915e99be82d409dbd859bd3304837d7be329faf01dc6092