[INFO] fetching crate g-rust 0.0.1-beta.8... [INFO] checking g-rust-0.0.1-beta.8 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate g-rust 0.0.1-beta.8 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate g-rust 0.0.1-beta.8 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate g-rust 0.0.1-beta.8 [INFO] finished tweaking crates.io crate g-rust 0.0.1-beta.8 [INFO] tweaked toml for crates.io crate g-rust 0.0.1-beta.8 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 27 packages to latest compatible versions [INFO] [stderr] Adding darling v0.14.4 (latest: v0.20.10) [INFO] [stderr] Adding darling_core v0.14.4 (latest: v0.20.10) [INFO] [stderr] Adding darling_macro v0.14.4 (latest: v0.20.10) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding quote v0.3.15 (latest: v1.0.37) [INFO] [stderr] Adding strsim v0.10.0 (latest: v0.11.1) [INFO] [stderr] Adding syn v0.11.11 (latest: v2.0.77) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding unicode-xid v0.0.4 (latest: v0.2.5) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4950fb02a6d952192f8836788f43f34f97b34133d6ae1e0ab2ddbd69cf8028f0 [INFO] running `Command { std: "docker" "start" "-a" "4950fb02a6d952192f8836788f43f34f97b34133d6ae1e0ab2ddbd69cf8028f0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4950fb02a6d952192f8836788f43f34f97b34133d6ae1e0ab2ddbd69cf8028f0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4950fb02a6d952192f8836788f43f34f97b34133d6ae1e0ab2ddbd69cf8028f0", kill_on_drop: false }` [INFO] [stdout] 4950fb02a6d952192f8836788f43f34f97b34133d6ae1e0ab2ddbd69cf8028f0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5e15da44d86667d3f818d4f03b882828f714224e62d614a46887ecaff58c4e33 [INFO] running `Command { std: "docker" "start" "-a" "5e15da44d86667d3f818d4f03b882828f714224e62d614a46887ecaff58c4e33", kill_on_drop: false }` [INFO] [stderr] Checking encoding_index_tests v0.1.4 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling ident_case v1.0.1 [INFO] [stderr] Compiling strsim v0.10.0 [INFO] [stderr] Compiling fnv v1.0.7 [INFO] [stderr] Compiling unicode-xid v0.0.4 [INFO] [stderr] Compiling quote v0.3.15 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Compiling synom v0.11.3 [INFO] [stderr] Checking encoding-index-tradchinese v1.20141219.5 [INFO] [stderr] Checking encoding-index-singlebyte v1.20141219.5 [INFO] [stderr] Checking encoding-index-japanese v1.20141219.5 [INFO] [stderr] Checking encoding-index-korean v1.20141219.5 [INFO] [stderr] Checking encoding-index-simpchinese v1.20141219.5 [INFO] [stderr] Checking miniz_oxide v0.7.4 [INFO] [stderr] Compiling syn v0.11.11 [INFO] [stderr] Checking encoding v0.2.33 [INFO] [stderr] Compiling packetvar-derive v0.1.0 [INFO] [stderr] Compiling darling_core v0.14.4 [INFO] [stderr] Compiling darling_macro v0.14.4 [INFO] [stderr] Compiling darling v0.14.4 [INFO] [stderr] Compiling parser-derive v0.1.0 [INFO] [stderr] Checking g-rust v0.0.1-beta.8 (/opt/rustwide/workdir) [INFO] [stdout] warning: associated function `from` is never used [INFO] [stdout] --> src/protocol/vars/longstring.rs:10:12 [INFO] [stdout] | [INFO] [stdout] 9 | impl LongString { [INFO] [stdout] | --------------- associated function in this implementation [INFO] [stdout] 10 | pub fn from(s: &str) -> LongString { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated constants `PACKET_TO_STRING_RESPONSE` and `STRING_TO_PACKET_RESPONSE` are never used [INFO] [stdout] --> src/misc/messages.rs:11:15 [INFO] [stdout] | [INFO] [stdout] 2 | impl IncomingMessageIds { [INFO] [stdout] | ----------------------- associated constants in this implementation [INFO] [stdout] ... [INFO] [stdout] 11 | pub const PACKET_TO_STRING_RESPONSE: i16 = 20; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 12 | pub const STRING_TO_PACKET_RESPONSE: i16 = 21; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated constants `PACKET_TO_STRING_REQUEST` and `STRING_TO_PACKET_REQUEST` are never used [INFO] [stdout] --> src/misc/messages.rs:21:15 [INFO] [stdout] | [INFO] [stdout] 16 | impl OutgoingMessageIds { [INFO] [stdout] | ----------------------- associated constants in this implementation [INFO] [stdout] ... [INFO] [stdout] 21 | pub const PACKET_TO_STRING_REQUEST: i16 = 20; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 22 | pub const STRING_TO_PACKET_REQUEST: i16 = 21; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol/vars/packetvariable.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 18 | fn to_sized_array(v: Vec) -> [T; N] { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | v[..N].to_vec().try_into().expect("Not enough byte lefts to read") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol/vars/packetvariable.rs:177:18 [INFO] [stdout] | [INFO] [stdout] 173 | let mut res: Vec = Vec::new(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 177 | (to_sized_array::(res), packet.read_index - 6) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 193 | impl_packet_array_variable! { 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30 } [INFO] [stdout] | --------------------------------------------------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `impl_packet_array_variable` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `from` is never used [INFO] [stdout] --> src/protocol/vars/longstring.rs:10:12 [INFO] [stdout] | [INFO] [stdout] 9 | impl LongString { [INFO] [stdout] | --------------- associated function in this implementation [INFO] [stdout] 10 | pub fn from(s: &str) -> LongString { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated constants `PACKET_TO_STRING_RESPONSE` and `STRING_TO_PACKET_RESPONSE` are never used [INFO] [stdout] --> src/misc/messages.rs:11:15 [INFO] [stdout] | [INFO] [stdout] 2 | impl IncomingMessageIds { [INFO] [stdout] | ----------------------- associated constants in this implementation [INFO] [stdout] ... [INFO] [stdout] 11 | pub const PACKET_TO_STRING_RESPONSE: i16 = 20; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 12 | pub const STRING_TO_PACKET_RESPONSE: i16 = 21; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated constants `PACKET_TO_STRING_REQUEST` and `STRING_TO_PACKET_REQUEST` are never used [INFO] [stdout] --> src/misc/messages.rs:21:15 [INFO] [stdout] | [INFO] [stdout] 16 | impl OutgoingMessageIds { [INFO] [stdout] | ----------------------- associated constants in this implementation [INFO] [stdout] ... [INFO] [stdout] 21 | pub const PACKET_TO_STRING_REQUEST: i16 = 20; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 22 | pub const STRING_TO_PACKET_REQUEST: i16 = 21; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol/vars/packetvariable.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 18 | fn to_sized_array(v: Vec) -> [T; N] { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | v[..N].to_vec().try_into().expect("Not enough byte lefts to read") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol/vars/packetvariable.rs:177:18 [INFO] [stdout] | [INFO] [stdout] 173 | let mut res: Vec = Vec::new(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 177 | (to_sized_array::(res), packet.read_index - 6) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 193 | impl_packet_array_variable! { 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30 } [INFO] [stdout] | --------------------------------------------------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `impl_packet_array_variable` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/misc/connection.rs:17:21 [INFO] [stdout] | [INFO] [stdout] 15 | let socket = self.socket.try_clone().expect("Couldn't clone extension"); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | GEarthConnection { [INFO] [stdout] 17 | socket: Box::new(socket) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/misc/connection.rs:27:21 [INFO] [stdout] | [INFO] [stdout] 24 | let con = TcpStream::connect(format!("127.0.0.1:{port}")).expect("Couldn't connect to G-Earth..."); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 27 | socket: Box::new(con) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/misc/connection.rs:17:21 [INFO] [stdout] | [INFO] [stdout] 15 | let socket = self.socket.try_clone().expect("Couldn't clone extension"); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | GEarthConnection { [INFO] [stdout] 17 | socket: Box::new(socket) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/misc/connection.rs:27:21 [INFO] [stdout] | [INFO] [stdout] 24 | let con = TcpStream::connect(format!("127.0.0.1:{port}")).expect("Couldn't connect to G-Earth..."); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 27 | socket: Box::new(con) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `g-rust` (lib) due to 5 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 4 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `g-rust` (lib test) due to 5 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "5e15da44d86667d3f818d4f03b882828f714224e62d614a46887ecaff58c4e33", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5e15da44d86667d3f818d4f03b882828f714224e62d614a46887ecaff58c4e33", kill_on_drop: false }` [INFO] [stdout] 5e15da44d86667d3f818d4f03b882828f714224e62d614a46887ecaff58c4e33