[INFO] fetching crate fwm 0.1.0... [INFO] checking fwm-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate fwm 0.1.0 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate fwm 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate fwm 0.1.0 [INFO] finished tweaking crates.io crate fwm 0.1.0 [INFO] tweaked toml for crates.io crate fwm 0.1.0 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate crates.io crate fwm 0.1.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a54e8de6714dfbafa08d5b70e11e04b179f54f7bfae66069635a9759c0e08783 [INFO] running `Command { std: "docker" "start" "-a" "a54e8de6714dfbafa08d5b70e11e04b179f54f7bfae66069635a9759c0e08783", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a54e8de6714dfbafa08d5b70e11e04b179f54f7bfae66069635a9759c0e08783", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a54e8de6714dfbafa08d5b70e11e04b179f54f7bfae66069635a9759c0e08783", kill_on_drop: false }` [INFO] [stdout] a54e8de6714dfbafa08d5b70e11e04b179f54f7bfae66069635a9759c0e08783 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] dfa833e152d5b8edc9240d6ae54a6176ac345c667dfb3f5bfca9af7ce68cd54c [INFO] running `Command { std: "docker" "start" "-a" "dfa833e152d5b8edc9240d6ae54a6176ac345c667dfb3f5bfca9af7ce68cd54c", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.26 [INFO] [stderr] Compiling unicode-xid v0.2.1 [INFO] [stderr] Compiling syn v1.0.68 [INFO] [stderr] Compiling serde_derive v1.0.125 [INFO] [stderr] Compiling serde v1.0.125 [INFO] [stderr] Compiling unicode-segmentation v1.7.1 [INFO] [stderr] Compiling pkg-config v0.3.19 [INFO] [stderr] Compiling version-compare v0.0.10 [INFO] [stderr] Compiling strum v0.18.0 [INFO] [stderr] Compiling libc v0.2.93 [INFO] [stderr] Compiling version_check v0.9.3 [INFO] [stderr] Compiling proc-macro-hack v0.5.19 [INFO] [stderr] Compiling proc-macro-nested v0.1.7 [INFO] [stderr] Compiling memchr v2.3.4 [INFO] [stderr] Checking futures-sink v0.3.14 [INFO] [stderr] Checking futures-core v0.3.14 [INFO] [stderr] Compiling anyhow v1.0.40 [INFO] [stderr] Checking futures-io v0.3.14 [INFO] [stderr] Checking pin-project-lite v0.2.6 [INFO] [stderr] Checking futures-channel v0.3.14 [INFO] [stderr] Checking slab v0.4.2 [INFO] [stderr] Checking futures-task v0.3.14 [INFO] [stderr] Compiling either v1.6.1 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Checking once_cell v1.7.2 [INFO] [stderr] Compiling gio v0.9.1 [INFO] [stderr] Compiling getrandom v0.2.2 [INFO] [stderr] Compiling cairo-rs v0.9.1 [INFO] [stderr] Compiling itertools v0.9.0 [INFO] [stderr] Compiling gdk-pixbuf v0.9.0 [INFO] [stderr] Compiling pango v0.9.1 [INFO] [stderr] Compiling gdk v0.13.2 [INFO] [stderr] Compiling heck v0.3.2 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling ryu v1.0.5 [INFO] [stderr] Compiling atk v0.9.0 [INFO] [stderr] Compiling serde_json v1.0.64 [INFO] [stderr] Checking ppv-lite86 v0.2.10 [INFO] [stderr] Checking itoa v0.4.7 [INFO] [stderr] Compiling gtk v0.9.2 [INFO] [stderr] Compiling quote v1.0.9 [INFO] [stderr] Checking rand_core v0.6.2 [INFO] [stderr] Checking rand_chacha v0.3.0 [INFO] [stderr] Checking rand v0.8.3 [INFO] [stderr] Compiling thiserror-impl v1.0.24 [INFO] [stderr] Compiling strum_macros v0.18.0 [INFO] [stderr] Compiling futures-macro v0.3.14 [INFO] [stderr] Checking futures-util v0.3.14 [INFO] [stderr] Compiling thiserror v1.0.24 [INFO] [stderr] Checking futures-executor v0.3.14 [INFO] [stderr] Checking futures v0.3.14 [INFO] [stderr] Compiling toml v0.5.8 [INFO] [stderr] Compiling system-deps v1.3.2 [INFO] [stderr] Compiling proc-macro-crate v0.1.5 [INFO] [stderr] Compiling glib-macros v0.10.1 [INFO] [stderr] Compiling glib-sys v0.10.1 [INFO] [stderr] Compiling gobject-sys v0.10.0 [INFO] [stderr] Compiling gio-sys v0.10.1 [INFO] [stderr] Compiling cairo-sys-rs v0.10.0 [INFO] [stderr] Compiling pango-sys v0.10.0 [INFO] [stderr] Compiling gdk-pixbuf-sys v0.10.0 [INFO] [stderr] Compiling gdk-sys v0.10.0 [INFO] [stderr] Compiling atk-sys v0.10.0 [INFO] [stderr] Compiling gtk-sys v0.10.0 [INFO] [stderr] Checking glib v0.10.3 [INFO] [stderr] Checking fwm v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/lib.rs:602:31 [INFO] [stdout] | [INFO] [stdout] 602 | let move_horizontal = (dir == Direction::Left || dir == Direction::Right); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 602 - let move_horizontal = (dir == Direction::Left || dir == Direction::Right); [INFO] [stdout] 602 + let move_horizontal = dir == Direction::Left || dir == Direction::Right; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/lib.rs:603:29 [INFO] [stdout] | [INFO] [stdout] 603 | let move_to_first = (dir == Direction::Right || dir == Direction::Down); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 603 - let move_to_first = (dir == Direction::Right || dir == Direction::Down); [INFO] [stdout] 603 + let move_to_first = dir == Direction::Right || dir == Direction::Down; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/lib.rs:602:31 [INFO] [stdout] | [INFO] [stdout] 602 | let move_horizontal = (dir == Direction::Left || dir == Direction::Right); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 602 - let move_horizontal = (dir == Direction::Left || dir == Direction::Right); [INFO] [stdout] 602 + let move_horizontal = dir == Direction::Left || dir == Direction::Right; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/lib.rs:603:29 [INFO] [stdout] | [INFO] [stdout] 603 | let move_to_first = (dir == Direction::Right || dir == Direction::Down); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 603 - let move_to_first = (dir == Direction::Right || dir == Direction::Down); [INFO] [stdout] 603 + let move_to_first = dir == Direction::Right || dir == Direction::Down; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `w_idx` [INFO] [stdout] --> src/lib.rs:641:29 [INFO] [stdout] | [INFO] [stdout] 641 | ItemIdx::Window(w_idx) => { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_w_idx` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `w_idx` [INFO] [stdout] --> src/lib.rs:641:29 [INFO] [stdout] | [INFO] [stdout] 641 | ItemIdx::Window(w_idx) => { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_w_idx` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `n_children` is never used [INFO] [stdout] --> src/lib.rs:136:8 [INFO] [stdout] | [INFO] [stdout] 135 | impl Layout { [INFO] [stdout] | ----------- method in this implementation [INFO] [stdout] 136 | fn n_children(&self, item: ItemIdx) -> usize { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:3:56 [INFO] [stdout] | [INFO] [stdout] 3 | #[derive(Debug, Eq, PartialEq, Copy, Clone, Serialize, Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `n_children` is never used [INFO] [stdout] --> src/lib.rs:136:8 [INFO] [stdout] | [INFO] [stdout] 135 | impl Layout { [INFO] [stdout] | ----------- method in this implementation [INFO] [stdout] 136 | fn n_children(&self, item: ItemIdx) -> usize { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:37:56 [INFO] [stdout] | [INFO] [stdout] 37 | #[derive(Debug, Eq, PartialEq, Copy, Clone, Serialize, Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:3:56 [INFO] [stdout] | [INFO] [stdout] 3 | #[derive(Debug, Eq, PartialEq, Copy, Clone, Serialize, Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:37:56 [INFO] [stdout] | [INFO] [stdout] 37 | #[derive(Debug, Eq, PartialEq, Copy, Clone, Serialize, Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:654:56 [INFO] [stdout] | [INFO] [stdout] 654 | #[derive(Debug, Eq, PartialEq, Copy, Clone, Serialize, Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:654:56 [INFO] [stdout] | [INFO] [stdout] 654 | #[derive(Debug, Eq, PartialEq, Copy, Clone, Serialize, Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `fwm` (lib test) due to 4 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `fwm` (lib) due to 4 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "dfa833e152d5b8edc9240d6ae54a6176ac345c667dfb3f5bfca9af7ce68cd54c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "dfa833e152d5b8edc9240d6ae54a6176ac345c667dfb3f5bfca9af7ce68cd54c", kill_on_drop: false }` [INFO] [stdout] dfa833e152d5b8edc9240d6ae54a6176ac345c667dfb3f5bfca9af7ce68cd54c