[INFO] fetching crate fuzzy-tree 0.1.2... [INFO] checking fuzzy-tree-0.1.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate fuzzy-tree 0.1.2 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate fuzzy-tree 0.1.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate fuzzy-tree 0.1.2 [INFO] finished tweaking crates.io crate fuzzy-tree 0.1.2 [INFO] tweaked toml for crates.io crate fuzzy-tree 0.1.2 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate crates.io crate fuzzy-tree 0.1.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a979f4b95595df1dd2ed9692cb06e8e07622e2a325812aa06512303e9d4c220c [INFO] running `Command { std: "docker" "start" "-a" "a979f4b95595df1dd2ed9692cb06e8e07622e2a325812aa06512303e9d4c220c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a979f4b95595df1dd2ed9692cb06e8e07622e2a325812aa06512303e9d4c220c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a979f4b95595df1dd2ed9692cb06e8e07622e2a325812aa06512303e9d4c220c", kill_on_drop: false }` [INFO] [stdout] a979f4b95595df1dd2ed9692cb06e8e07622e2a325812aa06512303e9d4c220c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1c89f453d21df666e29c711da79c07d56c8732b3f2edfe59772adbdb94be22a9 [INFO] running `Command { std: "docker" "start" "-a" "1c89f453d21df666e29c711da79c07d56c8732b3f2edfe59772adbdb94be22a9", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.68 [INFO] [stderr] Compiling cc v1.0.52 [INFO] [stderr] Compiling memchr v2.3.3 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Compiling log v0.4.8 [INFO] [stderr] Checking rustc-demangle v0.1.16 [INFO] [stderr] Checking regex-syntax v0.6.17 [INFO] [stderr] Checking unicode-width v0.1.7 [INFO] [stderr] Checking quick-error v1.2.3 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking vec_map v0.8.1 [INFO] [stderr] Checking numtoa v0.1.0 [INFO] [stderr] Checking termcolor v1.1.0 [INFO] [stderr] Checking thread_local v1.0.1 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking humantime v1.3.0 [INFO] [stderr] Checking aho-corasick v0.7.10 [INFO] [stderr] Compiling backtrace-sys v0.1.36 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking termion v1.5.5 [INFO] [stderr] Checking clap v2.33.0 [INFO] [stderr] Checking backtrace v0.3.46 [INFO] [stderr] Checking failure v0.1.7 [INFO] [stderr] Checking which v3.1.1 [INFO] [stderr] Checking regex v1.3.6 [INFO] [stderr] Checking env_logger v0.7.1 [INFO] [stderr] Checking fuzzy-tree v0.1.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: methods `add_parent` and `n_children` are never used [INFO] [stdout] --> src/path.rs:92:5 [INFO] [stdout] | [INFO] [stdout] 89 | pub trait PathBehaviour { [INFO] [stdout] | ------------- methods in this trait [INFO] [stdout] ... [INFO] [stdout] 92 | fn add_parent(&self, parent: &RcPath); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 96 | fn n_children(&self) -> usize; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/path.rs:164:26 [INFO] [stdout] | [INFO] [stdout] 164 | .map(|x| Path::from(x, fs::metadata(&x).map_or_else(|_| false, |v| v.is_dir()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tree.rs:82:16 [INFO] [stdout] | [INFO] [stdout] 82 | .filter(|p| p.borrow().matched) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tree.rs:429:60 [INFO] [stdout] | [INFO] [stdout] 429 | let children: Vec<&RcPath> = children.iter().filter(|x| x.borrow().matched).collect(); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tui.rs:96:6 [INFO] [stdout] | [INFO] [stdout] 80 | let mut stdout = io::stdout().into_raw_mode()?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 96 | Ok(Tui { [INFO] [stdout] | ____________^ [INFO] [stdout] 97 | | stdout: stdout, [INFO] [stdout] 98 | | start_pos: start_pos, [INFO] [stdout] 99 | | curs_pos: 0, [INFO] [stdout] ... | [INFO] [stdout] 107 | | current_lines, [INFO] [stdout] 108 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `fuzzy-tree` (bin "fztree") due to 5 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/tree.rs:525:7 [INFO] [stdout] | [INFO] [stdout] 525 | let mut paths = create_test_paths(); [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `add_parent` and `n_children` are never used [INFO] [stdout] --> src/path.rs:92:5 [INFO] [stdout] | [INFO] [stdout] 89 | pub trait PathBehaviour { [INFO] [stdout] | ------------- methods in this trait [INFO] [stdout] ... [INFO] [stdout] 92 | fn add_parent(&self, parent: &RcPath); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 96 | fn n_children(&self) -> usize; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/path.rs:164:26 [INFO] [stdout] | [INFO] [stdout] 164 | .map(|x| Path::from(x, fs::metadata(&x).map_or_else(|_| false, |v| v.is_dir()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tree.rs:82:16 [INFO] [stdout] | [INFO] [stdout] 82 | .filter(|p| p.borrow().matched) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tree.rs:429:60 [INFO] [stdout] | [INFO] [stdout] 429 | let children: Vec<&RcPath> = children.iter().filter(|x| x.borrow().matched).collect(); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused borrow that must be used [INFO] [stdout] --> src/tree.rs:481:3 [INFO] [stdout] | [INFO] [stdout] 481 | &paths[3].add_child(&paths[4]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the borrow produces a value [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 481 | let _ = &paths[3].add_child(&paths[4]); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused borrow that must be used [INFO] [stdout] --> src/tree.rs:482:3 [INFO] [stdout] | [INFO] [stdout] 482 | &paths[4].add_child(&paths[5]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the borrow produces a value [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 482 | let _ = &paths[4].add_child(&paths[5]); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused borrow that must be used [INFO] [stdout] --> src/tree.rs:483:3 [INFO] [stdout] | [INFO] [stdout] 483 | &paths[4].add_child(&paths[6]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the borrow produces a value [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 483 | let _ = &paths[4].add_child(&paths[6]); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused borrow that must be used [INFO] [stdout] --> src/tree.rs:484:3 [INFO] [stdout] | [INFO] [stdout] 484 | &paths[3].add_child(&paths[7]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the borrow produces a value [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 484 | let _ = &paths[3].add_child(&paths[7]); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused borrow that must be used [INFO] [stdout] --> src/tree.rs:485:3 [INFO] [stdout] | [INFO] [stdout] 485 | &paths[7].add_child(&paths[8]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the borrow produces a value [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 485 | let _ = &paths[7].add_child(&paths[8]); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused borrow that must be used [INFO] [stdout] --> src/tree.rs:486:3 [INFO] [stdout] | [INFO] [stdout] 486 | &paths[7].add_child(&paths[9]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the borrow produces a value [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 486 | let _ = &paths[7].add_child(&paths[9]); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tui.rs:96:6 [INFO] [stdout] | [INFO] [stdout] 80 | let mut stdout = io::stdout().into_raw_mode()?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 96 | Ok(Tui { [INFO] [stdout] | ____________^ [INFO] [stdout] 97 | | stdout: stdout, [INFO] [stdout] 98 | | start_pos: start_pos, [INFO] [stdout] 99 | | curs_pos: 0, [INFO] [stdout] ... | [INFO] [stdout] 107 | | current_lines, [INFO] [stdout] 108 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `fuzzy-tree` (bin "fztree" test) due to 5 previous errors; 8 warnings emitted [INFO] running `Command { std: "docker" "inspect" "1c89f453d21df666e29c711da79c07d56c8732b3f2edfe59772adbdb94be22a9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1c89f453d21df666e29c711da79c07d56c8732b3f2edfe59772adbdb94be22a9", kill_on_drop: false }` [INFO] [stdout] 1c89f453d21df666e29c711da79c07d56c8732b3f2edfe59772adbdb94be22a9