[INFO] fetching crate futures-rate 0.1.5... [INFO] checking futures-rate-0.1.5 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate futures-rate 0.1.5 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate futures-rate 0.1.5 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate futures-rate 0.1.5 [INFO] finished tweaking crates.io crate futures-rate 0.1.5 [INFO] tweaked toml for crates.io crate futures-rate 0.1.5 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate crates.io crate futures-rate 0.1.5 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ba00c5b6064aaf31afb1a93aca3ce8c31f499e656f30feb6d1956db6adea7fe4 [INFO] running `Command { std: "docker" "start" "-a" "ba00c5b6064aaf31afb1a93aca3ce8c31f499e656f30feb6d1956db6adea7fe4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ba00c5b6064aaf31afb1a93aca3ce8c31f499e656f30feb6d1956db6adea7fe4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ba00c5b6064aaf31afb1a93aca3ce8c31f499e656f30feb6d1956db6adea7fe4", kill_on_drop: false }` [INFO] [stdout] ba00c5b6064aaf31afb1a93aca3ce8c31f499e656f30feb6d1956db6adea7fe4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4e913fc24fe1544c4a6c3246b310caca2356f07feecc048c7a859767a72218e8 [INFO] running `Command { std: "docker" "start" "-a" "4e913fc24fe1544c4a6c3246b310caca2356f07feecc048c7a859767a72218e8", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.6 [INFO] [stderr] Compiling syn v1.0.11 [INFO] [stderr] Compiling proc-macro-nested v0.1.3 [INFO] [stderr] Compiling memchr v2.2.1 [INFO] [stderr] Compiling autocfg v0.1.7 [INFO] [stderr] Compiling libc v0.2.66 [INFO] [stderr] Checking futures-core v0.3.1 [INFO] [stderr] Checking futures-sink v0.3.1 [INFO] [stderr] Checking slab v0.4.2 [INFO] [stderr] Checking futures-channel v0.3.1 [INFO] [stderr] Checking futures-task v0.3.1 [INFO] [stderr] Checking futures-io v0.3.1 [INFO] [stderr] Checking pin-utils v0.1.0-alpha.4 [INFO] [stderr] Compiling crossbeam-utils v0.7.0 [INFO] [stderr] Compiling quote v1.0.2 [INFO] [stderr] Checking crossbeam-queue v0.2.0 [INFO] [stderr] Checking num_cpus v1.11.1 [INFO] [stderr] Checking futures-rate v0.1.5 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around function argument [INFO] [stdout] --> src/gatekeeper.rs:104:13 [INFO] [stdout] | [INFO] [stdout] 104 | / ( [INFO] [stdout] 105 | | async move { [INFO] [stdout] | |________________^ [INFO] [stdout] ... [INFO] [stdout] 108 | } [INFO] [stdout] | __________________^ [INFO] [stdout] 109 | | // Token {}, [INFO] [stdout] 110 | | ), [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 104 ~ async move { [INFO] [stdout] 105 | ticket.await?; [INFO] [stdout] 106 | Ok(fut.await) [INFO] [stdout] 107 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `add_token` is never used [INFO] [stdout] --> src/inner.rs:93:8 [INFO] [stdout] | [INFO] [stdout] 92 | pub(crate) trait TokenFetcher { [INFO] [stdout] | ------------ method in this trait [INFO] [stdout] 93 | fn add_token(&self, count: usize); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gatekeeper.rs:63:14 [INFO] [stdout] | [INFO] [stdout] 54 | pub fn register(&self, fut: F) -> Option> [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 63 | Some(Permit::new(fut, Arc::clone(&self.inner))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gatekeeper.rs:83:17 [INFO] [stdout] | [INFO] [stdout] 66 | pub fn issue(&self, fut: F) -> Option> [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 75 | let ticket: Ticket = Ticket::new(Arc::clone(&self.inner), None); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 78 | let _stub = match ticket.await { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 79 | Ok((t, _)) => t, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 83 | fut.await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gatekeeper.rs:104:13 [INFO] [stdout] | [INFO] [stdout] 91 | fut: F, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 101 | let ticket: Ticket = Ticket::new(Arc::clone(&self.inner), None); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 104 | / ( [INFO] [stdout] 105 | | async move { [INFO] [stdout] 106 | | ticket.await?; [INFO] [stdout] 107 | | Ok(fut.await) [INFO] [stdout] 108 | | } [INFO] [stdout] 109 | | // Token {}, [INFO] [stdout] 110 | | ), [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gatekeeper.rs:107:24 [INFO] [stdout] | [INFO] [stdout] 91 | fut: F, [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 101 | let ticket: Ticket = Ticket::new(Arc::clone(&self.inner), None); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 107 | Ok(fut.await) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pass.rs:64:49 [INFO] [stdout] | [INFO] [stdout] 64 | let need_token = PERMIT_SET.with(|set| !set.borrow().contains(&pool_id)); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pass.rs:111:19 [INFO] [stdout] | [INFO] [stdout] 107 | pub(crate) fn new(pool: Arc, fut: Option) -> Self { [INFO] [stdout] | -------------------- -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 111 | pool: Some(pool), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pass.rs:112:18 [INFO] [stdout] | [INFO] [stdout] 107 | pub(crate) fn new(pool: Arc, fut: Option) -> Self { [INFO] [stdout] | -------------------- -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 112 | fut: fut.map(Box::pin), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pass.rs:210:18 [INFO] [stdout] | [INFO] [stdout] 210 | !set.borrow().contains(&ref_this.pool_id) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `futures-rate` (lib) due to 9 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "4e913fc24fe1544c4a6c3246b310caca2356f07feecc048c7a859767a72218e8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4e913fc24fe1544c4a6c3246b310caca2356f07feecc048c7a859767a72218e8", kill_on_drop: false }` [INFO] [stdout] 4e913fc24fe1544c4a6c3246b310caca2356f07feecc048c7a859767a72218e8