[INFO] crate futures-glib 0.4.0 is already in cache [INFO] checking futures-glib-0.4.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate futures-glib 0.4.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate futures-glib 0.4.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate futures-glib 0.4.0 [INFO] finished tweaking crates.io crate futures-glib 0.4.0 [INFO] tweaked toml for crates.io crate futures-glib 0.4.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 37 packages to latest compatible versions [INFO] [stderr] Adding atk-sys v0.6.0 (latest: v0.18.0) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding bytes v0.4.12 (latest: v1.7.1) [INFO] [stderr] Adding c_vec v1.3.3 (latest: v2.0.0) [INFO] [stderr] Adding cairo-rs v0.4.1 (latest: v0.20.1) [INFO] [stderr] Adding cairo-sys-rs v0.6.0 (latest: v0.20.0) [INFO] [stderr] Adding cfg-if v0.1.10 (latest: v1.0.0) [INFO] [stderr] Adding futures v0.1.31 (latest: v0.3.30) [INFO] [stderr] Adding gdk v0.8.0 (latest: v0.18.0) [INFO] [stderr] Adding gdk-pixbuf v0.4.0 (latest: v0.20.1) [INFO] [stderr] Adding gdk-pixbuf-sys v0.6.0 (latest: v0.20.1) [INFO] [stderr] Adding gdk-sys v0.6.0 (latest: v0.18.0) [INFO] [stderr] Adding gio v0.4.1 (latest: v0.20.1) [INFO] [stderr] Adding gio-sys v0.6.0 (latest: v0.20.1) [INFO] [stderr] Adding glib v0.5.0 (latest: v0.20.2) [INFO] [stderr] Adding glib-sys v0.6.0 (latest: v0.20.2) [INFO] [stderr] Adding gobject-sys v0.6.0 (latest: v0.20.1) [INFO] [stderr] Adding gtk v0.4.1 (latest: v0.18.1) [INFO] [stderr] Adding gtk-sys v0.6.0 (latest: v0.18.0) [INFO] [stderr] Adding pango v0.4.0 (latest: v0.20.1) [INFO] [stderr] Adding pango-sys v0.6.0 (latest: v0.20.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 28ad1e835b015bee0695c502f8f6e11248a0a9e0539390309b857839dfc0983d [INFO] running `Command { std: "docker" "start" "-a" "28ad1e835b015bee0695c502f8f6e11248a0a9e0539390309b857839dfc0983d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "28ad1e835b015bee0695c502f8f6e11248a0a9e0539390309b857839dfc0983d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "28ad1e835b015bee0695c502f8f6e11248a0a9e0539390309b857839dfc0983d", kill_on_drop: false }` [INFO] [stdout] 28ad1e835b015bee0695c502f8f6e11248a0a9e0539390309b857839dfc0983d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4459ba26fd9a8b3361213c01436216e0cc13bc1dd09a15fa5ece874961846cda [INFO] running `Command { std: "docker" "start" "-a" "4459ba26fd9a8b3361213c01436216e0cc13bc1dd09a15fa5ece874961846cda", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Compiling glib-sys v0.6.0 [INFO] [stderr] Compiling gobject-sys v0.6.0 [INFO] [stderr] Compiling gio-sys v0.6.0 [INFO] [stderr] Compiling gdk-pixbuf-sys v0.6.0 [INFO] [stderr] Compiling cairo-sys-rs v0.6.0 [INFO] [stderr] Compiling pango-sys v0.6.0 [INFO] [stderr] Compiling gdk-sys v0.6.0 [INFO] [stderr] Compiling atk-sys v0.6.0 [INFO] [stderr] Compiling gio v0.4.1 [INFO] [stderr] Compiling gtk-sys v0.6.0 [INFO] [stderr] Compiling gdk-pixbuf v0.4.0 [INFO] [stderr] Compiling cairo-rs v0.4.1 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Compiling winapi v0.3.9 [INFO] [stderr] Checking c_vec v1.3.3 [INFO] [stderr] Compiling gdk v0.8.0 [INFO] [stderr] Checking bytes v0.4.12 [INFO] [stderr] Compiling gtk v0.4.1 [INFO] [stderr] Checking net2 v0.2.39 [INFO] [stderr] Checking tokio-io v0.1.13 [INFO] [stderr] Checking futures-glib v0.4.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: use of deprecated constant `std::sync::atomic::ATOMIC_BOOL_INIT`: the `new` function is now preferred [INFO] [stdout] --> src/rt.rs:1:47 [INFO] [stdout] | [INFO] [stdout] 1 | use std::sync::atomic::{AtomicBool, Ordering, ATOMIC_BOOL_INIT}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated constant `std::sync::atomic::ATOMIC_BOOL_INIT`: the `new` function is now preferred [INFO] [stdout] --> src/rt.rs:8:34 [INFO] [stdout] | [INFO] [stdout] 8 | static INITIALIZED: AtomicBool = ATOMIC_BOOL_INIT; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: replace the use of the deprecated constant [INFO] [stdout] | [INFO] [stdout] 8 | static INITIALIZED: AtomicBool = AtomicBool::new(false); [INFO] [stdout] | ~~~~~~~~~~~~~~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/future.rs:189:30 [INFO] [stdout] | [INFO] [stdout] 189 | future: Option>>>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 189 | future: Option>>>, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/future.rs:278:13 [INFO] [stdout] | [INFO] [stdout] 278 | Run(Box), [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 278 | Run(Box), [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:49:31 [INFO] [stdout] | [INFO] [stdout] 48 | fn new(t: T) -> ManuallyDrop { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | ManuallyDrop { inner: Some(t) } [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/future.rs:79:20 [INFO] [stdout] | [INFO] [stdout] 75 | pub fn spawn_fn(&self, f: F) [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 79 | self.spawn(future::lazy(f)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/future.rs:210:20 [INFO] [stdout] | [INFO] [stdout] 195 | let (tx, rx) = mpsc::unbounded(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 196 | let mut queue = Slab::with_capacity(128); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 206 | let ready_queue = Stack::new(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 210 | queue: RefCell::new(queue), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/future.rs:211:22 [INFO] [stdout] | [INFO] [stdout] 195 | let (tx, rx) = mpsc::unbounded(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 196 | let mut queue = Slab::with_capacity(128); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 206 | let ready_queue = Stack::new(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 211 | pending: RefCell::new(Stack::new().drain().peekable()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/future.rs:212:26 [INFO] [stdout] | [INFO] [stdout] 195 | let (tx, rx) = mpsc::unbounded(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 196 | let mut queue = Slab::with_capacity(128); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 206 | let ready_queue = Stack::new(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 212 | ready_queue: Arc::new(ready_queue), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/future.rs:213:28 [INFO] [stdout] | [INFO] [stdout] 195 | let (tx, rx) = mpsc::unbounded(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 196 | let mut queue = Slab::with_capacity(128); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 206 | let ready_queue = Stack::new(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 213 | message_queue: RefCell::new(spawn(rx)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a value that implements `Copy` does nothing [INFO] [stdout] --> src/timeout.rs:57:5 [INFO] [stdout] | [INFO] [stdout] 57 | drop(tx.send(())); [INFO] [stdout] | ^^^^^-----------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `Result<(), ()>` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dropping_copy_types)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 57 - drop(tx.send(())); [INFO] [stdout] 57 + let _ = tx.send(()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/net/tcp.rs:111:20 [INFO] [stdout] | [INFO] [stdout] 81 | let socket = (|| -> io::Result<_> { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 111 | state: Some(socket), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/net/tcp.rs:107:16 [INFO] [stdout] | [INFO] [stdout] 84 | let socket = match *addr { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 97 | let channel = IoChannel::from(socket); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 105 | let src = create_source(channel, active, context); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 106 | [INFO] [stdout] 107 | Ok(TcpStream { inner: src }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/net/tcp.rs:329:30 [INFO] [stdout] | [INFO] [stdout] 323 | let token = self.token.borrow(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 329 | (ready.is_input() && self.read.borrow().is_blocked()) || [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/net/tcp.rs:330:35 [INFO] [stdout] | [INFO] [stdout] 323 | let token = self.token.borrow(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 330 | (ready.is_output() && self.write.borrow().is_blocked()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 10 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `futures-glib` (lib) due to 11 previous errors; 5 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "4459ba26fd9a8b3361213c01436216e0cc13bc1dd09a15fa5ece874961846cda", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4459ba26fd9a8b3361213c01436216e0cc13bc1dd09a15fa5ece874961846cda", kill_on_drop: false }` [INFO] [stdout] 4459ba26fd9a8b3361213c01436216e0cc13bc1dd09a15fa5ece874961846cda