[INFO] fetching crate futures-bufio 0.2.0... [INFO] checking futures-bufio-0.2.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate futures-bufio 0.2.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate futures-bufio 0.2.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate futures-bufio 0.2.0 [INFO] finished tweaking crates.io crate futures-bufio 0.2.0 [INFO] tweaked toml for crates.io crate futures-bufio 0.2.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 6 packages to latest compatible versions [INFO] [stderr] Adding futures v0.1.31 (latest: v0.3.30) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6152dbb848c7b8149a9811c3565d873b15d8adb67a5f458931c83f5e59002ee6 [INFO] running `Command { std: "docker" "start" "-a" "6152dbb848c7b8149a9811c3565d873b15d8adb67a5f458931c83f5e59002ee6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6152dbb848c7b8149a9811c3565d873b15d8adb67a5f458931c83f5e59002ee6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6152dbb848c7b8149a9811c3565d873b15d8adb67a5f458931c83f5e59002ee6", kill_on_drop: false }` [INFO] [stdout] 6152dbb848c7b8149a9811c3565d873b15d8adb67a5f458931c83f5e59002ee6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] dfb9c68973fad42e3f8c47d5a75ce0dbf4e18db12d1f13361616f58724a4318c [INFO] running `Command { std: "docker" "start" "-a" "dfb9c68973fad42e3f8c47d5a75ce0dbf4e18db12d1f13361616f58724a4318c", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Checking futures v0.1.31 [INFO] [stderr] Checking futures-cpupool v0.1.8 [INFO] [stderr] Checking futures-bufio v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: use of deprecated function `std::mem::uninitialized`: use `mem::MaybeUninit` instead [INFO] [stdout] --> src/read.rs:211:52 [INFO] [stdout] | [INFO] [stdout] 211 | let r = mem::replace(&mut self.inner, mem::uninitialized()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `std::mem::uninitialized`: use `mem::MaybeUninit` instead [INFO] [stdout] --> src/read.rs:212:52 [INFO] [stdout] | [INFO] [stdout] 212 | let buf = mem::replace(&mut self.buf, mem::uninitialized()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `std::mem::uninitialized`: use `mem::MaybeUninit` instead [INFO] [stdout] --> src/read.rs:213:58 [INFO] [stdout] | [INFO] [stdout] 213 | let mut pool = mem::replace(&mut self.pool, mem::uninitialized()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `std::mem::uninitialized`: use `mem::MaybeUninit` instead [INFO] [stdout] --> src/write.rs:158:52 [INFO] [stdout] | [INFO] [stdout] 158 | let w = mem::replace(&mut self.inner, mem::uninitialized()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `std::mem::uninitialized`: use `mem::MaybeUninit` instead [INFO] [stdout] --> src/write.rs:159:52 [INFO] [stdout] | [INFO] [stdout] 159 | let buf = mem::replace(&mut self.buf, mem::uninitialized()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `std::mem::uninitialized`: use `mem::MaybeUninit` instead [INFO] [stdout] --> src/write.rs:160:58 [INFO] [stdout] | [INFO] [stdout] 160 | let mut pool = mem::replace(&mut self.pool, mem::uninitialized()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the feature `conservative_impl_trait` has been stable since 1.26.0 and no longer requires an attribute to enable [INFO] [stdout] --> src/lib.rs:10:12 [INFO] [stdout] | [INFO] [stdout] 10 | #![feature(conservative_impl_trait)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(stable_features)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `std::mem::uninitialized`: use `mem::MaybeUninit` instead [INFO] [stdout] --> src/read.rs:211:52 [INFO] [stdout] | [INFO] [stdout] 211 | let r = mem::replace(&mut self.inner, mem::uninitialized()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `std::mem::uninitialized`: use `mem::MaybeUninit` instead [INFO] [stdout] --> src/read.rs:212:52 [INFO] [stdout] | [INFO] [stdout] 212 | let buf = mem::replace(&mut self.buf, mem::uninitialized()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `std::mem::uninitialized`: use `mem::MaybeUninit` instead [INFO] [stdout] --> src/read.rs:213:58 [INFO] [stdout] | [INFO] [stdout] 213 | let mut pool = mem::replace(&mut self.pool, mem::uninitialized()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `std::mem::uninitialized`: use `mem::MaybeUninit` instead [INFO] [stdout] --> src/write.rs:158:52 [INFO] [stdout] | [INFO] [stdout] 158 | let w = mem::replace(&mut self.inner, mem::uninitialized()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `std::mem::uninitialized`: use `mem::MaybeUninit` instead [INFO] [stdout] --> src/write.rs:159:52 [INFO] [stdout] | [INFO] [stdout] 159 | let buf = mem::replace(&mut self.buf, mem::uninitialized()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `std::mem::uninitialized`: use `mem::MaybeUninit` instead [INFO] [stdout] --> src/write.rs:160:58 [INFO] [stdout] | [INFO] [stdout] 160 | let mut pool = mem::replace(&mut self.pool, mem::uninitialized()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the feature `conservative_impl_trait` has been stable since 1.26.0 and no longer requires an attribute to enable [INFO] [stdout] --> src/lib.rs:10:12 [INFO] [stdout] | [INFO] [stdout] 10 | #![feature(conservative_impl_trait)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(stable_features)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `rem` is never read [INFO] [stdout] --> src/write.rs:295:17 [INFO] [stdout] | [INFO] [stdout] 295 | rem -= n_write; [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/read.rs:84:44 [INFO] [stdout] | [INFO] [stdout] 79 | pub fn with_pool_and_capacity(pool: CpuPool, cap: usize, inner: R) -> BufReader { [INFO] [stdout] | ------------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 84 | BufReader::with_pool_and_buf(pool, buf.into_boxed_slice(), inner) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/read.rs:111:19 [INFO] [stdout] | [INFO] [stdout] 104 | pub fn with_pool_and_buf(pool: CpuPool, buf: Box<[u8]>, inner: R) -> BufReader { [INFO] [stdout] | ------------- -------------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 111 | pool: Some(pool), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type `Box<[u8]>` does not permit being left uninitialized [INFO] [stdout] --> src/read.rs:212:47 [INFO] [stdout] | [INFO] [stdout] 212 | let buf = mem::replace(&mut self.buf, mem::uninitialized()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this code causes undefined behavior when executed [INFO] [stdout] | help: use `MaybeUninit` instead, and only call `assume_init` after initialization is done [INFO] [stdout] | [INFO] [stdout] = note: `Box` must be non-null [INFO] [stdout] = note: `#[warn(invalid_value)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type `Option` does not permit being left uninitialized [INFO] [stdout] --> src/read.rs:213:53 [INFO] [stdout] | [INFO] [stdout] 213 | let mut pool = mem::replace(&mut self.pool, mem::uninitialized()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this code causes undefined behavior when executed [INFO] [stdout] | help: use `MaybeUninit` instead, and only call `assume_init` after initialization is done [INFO] [stdout] | [INFO] [stdout] note: enums with multiple inhabited variants have to be initialized to a variant [INFO] [stdout] --> /rustc/4d98531622e1718ae0bc3c7a1ab9cd8938428452/library/core/src/option.rs:571:1 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/read.rs:312:19 [INFO] [stdout] | [INFO] [stdout] 255 | mut self, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 256 | mut buf: B, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 278 | let pool = self.pool.take().expect(EXP_POOL); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 286 | let fut = pool.spawn_fn(move || { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 312 | Either::B(fut.then(|res| match res { [INFO] [stdout] | ___________________^ [INFO] [stdout] 313 | | Ok(mut x) => { [INFO] [stdout] 314 | | x.0.pool = Some(pool); [INFO] [stdout] 315 | | Ok(x) [INFO] [stdout] ... | [INFO] [stdout] 320 | | } [INFO] [stdout] 321 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/write.rs:89:44 [INFO] [stdout] | [INFO] [stdout] 84 | pub fn with_pool_and_capacity(pool: CpuPool, cap: usize, inner: W) -> BufWriter { [INFO] [stdout] | ------------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 89 | BufWriter::with_pool_and_buf(pool, buf.into_boxed_slice(), inner) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/write.rs:115:19 [INFO] [stdout] | [INFO] [stdout] 109 | pub fn with_pool_and_buf(pool: CpuPool, buf: Box<[u8]>, inner: W) -> BufWriter { [INFO] [stdout] | ------------- -------------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 115 | pool: Some(pool), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type `Box<[u8]>` does not permit being left uninitialized [INFO] [stdout] --> src/write.rs:159:47 [INFO] [stdout] | [INFO] [stdout] 159 | let buf = mem::replace(&mut self.buf, mem::uninitialized()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this code causes undefined behavior when executed [INFO] [stdout] | help: use `MaybeUninit` instead, and only call `assume_init` after initialization is done [INFO] [stdout] | [INFO] [stdout] = note: `Box` must be non-null [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type `Option` does not permit being left uninitialized [INFO] [stdout] --> src/write.rs:160:53 [INFO] [stdout] | [INFO] [stdout] 160 | let mut pool = mem::replace(&mut self.pool, mem::uninitialized()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this code causes undefined behavior when executed [INFO] [stdout] | help: use `MaybeUninit` instead, and only call `assume_init` after initialization is done [INFO] [stdout] | [INFO] [stdout] note: enums with multiple inhabited variants have to be initialized to a variant [INFO] [stdout] --> /rustc/4d98531622e1718ae0bc3c7a1ab9cd8938428452/library/core/src/option.rs:571:1 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/write.rs:302:19 [INFO] [stdout] | [INFO] [stdout] 249 | mut self, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 250 | buf: B, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 275 | let pool = self.pool.take().expect(EXP_POOL); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 276 | let fut = pool.spawn_fn(move || { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 302 | Either::B(fut.then(|res| match res { [INFO] [stdout] | ___________________^ [INFO] [stdout] 303 | | Ok(mut x) => { [INFO] [stdout] 304 | | x.0.pool = Some(pool); [INFO] [stdout] 305 | | Ok(x) [INFO] [stdout] ... | [INFO] [stdout] 310 | | } [INFO] [stdout] 311 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/write.rs:299:16 [INFO] [stdout] | [INFO] [stdout] 249 | mut self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 250 | buf: B, [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 299 | Ok((self, buf)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/write.rs:337:19 [INFO] [stdout] | [INFO] [stdout] 323 | pub fn flush_buf(mut self) -> impl Future { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 328 | let pool = self.pool.take().expect(EXP_POOL); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 329 | let fut = pool.spawn_fn(move || { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 337 | Either::B(fut.then(|res| match res { [INFO] [stdout] | ___________________^ [INFO] [stdout] 338 | | Ok(mut me) => { [INFO] [stdout] 339 | | me.pool = Some(pool); [INFO] [stdout] 340 | | Ok(me) [INFO] [stdout] ... | [INFO] [stdout] 345 | | } [INFO] [stdout] 346 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `rem` is never read [INFO] [stdout] --> src/write.rs:295:17 [INFO] [stdout] | [INFO] [stdout] 295 | rem -= n_write; [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/write.rs:366:18 [INFO] [stdout] | [INFO] [stdout] 357 | pub fn flush_inner(mut self) -> impl Future { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 358 | let pool = self.pool.take().expect(EXP_POOL); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 359 | let fut = pool.spawn_fn(move || { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 366 | fut.then(|res| match res { [INFO] [stdout] | __________________^ [INFO] [stdout] 367 | | Ok(mut me) => { [INFO] [stdout] 368 | | me.pool = Some(pool); [INFO] [stdout] 369 | | Ok(me) [INFO] [stdout] ... | [INFO] [stdout] 374 | | } [INFO] [stdout] 375 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors; 12 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `futures-bufio` (lib) due to 10 previous errors; 12 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/read.rs:84:44 [INFO] [stdout] | [INFO] [stdout] 79 | pub fn with_pool_and_capacity(pool: CpuPool, cap: usize, inner: R) -> BufReader { [INFO] [stdout] | ------------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 84 | BufReader::with_pool_and_buf(pool, buf.into_boxed_slice(), inner) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/read.rs:111:19 [INFO] [stdout] | [INFO] [stdout] 104 | pub fn with_pool_and_buf(pool: CpuPool, buf: Box<[u8]>, inner: R) -> BufReader { [INFO] [stdout] | ------------- -------------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 111 | pool: Some(pool), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type `Box<[u8]>` does not permit being left uninitialized [INFO] [stdout] --> src/read.rs:212:47 [INFO] [stdout] | [INFO] [stdout] 212 | let buf = mem::replace(&mut self.buf, mem::uninitialized()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this code causes undefined behavior when executed [INFO] [stdout] | help: use `MaybeUninit` instead, and only call `assume_init` after initialization is done [INFO] [stdout] | [INFO] [stdout] = note: `Box` must be non-null [INFO] [stdout] = note: `#[warn(invalid_value)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type `Option` does not permit being left uninitialized [INFO] [stdout] --> src/read.rs:213:53 [INFO] [stdout] | [INFO] [stdout] 213 | let mut pool = mem::replace(&mut self.pool, mem::uninitialized()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this code causes undefined behavior when executed [INFO] [stdout] | help: use `MaybeUninit` instead, and only call `assume_init` after initialization is done [INFO] [stdout] | [INFO] [stdout] note: enums with multiple inhabited variants have to be initialized to a variant [INFO] [stdout] --> /rustc/4d98531622e1718ae0bc3c7a1ab9cd8938428452/library/core/src/option.rs:571:1 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/read.rs:312:19 [INFO] [stdout] | [INFO] [stdout] 255 | mut self, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 256 | mut buf: B, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 278 | let pool = self.pool.take().expect(EXP_POOL); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 286 | let fut = pool.spawn_fn(move || { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 312 | Either::B(fut.then(|res| match res { [INFO] [stdout] | ___________________^ [INFO] [stdout] 313 | | Ok(mut x) => { [INFO] [stdout] 314 | | x.0.pool = Some(pool); [INFO] [stdout] 315 | | Ok(x) [INFO] [stdout] ... | [INFO] [stdout] 320 | | } [INFO] [stdout] 321 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/write.rs:89:44 [INFO] [stdout] | [INFO] [stdout] 84 | pub fn with_pool_and_capacity(pool: CpuPool, cap: usize, inner: W) -> BufWriter { [INFO] [stdout] | ------------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 89 | BufWriter::with_pool_and_buf(pool, buf.into_boxed_slice(), inner) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/write.rs:115:19 [INFO] [stdout] | [INFO] [stdout] 109 | pub fn with_pool_and_buf(pool: CpuPool, buf: Box<[u8]>, inner: W) -> BufWriter { [INFO] [stdout] | ------------- -------------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 115 | pool: Some(pool), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type `Box<[u8]>` does not permit being left uninitialized [INFO] [stdout] --> src/write.rs:159:47 [INFO] [stdout] | [INFO] [stdout] 159 | let buf = mem::replace(&mut self.buf, mem::uninitialized()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this code causes undefined behavior when executed [INFO] [stdout] | help: use `MaybeUninit` instead, and only call `assume_init` after initialization is done [INFO] [stdout] | [INFO] [stdout] = note: `Box` must be non-null [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type `Option` does not permit being left uninitialized [INFO] [stdout] --> src/write.rs:160:53 [INFO] [stdout] | [INFO] [stdout] 160 | let mut pool = mem::replace(&mut self.pool, mem::uninitialized()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this code causes undefined behavior when executed [INFO] [stdout] | help: use `MaybeUninit` instead, and only call `assume_init` after initialization is done [INFO] [stdout] | [INFO] [stdout] note: enums with multiple inhabited variants have to be initialized to a variant [INFO] [stdout] --> /rustc/4d98531622e1718ae0bc3c7a1ab9cd8938428452/library/core/src/option.rs:571:1 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/write.rs:302:19 [INFO] [stdout] | [INFO] [stdout] 249 | mut self, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 250 | buf: B, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 275 | let pool = self.pool.take().expect(EXP_POOL); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 276 | let fut = pool.spawn_fn(move || { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 302 | Either::B(fut.then(|res| match res { [INFO] [stdout] | ___________________^ [INFO] [stdout] 303 | | Ok(mut x) => { [INFO] [stdout] 304 | | x.0.pool = Some(pool); [INFO] [stdout] 305 | | Ok(x) [INFO] [stdout] ... | [INFO] [stdout] 310 | | } [INFO] [stdout] 311 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/write.rs:299:16 [INFO] [stdout] | [INFO] [stdout] 249 | mut self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 250 | buf: B, [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 299 | Ok((self, buf)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/write.rs:337:19 [INFO] [stdout] | [INFO] [stdout] 323 | pub fn flush_buf(mut self) -> impl Future { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 328 | let pool = self.pool.take().expect(EXP_POOL); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 329 | let fut = pool.spawn_fn(move || { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 337 | Either::B(fut.then(|res| match res { [INFO] [stdout] | ___________________^ [INFO] [stdout] 338 | | Ok(mut me) => { [INFO] [stdout] 339 | | me.pool = Some(pool); [INFO] [stdout] 340 | | Ok(me) [INFO] [stdout] ... | [INFO] [stdout] 345 | | } [INFO] [stdout] 346 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/write.rs:366:18 [INFO] [stdout] | [INFO] [stdout] 357 | pub fn flush_inner(mut self) -> impl Future { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 358 | let pool = self.pool.take().expect(EXP_POOL); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 359 | let fut = pool.spawn_fn(move || { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 366 | fut.then(|res| match res { [INFO] [stdout] | __________________^ [INFO] [stdout] 367 | | Ok(mut me) => { [INFO] [stdout] 368 | | me.pool = Some(pool); [INFO] [stdout] 369 | | Ok(me) [INFO] [stdout] ... | [INFO] [stdout] 374 | | } [INFO] [stdout] 375 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors; 12 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `futures-bufio` (lib test) due to 10 previous errors; 12 warnings emitted [INFO] running `Command { std: "docker" "inspect" "dfb9c68973fad42e3f8c47d5a75ce0dbf4e18db12d1f13361616f58724a4318c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "dfb9c68973fad42e3f8c47d5a75ce0dbf4e18db12d1f13361616f58724a4318c", kill_on_drop: false }` [INFO] [stdout] dfb9c68973fad42e3f8c47d5a75ce0dbf4e18db12d1f13361616f58724a4318c