[INFO] fetching crate funlib 0.1.8... [INFO] checking funlib-0.1.8 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate funlib 0.1.8 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate funlib 0.1.8 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate funlib 0.1.8 [INFO] finished tweaking crates.io crate funlib 0.1.8 [INFO] tweaked toml for crates.io crate funlib 0.1.8 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 2 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 50a2439dec7587d5ec82b78cc28b64ae2e738cddaeebbe1fa575401cdd9e9684 [INFO] running `Command { std: "docker" "start" "-a" "50a2439dec7587d5ec82b78cc28b64ae2e738cddaeebbe1fa575401cdd9e9684", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "50a2439dec7587d5ec82b78cc28b64ae2e738cddaeebbe1fa575401cdd9e9684", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "50a2439dec7587d5ec82b78cc28b64ae2e738cddaeebbe1fa575401cdd9e9684", kill_on_drop: false }` [INFO] [stdout] 50a2439dec7587d5ec82b78cc28b64ae2e738cddaeebbe1fa575401cdd9e9684 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] bb8074215fe1c1eebbc81931f5b4fdee118d634029583397a1b61d44c6dfd61c [INFO] running `Command { std: "docker" "start" "-a" "bb8074215fe1c1eebbc81931f5b4fdee118d634029583397a1b61d44c6dfd61c", kill_on_drop: false }` [INFO] [stderr] Checking funlib-macros v0.1.8 [INFO] [stderr] Checking funlib v0.1.8 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/functor/mod.rs:21:14 [INFO] [stdout] | [INFO] [stdout] 20 | fn fmap(&self, f: F) -> Box where F: Fn(&A) -> B { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | Box::new(f(self)) [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/functor/mod.rs:27:13 [INFO] [stdout] | [INFO] [stdout] 26 | fn fmap(&self, f: F) -> Rc where F: Fn(&A) -> B { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | Rc::new(f(self)) [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/functor/mod.rs:33:5 [INFO] [stdout] | [INFO] [stdout] 32 | fn fmap(&self, f: F) -> Vec where F: Fn(&A) -> B { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | self.iter().map(f).collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/applicative/mod.rs:14:11 [INFO] [stdout] | [INFO] [stdout] 13 | fn ap(&self, of: >::M) -> Option where F: Fn(&A) -> B { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 14 | match (self, of) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/applicative/mod.rs:27:14 [INFO] [stdout] | [INFO] [stdout] 26 | fn ap(&self, of: >::M) -> Box where F: Fn(&A) -> B { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | Box::new(of(self)) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/applicative/mod.rs:37:13 [INFO] [stdout] | [INFO] [stdout] 36 | fn ap(&self, of: >::M) -> Rc where F: Fn(&A) -> B { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | Rc::new(of(self)) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/monad/mod.rs:32:5 [INFO] [stdout] | [INFO] [stdout] 31 | fn bind(&self, f: F) -> Vec where F: FnMut(&A) -> Vec { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | self.iter().flat_map(f).collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:284:93 [INFO] [stdout] | [INFO] [stdout] 284 | fn fold_map(&self, f: F) -> B where F: Fn(&Self::A) -> B, B: Monoid { self.fold_left(B::mempty(), |b, a| B::mappend(&b, &f(&a))) } [INFO] [stdout] | ---- ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:284:129 [INFO] [stdout] | [INFO] [stdout] 284 | fn fold_map(&self, f: F) -> B where F: Fn(&Self::A) -> B, B: Monoid { self.fold_left(B::mempty(), |b, a| B::mappend(&b, &f(&a))) } [INFO] [stdout] | - ^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `funlib` (lib) due to 10 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/functor/mod.rs:21:14 [INFO] [stdout] | [INFO] [stdout] 20 | fn fmap(&self, f: F) -> Box where F: Fn(&A) -> B { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | Box::new(f(self)) [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/functor/mod.rs:27:13 [INFO] [stdout] | [INFO] [stdout] 26 | fn fmap(&self, f: F) -> Rc where F: Fn(&A) -> B { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | Rc::new(f(self)) [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/functor/mod.rs:33:5 [INFO] [stdout] | [INFO] [stdout] 32 | fn fmap(&self, f: F) -> Vec where F: Fn(&A) -> B { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | self.iter().map(f).collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary allocation, use `&` instead [INFO] [stdout] --> src/functor/mod.rs:61:16 [INFO] [stdout] | [INFO] [stdout] 61 | laws!(Box, Box::new(5i32), |x| x + 2, |x| x * 5); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_allocation)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/applicative/mod.rs:14:11 [INFO] [stdout] | [INFO] [stdout] 13 | fn ap(&self, of: >::M) -> Option where F: Fn(&A) -> B { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 14 | match (self, of) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/applicative/mod.rs:27:14 [INFO] [stdout] | [INFO] [stdout] 26 | fn ap(&self, of: >::M) -> Box where F: Fn(&A) -> B { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | Box::new(of(self)) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/applicative/mod.rs:37:13 [INFO] [stdout] | [INFO] [stdout] 36 | fn ap(&self, of: >::M) -> Rc where F: Fn(&A) -> B { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | Rc::new(of(self)) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary allocation, use `&` instead [INFO] [stdout] --> src/applicative/mod.rs:72:29 [INFO] [stdout] | [INFO] [stdout] 72 | assert_eq!(Box::new(4), Box::new(2).ap(Box::new(f))); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary allocation, use `&` instead [INFO] [stdout] --> src/applicative/mod.rs:73:29 [INFO] [stdout] | [INFO] [stdout] 73 | assert_eq!(Box::new(4), Box::new(2).ap(Box::new(&double))); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/monad/mod.rs:32:5 [INFO] [stdout] | [INFO] [stdout] 31 | fn bind(&self, f: F) -> Vec where F: FnMut(&A) -> Vec { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | self.iter().flat_map(f).collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary allocation, use `&` instead [INFO] [stdout] --> src/semigroup/mod.rs:86:31 [INFO] [stdout] | [INFO] [stdout] 86 | assert_eq!(Box::new(res), Box::new(v1).mappend(&Box::new(v2))); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary allocation, use `&` instead [INFO] [stdout] --> src/semigroup/mod.rs:94:31 [INFO] [stdout] | [INFO] [stdout] 94 | assert_ne!(Box::new(res), Box::new(v1).mappend(&Box::new(v2))); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary allocation, use `&` instead [INFO] [stdout] --> src/monoid/mod.rs:78:22 [INFO] [stdout] | [INFO] [stdout] 78 | laws2!(Box, i64, Box::new(5i64), Box::new(6i64), Box::new(10i64)); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary allocation, use `&` instead [INFO] [stdout] --> src/monoid/mod.rs:78:38 [INFO] [stdout] | [INFO] [stdout] 78 | laws2!(Box, i64, Box::new(5i64), Box::new(6i64), Box::new(10i64)); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:284:93 [INFO] [stdout] | [INFO] [stdout] 284 | fn fold_map(&self, f: F) -> B where F: Fn(&Self::A) -> B, B: Monoid { self.fold_left(B::mempty(), |b, a| B::mappend(&b, &f(&a))) } [INFO] [stdout] | ---- ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:284:129 [INFO] [stdout] | [INFO] [stdout] 284 | fn fold_map(&self, f: F) -> B where F: Fn(&Self::A) -> B, B: Monoid { self.fold_left(B::mempty(), |b, a| B::mappend(&b, &f(&a))) } [INFO] [stdout] | - ^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `funlib` (lib test) due to 10 previous errors; 7 warnings emitted [INFO] running `Command { std: "docker" "inspect" "bb8074215fe1c1eebbc81931f5b4fdee118d634029583397a1b61d44c6dfd61c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bb8074215fe1c1eebbc81931f5b4fdee118d634029583397a1b61d44c6dfd61c", kill_on_drop: false }` [INFO] [stdout] bb8074215fe1c1eebbc81931f5b4fdee118d634029583397a1b61d44c6dfd61c