[INFO] fetching crate fscmp 0.2.16... [INFO] checking fscmp-0.2.16 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate fscmp 0.2.16 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate fscmp 0.2.16 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate fscmp 0.2.16 [INFO] finished tweaking crates.io crate fscmp 0.2.16 [INFO] tweaked toml for crates.io crate fscmp 0.2.16 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate fscmp 0.2.16 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3275feea05e221f32dca363b61e87cc76effa8a56ede5c327dde6bd1bacb65fe [INFO] running `Command { std: "docker" "start" "-a" "3275feea05e221f32dca363b61e87cc76effa8a56ede5c327dde6bd1bacb65fe", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3275feea05e221f32dca363b61e87cc76effa8a56ede5c327dde6bd1bacb65fe", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3275feea05e221f32dca363b61e87cc76effa8a56ede5c327dde6bd1bacb65fe", kill_on_drop: false }` [INFO] [stdout] 3275feea05e221f32dca363b61e87cc76effa8a56ede5c327dde6bd1bacb65fe [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9aa10cd9ffd28b1b5f2d52b600cbb58ea9452e535949207c0ebd330f405ae2fb [INFO] running `Command { std: "docker" "start" "-a" "9aa10cd9ffd28b1b5f2d52b600cbb58ea9452e535949207c0ebd330f405ae2fb", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.62 [INFO] [stderr] Checking cfg-if v0.1.9 [INFO] [stderr] Compiling semver-parser v0.7.0 [INFO] [stderr] Compiling autocfg v0.1.6 [INFO] [stderr] Compiling proc-macro2 v1.0.3 [INFO] [stderr] Compiling proc-macro2 v0.4.30 [INFO] [stderr] Compiling unicode-xid v0.1.0 [INFO] [stderr] Compiling arrayvec v0.4.11 [INFO] [stderr] Compiling unicode-xid v0.2.0 [INFO] [stderr] Compiling getrandom v0.1.12 [INFO] [stderr] Compiling syn v1.0.5 [INFO] [stderr] Compiling cc v1.0.45 [INFO] [stderr] Checking nodrop v0.1.13 [INFO] [stderr] Compiling syn v0.15.44 [INFO] [stderr] Compiling bitflags v1.1.0 [INFO] [stderr] Checking scopeguard v1.0.0 [INFO] [stderr] Checking crossbeam-utils v0.6.6 [INFO] [stderr] Compiling byteorder v1.3.2 [INFO] [stderr] Checking unicode-width v0.1.6 [INFO] [stderr] Checking ppv-lite86 v0.2.5 [INFO] [stderr] Compiling log v0.4.8 [INFO] [stderr] Compiling failure_derive v0.1.5 [INFO] [stderr] Compiling unicode-segmentation v1.3.0 [INFO] [stderr] Compiling rayon-core v1.6.0 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Compiling num-traits v0.2.8 [INFO] [stderr] Compiling num-integer v0.1.41 [INFO] [stderr] Compiling rustc_version v0.2.3 [INFO] [stderr] Checking crossbeam-queue v0.1.2 [INFO] [stderr] Compiling nix v0.16.0 [INFO] [stderr] Checking c2-chacha v0.2.2 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking vec_map v0.8.1 [INFO] [stderr] Compiling heck v0.3.1 [INFO] [stderr] Checking rustc-demangle v0.1.16 [INFO] [stderr] Checking either v1.5.2 [INFO] [stderr] Checking same-file v1.0.5 [INFO] [stderr] Checking remove_dir_all v0.5.2 [INFO] [stderr] Compiling memoffset v0.5.1 [INFO] [stderr] Checking walkdir v2.2.9 [INFO] [stderr] Compiling backtrace-sys v0.1.31 [INFO] [stderr] Checking crossbeam-epoch v0.7.2 [INFO] [stderr] Compiling quote v0.6.13 [INFO] [stderr] Compiling quote v1.0.2 [INFO] [stderr] Checking atty v0.2.13 [INFO] [stderr] Checking num_cpus v1.10.1 [INFO] [stderr] Checking time v0.1.42 [INFO] [stderr] Checking dirs v1.0.5 [INFO] [stderr] Checking openat v0.1.18 [INFO] [stderr] Checking clap v2.33.0 [INFO] [stderr] Checking term v0.5.2 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking crossbeam-deque v0.7.1 [INFO] [stderr] Checking rand_chacha v0.2.1 [INFO] [stderr] Checking rand v0.7.0 [INFO] [stderr] Checking chrono v0.4.9 [INFO] [stderr] Checking rayon v1.2.0 [INFO] [stderr] Checking backtrace v0.3.37 [INFO] [stderr] Checking tempfile v3.1.0 [INFO] [stderr] Checking simplelog v0.7.1 [INFO] [stderr] Compiling synstructure v0.10.2 [INFO] [stderr] Compiling proc-macro-error v0.2.6 [INFO] [stderr] Compiling structopt-derive v0.3.1 [INFO] [stderr] Checking failure v0.1.5 [INFO] [stderr] Checking structopt v0.3.1 [INFO] [stderr] Checking fscmp v0.2.16 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:88:8 [INFO] [stdout] | [INFO] [stdout] 81 | let fscmp = FSCmp::new( [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 88 | Ok(if let Some(content_size) = opt.content_size { [INFO] [stdout] | ________^ [INFO] [stdout] 89 | | fscmp.contents(content_size)? [INFO] [stdout] 90 | | } else { [INFO] [stdout] 91 | | fscmp.dirs()? [INFO] [stdout] 92 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cmp/mod.rs:62:12 [INFO] [stdout] | [INFO] [stdout] 59 | let dir = Dir::open(&path)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 62 | Ok(EntryInfo { [INFO] [stdout] | ____________^ [INFO] [stdout] 63 | | parent: Arc::new(dir), [INFO] [stdout] 64 | | parent_path: Default::default(), [INFO] [stdout] 65 | | path, [INFO] [stdout] 66 | | metadata, [INFO] [stdout] 67 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cmp/mod.rs:76:12 [INFO] [stdout] | [INFO] [stdout] 73 | let dir = Dir::open(path.parent().unwrap())?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 76 | Ok(EntryInfo { [INFO] [stdout] | ____________^ [INFO] [stdout] 77 | | parent: Arc::new(dir), [INFO] [stdout] 78 | | parent_path: Default::default(), [INFO] [stdout] 79 | | path, [INFO] [stdout] 80 | | metadata, [INFO] [stdout] 81 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cmp/mod.rs:140:15 [INFO] [stdout] | [INFO] [stdout] 133 | ignored_dirs: HashSet, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 140 | ..Default::default() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cmp/mod.rs:253:9 [INFO] [stdout] | [INFO] [stdout] 246 | let first_contents: HashSet<_> = self.list_dir(first).context("first")?; [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 247 | let second_contents: HashSet<_> = self.list_dir(second).context("second")?; [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 253 | / first_contents [INFO] [stdout] 254 | | .par_iter() [INFO] [stdout] 255 | | .map(|name| { [INFO] [stdout] 256 | | if second_contents.contains(name) { [INFO] [stdout] ... | [INFO] [stdout] 267 | | }) [INFO] [stdout] 268 | | .find_any(|r| r.as_ref().ok() != Some(&Comparison::Equal)) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |______________________________________________________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cmp/mod.rs:269:24 [INFO] [stdout] | [INFO] [stdout] 246 | let first_contents: HashSet<_> = self.list_dir(first).context("first")?; [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 247 | let second_contents: HashSet<_> = self.list_dir(second).context("second")?; [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 269 | .unwrap_or(Ok(Comparison::Equal)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cmp/mod.rs:268:52 [INFO] [stdout] | [INFO] [stdout] 268 | .find_any(|r| r.as_ref().ok() != Some(&Comparison::Equal)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cmp/mod.rs:311:9 [INFO] [stdout] | [INFO] [stdout] 305 | let file1 = open_file(first)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 306 | let file2 = open_file(second)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 311 | / (0..calc_chunk_count(limit, BUF_SIZE_U64)) [INFO] [stdout] 312 | | .into_par_iter() [INFO] [stdout] 313 | | .map(|i| ((i * leap)..min(size, i * leap + BUF_SIZE_U64))) [INFO] [stdout] 314 | | .map(|chunk| { [INFO] [stdout] ... | [INFO] [stdout] 354 | | }) [INFO] [stdout] 355 | | .find_any(|r| r.as_ref().ok() != Some(&Comparison::Equal)) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |______________________________________________________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type `[u8; 262144]` does not permit being left uninitialized [INFO] [stdout] --> src/cmp/mod.rs:323:58 [INFO] [stdout] | [INFO] [stdout] 323 | let mut buffer1 = AlignedBuffer(unsafe { std::mem::MaybeUninit::uninit().assume_init() }); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this code causes undefined behavior when executed [INFO] [stdout] | help: use `MaybeUninit` instead, and only call `assume_init` after initialization is done [INFO] [stdout] | [INFO] [stdout] = note: integers must be initialized [INFO] [stdout] = note: `#[warn(invalid_value)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type `[u8; 262144]` does not permit being left uninitialized [INFO] [stdout] --> src/cmp/mod.rs:324:58 [INFO] [stdout] | [INFO] [stdout] 324 | let mut buffer2 = AlignedBuffer(unsafe { std::mem::MaybeUninit::uninit().assume_init() }); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this code causes undefined behavior when executed [INFO] [stdout] | help: use `MaybeUninit` instead, and only call `assume_init` after initialization is done [INFO] [stdout] | [INFO] [stdout] = note: integers must be initialized [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cmp/mod.rs:355:52 [INFO] [stdout] | [INFO] [stdout] 355 | .find_any(|r| r.as_ref().ok() != Some(&Comparison::Equal)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cmp/mod.rs:373:12 [INFO] [stdout] | [INFO] [stdout] 373 | Ok(Comparison::Equal) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 10 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `fscmp` (bin "fscmp" test) due to 11 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:88:8 [INFO] [stdout] | [INFO] [stdout] 81 | let fscmp = FSCmp::new( [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 88 | Ok(if let Some(content_size) = opt.content_size { [INFO] [stdout] | ________^ [INFO] [stdout] 89 | | fscmp.contents(content_size)? [INFO] [stdout] 90 | | } else { [INFO] [stdout] 91 | | fscmp.dirs()? [INFO] [stdout] 92 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cmp/mod.rs:62:12 [INFO] [stdout] | [INFO] [stdout] 59 | let dir = Dir::open(&path)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 62 | Ok(EntryInfo { [INFO] [stdout] | ____________^ [INFO] [stdout] 63 | | parent: Arc::new(dir), [INFO] [stdout] 64 | | parent_path: Default::default(), [INFO] [stdout] 65 | | path, [INFO] [stdout] 66 | | metadata, [INFO] [stdout] 67 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cmp/mod.rs:76:12 [INFO] [stdout] | [INFO] [stdout] 73 | let dir = Dir::open(path.parent().unwrap())?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 76 | Ok(EntryInfo { [INFO] [stdout] | ____________^ [INFO] [stdout] 77 | | parent: Arc::new(dir), [INFO] [stdout] 78 | | parent_path: Default::default(), [INFO] [stdout] 79 | | path, [INFO] [stdout] 80 | | metadata, [INFO] [stdout] 81 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cmp/mod.rs:140:15 [INFO] [stdout] | [INFO] [stdout] 133 | ignored_dirs: HashSet, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 140 | ..Default::default() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cmp/mod.rs:253:9 [INFO] [stdout] | [INFO] [stdout] 246 | let first_contents: HashSet<_> = self.list_dir(first).context("first")?; [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 247 | let second_contents: HashSet<_> = self.list_dir(second).context("second")?; [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 253 | / first_contents [INFO] [stdout] 254 | | .par_iter() [INFO] [stdout] 255 | | .map(|name| { [INFO] [stdout] 256 | | if second_contents.contains(name) { [INFO] [stdout] ... | [INFO] [stdout] 267 | | }) [INFO] [stdout] 268 | | .find_any(|r| r.as_ref().ok() != Some(&Comparison::Equal)) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |______________________________________________________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cmp/mod.rs:269:24 [INFO] [stdout] | [INFO] [stdout] 246 | let first_contents: HashSet<_> = self.list_dir(first).context("first")?; [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 247 | let second_contents: HashSet<_> = self.list_dir(second).context("second")?; [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 269 | .unwrap_or(Ok(Comparison::Equal)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cmp/mod.rs:268:52 [INFO] [stdout] | [INFO] [stdout] 268 | .find_any(|r| r.as_ref().ok() != Some(&Comparison::Equal)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cmp/mod.rs:311:9 [INFO] [stdout] | [INFO] [stdout] 305 | let file1 = open_file(first)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 306 | let file2 = open_file(second)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 311 | / (0..calc_chunk_count(limit, BUF_SIZE_U64)) [INFO] [stdout] 312 | | .into_par_iter() [INFO] [stdout] 313 | | .map(|i| ((i * leap)..min(size, i * leap + BUF_SIZE_U64))) [INFO] [stdout] 314 | | .map(|chunk| { [INFO] [stdout] ... | [INFO] [stdout] 354 | | }) [INFO] [stdout] 355 | | .find_any(|r| r.as_ref().ok() != Some(&Comparison::Equal)) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |______________________________________________________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type `[u8; 262144]` does not permit being left uninitialized [INFO] [stdout] --> src/cmp/mod.rs:323:58 [INFO] [stdout] | [INFO] [stdout] 323 | let mut buffer1 = AlignedBuffer(unsafe { std::mem::MaybeUninit::uninit().assume_init() }); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this code causes undefined behavior when executed [INFO] [stdout] | help: use `MaybeUninit` instead, and only call `assume_init` after initialization is done [INFO] [stdout] | [INFO] [stdout] = note: integers must be initialized [INFO] [stdout] = note: `#[warn(invalid_value)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type `[u8; 262144]` does not permit being left uninitialized [INFO] [stdout] --> src/cmp/mod.rs:324:58 [INFO] [stdout] | [INFO] [stdout] 324 | let mut buffer2 = AlignedBuffer(unsafe { std::mem::MaybeUninit::uninit().assume_init() }); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this code causes undefined behavior when executed [INFO] [stdout] | help: use `MaybeUninit` instead, and only call `assume_init` after initialization is done [INFO] [stdout] | [INFO] [stdout] = note: integers must be initialized [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cmp/mod.rs:355:52 [INFO] [stdout] | [INFO] [stdout] 355 | .find_any(|r| r.as_ref().ok() != Some(&Comparison::Equal)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cmp/mod.rs:373:12 [INFO] [stdout] | [INFO] [stdout] 373 | Ok(Comparison::Equal) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 10 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `fscmp` (bin "fscmp") due to 11 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "9aa10cd9ffd28b1b5f2d52b600cbb58ea9452e535949207c0ebd330f405ae2fb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9aa10cd9ffd28b1b5f2d52b600cbb58ea9452e535949207c0ebd330f405ae2fb", kill_on_drop: false }` [INFO] [stdout] 9aa10cd9ffd28b1b5f2d52b600cbb58ea9452e535949207c0ebd330f405ae2fb