[INFO] fetching crate fs-dir-cache 0.1.0... [INFO] checking fs-dir-cache-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate fs-dir-cache 0.1.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate fs-dir-cache 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-0-tc2/source/.cargo/config.toml [INFO] started tweaking crates.io crate fs-dir-cache 0.1.0 [INFO] finished tweaking crates.io crate fs-dir-cache 0.1.0 [INFO] tweaked toml for crates.io crate fs-dir-cache 0.1.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate fs-dir-cache 0.1.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 889b58f38e8ee24871d4544eaa199911101ed36e2475a5fd8ae772150fd55944 [INFO] running `Command { std: "docker" "start" "-a" "889b58f38e8ee24871d4544eaa199911101ed36e2475a5fd8ae772150fd55944", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "889b58f38e8ee24871d4544eaa199911101ed36e2475a5fd8ae772150fd55944", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "889b58f38e8ee24871d4544eaa199911101ed36e2475a5fd8ae772150fd55944", kill_on_drop: false }` [INFO] [stdout] 889b58f38e8ee24871d4544eaa199911101ed36e2475a5fd8ae772150fd55944 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 34b6b5d79bc905d68fec02a95c0a43ceed3a3b5ce1d0218682a5dd0817f49566 [INFO] running `Command { std: "docker" "start" "-a" "34b6b5d79bc905d68fec02a95c0a43ceed3a3b5ce1d0218682a5dd0817f49566", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.66 [INFO] [stderr] Compiling unicode-ident v1.0.11 [INFO] [stderr] Compiling typenum v1.16.0 [INFO] [stderr] Compiling version_check v0.9.4 [INFO] [stderr] Checking once_cell v1.18.0 [INFO] [stderr] Compiling libc v0.2.147 [INFO] [stderr] Compiling serde v1.0.187 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Checking anstyle-parse v0.2.1 [INFO] [stderr] Checking tracing-core v0.1.31 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Checking regex-syntax v0.7.4 [INFO] [stderr] Compiling num-traits v0.2.16 [INFO] [stderr] Checking anstyle v1.0.2 [INFO] [stderr] Checking anstyle-query v1.0.0 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking colorchoice v1.0.0 [INFO] [stderr] Checking regex-syntax v0.6.29 [INFO] [stderr] Checking anstream v0.5.0 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Checking pin-project-lite v0.2.13 [INFO] [stderr] Checking overload v0.1.1 [INFO] [stderr] Checking clap_lex v0.5.1 [INFO] [stderr] Compiling serde_json v1.0.105 [INFO] [stderr] Compiling syn v2.0.29 [INFO] [stderr] Compiling cc v1.0.83 [INFO] [stderr] Compiling anyhow v1.0.75 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Checking subtle v2.5.0 [INFO] [stderr] Checking tracing-log v0.1.3 [INFO] [stderr] Checking clap_builder v4.4.0 [INFO] [stderr] Checking nu-ansi-term v0.46.0 [INFO] [stderr] Checking time v0.1.45 [INFO] [stderr] Checking regex-automata v0.3.6 [INFO] [stderr] Checking sharded-slab v0.1.4 [INFO] [stderr] Checking thread_local v1.1.7 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking constant_time_eq v0.3.0 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking iana-time-zone v0.1.57 [INFO] [stderr] Checking itoa v1.0.9 [INFO] [stderr] Compiling blake3 v1.4.1 [INFO] [stderr] Checking smallvec v1.11.0 [INFO] [stderr] Checking ryu v1.0.15 [INFO] [stderr] Checking arrayvec v0.7.4 [INFO] [stderr] Checking arrayref v0.3.7 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking fs2 v0.4.3 [INFO] [stderr] Checking regex v1.9.3 [INFO] [stderr] Checking convi v0.0.7 [INFO] [stderr] Checking matchers v0.1.0 [INFO] [stderr] Compiling serde_derive v1.0.187 [INFO] [stderr] Compiling tracing-attributes v0.1.26 [INFO] [stderr] Compiling clap_derive v4.4.0 [INFO] [stderr] Checking tracing v0.1.37 [INFO] [stderr] Checking tracing-subscriber v0.3.17 [INFO] [stderr] Checking clap v4.4.0 [INFO] [stderr] Checking chrono v0.4.26 [INFO] [stderr] Checking fs-dir-cache v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/root.rs:29:12 [INFO] [stdout] | [INFO] [stdout] 23 | pub fn new(path: impl Into) -> Result { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 27 | let lock = util::open_lock_file(&path)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | [INFO] [stdout] 29 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 30 | | path, [INFO] [stdout] 31 | | lock_file: lock, [INFO] [stdout] 32 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/root.rs:36:16 [INFO] [stdout] | [INFO] [stdout] 35 | pub fn with_lock(&mut self, f: impl FnOnce(&mut LockedRoot) -> Result) -> Result { [INFO] [stdout] | -------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | f(&mut LockedRoot::new(&self.path, &mut self.lock_file)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util.rs:45:8 [INFO] [stdout] | [INFO] [stdout] 31 | pub fn store_to_file_with(path: &Path, f: F) -> io::Result> [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 37 | let mut file = std::fs::File::create(&tmp_path)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | Ok(Ok(())) [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `fs-dir-cache` (bin "fs-dir-cache") due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/root.rs:29:12 [INFO] [stdout] | [INFO] [stdout] 23 | pub fn new(path: impl Into) -> Result { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 27 | let lock = util::open_lock_file(&path)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | [INFO] [stdout] 29 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 30 | | path, [INFO] [stdout] 31 | | lock_file: lock, [INFO] [stdout] 32 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/root.rs:36:16 [INFO] [stdout] | [INFO] [stdout] 35 | pub fn with_lock(&mut self, f: impl FnOnce(&mut LockedRoot) -> Result) -> Result { [INFO] [stdout] | -------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | f(&mut LockedRoot::new(&self.path, &mut self.lock_file)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util.rs:45:8 [INFO] [stdout] | [INFO] [stdout] 31 | pub fn store_to_file_with(path: &Path, f: F) -> io::Result> [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 37 | let mut file = std::fs::File::create(&tmp_path)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | Ok(Ok(())) [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `fs-dir-cache` (bin "fs-dir-cache" test) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "34b6b5d79bc905d68fec02a95c0a43ceed3a3b5ce1d0218682a5dd0817f49566", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "34b6b5d79bc905d68fec02a95c0a43ceed3a3b5ce1d0218682a5dd0817f49566", kill_on_drop: false }` [INFO] [stdout] 34b6b5d79bc905d68fec02a95c0a43ceed3a3b5ce1d0218682a5dd0817f49566