[INFO] fetching crate frum 0.1.2... [INFO] checking frum-0.1.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate frum 0.1.2 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate frum 0.1.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate frum 0.1.2 [INFO] finished tweaking crates.io crate frum 0.1.2 [INFO] tweaked toml for crates.io crate frum 0.1.2 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate crates.io crate frum 0.1.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 598c19327a3806240b764585d6d00f070d5dda0b45b8aad4f476118fed5d9862 [INFO] running `Command { std: "docker" "start" "-a" "598c19327a3806240b764585d6d00f070d5dda0b45b8aad4f476118fed5d9862", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "598c19327a3806240b764585d6d00f070d5dda0b45b8aad4f476118fed5d9862", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "598c19327a3806240b764585d6d00f070d5dda0b45b8aad4f476118fed5d9862", kill_on_drop: false }` [INFO] [stdout] 598c19327a3806240b764585d6d00f070d5dda0b45b8aad4f476118fed5d9862 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4d3d525fab6f6ec3967e40dd94610a1f187095cb6e4fba80194636321a9db1ba [INFO] running `Command { std: "docker" "start" "-a" "4d3d525fab6f6ec3967e40dd94610a1f187095cb6e4fba80194636321a9db1ba", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.93 [INFO] [stderr] Compiling cc v1.0.67 [INFO] [stderr] Compiling proc-macro2 v1.0.26 [INFO] [stderr] Compiling unicode-xid v0.2.1 [INFO] [stderr] Compiling syn v1.0.69 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Compiling memchr v2.3.4 [INFO] [stderr] Checking pin-project-lite v0.2.6 [INFO] [stderr] Compiling pkg-config v0.3.19 [INFO] [stderr] Checking bytes v1.0.1 [INFO] [stderr] Checking once_cell v1.7.2 [INFO] [stderr] Compiling tokio v1.5.0 [INFO] [stderr] Checking itoa v0.4.7 [INFO] [stderr] Checking futures-core v0.3.14 [INFO] [stderr] Compiling indexmap v1.6.2 [INFO] [stderr] Compiling getrandom v0.2.2 [INFO] [stderr] Checking matches v0.1.8 [INFO] [stderr] Compiling serde_derive v1.0.125 [INFO] [stderr] Checking tracing-core v0.1.17 [INFO] [stderr] Checking slab v0.4.3 [INFO] [stderr] Checking futures-io v0.3.14 [INFO] [stderr] Checking futures-sink v0.3.14 [INFO] [stderr] Checking futures-task v0.3.14 [INFO] [stderr] Compiling serde v1.0.125 [INFO] [stderr] Checking hashbrown v0.9.1 [INFO] [stderr] Compiling httparse v1.4.0 [INFO] [stderr] Checking tinyvec v1.2.0 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling crc32fast v1.2.1 [INFO] [stderr] Compiling encoding_rs v0.8.28 [INFO] [stderr] Checking http v0.2.4 [INFO] [stderr] Checking want v0.3.0 [INFO] [stderr] Checking form_urlencoded v1.0.1 [INFO] [stderr] Checking futures-channel v0.3.14 [INFO] [stderr] Checking unicode-bidi v0.3.5 [INFO] [stderr] Compiling num-integer v0.1.44 [INFO] [stderr] Compiling serde_json v1.0.64 [INFO] [stderr] Checking httpdate v0.3.2 [INFO] [stderr] Checking ppv-lite86 v0.2.10 [INFO] [stderr] Checking tracing v0.1.25 [INFO] [stderr] Checking ucd-trie v0.1.3 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Checking aho-corasick v0.7.15 [INFO] [stderr] Compiling embed-resource v1.6.1 [INFO] [stderr] Checking pest v2.1.3 [INFO] [stderr] Compiling anyhow v1.0.40 [INFO] [stderr] Checking regex-syntax v0.6.23 [INFO] [stderr] Checking unicode-width v0.1.8 [INFO] [stderr] Checking remove_dir_all v0.5.3 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking mio v0.7.11 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking socket2 v0.4.0 [INFO] [stderr] Checking time v0.1.43 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking xattr v0.2.2 [INFO] [stderr] Compiling quote v1.0.9 [INFO] [stderr] Checking rand_core v0.6.2 [INFO] [stderr] Checking filetime v0.2.14 [INFO] [stderr] Checking dirs-sys v0.3.5 [INFO] [stderr] Checking flate2 v1.0.20 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking rand_chacha v0.3.0 [INFO] [stderr] Compiling unindent v0.1.7 [INFO] [stderr] Checking ipnet v2.3.0 [INFO] [stderr] Checking unicode-normalization v0.1.17 [INFO] [stderr] Checking either v1.6.1 [INFO] [stderr] Checking clap v2.33.3 [INFO] [stderr] Compiling ring v0.16.20 [INFO] [stderr] Compiling bzip2-sys v0.1.10+1.0.8 [INFO] [stderr] Compiling lzma-sys v0.1.17 [INFO] [stderr] Checking rand v0.8.3 [INFO] [stderr] Compiling frum v0.1.2 (/opt/rustwide/workdir) [INFO] [stderr] Checking encoding_rs_io v0.1.7 [INFO] [stderr] Checking itertools v0.10.1 [INFO] [stderr] Checking semver-parser v0.10.2 [INFO] [stderr] Compiling indoc v1.0.3 [INFO] [stderr] Checking dirs v3.0.1 [INFO] [stderr] Checking tar v0.4.33 [INFO] [stderr] Checking semver v0.11.0 [INFO] [stderr] Checking xz2 v0.1.6 [INFO] [stderr] Checking chrono v0.4.19 [INFO] [stderr] Checking colored v2.0.0 [INFO] [stderr] Checking difference v2.0.0 [INFO] [stderr] Checking regex v1.4.5 [INFO] [stderr] Checking tempfile v3.2.0 [INFO] [stderr] Checking idna v0.2.3 [INFO] [stderr] Checking http-body v0.4.1 [INFO] [stderr] Checking url v2.2.1 [INFO] [stderr] Checking bzip2 v0.3.3 [INFO] [stderr] Checking env_logger v0.8.3 [INFO] [stderr] Checking tokio-util v0.6.6 [INFO] [stderr] Checking webpki v0.21.4 [INFO] [stderr] Checking sct v0.6.1 [INFO] [stderr] Checking rustls v0.19.1 [INFO] [stderr] Checking webpki-roots v0.21.1 [INFO] [stderr] Compiling futures-macro v0.3.14 [INFO] [stderr] Compiling pin-project-internal v1.0.7 [INFO] [stderr] Compiling thiserror-impl v1.0.24 [INFO] [stderr] Checking futures-util v0.3.14 [INFO] [stderr] Checking thiserror v1.0.24 [INFO] [stderr] Checking zip v0.5.12 [INFO] [stderr] Checking pin-project v1.0.7 [INFO] [stderr] Checking tokio-rustls v0.22.0 [INFO] [stderr] Checking h2 v0.3.2 [INFO] [stderr] Checking hyper v0.14.5 [INFO] [stderr] Checking serde_urlencoded v0.7.0 [INFO] [stderr] Checking hyper-rustls v0.22.1 [INFO] [stderr] Checking reqwest v0.11.3 [INFO] [stdout] warning: unused import: `windows_command::WindowsCommand` [INFO] [stdout] --> src/shell/mod.rs:14:9 [INFO] [stdout] | [INFO] [stdout] 14 | pub use windows_command::WindowsCommand; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `windows_command::WindowsCommand` [INFO] [stdout] --> src/shell/mod.rs:14:9 [INFO] [stdout] | [INFO] [stdout] 14 | pub use windows_command::WindowsCommand; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/utils/mod.rs:452:9 [INFO] [stdout] | [INFO] [stdout] 442 | fn repeat io::Result<()>>(mut f: F) -> io::Result<()> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 443 | let mut last_err = None; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 452 | Err(last_err.unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `frum` (test "lib") due to 2 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: fields `url`, `sha1`, `sha256`, and `sha521` are never read [INFO] [stdout] --> src/remote_ruby_index.rs:5:9 [INFO] [stdout] | [INFO] [stdout] 3 | pub struct IndexedRubyVersion { [INFO] [stdout] | ------------------ fields in this struct [INFO] [stdout] 4 | pub version: Version, [INFO] [stdout] 5 | pub url: String, [INFO] [stdout] | ^^^ [INFO] [stdout] 6 | pub sha1: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] 7 | pub sha256: String, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 8 | pub sha521: String, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `ProcessInfo` is never constructed [INFO] [stdout] --> src/shell/infer/mod.rs:7:8 [INFO] [stdout] | [INFO] [stdout] 7 | struct ProcessInfo { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commands/completions.rs:76:25 [INFO] [stdout] | [INFO] [stdout] 76 | .or_else(|| infer_shell().map(Into::into)) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commands/install.rs:56:56 [INFO] [stdout] | [INFO] [stdout] 56 | .or_else(|| get_user_version_for_directory(std::env::current_dir().unwrap())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commands/local.rs:73:11 [INFO] [stdout] | [INFO] [stdout] 72 | let symlink_deletion_result = remove_symlink_dir(&to); [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | match create_symlink_dir(&from, &to) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/input_version.rs:16:9 [INFO] [stdout] | [INFO] [stdout] 12 | pub fn to_version<'a, T>(&self, available_versions: T) -> Option<&'a Version> [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 16 | / available_versions [INFO] [stdout] 17 | | .into_iter() [INFO] [stdout] 18 | | .filter(|x| self.matches(x)) [INFO] [stdout] | |________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `frum` (bin "frum") due to 5 previous errors; 3 warnings emitted [INFO] [stdout] warning: fields `url`, `sha1`, `sha256`, and `sha521` are never read [INFO] [stdout] --> src/remote_ruby_index.rs:5:9 [INFO] [stdout] | [INFO] [stdout] 3 | pub struct IndexedRubyVersion { [INFO] [stdout] | ------------------ fields in this struct [INFO] [stdout] 4 | pub version: Version, [INFO] [stdout] 5 | pub url: String, [INFO] [stdout] | ^^^ [INFO] [stdout] 6 | pub sha1: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] 7 | pub sha256: String, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 8 | pub sha521: String, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `ProcessInfo` is never constructed [INFO] [stdout] --> src/shell/infer/mod.rs:7:8 [INFO] [stdout] | [INFO] [stdout] 7 | struct ProcessInfo { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commands/completions.rs:76:25 [INFO] [stdout] | [INFO] [stdout] 76 | .or_else(|| infer_shell().map(Into::into)) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commands/install.rs:56:56 [INFO] [stdout] | [INFO] [stdout] 56 | .or_else(|| get_user_version_for_directory(std::env::current_dir().unwrap())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commands/local.rs:73:11 [INFO] [stdout] | [INFO] [stdout] 72 | let symlink_deletion_result = remove_symlink_dir(&to); [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | match create_symlink_dir(&from, &to) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/input_version.rs:16:9 [INFO] [stdout] | [INFO] [stdout] 12 | pub fn to_version<'a, T>(&self, available_versions: T) -> Option<&'a Version> [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 16 | / available_versions [INFO] [stdout] 17 | | .into_iter() [INFO] [stdout] 18 | | .filter(|x| self.matches(x)) [INFO] [stdout] | |________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `frum` (bin "frum" test) due to 5 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "4d3d525fab6f6ec3967e40dd94610a1f187095cb6e4fba80194636321a9db1ba", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4d3d525fab6f6ec3967e40dd94610a1f187095cb6e4fba80194636321a9db1ba", kill_on_drop: false }` [INFO] [stdout] 4d3d525fab6f6ec3967e40dd94610a1f187095cb6e4fba80194636321a9db1ba